[master] RFR: 8302209: [Lilliput] Optimize fix-anon monitor owner path [v2]
Thomas Stuefe
stuefe at openjdk.org
Wed Mar 8 07:48:44 UTC 2023
On Tue, 14 Feb 2023 14:47:41 GMT, Roman Kennke <rkennke at openjdk.org> wrote:
>> When trying to exit a monitor, we need to check if the current owner is anonymous, and if so, fix it before exiting the monitor. So far, we have been doing this by calling into the slow-path and handle it in the runtime. However, it is fairly easy to do in the fast-path and avoid calling into the runtime altogether. I also included those changes in [upstream fast-locking PR](https://github.com/openjdk/jdk/pull/10907).
>>
>> Testing:
>> - [x] tier1 (x86_64, aarch64)
>> - [x] tier2 (x86_64, aarch64)
>> - [ ] jcstress -t sync -m quick
>
> Roman Kennke has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains two commits:
>
> - Merge branch 'master' into JDK-8302209
> - 8302209: [Lilliput] Optimize fix-anon monitor owner path
src/hotspot/cpu/x86/c2_MacroAssembler_x86.cpp line 822:
> 820: bind(stub->continuation());
> 821: #else
> 822: jcc(Assembler::notEqual, NO_COUNT);
Could you add a comment "// not yet implemented" ? Just to show that there is nothing basic stopping us from doing this for 32-bit, its just not yet done.
-------------
PR: https://git.openjdk.org/lilliput/pull/74
More information about the lilliput-dev
mailing list