[master] RFR: JDK-8303823: [Lilliput] Inline initial LockStack stack [v2]
Thomas Stuefe
stuefe at openjdk.org
Wed Mar 8 17:16:51 UTC 2023
On Wed, 8 Mar 2023 17:03:47 GMT, Roman Kennke <rkennke at openjdk.org> wrote:
>> Thomas Stuefe has updated the pull request incrementally with one additional commit since the last revision:
>>
>> make init cap 4
>
> src/hotspot/share/runtime/lockStack.hpp line 38:
>
>> 36: friend class VMStructs;
>> 37: private:
>> 38: static const size_t INITIAL_CAPACITY = 1;
>
> Uh where did the '1' here come from? I certainly wanted to make this value at least 4. 4 seems to capture a majority of locking depths while not being excessively large. With just 1 or 2 I would expect to blow out the caching advantage with a significant number of workloads. This is probably a left-over from when I wanted to test the growing parts, which I haven't reverted. Please be generous and make that initial size 3 or 4, unless you have objections to that.
Done
-------------
PR: https://git.openjdk.org/lilliput/pull/80
More information about the lilliput-dev
mailing list