[master] RFR: 8303813: [Lilliput] (AArch64) Use tbz instead of tst and br in load_klass() [v2]
Roman Kennke
rkennke at openjdk.org
Thu Mar 9 17:07:29 UTC 2023
The message from this sender included one or more files
which could not be scanned for virus detection; do not
open these files unless you are certain of the sender's intent.
----------------------------------------------------------------------
On Thu, 9 Mar 2023 16:29:10 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:
> Looks good. "fast" is close enough for TBZ.
>
> You can adapt the comment now; remove the "clobbers condition flags".
Will do.
> Question, you are not concerned here with avoiding branches for the fast path? Is this less of a problem with arm64?
I am, very much. I found that some workloads are regressing close to 10% because of forward-branches in load-klass code path. However, the code in MacroAssembler is only used for interpreter and other various code paths, but not for C1 and C2. The latter have their own implementation and there we are using stubs.
-------------
PR: https://git.openjdk.org/lilliput/pull/78
More information about the lilliput-dev
mailing list