[lilliput-jdk17u:lilliput] RFR: 8304329: [Lilliput/JDK17] Fix DiagnoseSyncOnValueBasedClasses

Aleksey Shipilev shade at openjdk.org
Thu Mar 16 09:53:42 UTC 2023


On Thu, 16 Mar 2023 09:15:02 GMT, Roman Kennke <rkennke at openjdk.org> wrote:

> Some deeper testing shows that the following test is currently failing in Lilliput/JDK17:
> 
> java/net/httpclient/LineBodyHandlerTest.java
> 
> That is caused by that test using DiagnoseSyncOnValueBasedClasses, and that seems currently broken with Lilliput/JDK17 because it sets a plain prototype header on a class, where it should also set the narrow Klass* in the prototype.
> 
> Testing:
>  - [x] java/net/httpclient/LineBodyHandlerTest.java
>  - [x] tier1

I wonder if it is cleaner for backporting/feature reasons to have:


if (UseCompactObjectHeaders) {
  ik->set_prototype_header(markWord::prototype().set_klass(ik));
} else {
  ik->set_prototype_header(markWord::prototype());
}


But, your call.

-------------

Marked as reviewed by shade (Reviewer).

PR: https://git.openjdk.org/lilliput-jdk17u/pull/11


More information about the lilliput-dev mailing list