[lilliput-jdk17u:lilliput] RFR: 8304410: [Lilliput/JDK17] Remove unneeded code in ContiguousSpace::object_iterate_from() [v2]
Roman Kennke
rkennke at openjdk.org
Mon Mar 20 14:14:13 UTC 2023
> There is some code in space.cpp that resolves a forwarding pointer to get to the Klass* of an object under Lilliput, but it is not necessary and actually causes harm (the null-check doesn't really make sense when the object is indeed forwarded, but we should not observe a forwarded object to begin with). It is not in upstream JDK(21) version of Lilliput and removing it causes no harm.
>
> Testing:
> - [x] tier1 -XX:+UseCompactHeaders
> - [x] tier1 -XX:-UseCompactHeaders
> - [x] tier2 -XX:+UseCompactHeaders
> - [x] tier2 -XX:-UseCompactHeaders
Roman Kennke has updated the pull request incrementally with one additional commit since the last revision:
Clean revert to upstream state
-------------
Changes:
- all: https://git.openjdk.org/lilliput-jdk17u/pull/13/files
- new: https://git.openjdk.org/lilliput-jdk17u/pull/13/files/97fe4d63..b14f126a
Webrevs:
- full: https://webrevs.openjdk.org/?repo=lilliput-jdk17u&pr=13&range=01
- incr: https://webrevs.openjdk.org/?repo=lilliput-jdk17u&pr=13&range=00-01
Stats: 2 lines in 1 file changed: 0 ins; 1 del; 1 mod
Patch: https://git.openjdk.org/lilliput-jdk17u/pull/13.diff
Fetch: git fetch https://git.openjdk.org/lilliput-jdk17u pull/13/head:pull/13
PR: https://git.openjdk.org/lilliput-jdk17u/pull/13
More information about the lilliput-dev
mailing list