[lilliput-jdk17u:lilliput] Integrated: 8304410: [Lilliput/JDK17] Remove unneeded code in ContiguousSpace::object_iterate_from()

Roman Kennke rkennke at openjdk.org
Mon Mar 20 14:44:19 UTC 2023


On Fri, 17 Mar 2023 16:07:10 GMT, Roman Kennke <rkennke at openjdk.org> wrote:

> There is some code in space.cpp that resolves a forwarding pointer to get to the Klass* of an object under Lilliput, but it is not necessary and actually causes harm (the null-check doesn't really make sense when the object is indeed forwarded, but we should not observe a forwarded object to begin with). It is not in upstream JDK(21) version of Lilliput and removing it causes no harm.
> 
> Testing:
>  - [x] tier1 -XX:+UseCompactHeaders
>  - [x] tier1 -XX:-UseCompactHeaders
>  - [x] tier2 -XX:+UseCompactHeaders
>  - [x] tier2 -XX:-UseCompactHeaders

This pull request has now been integrated.

Changeset: ec4163b1
Author:    Roman Kennke <rkennke at openjdk.org>
URL:       https://git.openjdk.org/lilliput-jdk17u/commit/ec4163b1fb6b161be02cdb43ed063ce45970fd88
Stats:     7 lines in 1 file changed: 0 ins; 6 del; 1 mod

8304410: [Lilliput/JDK17] Remove unneeded code in ContiguousSpace::object_iterate_from()

Reviewed-by: shade

-------------

PR: https://git.openjdk.org/lilliput-jdk17u/pull/13


More information about the lilliput-dev mailing list