[master] RFR: 8307392: [Lilliput] Revert deflation of dead object's monitors [v2]

Aleksey Shipilev shade at openjdk.org
Thu May 4 11:49:44 UTC 2023


On Thu, 4 May 2023 11:32:32 GMT, Roman Kennke <rkennke at openjdk.org> wrote:

>> In https://github.com/openjdk/lilliput/pull/28, I introduced some code that forces deflation of monitors on objects that are about to die. Discussions around a possible upstreaming of this code (https://github.com/openjdk/jdk/pull/13721) comes to the conclusion that this should not be necessary, and indeed, I could not reproduce the original problem that I was having in Lilliput with the code removed. I assume some changes in upstream and/or Lilliput since then have fixed the root cause. Let's remove that code and see what explodes.
>> 
>> Testing: (All with -XX:+UseHeavyMonitors to amplify monitor traffic)
>>  - [x] hotspot_gc
>>  - [x] tier1
>>  - [x] tier2
>>  - [x] SPECjvm workloads
>
> Roman Kennke has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Cleanup

Okay then!

-------------

Marked as reviewed by shade (Committer).

PR Review: https://git.openjdk.org/lilliput/pull/88#pullrequestreview-1412916545


More information about the lilliput-dev mailing list