[lilliput-jdk17u:lilliput] RFR: 8308107: [Lilliput/JDK17] Cherry-pick: 8291555: Implement alternative fast-locking scheme [v3]

Roman Kennke rkennke at openjdk.org
Mon May 22 17:43:23 UTC 2023


On Mon, 22 May 2023 10:21:33 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

>> Roman Kennke has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Don't restrict Klass prototype headers to Lilliput, b/c biased-locking
>
> src/hotspot/cpu/x86/c2_MacroAssembler_x86.cpp line 724:
> 
>> 722:       // Call the slow-path instead.
>> 723:       jcc(Assembler::notEqual, DONE_LABEL);
>> 724:     }
> 
> (Cannot comment on unaffected code, commenting on the nearest hunk)
> 
> Upstream does `jmpb` -> `jmp`  in the RTM block below: https://github.com/openjdk/jdk/commit/7f6358a8b53a35a87c9413c68f8fe6c5fdec0caf#diff-318d0e76b9a97e8cf8936be1de34e52735c4d947a77cac38babbbf9a081d16fcR812

Yes, but it already is jmp here? So no need to change anything?

-------------

PR Review Comment: https://git.openjdk.org/lilliput-jdk17u/pull/19#discussion_r1200833571


More information about the lilliput-dev mailing list