[lilliput-jdk17u:lilliput] RFR: 8309192: [Lilliput/JDK17] Disable Lilliput by default, and turn off CDS when Lilliput is enabled

Thomas Stuefe stuefe at openjdk.org
Wed May 31 12:07:22 UTC 2023


On Wed, 31 May 2023 11:10:03 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

> See the discussion in the bug.
> 
> There is a problem that disabling Lilliput effectively disables CDS. I think for 17u we should disable UCOH by default, and disable CDS when UCOH is on. That is, keep the legacy configuration untouched, and let Lilliput pay the price, if any.
> 
> Additional testing:
>  - [x] macos-aarch64-server-fastdebug, `runtime/cds`

Okay as in it does what you write it does. Not much discussion found in the bug though. In Lilliput master, CDS works with compact headers. Are the necessary parts just missing?

Note that I currently work on the upstream patch for https://github.com/tstuefe/jdk/tree/metaspace-for-lilliput (still very much wip), which will also touch CDS.

Cheers, Thomas

p.s. you may run into CDS tests that assume CDS is enabled by default, or that test that.

-------------

Marked as reviewed by stuefe (Reviewer).

PR Review: https://git.openjdk.org/lilliput-jdk17u/pull/29#pullrequestreview-1453025556


More information about the lilliput-dev mailing list