From shade at openjdk.org Wed Nov 1 19:26:45 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Wed, 1 Nov 2023 19:26:45 GMT Subject: [master] RFR: 8319135: [Lilliput] Fix objArrayOop gtest In-Reply-To: References: Message-ID: On Mon, 30 Oct 2023 18:42:18 GMT, Roman Kennke wrote: > The objArrayOop gtest is broken with Lilliput. The test checks the size of obj-arrays under various settings (coops, ccp) and different alignments, but it does not consider UseCompactObjectHeaders, yet. > > The change adds handling of UseCompactObjectHeaders. > > Testing: > - [x] gtest:objArrayOop (+UCOH) > - [x] gtest:objArrayOop (-UCOH) Were you able to run this test with combination of `ObjectAlignmentBytes` / `UseCompressedClassPointers` and `UseCompressedOops`? I think the test only selects one case out of the runtime configuration. test/hotspot/gtest/oops/test_objArrayOop.cpp line 54: > 52: { 16, false, true, true, 2 }, // 20 byte header, 4 byte oops, 16-byte align > 53: { 16, true, false, true, 4 }, // 16 byte header, 8 byte oops, 16-byte align > 54: { 16, true, true, true, 2 }, // 16 byte header, 4 byte oops, 16-byte align Are these really "20 byte" and "16 byte headers" here? Thought they would be smaller. ------------- PR Review: https://git.openjdk.org/lilliput/pull/114#pullrequestreview-1708873881 PR Review Comment: https://git.openjdk.org/lilliput/pull/114#discussion_r1379210764 From shade at openjdk.org Wed Nov 1 19:43:37 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Wed, 1 Nov 2023 19:43:37 GMT Subject: [master] RFR: 8319135: [Lilliput] Fix objArrayOop gtest In-Reply-To: References: Message-ID: On Mon, 30 Oct 2023 18:42:18 GMT, Roman Kennke wrote: > The objArrayOop gtest is broken with Lilliput. The test checks the size of obj-arrays under various settings (coops, ccp) and different alignments, but it does not consider UseCompactObjectHeaders, yet. > > The change adds handling of UseCompactObjectHeaders. > > Testing: > - [x] gtest:objArrayOop (+UCOH) > - [x] gtest:objArrayOop (-UCOH) OK, so maybe touch up the comments, and this is good to go. ------------- Marked as reviewed by shade (Committer). PR Review: https://git.openjdk.org/lilliput/pull/114#pullrequestreview-1708904564 From rkennke at openjdk.org Wed Nov 1 19:43:37 2023 From: rkennke at openjdk.org (Roman Kennke) Date: Wed, 1 Nov 2023 19:43:37 GMT Subject: [master] RFR: 8319135: [Lilliput] Fix objArrayOop gtest In-Reply-To: References: Message-ID: On Wed, 1 Nov 2023 19:23:18 GMT, Aleksey Shipilev wrote: > Were you able to run this test with combination of `ObjectAlignmentBytes` / `UseCompressedClassPointers` and `UseCompressedOops`? I think the test only selects one case out of the runtime configuration. Right. I tested all combinations now and all are passing. ------------- PR Comment: https://git.openjdk.org/lilliput/pull/114#issuecomment-1789543932 From rkennke at openjdk.org Wed Nov 1 19:48:40 2023 From: rkennke at openjdk.org (Roman Kennke) Date: Wed, 1 Nov 2023 19:48:40 GMT Subject: [master] RFR: 8319135: [Lilliput] Fix objArrayOop gtest [v2] In-Reply-To: References: Message-ID: > The objArrayOop gtest is broken with Lilliput. The test checks the size of obj-arrays under various settings (coops, ccp) and different alignments, but it does not consider UseCompactObjectHeaders, yet. > > The change adds handling of UseCompactObjectHeaders. > > Testing: > - [x] gtest:objArrayOop (+UCOH) > - [x] gtest:objArrayOop (-UCOH) Roman Kennke has updated the pull request incrementally with one additional commit since the last revision: Fix comments ------------- Changes: - all: https://git.openjdk.org/lilliput/pull/114/files - new: https://git.openjdk.org/lilliput/pull/114/files/02b5da1d..170bc4ec Webrevs: - full: https://webrevs.openjdk.org/?repo=lilliput&pr=114&range=01 - incr: https://webrevs.openjdk.org/?repo=lilliput&pr=114&range=00-01 Stats: 6 lines in 1 file changed: 0 ins; 0 del; 6 mod Patch: https://git.openjdk.org/lilliput/pull/114.diff Fetch: git fetch https://git.openjdk.org/lilliput.git pull/114/head:pull/114 PR: https://git.openjdk.org/lilliput/pull/114 From rkennke at openjdk.org Wed Nov 1 20:20:41 2023 From: rkennke at openjdk.org (Roman Kennke) Date: Wed, 1 Nov 2023 20:20:41 GMT Subject: [master] Integrated: 8319135: [Lilliput] Fix objArrayOop gtest In-Reply-To: References: Message-ID: On Mon, 30 Oct 2023 18:42:18 GMT, Roman Kennke wrote: > The objArrayOop gtest is broken with Lilliput. The test checks the size of obj-arrays under various settings (coops, ccp) and different alignments, but it does not consider UseCompactObjectHeaders, yet. > > The change adds handling of UseCompactObjectHeaders. > > Testing: > - [x] gtest:objArrayOop (+UCOH) > - [x] gtest:objArrayOop (-UCOH) This pull request has now been integrated. Changeset: fc9020fb Author: Roman Kennke URL: https://git.openjdk.org/lilliput/commit/fc9020fbf193b1c6d2b2fb5d80192c3082dbcf2e Stats: 29 lines in 1 file changed: 12 ins; 0 del; 17 mod 8319135: [Lilliput] Fix objArrayOop gtest Reviewed-by: shade ------------- PR: https://git.openjdk.org/lilliput/pull/114 From rkennke at openjdk.org Mon Nov 6 11:19:06 2023 From: rkennke at openjdk.org (Roman Kennke) Date: Mon, 6 Nov 2023 11:19:06 GMT Subject: [master] RFR: 8319524: [Lilliput] Only warn when compact headers are explicitly enabled Message-ID: We currently print a warning when a user specifies +UseZGC together with +UseCompactObjectHeaders. We should only print the warning when +UCOH is explicitly enabled at the command-line. This may not be very relevant at the moment, but might be in the future, or in downstreams which may want to enable compact headers by default. When building with +UCOH by default, a number of langtools:tier1 tests are failing because of the warning. Testing: - [x] langtools:tier1 (+UseZGC and hardcoded +UCOH) ------------- Commit messages: - 8319524: [Lilliput] Only warn when compact headers are explicitly enabled Changes: https://git.openjdk.org/lilliput/pull/115/files Webrev: https://webrevs.openjdk.org/?repo=lilliput&pr=115&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8319524 Stats: 3 lines in 1 file changed: 2 ins; 0 del; 1 mod Patch: https://git.openjdk.org/lilliput/pull/115.diff Fetch: git fetch https://git.openjdk.org/lilliput.git pull/115/head:pull/115 PR: https://git.openjdk.org/lilliput/pull/115 From rkennke at openjdk.org Mon Nov 6 11:21:53 2023 From: rkennke at openjdk.org (Roman Kennke) Date: Mon, 6 Nov 2023 11:21:53 GMT Subject: [lilliput-jdk21u:lilliput] RFR: 8319135: [Lilliput] Fix objArrayOop gtest Message-ID: Hi all, This pull request contains a backport of commit [fc9020fb](https://github.com/openjdk/lilliput/commit/fc9020fbf193b1c6d2b2fb5d80192c3082dbcf2e) from the [openjdk/lilliput](https://git.openjdk.org/lilliput) repository. The commit being backported was authored by Roman Kennke on 1 Nov 2023 and was reviewed by Aleksey Shipilev. Thanks! ------------- Commit messages: - Backport fc9020fbf193b1c6d2b2fb5d80192c3082dbcf2e Changes: https://git.openjdk.org/lilliput-jdk21u/pull/12/files Webrev: https://webrevs.openjdk.org/?repo=lilliput-jdk21u&pr=12&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8319135 Stats: 29 lines in 1 file changed: 12 ins; 0 del; 17 mod Patch: https://git.openjdk.org/lilliput-jdk21u/pull/12.diff Fetch: git fetch https://git.openjdk.org/lilliput-jdk21u.git pull/12/head:pull/12 PR: https://git.openjdk.org/lilliput-jdk21u/pull/12 From shade at openjdk.org Mon Nov 6 12:02:47 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Mon, 6 Nov 2023 12:02:47 GMT Subject: [master] RFR: 8319524: [Lilliput] Only warn when compact headers are explicitly enabled In-Reply-To: References: Message-ID: <8hp-rjoeyzFmWKZuPypm2AV3dhKcBBHUWwQTuY6u3Zw=.d9c58c9d-e0a8-493a-823f-136137c7cdda@github.com> On Mon, 6 Nov 2023 11:13:44 GMT, Roman Kennke wrote: > We currently print a warning when a user specifies +UseZGC together with +UseCompactObjectHeaders. We should only print the warning when +UCOH is explicitly enabled at the command-line. This may not be very relevant at the moment, but might be in the future, or in downstreams which may want to enable compact headers by default. > > When building with +UCOH by default, a number of langtools:tier1 tests are failing because of the warning. > > Testing: > - [x] langtools:tier1 (+UseZGC and hardcoded +UCOH) Marked as reviewed by shade (Committer). ------------- PR Review: https://git.openjdk.org/lilliput/pull/115#pullrequestreview-1714996621 From shade at openjdk.org Mon Nov 6 12:09:38 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Mon, 6 Nov 2023 12:09:38 GMT Subject: [lilliput-jdk21u:lilliput] RFR: 8319163: [Lilliput/JDK21] Fix arrayOopDesc gtest In-Reply-To: References: Message-ID: On Tue, 31 Oct 2023 11:09:04 GMT, Roman Kennke wrote: > In Lilliput/JDK21 the arrayOopDesc gtest is broken. It checks the base-offset of all array types with different settings of coops and ccp, but doesn't check UseCompactObjectHeaders. > > The change brings the arrayOopDesc gtest in sync with what is in the lilliput mainline and lilliput-jdk17 repos. > > Testing: > - [x] gtest:arrayOopDesc (+UCOH) > - [x] gtest:arrayOopDesc (-UCOH) Marked as reviewed by shade (Reviewer). ------------- PR Review: https://git.openjdk.org/lilliput-jdk21u/pull/11#pullrequestreview-1715009168 From rkennke at openjdk.org Mon Nov 6 12:13:06 2023 From: rkennke at openjdk.org (Roman Kennke) Date: Mon, 6 Nov 2023 12:13:06 GMT Subject: [lilliput-jdk21u:lilliput] Integrated: 8319163: [Lilliput/JDK21] Fix arrayOopDesc gtest In-Reply-To: References: Message-ID: <4l2zyoY9lBV7r2g1vDiV0RwGVM6izi-sxEALlt6WaDc=.3b6fab96-1a3b-4825-ab29-fb38af588d3f@github.com> On Tue, 31 Oct 2023 11:09:04 GMT, Roman Kennke wrote: > In Lilliput/JDK21 the arrayOopDesc gtest is broken. It checks the base-offset of all array types with different settings of coops and ccp, but doesn't check UseCompactObjectHeaders. > > The change brings the arrayOopDesc gtest in sync with what is in the lilliput mainline and lilliput-jdk17 repos. > > Testing: > - [x] gtest:arrayOopDesc (+UCOH) > - [x] gtest:arrayOopDesc (-UCOH) This pull request has now been integrated. Changeset: 4af2fad9 Author: Roman Kennke URL: https://git.openjdk.org/lilliput-jdk21u/commit/4af2fad9c24fdf815f03a950092ba5656d964653 Stats: 12 lines in 1 file changed: 11 ins; 0 del; 1 mod 8319163: [Lilliput/JDK21] Fix arrayOopDesc gtest Reviewed-by: shade ------------- PR: https://git.openjdk.org/lilliput-jdk21u/pull/11 From rkennke at openjdk.org Mon Nov 6 12:16:36 2023 From: rkennke at openjdk.org (Roman Kennke) Date: Mon, 6 Nov 2023 12:16:36 GMT Subject: [lilliput-jdk21u:lilliput] Integrated: 8319135: [Lilliput] Fix objArrayOop gtest In-Reply-To: References: Message-ID: On Mon, 6 Nov 2023 11:14:48 GMT, Roman Kennke wrote: > Hi all, > > This pull request contains a backport of commit [fc9020fb](https://github.com/openjdk/lilliput/commit/fc9020fbf193b1c6d2b2fb5d80192c3082dbcf2e) from the [openjdk/lilliput](https://git.openjdk.org/lilliput) repository. > > The commit being backported was authored by Roman Kennke on 1 Nov 2023 and was reviewed by Aleksey Shipilev. > > Thanks! This pull request has now been integrated. Changeset: 0406563a Author: Roman Kennke URL: https://git.openjdk.org/lilliput-jdk21u/commit/0406563a390d7a2fc92ff55531050c66f72f2753 Stats: 29 lines in 1 file changed: 12 ins; 0 del; 17 mod 8319135: [Lilliput] Fix objArrayOop gtest Backport-of: fc9020fbf193b1c6d2b2fb5d80192c3082dbcf2e ------------- PR: https://git.openjdk.org/lilliput-jdk21u/pull/12 From rkennke at openjdk.org Mon Nov 6 12:37:19 2023 From: rkennke at openjdk.org (Roman Kennke) Date: Mon, 6 Nov 2023 12:37:19 GMT Subject: [lilliput-jdk17u:lilliput] RFR: 8319135: [Lilliput] Fix objArrayOop gtest Message-ID: Hi all, This pull request contains a backport of commit [fc9020fb](https://github.com/openjdk/lilliput/commit/fc9020fbf193b1c6d2b2fb5d80192c3082dbcf2e) from the [openjdk/lilliput](https://git.openjdk.org/lilliput) repository. The commit being backported was authored by Roman Kennke on 1 Nov 2023 and was reviewed by Aleksey Shipilev. The test does not yet exist in lilliput-jdk17u. It has originally been introduced in the [openjdk/lilliput](https://git.openjdk.org/lilliput) repository, I am adding it here in full. Thanks! ------------- Commit messages: - Backport fc9020fbf193b1c6d2b2fb5d80192c3082dbcf2e Changes: https://git.openjdk.org/lilliput-jdk17u/pull/61/files Webrev: https://webrevs.openjdk.org/?repo=lilliput-jdk17u&pr=61&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8319135 Stats: 69 lines in 1 file changed: 69 ins; 0 del; 0 mod Patch: https://git.openjdk.org/lilliput-jdk17u/pull/61.diff Fetch: git fetch https://git.openjdk.org/lilliput-jdk17u.git pull/61/head:pull/61 PR: https://git.openjdk.org/lilliput-jdk17u/pull/61 From shade at openjdk.org Mon Nov 6 12:37:20 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Mon, 6 Nov 2023 12:37:20 GMT Subject: [lilliput-jdk17u:lilliput] RFR: 8319135: [Lilliput] Fix objArrayOop gtest In-Reply-To: References: Message-ID: On Mon, 6 Nov 2023 12:21:08 GMT, Roman Kennke wrote: > Hi all, > > This pull request contains a backport of commit [fc9020fb](https://github.com/openjdk/lilliput/commit/fc9020fbf193b1c6d2b2fb5d80192c3082dbcf2e) from the [openjdk/lilliput](https://git.openjdk.org/lilliput) repository. > > The commit being backported was authored by Roman Kennke on 1 Nov 2023 and was reviewed by Aleksey Shipilev. > > The test does not yet exist in lilliput-jdk17u. It has originally been introduced in the [openjdk/lilliput](https://git.openjdk.org/lilliput) repository, I am adding it here in full. > > Thanks! Marked as reviewed by shade (Reviewer). ------------- PR Review: https://git.openjdk.org/lilliput-jdk17u/pull/61#pullrequestreview-1715052357 From rkennke at openjdk.org Mon Nov 6 13:34:14 2023 From: rkennke at openjdk.org (Roman Kennke) Date: Mon, 6 Nov 2023 13:34:14 GMT Subject: [lilliput-jdk17u:lilliput] RFR: 8319135: [Lilliput] Fix objArrayOop gtest [v2] In-Reply-To: References: Message-ID: > Hi all, > > This pull request contains a backport of commit [fc9020fb](https://github.com/openjdk/lilliput/commit/fc9020fbf193b1c6d2b2fb5d80192c3082dbcf2e) from the [openjdk/lilliput](https://git.openjdk.org/lilliput) repository. > > The commit being backported was authored by Roman Kennke on 1 Nov 2023 and was reviewed by Aleksey Shipilev. > > The test does not yet exist in lilliput-jdk17u. It has originally been introduced in the [openjdk/lilliput](https://git.openjdk.org/lilliput) repository, I am adding it here in full. > > Thanks! Roman Kennke has updated the pull request incrementally with one additional commit since the last revision: Remove bad cast ------------- Changes: - all: https://git.openjdk.org/lilliput-jdk17u/pull/61/files - new: https://git.openjdk.org/lilliput-jdk17u/pull/61/files/24add19f..3212d20c Webrevs: - full: https://webrevs.openjdk.org/?repo=lilliput-jdk17u&pr=61&range=01 - incr: https://webrevs.openjdk.org/?repo=lilliput-jdk17u&pr=61&range=00-01 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/lilliput-jdk17u/pull/61.diff Fetch: git fetch https://git.openjdk.org/lilliput-jdk17u.git pull/61/head:pull/61 PR: https://git.openjdk.org/lilliput-jdk17u/pull/61 From rkennke at openjdk.org Mon Nov 6 16:09:48 2023 From: rkennke at openjdk.org (Roman Kennke) Date: Mon, 6 Nov 2023 16:09:48 GMT Subject: [master] Integrated: 8319524: [Lilliput] Only warn when compact headers are explicitly enabled In-Reply-To: References: Message-ID: On Mon, 6 Nov 2023 11:13:44 GMT, Roman Kennke wrote: > We currently print a warning when a user specifies +UseZGC together with +UseCompactObjectHeaders. We should only print the warning when +UCOH is explicitly enabled at the command-line. This may not be very relevant at the moment, but might be in the future, or in downstreams which may want to enable compact headers by default. > > When building with +UCOH by default, a number of langtools:tier1 tests are failing because of the warning. > > Testing: > - [x] langtools:tier1 (+UseZGC and hardcoded +UCOH) This pull request has now been integrated. Changeset: 3f73f014 Author: Roman Kennke URL: https://git.openjdk.org/lilliput/commit/3f73f014097262455cc42a71c32af374b77b6efd Stats: 3 lines in 1 file changed: 2 ins; 0 del; 1 mod 8319524: [Lilliput] Only warn when compact headers are explicitly enabled Reviewed-by: shade ------------- PR: https://git.openjdk.org/lilliput/pull/115 From rkennke at openjdk.org Mon Nov 6 16:30:03 2023 From: rkennke at openjdk.org (Roman Kennke) Date: Mon, 6 Nov 2023 16:30:03 GMT Subject: [lilliput-jdk21u:lilliput] RFR: 8319524: [Lilliput] Only warn when compact headers are explicitly enabled Message-ID: <2k5iiNdzAHrBnA-P7_2ywfgJb-Mpl8th2vAUSDB9WqM=.a1b50316-bb53-4831-9c91-c795bae49924@github.com> Hi all, This pull request contains a backport of commit [3f73f014](https://github.com/openjdk/lilliput/commit/3f73f014097262455cc42a71c32af374b77b6efd) from the [openjdk/lilliput](https://git.openjdk.org/lilliput) repository. The commit being backported was authored by Roman Kennke on 6 Nov 2023 and was reviewed by Aleksey Shipilev. Thanks! ------------- Commit messages: - Backport 3f73f014097262455cc42a71c32af374b77b6efd Changes: https://git.openjdk.org/lilliput-jdk21u/pull/13/files Webrev: https://webrevs.openjdk.org/?repo=lilliput-jdk21u&pr=13&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8319524 Stats: 3 lines in 1 file changed: 2 ins; 0 del; 1 mod Patch: https://git.openjdk.org/lilliput-jdk21u/pull/13.diff Fetch: git fetch https://git.openjdk.org/lilliput-jdk21u.git pull/13/head:pull/13 PR: https://git.openjdk.org/lilliput-jdk21u/pull/13 From rkennke at openjdk.org Tue Nov 7 11:37:04 2023 From: rkennke at openjdk.org (Roman Kennke) Date: Tue, 7 Nov 2023 11:37:04 GMT Subject: [lilliput-jdk21u:lilliput] Integrated: 8319524: [Lilliput] Only warn when compact headers are explicitly enabled In-Reply-To: <2k5iiNdzAHrBnA-P7_2ywfgJb-Mpl8th2vAUSDB9WqM=.a1b50316-bb53-4831-9c91-c795bae49924@github.com> References: <2k5iiNdzAHrBnA-P7_2ywfgJb-Mpl8th2vAUSDB9WqM=.a1b50316-bb53-4831-9c91-c795bae49924@github.com> Message-ID: On Mon, 6 Nov 2023 16:24:30 GMT, Roman Kennke wrote: > Hi all, > > This pull request contains a backport of commit [3f73f014](https://github.com/openjdk/lilliput/commit/3f73f014097262455cc42a71c32af374b77b6efd) from the [openjdk/lilliput](https://git.openjdk.org/lilliput) repository. > > The commit being backported was authored by Roman Kennke on 6 Nov 2023 and was reviewed by Aleksey Shipilev. > > Thanks! This pull request has now been integrated. Changeset: 4876421b Author: Roman Kennke URL: https://git.openjdk.org/lilliput-jdk21u/commit/4876421bcea7d14feb901bd1d2c66b08bea8338b Stats: 3 lines in 1 file changed: 2 ins; 0 del; 1 mod 8319524: [Lilliput] Only warn when compact headers are explicitly enabled Backport-of: 3f73f014097262455cc42a71c32af374b77b6efd ------------- PR: https://git.openjdk.org/lilliput-jdk21u/pull/13 From rkennke at openjdk.org Wed Nov 8 15:57:17 2023 From: rkennke at openjdk.org (Roman Kennke) Date: Wed, 8 Nov 2023 15:57:17 GMT Subject: [master] RFR: 8319724: [Lilliput] ParallelGC: Forwarded objects found during heap inspection Message-ID: This is the Lilliput variant of [JDK-8319376](https://bugs.openjdk.org/browse/JDK-8319376). With Lilliput we need special treatment of the fix, because the iterator needs to access the Klass*, which it can only get via the forwardee. Testing: - [x] gc/logging/TestUnifiedLoggingSwitchStress.java +UseParallelGC +UCOH - [x] gc/logging/TestUnifiedLoggingSwitchStress.java +UseParallelGC -UCOH - [ ] hotspot_gc +UCOH - [ ] tier1 +UCOH - [ ] tier2 +UCOH ------------- Commit messages: - 8319724: [Lilliput] ParallelGC: Forwarded objects found during heap inspection Changes: https://git.openjdk.org/lilliput/pull/116/files Webrev: https://webrevs.openjdk.org/?repo=lilliput&pr=116&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8319724 Stats: 31 lines in 2 files changed: 28 ins; 0 del; 3 mod Patch: https://git.openjdk.org/lilliput/pull/116.diff Fetch: git fetch https://git.openjdk.org/lilliput.git pull/116/head:pull/116 PR: https://git.openjdk.org/lilliput/pull/116 From shade at openjdk.org Wed Nov 8 16:14:35 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Wed, 8 Nov 2023 16:14:35 GMT Subject: [master] RFR: 8319724: [Lilliput] ParallelGC: Forwarded objects found during heap inspection In-Reply-To: References: Message-ID: On Wed, 8 Nov 2023 15:51:39 GMT, Roman Kennke wrote: > This is the Lilliput variant of [JDK-8319376](https://bugs.openjdk.org/browse/JDK-8319376). With Lilliput we need special treatment of the fix, because the iterator needs to access the Klass*, which it can only get via the forwardee. > > Testing: > - [x] gc/logging/TestUnifiedLoggingSwitchStress.java +UseParallelGC +UCOH > - [x] gc/logging/TestUnifiedLoggingSwitchStress.java +UseParallelGC -UCOH > - [ ] hotspot_gc +UCOH > - [ ] tier1 +UCOH > - [ ] tier2 +UCOH src/hotspot/share/gc/parallel/mutableSpace.cpp line 254: > 252: p += obj->forwardee()->size(); > 253: } else { > 254: p += obj->size(); Is this just `oopDesc::forward_safe_size()`? ------------- PR Review Comment: https://git.openjdk.org/lilliput/pull/116#discussion_r1386875673 From shade at openjdk.org Wed Nov 8 16:54:22 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Wed, 8 Nov 2023 16:54:22 GMT Subject: [master] RFR: 8319724: [Lilliput] ParallelGC: Forwarded objects found during heap inspection In-Reply-To: References: Message-ID: On Wed, 8 Nov 2023 15:51:39 GMT, Roman Kennke wrote: > This is the Lilliput variant of [JDK-8319376](https://bugs.openjdk.org/browse/JDK-8319376). With Lilliput we need special treatment of the fix, because the iterator needs to access the Klass*, which it can only get via the forwardee. > > Testing: > - [x] gc/logging/TestUnifiedLoggingSwitchStress.java +UseParallelGC +UCOH > - [x] gc/logging/TestUnifiedLoggingSwitchStress.java +UseParallelGC -UCOH > - [ ] hotspot_gc +UCOH > - [ ] tier1 +UCOH > - [ ] tier2 +UCOH Marked as reviewed by shade (Committer). ------------- PR Review: https://git.openjdk.org/lilliput/pull/116#pullrequestreview-1720835100 From rkennke at openjdk.org Wed Nov 8 16:54:24 2023 From: rkennke at openjdk.org (Roman Kennke) Date: Wed, 8 Nov 2023 16:54:24 GMT Subject: [master] RFR: 8319724: [Lilliput] ParallelGC: Forwarded objects found during heap inspection In-Reply-To: References: Message-ID: On Wed, 8 Nov 2023 16:12:02 GMT, Aleksey Shipilev wrote: >> This is the Lilliput variant of [JDK-8319376](https://bugs.openjdk.org/browse/JDK-8319376). With Lilliput we need special treatment of the fix, because the iterator needs to access the Klass*, which it can only get via the forwardee. >> >> Testing: >> - [x] gc/logging/TestUnifiedLoggingSwitchStress.java +UseParallelGC +UCOH >> - [x] gc/logging/TestUnifiedLoggingSwitchStress.java +UseParallelGC -UCOH >> - [ ] hotspot_gc +UCOH >> - [ ] tier1 +UCOH >> - [ ] tier2 +UCOH > > src/hotspot/share/gc/parallel/mutableSpace.cpp line 254: > >> 252: p += obj->forwardee()->size(); >> 253: } else { >> 254: p += obj->size(); > > Is this just `oopDesc::forward_safe_size()`? kinda, yeah, but optimized to avoid the UCOH check for every object and do it once outside of the loop, which is probably important in the object iterator. ------------- PR Review Comment: https://git.openjdk.org/lilliput/pull/116#discussion_r1386926175 From shade at openjdk.org Wed Nov 8 16:54:24 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Wed, 8 Nov 2023 16:54:24 GMT Subject: [master] RFR: 8319724: [Lilliput] ParallelGC: Forwarded objects found during heap inspection In-Reply-To: References: Message-ID: On Wed, 8 Nov 2023 16:49:09 GMT, Roman Kennke wrote: >> src/hotspot/share/gc/parallel/mutableSpace.cpp line 254: >> >>> 252: p += obj->forwardee()->size(); >>> 253: } else { >>> 254: p += obj->size(); >> >> Is this just `oopDesc::forward_safe_size()`? > > kinda, yeah, but optimized to avoid the UCOH check for every object and do it once outside of the loop, which is probably important in the object iterator. All right then. ------------- PR Review Comment: https://git.openjdk.org/lilliput/pull/116#discussion_r1386929173 From rkennke at openjdk.org Thu Nov 9 10:18:35 2023 From: rkennke at openjdk.org (Roman Kennke) Date: Thu, 9 Nov 2023 10:18:35 GMT Subject: [master] Integrated: 8319724: [Lilliput] ParallelGC: Forwarded objects found during heap inspection In-Reply-To: References: Message-ID: On Wed, 8 Nov 2023 15:51:39 GMT, Roman Kennke wrote: > This is the Lilliput variant of [JDK-8319376](https://bugs.openjdk.org/browse/JDK-8319376). With Lilliput we need special treatment of the fix, because the iterator needs to access the Klass*, which it can only get via the forwardee. > > Testing: > - [x] gc/logging/TestUnifiedLoggingSwitchStress.java +UseParallelGC +UCOH > - [x] gc/logging/TestUnifiedLoggingSwitchStress.java +UseParallelGC -UCOH > - [x] hotspot_gc +UCOH > - [x] tier1 +UCOH > - [x] tier2 +UCOH This pull request has now been integrated. Changeset: 0568386e Author: Roman Kennke URL: https://git.openjdk.org/lilliput/commit/0568386e062474b1fc31e2e7106db0079ded7d76 Stats: 31 lines in 2 files changed: 28 ins; 0 del; 3 mod 8319724: [Lilliput] ParallelGC: Forwarded objects found during heap inspection Reviewed-by: shade ------------- PR: https://git.openjdk.org/lilliput/pull/116 From rkennke at openjdk.org Thu Nov 9 10:28:41 2023 From: rkennke at openjdk.org (Roman Kennke) Date: Thu, 9 Nov 2023 10:28:41 GMT Subject: [lilliput-jdk21u:lilliput] RFR: 8319724: [Lilliput] ParallelGC: Forwarded objects found during heap inspection Message-ID: Clean backport of https://github.com/openjdk/lilliput/pull/116 to lilliput-jdk21u ------------- Commit messages: - Backport 0568386e062474b1fc31e2e7106db0079ded7d76 Changes: https://git.openjdk.org/lilliput-jdk21u/pull/14/files Webrev: https://webrevs.openjdk.org/?repo=lilliput-jdk21u&pr=14&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8319724 Stats: 31 lines in 2 files changed: 28 ins; 0 del; 3 mod Patch: https://git.openjdk.org/lilliput-jdk21u/pull/14.diff Fetch: git fetch https://git.openjdk.org/lilliput-jdk21u.git pull/14/head:pull/14 PR: https://git.openjdk.org/lilliput-jdk21u/pull/14 From rkennke at openjdk.org Thu Nov 9 10:41:43 2023 From: rkennke at openjdk.org (Roman Kennke) Date: Thu, 9 Nov 2023 10:41:43 GMT Subject: [lilliput-jdk17u:lilliput] RFR: 8319724: [Lilliput] ParallelGC: Forwarded objects found during heap inspection Message-ID: <5AaAktoMaqhdcAcAabWmR4vHBwcYChcL0KcotCaPIvk=.e215697e-9332-46f6-99d5-49086d87bf0b@github.com> Hi all, This pull request contains a backport of commit [0568386e](https://github.com/openjdk/lilliput/commit/0568386e062474b1fc31e2e7106db0079ded7d76) from the [openjdk/lilliput](https://git.openjdk.org/lilliput) repository. The commit being backported was authored by Roman Kennke on 9 Nov 2023 and was reviewed by Aleksey Shipilev. Thanks! ------------- Commit messages: - Backport 0568386e062474b1fc31e2e7106db0079ded7d76 Changes: https://git.openjdk.org/lilliput-jdk17u/pull/62/files Webrev: https://webrevs.openjdk.org/?repo=lilliput-jdk17u&pr=62&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8319724 Stats: 31 lines in 2 files changed: 28 ins; 0 del; 3 mod Patch: https://git.openjdk.org/lilliput-jdk17u/pull/62.diff Fetch: git fetch https://git.openjdk.org/lilliput-jdk17u.git pull/62/head:pull/62 PR: https://git.openjdk.org/lilliput-jdk17u/pull/62 From rkennke at openjdk.org Thu Nov 9 11:56:33 2023 From: rkennke at openjdk.org (Roman Kennke) Date: Thu, 9 Nov 2023 11:56:33 GMT Subject: [lilliput-jdk17u:lilliput] Integrated: 8319724: [Lilliput] ParallelGC: Forwarded objects found during heap inspection In-Reply-To: <5AaAktoMaqhdcAcAabWmR4vHBwcYChcL0KcotCaPIvk=.e215697e-9332-46f6-99d5-49086d87bf0b@github.com> References: <5AaAktoMaqhdcAcAabWmR4vHBwcYChcL0KcotCaPIvk=.e215697e-9332-46f6-99d5-49086d87bf0b@github.com> Message-ID: On Thu, 9 Nov 2023 10:34:04 GMT, Roman Kennke wrote: > Hi all, > > This pull request contains a backport of commit [0568386e](https://github.com/openjdk/lilliput/commit/0568386e062474b1fc31e2e7106db0079ded7d76) from the [openjdk/lilliput](https://git.openjdk.org/lilliput) repository. > > The commit being backported was authored by Roman Kennke on 9 Nov 2023 and was reviewed by Aleksey Shipilev. > > Thanks! This pull request has now been integrated. Changeset: 28fc5f24 Author: Roman Kennke URL: https://git.openjdk.org/lilliput-jdk17u/commit/28fc5f249ab974d14c5d79290a0255f9c4f855ae Stats: 31 lines in 2 files changed: 28 ins; 0 del; 3 mod 8319724: [Lilliput] ParallelGC: Forwarded objects found during heap inspection Backport-of: 0568386e062474b1fc31e2e7106db0079ded7d76 ------------- PR: https://git.openjdk.org/lilliput-jdk17u/pull/62 From rkennke at openjdk.org Thu Nov 9 11:56:35 2023 From: rkennke at openjdk.org (Roman Kennke) Date: Thu, 9 Nov 2023 11:56:35 GMT Subject: [lilliput-jdk21u:lilliput] Integrated: 8319724: [Lilliput] ParallelGC: Forwarded objects found during heap inspection In-Reply-To: References: Message-ID: On Thu, 9 Nov 2023 10:20:51 GMT, Roman Kennke wrote: > Clean backport of https://github.com/openjdk/lilliput/pull/116 to lilliput-jdk21u This pull request has now been integrated. Changeset: d139dae3 Author: Roman Kennke URL: https://git.openjdk.org/lilliput-jdk21u/commit/d139dae3677fa7be2eed17c97a3eff487edbdcfb Stats: 31 lines in 2 files changed: 28 ins; 0 del; 3 mod 8319724: [Lilliput] ParallelGC: Forwarded objects found during heap inspection Backport-of: 0568386e062474b1fc31e2e7106db0079ded7d76 ------------- PR: https://git.openjdk.org/lilliput-jdk21u/pull/14 From rkennke at openjdk.org Thu Nov 9 13:43:55 2023 From: rkennke at openjdk.org (Roman Kennke) Date: Thu, 9 Nov 2023 13:43:55 GMT Subject: [lilliput-jdk17u:lilliput] Integrated: 8319135: [Lilliput] Fix objArrayOop gtest In-Reply-To: References: Message-ID: On Mon, 6 Nov 2023 12:21:08 GMT, Roman Kennke wrote: > Hi all, > > This pull request contains a backport of commit [fc9020fb](https://github.com/openjdk/lilliput/commit/fc9020fbf193b1c6d2b2fb5d80192c3082dbcf2e) from the [openjdk/lilliput](https://git.openjdk.org/lilliput) repository. > > The commit being backported was authored by Roman Kennke on 1 Nov 2023 and was reviewed by Aleksey Shipilev. > > The test does not yet exist in lilliput-jdk17u. It has originally been introduced in the [openjdk/lilliput](https://git.openjdk.org/lilliput) repository, I am adding it here in full. > > Thanks! This pull request has now been integrated. Changeset: 2c7d32d8 Author: Roman Kennke URL: https://git.openjdk.org/lilliput-jdk17u/commit/2c7d32d8a21dd4183687cc9631d9beafecef025d Stats: 69 lines in 1 file changed: 69 ins; 0 del; 0 mod 8319135: [Lilliput] Fix objArrayOop gtest Reviewed-by: shade Backport-of: fc9020fbf193b1c6d2b2fb5d80192c3082dbcf2e ------------- PR: https://git.openjdk.org/lilliput-jdk17u/pull/61 From duke at openjdk.org Tue Nov 21 08:37:54 2023 From: duke at openjdk.org (duke) Date: Tue, 21 Nov 2023 08:37:54 GMT Subject: git: openjdk/lilliput: created branch JDK-8319185 based on the branch master containing 1 unique commit Message-ID: <69f94c49-7789-4729-89ed-5eaecec89d9b@openjdk.org> The following commits are unique to the JDK-8319185 branch: ======================================================== 5fd00d64: 8319185: [Lilliput] Enable and fix vectorization tests From duke at openjdk.org Tue Nov 21 09:09:18 2023 From: duke at openjdk.org (duke) Date: Tue, 21 Nov 2023 09:09:18 GMT Subject: git: openjdk/lilliput: JDK-8319185: Untabify test Message-ID: <65fbaef5-988c-4105-890c-d9135941bd2d@openjdk.org> Changeset: f42de386 Author: Roman Kennke Date: 2023-11-21 09:08:06 +0000 URL: https://git.openjdk.org/lilliput/commit/f42de386d97200f5d66f10d425da3e8ef821b1c5 Untabify test ! test/hotspot/jtreg/compiler/c2/irTests/TestVectorizationMismatchedAccess.java From duke at openjdk.org Tue Nov 21 09:17:35 2023 From: duke at openjdk.org (duke) Date: Tue, 21 Nov 2023 09:17:35 GMT Subject: git: openjdk/lilliput: JDK-8319185: More whitespace fixes Message-ID: Changeset: 1873107c Author: Roman Kennke Date: 2023-11-21 09:14:45 +0000 URL: https://git.openjdk.org/lilliput/commit/1873107ce7627ed25473f1b8f4e7a0af5e69ddd7 More whitespace fixes ! test/hotspot/jtreg/compiler/c2/irTests/TestVectorizationMismatchedAccess.java ! test/hotspot/jtreg/compiler/lib/ir_framework/TestFramework.java From rkennke at openjdk.org Tue Nov 21 09:21:01 2023 From: rkennke at openjdk.org (Roman Kennke) Date: Tue, 21 Nov 2023 09:21:01 GMT Subject: [master] RFR: 8319185: [Lilliput] Enable and fix vectorization tests Message-ID: The change does two (related) things: - It white-lists the UseCompactObjectHeaders flag in the IR testing framework. Without this, the flag would not be passed through to any IR framework test. - That first change makes 3 tests fail. Those are all vectorization tests, and they are failing because 'small' array types (4-byte-elements and smaller) no longer have their elements aligned at 8-byte-boundaries. This throws off vectorization because this only kicks in on aligned accesses. The fix is to allocate those arrays a little larger and align-up the test data to the next 8-byte-boundary. (And no, Lilliput does not break vectorization in general, but it can change the characteristics in particular cases.) Testing: - [x] compiler/c2/irTests/TestVectorizationMismatchedAccess.java +UCOH - [x] compiler/c2/irTests/TestVectorizationNotRun.java +UCOH - [x] compiler/loopopts/superword/TestIndependentPacksWithCyclicDependency.java +UCOH - [x] compiler/c2/irTests/TestVectorizationMismatchedAccess.java -UCOH - [x] compiler/c2/irTests/TestVectorizationNotRun.java -UCOH - [x] compiler/loopopts/superword/TestIndependentPacksWithCyclicDependency.java -UCOH - [x] tier1 +UCOH - [x] tier1 -UCOH ------------- Commit messages: - More whitespace fixes - Untabify test - 8319185: [Lilliput] Enable and fix vectorization tests Changes: https://git.openjdk.org/lilliput/pull/117/files Webrev: https://webrevs.openjdk.org/?repo=lilliput&pr=117&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8319185 Stats: 95 lines in 4 files changed: 57 ins; 0 del; 38 mod Patch: https://git.openjdk.org/lilliput/pull/117.diff Fetch: git fetch https://git.openjdk.org/lilliput.git pull/117/head:pull/117 PR: https://git.openjdk.org/lilliput/pull/117 From rkennke at openjdk.org Tue Nov 21 10:57:33 2023 From: rkennke at openjdk.org (Roman Kennke) Date: Tue, 21 Nov 2023 10:57:33 GMT Subject: [master] RFR: 8319185: [Lilliput] Enable and fix vectorization tests In-Reply-To: References: Message-ID: On Tue, 21 Nov 2023 08:44:32 GMT, Roman Kennke wrote: > The change does two (related) things: > - It white-lists the UseCompactObjectHeaders flag in the IR testing framework. Without this, the flag would not be passed through to any IR framework test. > - That first change makes 3 tests fail. Those are all vectorization tests, and they are failing because 'small' array types (4-byte-elements and smaller) no longer have their elements aligned at 8-byte-boundaries. This throws off vectorization because this only kicks in on aligned accesses. The fix is to allocate those arrays a little larger and align-up the test data to the next 8-byte-boundary. (And no, Lilliput does not break vectorization in general, but it can change the characteristics in particular cases.) > > Testing: > - [x] compiler/c2/irTests/TestVectorizationMismatchedAccess.java +UCOH > - [x] compiler/c2/irTests/TestVectorizationNotRun.java +UCOH > - [x] compiler/loopopts/superword/TestIndependentPacksWithCyclicDependency.java +UCOH > - [x] compiler/c2/irTests/TestVectorizationMismatchedAccess.java -UCOH > - [x] compiler/c2/irTests/TestVectorizationNotRun.java -UCOH > - [x] compiler/loopopts/superword/TestIndependentPacksWithCyclicDependency.java -UCOH > - [x] tier1 +UCOH > - [x] tier1 -UCOH wrong repo/branch in PR, see #118 instead ------------- PR Comment: https://git.openjdk.org/lilliput/pull/117#issuecomment-1820685469 From rkennke at openjdk.org Tue Nov 21 10:57:34 2023 From: rkennke at openjdk.org (Roman Kennke) Date: Tue, 21 Nov 2023 10:57:34 GMT Subject: [master] Withdrawn: 8319185: [Lilliput] Enable and fix vectorization tests In-Reply-To: References: Message-ID: On Tue, 21 Nov 2023 08:44:32 GMT, Roman Kennke wrote: > The change does two (related) things: > - It white-lists the UseCompactObjectHeaders flag in the IR testing framework. Without this, the flag would not be passed through to any IR framework test. > - That first change makes 3 tests fail. Those are all vectorization tests, and they are failing because 'small' array types (4-byte-elements and smaller) no longer have their elements aligned at 8-byte-boundaries. This throws off vectorization because this only kicks in on aligned accesses. The fix is to allocate those arrays a little larger and align-up the test data to the next 8-byte-boundary. (And no, Lilliput does not break vectorization in general, but it can change the characteristics in particular cases.) > > Testing: > - [x] compiler/c2/irTests/TestVectorizationMismatchedAccess.java +UCOH > - [x] compiler/c2/irTests/TestVectorizationNotRun.java +UCOH > - [x] compiler/loopopts/superword/TestIndependentPacksWithCyclicDependency.java +UCOH > - [x] compiler/c2/irTests/TestVectorizationMismatchedAccess.java -UCOH > - [x] compiler/c2/irTests/TestVectorizationNotRun.java -UCOH > - [x] compiler/loopopts/superword/TestIndependentPacksWithCyclicDependency.java -UCOH > - [x] tier1 +UCOH > - [x] tier1 -UCOH This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/lilliput/pull/117 From rkennke at openjdk.org Tue Nov 21 11:00:01 2023 From: rkennke at openjdk.org (Roman Kennke) Date: Tue, 21 Nov 2023 11:00:01 GMT Subject: [master] RFR: 8319185: [Lilliput] Enable and fix vectorization tests Message-ID: The change does two (related) things: - It white-lists the UseCompactObjectHeaders flag in the IR testing framework. Without this, the flag would not be passed through to any IR framework test. - That first change makes 3 tests fail. Those are all vectorization tests, and they are failing because 'small' array types (4-byte-elements and smaller) no longer have their elements aligned at 8-byte-boundaries. This throws off vectorization because this only kicks in on aligned accesses. The fix is to allocate those arrays a little larger and align-up the test data to the next 8-byte-boundary. (And no, Lilliput does not break vectorization in general, but it can change the characteristics in particular cases.) Testing: - [x] compiler/c2/irTests/TestVectorizationMismatchedAccess.java +UCOH - [x] compiler/c2/irTests/TestVectorizationNotRun.java +UCOH - [x] compiler/loopopts/superword/TestIndependentPacksWithCyclicDependency.java +UCOH - [x] compiler/c2/irTests/TestVectorizationMismatchedAccess.java -UCOH - [x] compiler/c2/irTests/TestVectorizationNotRun.java -UCOH - [x] compiler/loopopts/superword/TestIndependentPacksWithCyclicDependency.java -UCOH - [x] tier1 +UCOH - [x] tier1 -UCOH ------------- Commit messages: - More whitespace fixes - Untabify test - 8319185: [Lilliput] Enable and fix vectorization tests Changes: https://git.openjdk.org/lilliput/pull/118/files Webrev: https://webrevs.openjdk.org/?repo=lilliput&pr=118&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8319185 Stats: 95 lines in 4 files changed: 57 ins; 0 del; 38 mod Patch: https://git.openjdk.org/lilliput/pull/118.diff Fetch: git fetch https://git.openjdk.org/lilliput.git pull/118/head:pull/118 PR: https://git.openjdk.org/lilliput/pull/118 From rkennke at openjdk.org Wed Nov 22 11:58:50 2023 From: rkennke at openjdk.org (Roman Kennke) Date: Wed, 22 Nov 2023 11:58:50 GMT Subject: [master] RFR: Merge jdk:jdk-22+25 Message-ID: Let's merge latest upstream tag. ------------- Commit messages: - Merge tag 'jdk-22+25' into merge-jdk-22+25 - 8074211: javax.sound.midi: Error with send System Exclusive messages of different length - 8320278: ARM32 build is broken after JDK-8301997 - 8318364: Add an FFM-based implementation of harfbuzz OpenType layout - 8319124: Update XML Security for Java to 3.0.3 - 8317742: ISO Standard Date Format implementation consistency on DateTimeFormatter and String.format - 8320272: Make method_entry_barrier address shared - 8320526: Use title case in building.md - 8315969: compiler/rangechecks/TestRangeCheckHoistingScaledIV.java: make flagless - 8187591: -Werror turns incubator module warning to an error - ... and 562 more: https://git.openjdk.org/lilliput/compare/0568386e...79546a5c The webrevs contain the adjustments done while merging with regards to each parent branch: - master: https://webrevs.openjdk.org/?repo=lilliput&pr=119&range=00.0 - jdk:jdk-22+25: https://webrevs.openjdk.org/?repo=lilliput&pr=119&range=00.1 Changes: https://git.openjdk.org/lilliput/pull/119/files Stats: 704267 lines in 3572 files changed: 132106 ins; 492081 del; 80080 mod Patch: https://git.openjdk.org/lilliput/pull/119.diff Fetch: git fetch https://git.openjdk.org/lilliput.git pull/119/head:pull/119 PR: https://git.openjdk.org/lilliput/pull/119 From rkennke at openjdk.org Wed Nov 22 12:23:10 2023 From: rkennke at openjdk.org (Roman Kennke) Date: Wed, 22 Nov 2023 12:23:10 GMT Subject: [lilliput-jdk21u:lilliput] RFR: Merge jdk21u:jdk-21.0.1-ga Message-ID: Let's merge the latest jdk21u tag/release. ------------- Commit messages: - Merge tag 'jdk-21.0.1-ga' into merge-jdk-21.0.1-ga - 8317121: vector_masked_load instruction is moved too early after JDK-8286941 - Merge - 8313323: javac -g on a java file which uses unnamed variable leads to ClassFormatError when launching that class - 8315534: Incorrect warnings about implicit annotation processing - 8299658: C1 compilation crashes in LinearScan::resolve_exception_edge - 8309032: jpackage does not work for module projects unless --module-path is specified - 8314024: SIGSEGV in PhaseIdealLoop::build_loop_late_post_work due to bad immediate dominator info - 8311033: [macos] PrinterJob does not take into account Sides attribute - 8315051: jdk/jfr/jvm/TestGetEventWriter.java fails with non-JVMCI GCs - ... and 60 more: https://git.openjdk.org/lilliput-jdk21u/compare/d139dae3...86a063a3 The webrevs contain the adjustments done while merging with regards to each parent branch: - lilliput: https://webrevs.openjdk.org/?repo=lilliput-jdk21u&pr=15&range=00.0 - jdk21u:jdk-21.0.1-ga: https://webrevs.openjdk.org/?repo=lilliput-jdk21u&pr=15&range=00.1 Changes: https://git.openjdk.org/lilliput-jdk21u/pull/15/files Stats: 7535 lines in 220 files changed: 6145 ins; 757 del; 633 mod Patch: https://git.openjdk.org/lilliput-jdk21u/pull/15.diff Fetch: git fetch https://git.openjdk.org/lilliput-jdk21u.git pull/15/head:pull/15 PR: https://git.openjdk.org/lilliput-jdk21u/pull/15 From rkennke at openjdk.org Wed Nov 22 14:10:17 2023 From: rkennke at openjdk.org (Roman Kennke) Date: Wed, 22 Nov 2023 14:10:17 GMT Subject: [lilliput-jdk17u:lilliput] RFR: Merge jdk17u:jdk-17.0.10+4 Message-ID: Let's merge the latest upstream jdk17u tag. ------------- Commit messages: - Merge tag 'jdk-17.0.10+4' into merge-jdk-17.0.10+4 - 8279856: Parallel: Use PreservedMarks to record promotion-failed objects - 8262186: Call X509KeyManager.chooseClientAlias once for all key types - 8302109: Trivial fixes to btree tests - 8292067: Convert test/sun/management/jmxremote/bootstrap shell tests to java version - 8320053: GHA: Cross-compile gtest code - 8317834: java/lang/Thread/IsAlive.java timed out - 8316645: RISC-V: Remove dependency on libatomic by adding cmpxchg 1b - 8319958: test/jdk/java/io/File/libGetXSpace.c does not compile on Windows 32-bit - 8318759: Add four DigiCert root certificates - ... and 256 more: https://git.openjdk.org/lilliput-jdk17u/compare/2c7d32d8...63e7235f The webrevs contain the adjustments done while merging with regards to each parent branch: - lilliput: https://webrevs.openjdk.org/?repo=lilliput-jdk17u&pr=63&range=00.0 - jdk17u:jdk-17.0.10+4: https://webrevs.openjdk.org/?repo=lilliput-jdk17u&pr=63&range=00.1 Changes: https://git.openjdk.org/lilliput-jdk17u/pull/63/files Stats: 36645 lines in 900 files changed: 18940 ins; 13179 del; 4526 mod Patch: https://git.openjdk.org/lilliput-jdk17u/pull/63.diff Fetch: git fetch https://git.openjdk.org/lilliput-jdk17u.git pull/63/head:pull/63 PR: https://git.openjdk.org/lilliput-jdk17u/pull/63 From rkennke at openjdk.org Wed Nov 22 17:21:57 2023 From: rkennke at openjdk.org (Roman Kennke) Date: Wed, 22 Nov 2023 17:21:57 GMT Subject: [lilliput-jdk21u:lilliput] Integrated: Merge jdk21u:jdk-21.0.1-ga In-Reply-To: References: Message-ID: On Wed, 22 Nov 2023 12:05:37 GMT, Roman Kennke wrote: > Let's merge the latest jdk21u tag/release. This pull request has now been integrated. Changeset: 11afa8a4 Author: Roman Kennke URL: https://git.openjdk.org/lilliput-jdk21u/commit/11afa8a4344b877ca5e80df1b64f6d5764a987ee Stats: 7535 lines in 220 files changed: 6145 ins; 757 del; 633 mod Merge ------------- PR: https://git.openjdk.org/lilliput-jdk21u/pull/15 From rkennke at openjdk.org Wed Nov 22 17:22:29 2023 From: rkennke at openjdk.org (Roman Kennke) Date: Wed, 22 Nov 2023 17:22:29 GMT Subject: [lilliput-jdk17u:lilliput] RFR: Merge jdk17u:jdk-17.0.10+4 [v2] In-Reply-To: References: Message-ID: <-fd29EAwAI98B8QnmvYdN57u0W0-ZewUGHqmuC3nYAk=.e1f24a48-cb10-49d1-93e2-edc4c4501212@github.com> > Let's merge the latest upstream jdk17u tag. Roman Kennke has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 63 commits: - Merge tag 'jdk-17.0.10+4' into merge-jdk-17.0.10+4 Added tag jdk-17.0.10+4 for changeset 40c29f7d80b5 - 8319135: [Lilliput] Fix objArrayOop gtest Reviewed-by: shade Backport-of: fc9020fbf193b1c6d2b2fb5d80192c3082dbcf2e - 8319724: [Lilliput] ParallelGC: Forwarded objects found during heap inspection Backport-of: 0568386e062474b1fc31e2e7106db0079ded7d76 - 8318172: [Lilliput/JDK17] Disable Lilliput in TestZGCWithCDS Reviewed-by: shade - 8317957: [Lilliput/JDK17] Make C2 LoadNKlassCompactHeader more robust Reviewed-by: shade - Merge - 8314894: [Lilliput/JDK17] Revert changes in zRelocate, prevent ZGC with Lilliput Reviewed-by: shade - 8308411: [Lilliput/JDK17] Cherry-pick: 8283710: JVMTI: Use BitSet for object marking Reviewed-by: shade - 8314131: [Lilliput/JDK17] Make loadNKlassCompactHeaders not use a TEMP register Reviewed-by: shade - 8312606: [Lilliput/JDK17] Cherry-pick: 8276333: jdk/jfr/event/oldobject/TestLargeRootSet.java failed "assert(!contains(edge->reference())) failed: invariant" Reviewed-by: shade - ... and 53 more: https://git.openjdk.org/lilliput-jdk17u/compare/40c29f7d...63e7235f ------------- Changes: https://git.openjdk.org/lilliput-jdk17u/pull/63/files Webrev: https://webrevs.openjdk.org/?repo=lilliput-jdk17u&pr=63&range=01 Stats: 6955 lines in 208 files changed: 4968 ins; 1025 del; 962 mod Patch: https://git.openjdk.org/lilliput-jdk17u/pull/63.diff Fetch: git fetch https://git.openjdk.org/lilliput-jdk17u.git pull/63/head:pull/63 PR: https://git.openjdk.org/lilliput-jdk17u/pull/63 From rkennke at openjdk.org Wed Nov 22 17:22:31 2023 From: rkennke at openjdk.org (Roman Kennke) Date: Wed, 22 Nov 2023 17:22:31 GMT Subject: [lilliput-jdk17u:lilliput] Integrated: Merge jdk17u:jdk-17.0.10+4 In-Reply-To: References: Message-ID: On Wed, 22 Nov 2023 14:03:10 GMT, Roman Kennke wrote: > Let's merge the latest upstream jdk17u tag. This pull request has now been integrated. Changeset: bbeb721f Author: Roman Kennke URL: https://git.openjdk.org/lilliput-jdk17u/commit/bbeb721fcaa1c5b87fdcbf4014e7749ef4ce5b84 Stats: 36645 lines in 900 files changed: 18940 ins; 13179 del; 4526 mod Merge ------------- PR: https://git.openjdk.org/lilliput-jdk17u/pull/63 From rkennke at openjdk.org Wed Nov 22 17:22:58 2023 From: rkennke at openjdk.org (Roman Kennke) Date: Wed, 22 Nov 2023 17:22:58 GMT Subject: [master] RFR: Merge jdk:jdk-22+25 [v2] In-Reply-To: References: Message-ID: > Let's merge latest upstream tag. Roman Kennke has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 113 commits: - Merge tag 'jdk-22+25' into merge-jdk-22+25 Added tag jdk-22+25 for changeset e47cf611 - 8319724: [Lilliput] ParallelGC: Forwarded objects found during heap inspection Reviewed-by: shade - 8319524: [Lilliput] Only warn when compact headers are explicitly enabled Reviewed-by: shade - 8319135: [Lilliput] Fix objArrayOop gtest Reviewed-by: shade - Merge jdk:jdk-22+19 - 8318011: [Lilliput] Fix CDS narrowKlass encoding Reviewed-by: shade, stuefe - 8317812: [Lilliput] Make C2 LoadNKlassCompactHeader more robust Reviewed-by: shade - 8317352: [Lilliput] Sync with upstreaming PRs Reviewed-by: shade - 8314863: [Lilliput] Revert changes in zRelocate, prevent ZGC with Lilliput Reviewed-by: shade - Merge jdk - ... and 103 more: https://git.openjdk.org/lilliput/compare/e47cf611...79546a5c ------------- Changes: https://git.openjdk.org/lilliput/pull/119/files Webrev: https://webrevs.openjdk.org/?repo=lilliput&pr=119&range=01 Stats: 3169 lines in 158 files changed: 2599 ins; 214 del; 356 mod Patch: https://git.openjdk.org/lilliput/pull/119.diff Fetch: git fetch https://git.openjdk.org/lilliput.git pull/119/head:pull/119 PR: https://git.openjdk.org/lilliput/pull/119 From rkennke at openjdk.org Wed Nov 22 17:23:06 2023 From: rkennke at openjdk.org (Roman Kennke) Date: Wed, 22 Nov 2023 17:23:06 GMT Subject: [master] Integrated: Merge jdk:jdk-22+25 In-Reply-To: References: Message-ID: On Wed, 22 Nov 2023 11:51:21 GMT, Roman Kennke wrote: > Let's merge latest upstream tag. This pull request has now been integrated. Changeset: c11d6476 Author: Roman Kennke URL: https://git.openjdk.org/lilliput/commit/c11d6476a4d68ba8a05ef28c444ac22cc1388ca6 Stats: 704267 lines in 3572 files changed: 132106 ins; 492081 del; 80080 mod Merge jdk:jdk-22+25 ------------- PR: https://git.openjdk.org/lilliput/pull/119 From rkennke at openjdk.org Thu Nov 23 14:33:05 2023 From: rkennke at openjdk.org (Roman Kennke) Date: Thu, 23 Nov 2023 14:33:05 GMT Subject: [lilliput-jdk17u:lilliput] RFR: 8319524: [Lilliput] Only warn when compact headers are explicitly enabled Message-ID: This backports [JDK-8319524: [Lilliput] Only warn when compact headers are explicitly enabled ](https://bugs.openjdk.org/browse/JDK-8319524) to lilliput-jdk17u. The backport is not clean, because there is no ZGenerational flag to check. - [x] tier1 +UCOH +ZGC ------------- Commit messages: - Backport 3f73f014097262455cc42a71c32af374b77b6efd Changes: https://git.openjdk.org/lilliput-jdk17u/pull/64/files Webrev: https://webrevs.openjdk.org/?repo=lilliput-jdk17u&pr=64&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8319524 Stats: 3 lines in 1 file changed: 2 ins; 0 del; 1 mod Patch: https://git.openjdk.org/lilliput-jdk17u/pull/64.diff Fetch: git fetch https://git.openjdk.org/lilliput-jdk17u.git pull/64/head:pull/64 PR: https://git.openjdk.org/lilliput-jdk17u/pull/64 From rkennke at openjdk.org Thu Nov 23 15:20:00 2023 From: rkennke at openjdk.org (Roman Kennke) Date: Thu, 23 Nov 2023 15:20:00 GMT Subject: [lilliput-jdk17u:lilliput] RFR: 8320666: [Lilliput/JDK17] Add arrayOopDesc::base_offset() gtests Message-ID: Mainline and JDK21 trees of Lilliput have a gtest that checks the base-offset of various array types under different settings. We should also have it in the Lilliput/JDK17u tree. Testing: - [x] gtest:arrayOopDesc +UCOH - [x] gtest:arrayOopDesc -UCOH - [x] gtest:arrayOopDesc -CCP ------------- Commit messages: - 8320666: [Lilliput/JDK17] Add arrayOopDesc::base_offset() gtest Changes: https://git.openjdk.org/lilliput-jdk17u/pull/65/files Webrev: https://webrevs.openjdk.org/?repo=lilliput-jdk17u&pr=65&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8320666 Stats: 55 lines in 1 file changed: 55 ins; 0 del; 0 mod Patch: https://git.openjdk.org/lilliput-jdk17u/pull/65.diff Fetch: git fetch https://git.openjdk.org/lilliput-jdk17u.git pull/65/head:pull/65 PR: https://git.openjdk.org/lilliput-jdk17u/pull/65 From shade at openjdk.org Thu Nov 23 16:11:36 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Thu, 23 Nov 2023 16:11:36 GMT Subject: [lilliput-jdk17u:lilliput] RFR: 8320666: [Lilliput/JDK17] Add arrayOopDesc::base_offset() gtests In-Reply-To: References: Message-ID: <5ihXvRGvP5apeX-eCqHoVJWnPFR25iBYxi8KgyT0BBo=.7a5012bd-27d5-4f88-9db4-d22d0a60274e@github.com> On Thu, 23 Nov 2023 15:11:15 GMT, Roman Kennke wrote: > Mainline and JDK21 trees of Lilliput have a gtest that checks the base-offset of various array types under different settings. We should also have it in the Lilliput/JDK17u tree. > > Testing: > - [x] gtest:arrayOopDesc +UCOH > - [x] gtest:arrayOopDesc -UCOH > - [x] gtest:arrayOopDesc -CCP Marked as reviewed by shade (Reviewer). ------------- PR Review: https://git.openjdk.org/lilliput-jdk17u/pull/65#pullrequestreview-1746755262 From shade at openjdk.org Thu Nov 23 16:13:44 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Thu, 23 Nov 2023 16:13:44 GMT Subject: [lilliput-jdk17u:lilliput] RFR: 8319524: [Lilliput] Only warn when compact headers are explicitly enabled In-Reply-To: References: Message-ID: On Thu, 23 Nov 2023 14:26:13 GMT, Roman Kennke wrote: > This backports [JDK-8319524: [Lilliput] Only warn when compact headers are explicitly enabled > ](https://bugs.openjdk.org/browse/JDK-8319524) to lilliput-jdk17u. The backport is not clean, because there is no ZGenerational flag to check. > > - [x] tier1 +UCOH +ZGC Marked as reviewed by shade (Reviewer). ------------- PR Review: https://git.openjdk.org/lilliput-jdk17u/pull/64#pullrequestreview-1746757662 From rkennke at openjdk.org Thu Nov 23 19:27:29 2023 From: rkennke at openjdk.org (Roman Kennke) Date: Thu, 23 Nov 2023 19:27:29 GMT Subject: [lilliput-jdk17u:lilliput] Integrated: 8319524: [Lilliput] Only warn when compact headers are explicitly enabled In-Reply-To: References: Message-ID: On Thu, 23 Nov 2023 14:26:13 GMT, Roman Kennke wrote: > This backports [JDK-8319524: [Lilliput] Only warn when compact headers are explicitly enabled > ](https://bugs.openjdk.org/browse/JDK-8319524) to lilliput-jdk17u. The backport is not clean, because there is no ZGenerational flag to check. > > - [x] tier1 +UCOH +ZGC This pull request has now been integrated. Changeset: a916ef1c Author: Roman Kennke URL: https://git.openjdk.org/lilliput-jdk17u/commit/a916ef1cc8dd76683f5a76ecc96f37ccc26677fa Stats: 3 lines in 1 file changed: 2 ins; 0 del; 1 mod 8319524: [Lilliput] Only warn when compact headers are explicitly enabled Reviewed-by: shade Backport-of: 3f73f014097262455cc42a71c32af374b77b6efd ------------- PR: https://git.openjdk.org/lilliput-jdk17u/pull/64 From rkennke at openjdk.org Fri Nov 24 13:59:42 2023 From: rkennke at openjdk.org (Roman Kennke) Date: Fri, 24 Nov 2023 13:59:42 GMT Subject: [lilliput-jdk17u:lilliput] Integrated: 8320666: [Lilliput/JDK17] Add arrayOopDesc::base_offset() gtest In-Reply-To: References: Message-ID: On Thu, 23 Nov 2023 15:11:15 GMT, Roman Kennke wrote: > Mainline and JDK21 trees of Lilliput have a gtest that checks the base-offset of various array types under different settings. We should also have it in the Lilliput/JDK17u tree. > > Testing: > - [x] gtest:arrayOopDesc +UCOH > - [x] gtest:arrayOopDesc -UCOH > - [x] gtest:arrayOopDesc -CCP This pull request has now been integrated. Changeset: e0899ff1 Author: Roman Kennke URL: https://git.openjdk.org/lilliput-jdk17u/commit/e0899ff14dbfcfee1beb7d30aa798f1871448e3d Stats: 55 lines in 1 file changed: 55 ins; 0 del; 0 mod 8320666: [Lilliput/JDK17] Add arrayOopDesc::base_offset() gtest Reviewed-by: shade ------------- PR: https://git.openjdk.org/lilliput-jdk17u/pull/65 From rkennke at openjdk.org Mon Nov 27 12:06:56 2023 From: rkennke at openjdk.org (Roman Kennke) Date: Mon, 27 Nov 2023 12:06:56 GMT Subject: [lilliput-jdk17u:lilliput] RFR: 8316179: Use consistent naming for lightweight locking in MacroAssembler Message-ID: Backport of upstream renaming, preparation for follow-up backports. Leaves out the arm, ppc and riscv parts, which don't have the lightweight locking implementation in Lilliput-JDK17u. Testing: - [x] tier1 +UCOH aarch64 - [x] tier2 +UCOH aarch64 - [x] tier1 +UCOH x86_64 - [x] tier2 +UCOH x86_64 ------------- Commit messages: - Fix x86 build - Backport 639ba13c4b0ada1c2ae0a46e99ed707c219b3e53 Changes: https://git.openjdk.org/lilliput-jdk17u/pull/66/files Webrev: https://webrevs.openjdk.org/?repo=lilliput-jdk17u&pr=66&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8316179 Stats: 73 lines in 15 files changed: 22 ins; 2 del; 49 mod Patch: https://git.openjdk.org/lilliput-jdk17u/pull/66.diff Fetch: git fetch https://git.openjdk.org/lilliput-jdk17u.git pull/66/head:pull/66 PR: https://git.openjdk.org/lilliput-jdk17u/pull/66 From rkennke at openjdk.org Mon Nov 27 12:13:04 2023 From: rkennke at openjdk.org (Roman Kennke) Date: Mon, 27 Nov 2023 12:13:04 GMT Subject: [lilliput-jdk17u:lilliput] RFR: 8316179: Use consistent naming for lightweight locking in MacroAssembler [v2] In-Reply-To: References: Message-ID: > Backport of upstream renaming, preparation for follow-up backports. Leaves out the arm, ppc and riscv parts, which don't have the lightweight locking implementation in Lilliput-JDK17u. > > Testing: > - [x] tier1 +UCOH aarch64 > - [x] tier2 +UCOH aarch64 > - [x] tier1 +UCOH x86_64 > - [x] tier2 +UCOH x86_64 Roman Kennke has updated the pull request incrementally with two additional commits since the last revision: - Merge remote-tracking branch 'rkennke/rkennke-backport-639ba13c' into rkennke-backport-639ba13c - Revert unrelated changes ------------- Changes: - all: https://git.openjdk.org/lilliput-jdk17u/pull/66/files - new: https://git.openjdk.org/lilliput-jdk17u/pull/66/files/cfac1e9c..e4c84a86 Webrevs: - full: https://webrevs.openjdk.org/?repo=lilliput-jdk17u&pr=66&range=01 - incr: https://webrevs.openjdk.org/?repo=lilliput-jdk17u&pr=66&range=00-01 Stats: 41 lines in 6 files changed: 1 ins; 22 del; 18 mod Patch: https://git.openjdk.org/lilliput-jdk17u/pull/66.diff Fetch: git fetch https://git.openjdk.org/lilliput-jdk17u.git pull/66/head:pull/66 PR: https://git.openjdk.org/lilliput-jdk17u/pull/66 From rkennke at openjdk.org Thu Nov 30 17:59:16 2023 From: rkennke at openjdk.org (Roman Kennke) Date: Thu, 30 Nov 2023 17:59:16 GMT Subject: [lilliput-jdk21u:lilliput] RFR: 8321134: [Lilliput/JDK21] Fix repo permissions Message-ID: The Lilliput/JDK21u repo has the wrong permissons: it inherits permissions from jdk-updates, but should use permission from she Shenandoah project instead. ------------- Commit messages: - 8321134: [Lilliput/JDK21] Fix repo permissions Changes: https://git.openjdk.org/lilliput-jdk21u/pull/16/files Webrev: https://webrevs.openjdk.org/?repo=lilliput-jdk21u&pr=16&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8321134 Stats: 3 lines in 1 file changed: 0 ins; 0 del; 3 mod Patch: https://git.openjdk.org/lilliput-jdk21u/pull/16.diff Fetch: git fetch https://git.openjdk.org/lilliput-jdk21u.git pull/16/head:pull/16 PR: https://git.openjdk.org/lilliput-jdk21u/pull/16 From shade at openjdk.org Thu Nov 30 17:59:17 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Thu, 30 Nov 2023 17:59:17 GMT Subject: [lilliput-jdk21u:lilliput] RFR: 8321134: [Lilliput/JDK21] Fix repo permissions In-Reply-To: References: Message-ID: On Thu, 30 Nov 2023 17:49:55 GMT, Roman Kennke wrote: > The Lilliput/JDK21u repo has the wrong permissons: it inherits permissions from jdk-updates, but should use permission from she Shenandoah project instead. Marked as reviewed by shade (Reviewer). ------------- PR Review: https://git.openjdk.org/lilliput-jdk21u/pull/16#pullrequestreview-1758130391 From rkennke at openjdk.org Thu Nov 30 17:59:18 2023 From: rkennke at openjdk.org (Roman Kennke) Date: Thu, 30 Nov 2023 17:59:18 GMT Subject: [lilliput-jdk21u:lilliput] RFR: 8321134: [Lilliput/JDK21] Fix repo permissions In-Reply-To: References: Message-ID: On Thu, 30 Nov 2023 17:49:55 GMT, Roman Kennke wrote: > The Lilliput/JDK21u repo has the wrong permissons: it inherits permissions from jdk-updates, but should use permission from she Shenandoah project instead. Thanks! ------------- PR Comment: https://git.openjdk.org/lilliput-jdk21u/pull/16#issuecomment-1834280960 From rkennke at openjdk.org Thu Nov 30 18:00:20 2023 From: rkennke at openjdk.org (Roman Kennke) Date: Thu, 30 Nov 2023 18:00:20 GMT Subject: [lilliput-jdk17u:lilliput] RFR: 8321135: [Lilliput/JDK17] Fix repo permissions Message-ID: The Lilliput/JDK17u repo has the wrong permissons: it inherits permissions from jdk-updates, but should use permission from she Shenandoah project instead. ------------- Commit messages: - 8321135: [Lilliput/JDK17] Fix repo permissions Changes: https://git.openjdk.org/lilliput-jdk17u/pull/67/files Webrev: https://webrevs.openjdk.org/?repo=lilliput-jdk17u&pr=67&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8321135 Stats: 3 lines in 1 file changed: 0 ins; 0 del; 3 mod Patch: https://git.openjdk.org/lilliput-jdk17u/pull/67.diff Fetch: git fetch https://git.openjdk.org/lilliput-jdk17u.git pull/67/head:pull/67 PR: https://git.openjdk.org/lilliput-jdk17u/pull/67 From rkennke at openjdk.org Thu Nov 30 18:02:42 2023 From: rkennke at openjdk.org (Roman Kennke) Date: Thu, 30 Nov 2023 18:02:42 GMT Subject: [lilliput-jdk21u:lilliput] Integrated: 8321134: [Lilliput/JDK21] Fix repo permissions In-Reply-To: References: Message-ID: On Thu, 30 Nov 2023 17:49:55 GMT, Roman Kennke wrote: > The Lilliput/JDK21u repo has the wrong permissons: it inherits permissions from jdk-updates, but should use permission from she Shenandoah project instead. This pull request has now been integrated. Changeset: e3adaa5b Author: Roman Kennke URL: https://git.openjdk.org/lilliput-jdk21u/commit/e3adaa5bd3a81f1ab2138d9e437b678febe63023 Stats: 3 lines in 1 file changed: 0 ins; 0 del; 3 mod 8321134: [Lilliput/JDK21] Fix repo permissions Reviewed-by: shade ------------- PR: https://git.openjdk.org/lilliput-jdk21u/pull/16 From shade at openjdk.org Thu Nov 30 18:06:39 2023 From: shade at openjdk.org (Aleksey Shipilev) Date: Thu, 30 Nov 2023 18:06:39 GMT Subject: [lilliput-jdk17u:lilliput] RFR: 8321135: [Lilliput/JDK17] Fix repo permissions In-Reply-To: References: Message-ID: On Thu, 30 Nov 2023 17:54:35 GMT, Roman Kennke wrote: > The Lilliput/JDK17u repo has the wrong permissons: it inherits permissions from jdk-updates, but should use permission from she Shenandoah project instead. Marked as reviewed by shade (Reviewer). ------------- PR Review: https://git.openjdk.org/lilliput-jdk17u/pull/67#pullrequestreview-1758148111 From rkennke at openjdk.org Thu Nov 30 18:12:35 2023 From: rkennke at openjdk.org (Roman Kennke) Date: Thu, 30 Nov 2023 18:12:35 GMT Subject: [lilliput-jdk17u:lilliput] RFR: 8321135: [Lilliput/JDK17] Fix repo permissions In-Reply-To: References: Message-ID: On Thu, 30 Nov 2023 17:54:35 GMT, Roman Kennke wrote: > The Lilliput/JDK17u repo has the wrong permissons: it inherits permissions from jdk-updates, but should use permission from she Shenandoah project instead. Thanks! ------------- PR Comment: https://git.openjdk.org/lilliput-jdk17u/pull/67#issuecomment-1834300677 From rkennke at openjdk.org Thu Nov 30 18:12:36 2023 From: rkennke at openjdk.org (Roman Kennke) Date: Thu, 30 Nov 2023 18:12:36 GMT Subject: [lilliput-jdk17u:lilliput] Integrated: 8321135: [Lilliput/JDK17] Fix repo permissions In-Reply-To: References: Message-ID: On Thu, 30 Nov 2023 17:54:35 GMT, Roman Kennke wrote: > The Lilliput/JDK17u repo has the wrong permissons: it inherits permissions from jdk-updates, but should use permission from she Shenandoah project instead. This pull request has now been integrated. Changeset: 35c51935 Author: Roman Kennke URL: https://git.openjdk.org/lilliput-jdk17u/commit/35c519355e4595ad6f24c83f69cccb6bc2619d29 Stats: 3 lines in 1 file changed: 0 ins; 0 del; 3 mod 8321135: [Lilliput/JDK17] Fix repo permissions Reviewed-by: shade ------------- PR: https://git.openjdk.org/lilliput-jdk17u/pull/67