[master] RFR: 8317345: [Lilliput] CDS fixes [v2]

Aleksey Shipilev shade at openjdk.org
Mon Oct 2 17:29:43 UTC 2023


On Mon, 2 Oct 2023 15:24:31 GMT, Roman Kennke <rkennke at openjdk.org> wrote:

>> Sync CDS code with https://github.com/openjdk/jdk/pull/13961 to fix some JTREG failures. It also includes a bunch of test fixes for ZGC/CDS, similar to https://github.com/openjdk/lilliput-jdk21u/pull/7. The changes make tier1 cds tests clean.
>> 
>> Testing:
>>  - [x] tier1 (+UCOH)
>>  - [x] tier1 (-UCOH)
>
> Roman Kennke has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Add proper guards

src/hotspot/share/cds/archiveBuilder.cpp line 728:

> 726:     k->remove_java_mirror();
> 727: #ifdef _LP64
> 728: #ifdef INCLUDE_CDS_JAVA_HEAP

Should be `#if`, not `#ifdef`?

-------------

PR Review Comment: https://git.openjdk.org/lilliput/pull/109#discussion_r1342948832


More information about the lilliput-dev mailing list