[master] RFR: 8317812: [Lilliput] Make C2 LoadNKlassCompactHeader more robust [v7]

Roman Kennke rkennke at openjdk.org
Thu Oct 12 08:59:39 UTC 2023


> Lilliput's C2 code for generating LoadNKlass currently assumes that the disp of the incoming address is klass_offset_in_bytes. It then extracts the base register and loads from the mark_offset_in_bytes instead.
> Sometimes (apparently very rarely) it happens that C2 emits code that pre-adds obj+klass_offset into a register, and uses that as base, but with offset 0. In this case we would trip the assert or crash in release builds.
> 
> - [x] specjvm derby (which triggered the bug)
> - [x] tier1 x86_64 +UCOH
> - [x] tier1 aarch64 +UCOH

Roman Kennke has updated the pull request incrementally with one additional commit since the last revision:

  Accept indexed address

-------------

Changes:
  - all: https://git.openjdk.org/lilliput/pull/111/files
  - new: https://git.openjdk.org/lilliput/pull/111/files/1a4686df..400fc8c6

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=lilliput&pr=111&range=06
 - incr: https://webrevs.openjdk.org/?repo=lilliput&pr=111&range=05-06

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/lilliput/pull/111.diff
  Fetch: git fetch https://git.openjdk.org/lilliput.git pull/111/head:pull/111

PR: https://git.openjdk.org/lilliput/pull/111


More information about the lilliput-dev mailing list