From rkennke at openjdk.org  Tue Sep 12 10:39:29 2023
From: rkennke at openjdk.org (Roman Kennke)
Date: Tue, 12 Sep 2023 10:39:29 GMT
Subject: [lilliput-jdk21u:lilliput] Integrated: 8315047: [Lilliput/JDK21] Some
 additions to 8139457: Array bases are aligned at HeapWord granularity
In-Reply-To: <LX6vsm0e5gKC66MUE-xMDlDh2gd4K-nuKKLXzVSi6so=.a89ea0a8-aeb1-4cd0-bfef-0f7fe2d8c47c@github.com>
References: <LX6vsm0e5gKC66MUE-xMDlDh2gd4K-nuKKLXzVSi6so=.a89ea0a8-aeb1-4cd0-bfef-0f7fe2d8c47c@github.com>
Message-ID: <j6_dWrD_kE_ngJVzjCYzCXOEs1yH6n1KXU8oZ7Gv-Pk=.b23be1a7-de28-41f2-a102-b8e39d45b474@github.com>

On Fri, 25 Aug 2023 18:17:03 GMT, Roman Kennke <rkennke at openjdk.org> wrote:

> The original cherry-pick for 8139457 missed a couple of new tests. Also, I'd also bring in some recent updates from the PR (in response to reviews).
> 
> Testing:
>  - [x] tier1 -CCP
>  - [x] tier1 +CCP

This pull request has now been integrated.

Changeset: 51108cb8
Author:    Roman Kennke <rkennke at openjdk.org>
URL:       https://git.openjdk.org/lilliput-jdk21u/commit/51108cb80ec4e524e6550dd4b392a8a5c66bcfc5
Stats:     399 lines in 15 files changed: 349 ins; 33 del; 17 mod

8315047: [Lilliput/JDK21] Some additions to 8139457: Array bases are aligned at HeapWord granularity

Reviewed-by: shade

-------------

PR: https://git.openjdk.org/lilliput-jdk21u/pull/2

From rkennke at openjdk.org  Tue Sep 12 10:47:17 2023
From: rkennke at openjdk.org (Roman Kennke)
Date: Tue, 12 Sep 2023 10:47:17 GMT
Subject: [lilliput-jdk21u:lilliput] RFR: 8315046: [Lilliput/JDK21]
 Cherry-pick: 8305896: Alternative full GC forwarding [v2]
In-Reply-To: <oX9QrbUz2xuBg0PfyblzJGgW8vcH0iyPl93uRNFU-ao=.6f08f09d-f800-4248-823e-62ba5769c6f7@github.com>
References: <oX9QrbUz2xuBg0PfyblzJGgW8vcH0iyPl93uRNFU-ao=.6f08f09d-f800-4248-823e-62ba5769c6f7@github.com>
Message-ID: <yswFhPJykzU1s9Mjog3akpSR2sqMgwzaSkbhiq0vX-g=.040c224c-5dbe-4655-a040-e29d07658c90@github.com>

> Let's cherry-pick the alternative full GC forwarding PR in its current state into Lilliput-21.
> I needed to make some adjustments because PreservedMarks stuff has been refactored between 21 and 22.
> 
> Testing:
> - [ ] hotspot_gc +UseAltGCForwarding
> - [ ] hotspot_gc -UseAltGCForwarding

Roman Kennke has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision:

 - Merge branch 'lilliput' into JDK-8315046
 - 8315046: [Lilliput/JDK21] Cherry-pick: 8305896: Alternative full GC forwarding

-------------

Changes:
  - all: https://git.openjdk.org/lilliput-jdk21u/pull/3/files
  - new: https://git.openjdk.org/lilliput-jdk21u/pull/3/files/fd29cbb7..7e4e993f

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=lilliput-jdk21u&pr=3&range=01
 - incr: https://webrevs.openjdk.org/?repo=lilliput-jdk21u&pr=3&range=00-01

  Stats: 399 lines in 15 files changed: 349 ins; 33 del; 17 mod
  Patch: https://git.openjdk.org/lilliput-jdk21u/pull/3.diff
  Fetch: git fetch https://git.openjdk.org/lilliput-jdk21u.git pull/3/head:pull/3

PR: https://git.openjdk.org/lilliput-jdk21u/pull/3

From shade at openjdk.org  Tue Sep 12 10:52:29 2023
From: shade at openjdk.org (Aleksey Shipilev)
Date: Tue, 12 Sep 2023 10:52:29 GMT
Subject: [lilliput-jdk21u:lilliput] RFR: 8315046: [Lilliput/JDK21]
 Cherry-pick: 8305896: Alternative full GC forwarding [v2]
In-Reply-To: <yswFhPJykzU1s9Mjog3akpSR2sqMgwzaSkbhiq0vX-g=.040c224c-5dbe-4655-a040-e29d07658c90@github.com>
References: <oX9QrbUz2xuBg0PfyblzJGgW8vcH0iyPl93uRNFU-ao=.6f08f09d-f800-4248-823e-62ba5769c6f7@github.com>
 <yswFhPJykzU1s9Mjog3akpSR2sqMgwzaSkbhiq0vX-g=.040c224c-5dbe-4655-a040-e29d07658c90@github.com>
Message-ID: <LnmV-hmOTujFgzoqbu_cdyxxlXF7J6BVDdS0j5IHw34=.58f4cafe-44e4-498b-a475-2443dee91c5a@github.com>

On Tue, 12 Sep 2023 10:47:17 GMT, Roman Kennke <rkennke at openjdk.org> wrote:

>> Let's cherry-pick the alternative full GC forwarding PR in its current state into Lilliput-21.
>> I needed to make some adjustments because PreservedMarks stuff has been refactored between 21 and 22.
>> 
>> Testing:
>> - [ ] hotspot_gc +UseAltGCForwarding
>> - [ ] hotspot_gc -UseAltGCForwarding
>
> Roman Kennke has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision:
> 
>  - Merge branch 'lilliput' into JDK-8315046
>  - 8315046: [Lilliput/JDK21] Cherry-pick: 8305896: Alternative full GC forwarding

Marked as reviewed by shade (Reviewer).

-------------

PR Review: https://git.openjdk.org/lilliput-jdk21u/pull/3#pullrequestreview-1621959457

From rkennke at openjdk.org  Tue Sep 12 10:59:11 2023
From: rkennke at openjdk.org (Roman Kennke)
Date: Tue, 12 Sep 2023 10:59:11 GMT
Subject: [lilliput-jdk21u:lilliput] Integrated: 8315046: [Lilliput/JDK21]
 Cherry-pick: 8305896: Alternative full GC forwarding
In-Reply-To: <oX9QrbUz2xuBg0PfyblzJGgW8vcH0iyPl93uRNFU-ao=.6f08f09d-f800-4248-823e-62ba5769c6f7@github.com>
References: <oX9QrbUz2xuBg0PfyblzJGgW8vcH0iyPl93uRNFU-ao=.6f08f09d-f800-4248-823e-62ba5769c6f7@github.com>
Message-ID: <ezShNYyjmDIMXxhNQTiYamGSgben4EoWItA8Re3kPBM=.e560bc72-fe9e-4cd2-ba61-e0958f2a7fdb@github.com>

On Fri, 25 Aug 2023 18:34:54 GMT, Roman Kennke <rkennke at openjdk.org> wrote:

> Let's cherry-pick the alternative full GC forwarding PR in its current state into Lilliput-21.
> I needed to make some adjustments because PreservedMarks stuff has been refactored between 21 and 22.
> 
> Testing:
> - [x] hotspot_gc +UseAltGCForwarding
> - [x] hotspot_gc -UseAltGCForwarding

This pull request has now been integrated.

Changeset: 882ff141
Author:    Roman Kennke <rkennke at openjdk.org>
URL:       https://git.openjdk.org/lilliput-jdk21u/commit/882ff1417ac89181712aacc04d2ae734d435c27a
Stats:     1196 lines in 39 files changed: 1077 ins; 10 del; 109 mod

8315046: [Lilliput/JDK21] Cherry-pick: 8305896: Alternative full GC forwarding

Reviewed-by: shade

-------------

PR: https://git.openjdk.org/lilliput-jdk21u/pull/3

From rkennke at openjdk.org  Tue Sep 12 11:23:43 2023
From: rkennke at openjdk.org (Roman Kennke)
Date: Tue, 12 Sep 2023 11:23:43 GMT
Subject: [lilliput-jdk21u:lilliput] RFR: 8316108: [Lilliput/JDK21] Cherry-pick:
 8305898: Alternative self-forwarding mechanism
Message-ID: <zRQDqzEOQpNoRti0u67TyHzk1lZ7jIOP2MnuWLAWpYM=.c04694ef-0fc3-449c-98bf-b4b09a679ac3@github.com>

Let's cherry-pick the current state of the upstream PR https://github.com/openjdk/jdk/pull/13779. It applies cleanly on top of lilliput/jdk21u.

Testing:
 - [ ] hotspot_gc (+UseAltGCForwarding)
 - [ ] hotspot_gc (-UseAltGCForwarding)

-------------

Commit messages:
 - 8316108: [Lilliput/JDK21] Cherry-pick: 8305898: Alternative self-forwarding mechanism

Changes: https://git.openjdk.org/lilliput-jdk21u/pull/4/files
 Webrev: https://webrevs.openjdk.org/?repo=lilliput-jdk21u&pr=4&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8316108
  Stats: 101 lines in 8 files changed: 85 ins; 2 del; 14 mod
  Patch: https://git.openjdk.org/lilliput-jdk21u/pull/4.diff
  Fetch: git fetch https://git.openjdk.org/lilliput-jdk21u.git pull/4/head:pull/4

PR: https://git.openjdk.org/lilliput-jdk21u/pull/4

From shade at openjdk.org  Tue Sep 12 11:39:09 2023
From: shade at openjdk.org (Aleksey Shipilev)
Date: Tue, 12 Sep 2023 11:39:09 GMT
Subject: [lilliput-jdk21u:lilliput] RFR: 8316108: [Lilliput/JDK21]
 Cherry-pick: 8305898: Alternative self-forwarding mechanism
In-Reply-To: <zRQDqzEOQpNoRti0u67TyHzk1lZ7jIOP2MnuWLAWpYM=.c04694ef-0fc3-449c-98bf-b4b09a679ac3@github.com>
References: <zRQDqzEOQpNoRti0u67TyHzk1lZ7jIOP2MnuWLAWpYM=.c04694ef-0fc3-449c-98bf-b4b09a679ac3@github.com>
Message-ID: <K3ObsMgaHuPh5WYzLa-briGHzfch3STwchUSscqfUVs=.b6bf591e-422a-4528-a676-6529b4485c9d@github.com>

On Tue, 12 Sep 2023 11:15:28 GMT, Roman Kennke <rkennke at openjdk.org> wrote:

> Let's cherry-pick the current state of the upstream PR https://github.com/openjdk/jdk/pull/13779. It applies cleanly on top of lilliput/jdk21u.
> 
> Testing:
>  - [ ] hotspot_gc (+UseAltGCForwarding)
>  - [ ] hotspot_gc (-UseAltGCForwarding)

Looks okay.

-------------

Marked as reviewed by shade (Reviewer).

PR Review: https://git.openjdk.org/lilliput-jdk21u/pull/4#pullrequestreview-1622037095

From rkennke at openjdk.org  Tue Sep 12 14:56:30 2023
From: rkennke at openjdk.org (Roman Kennke)
Date: Tue, 12 Sep 2023 14:56:30 GMT
Subject: [lilliput-jdk21u:lilliput] Integrated: 8316108: [Lilliput/JDK21]
 Cherry-pick: 8305898: Alternative self-forwarding mechanism
In-Reply-To: <zRQDqzEOQpNoRti0u67TyHzk1lZ7jIOP2MnuWLAWpYM=.c04694ef-0fc3-449c-98bf-b4b09a679ac3@github.com>
References: <zRQDqzEOQpNoRti0u67TyHzk1lZ7jIOP2MnuWLAWpYM=.c04694ef-0fc3-449c-98bf-b4b09a679ac3@github.com>
Message-ID: <zb_RfJUoy5q_-28klHAo4froEeOBRKueqFweQuTNJOY=.2cf0ed9e-7c79-4173-a95f-e2725b5288a8@github.com>

On Tue, 12 Sep 2023 11:15:28 GMT, Roman Kennke <rkennke at openjdk.org> wrote:

> Let's cherry-pick the current state of the upstream PR https://github.com/openjdk/jdk/pull/13779. It applies cleanly on top of lilliput/jdk21u.
> 
> Testing:
>  - [x] hotspot_gc (+UseAltGCForwarding)
>  - [x] hotspot_gc (-UseAltGCForwarding)

This pull request has now been integrated.

Changeset: b1494611
Author:    Roman Kennke <rkennke at openjdk.org>
URL:       https://git.openjdk.org/lilliput-jdk21u/commit/b14946110d59e128334778059ad83f48be958695
Stats:     101 lines in 8 files changed: 85 ins; 2 del; 14 mod

8316108: [Lilliput/JDK21] Cherry-pick: 8305898: Alternative self-forwarding mechanism

Reviewed-by: shade

-------------

PR: https://git.openjdk.org/lilliput-jdk21u/pull/4

From rkennke at openjdk.org  Tue Sep 12 15:32:30 2023
From: rkennke at openjdk.org (Roman Kennke)
Date: Tue, 12 Sep 2023 15:32:30 GMT
Subject: [lilliput-jdk21u:lilliput] RFR: 8316126: [Lilliput/JDK21] Cherry-pick:
 8305895: Implementation: JEP 450: Compact Object Headers (Experimental)
Message-ID: <5m6vCFnAHMn1Csly9Jk9JLvjWO5oJUbFzvkG_kGISCg=.0e4e72dc-2fa1-42bb-a480-bb4a853eb5c9@github.com>

Let's cherry-pick the current state of upstream https://github.com/openjdk/jdk/pull/13961 into Lilliput/JDK21u.

Testing:
 - [ ] tier1 +UCOH
 - [ ] tier1 -UCOH

-------------

Commit messages:
 - 8316126: [Lilliput/JDK21] Cherry-pick: 8305895: Implementation: JEP 450: Compact Object Headers (Experimental)

Changes: https://git.openjdk.org/lilliput-jdk21u/pull/5/files
 Webrev: https://webrevs.openjdk.org/?repo=lilliput-jdk21u&pr=5&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8316126
  Stats: 1255 lines in 110 files changed: 935 ins; 115 del; 205 mod
  Patch: https://git.openjdk.org/lilliput-jdk21u/pull/5.diff
  Fetch: git fetch https://git.openjdk.org/lilliput-jdk21u.git pull/5/head:pull/5

PR: https://git.openjdk.org/lilliput-jdk21u/pull/5

From rkennke at openjdk.org  Tue Sep 12 15:39:56 2023
From: rkennke at openjdk.org (Roman Kennke)
Date: Tue, 12 Sep 2023 15:39:56 GMT
Subject: [lilliput-jdk21u:lilliput] RFR: 8316126: [Lilliput/JDK21]
 Cherry-pick: 8305895: Implementation: JEP 450: Compact Object Headers
 (Experimental) [v2]
In-Reply-To: <5m6vCFnAHMn1Csly9Jk9JLvjWO5oJUbFzvkG_kGISCg=.0e4e72dc-2fa1-42bb-a480-bb4a853eb5c9@github.com>
References: <5m6vCFnAHMn1Csly9Jk9JLvjWO5oJUbFzvkG_kGISCg=.0e4e72dc-2fa1-42bb-a480-bb4a853eb5c9@github.com>
Message-ID: <inyBeHf4VWoguXBd0pL8RdJT8_prYzJgqx3wfxKz0M4=.2eb40377-4587-43a0-9677-eebe6e9b69d4@github.com>

> Let's cherry-pick the current state of upstream https://github.com/openjdk/jdk/pull/13961 into Lilliput/JDK21u.
> 
> Testing:
>  - [ ] tier1 +UCOH
>  - [ ] tier1 -UCOH

Roman Kennke has updated the pull request incrementally with one additional commit since the last revision:

  Add missing files

-------------

Changes:
  - all: https://git.openjdk.org/lilliput-jdk21u/pull/5/files
  - new: https://git.openjdk.org/lilliput-jdk21u/pull/5/files/bfe4b5fc..7219d763

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=lilliput-jdk21u&pr=5&range=01
 - incr: https://webrevs.openjdk.org/?repo=lilliput-jdk21u&pr=5&range=00-01

  Stats: 266 lines in 3 files changed: 266 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/lilliput-jdk21u/pull/5.diff
  Fetch: git fetch https://git.openjdk.org/lilliput-jdk21u.git pull/5/head:pull/5

PR: https://git.openjdk.org/lilliput-jdk21u/pull/5

From rkennke at openjdk.org  Tue Sep 12 15:46:05 2023
From: rkennke at openjdk.org (Roman Kennke)
Date: Tue, 12 Sep 2023 15:46:05 GMT
Subject: [lilliput-jdk21u:lilliput] RFR: 8316126: [Lilliput/JDK21]
 Cherry-pick: 8305895: Implementation: JEP 450: Compact Object Headers
 (Experimental) [v3]
In-Reply-To: <5m6vCFnAHMn1Csly9Jk9JLvjWO5oJUbFzvkG_kGISCg=.0e4e72dc-2fa1-42bb-a480-bb4a853eb5c9@github.com>
References: <5m6vCFnAHMn1Csly9Jk9JLvjWO5oJUbFzvkG_kGISCg=.0e4e72dc-2fa1-42bb-a480-bb4a853eb5c9@github.com>
Message-ID: <Fjc5NW1WvgmXXlWZmSQOg_t1TjDHXL9mEMjAedQdZVs=.7d881045-1a89-471d-979c-f07dab7d5dfd@github.com>

> Let's cherry-pick the current state of upstream https://github.com/openjdk/jdk/pull/13961 into Lilliput/JDK21u.
> 
> Testing:
>  - [ ] tier1 +UCOH
>  - [ ] tier1 -UCOH

Roman Kennke has updated the pull request incrementally with one additional commit since the last revision:

  Remove misplaced assert

-------------

Changes:
  - all: https://git.openjdk.org/lilliput-jdk21u/pull/5/files
  - new: https://git.openjdk.org/lilliput-jdk21u/pull/5/files/7219d763..1040e37a

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=lilliput-jdk21u&pr=5&range=02
 - incr: https://webrevs.openjdk.org/?repo=lilliput-jdk21u&pr=5&range=01-02

  Stats: 3 lines in 1 file changed: 0 ins; 3 del; 0 mod
  Patch: https://git.openjdk.org/lilliput-jdk21u/pull/5.diff
  Fetch: git fetch https://git.openjdk.org/lilliput-jdk21u.git pull/5/head:pull/5

PR: https://git.openjdk.org/lilliput-jdk21u/pull/5

From shade at openjdk.org  Tue Sep 12 17:01:26 2023
From: shade at openjdk.org (Aleksey Shipilev)
Date: Tue, 12 Sep 2023 17:01:26 GMT
Subject: [lilliput-jdk21u:lilliput] RFR: 8316126: [Lilliput/JDK21]
 Cherry-pick: 8305895: Implementation: JEP 450: Compact Object Headers
 (Experimental) [v3]
In-Reply-To: <Fjc5NW1WvgmXXlWZmSQOg_t1TjDHXL9mEMjAedQdZVs=.7d881045-1a89-471d-979c-f07dab7d5dfd@github.com>
References: <5m6vCFnAHMn1Csly9Jk9JLvjWO5oJUbFzvkG_kGISCg=.0e4e72dc-2fa1-42bb-a480-bb4a853eb5c9@github.com>
 <Fjc5NW1WvgmXXlWZmSQOg_t1TjDHXL9mEMjAedQdZVs=.7d881045-1a89-471d-979c-f07dab7d5dfd@github.com>
Message-ID: <QfCaZV2EqZ03NpZaExiSTMp2Xn63U9kh7e9PgbZ4FK4=.4392ba57-5180-4db6-ab9d-43b6788db4e5@github.com>

On Tue, 12 Sep 2023 15:46:05 GMT, Roman Kennke <rkennke at openjdk.org> wrote:

>> Let's cherry-pick the current state of upstream https://github.com/openjdk/jdk/pull/13961 into Lilliput/JDK21u.
>> 
>> Testing:
>>  - [ ] tier1 +UCOH
>>  - [ ] tier1 -UCOH
>
> Roman Kennke has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Remove misplaced assert

I basically have an only question about `TypeOopPtr` constants. It does not seem to match lilliput-jdk17u. 

Also, we probably miss the `Problemlist-Lilliput` support. We can do it later.

src/hotspot/share/opto/compile.cpp line 1353:

> 1351:         // range is OK as-is.
> 1352:         tj = ta = TypeAryPtr::RANGE;
> 1353:       } else if( offset == TypeOopPtr::klass_offset_in_bytes() ) {

Here and everywhere. Not sure why this is here. Why not in `oopDesc::`?

-------------

PR Review: https://git.openjdk.org/lilliput-jdk21u/pull/5#pullrequestreview-1622716297
PR Review Comment: https://git.openjdk.org/lilliput-jdk21u/pull/5#discussion_r1323320150

From rkennke at openjdk.org  Wed Sep 13 11:31:47 2023
From: rkennke at openjdk.org (Roman Kennke)
Date: Wed, 13 Sep 2023 11:31:47 GMT
Subject: [lilliput-jdk21u:lilliput] RFR: 8316126: [Lilliput/JDK21]
 Cherry-pick: 8305895: Implementation: JEP 450: Compact Object Headers
 (Experimental) [v3]
In-Reply-To: <QfCaZV2EqZ03NpZaExiSTMp2Xn63U9kh7e9PgbZ4FK4=.4392ba57-5180-4db6-ab9d-43b6788db4e5@github.com>
References: <5m6vCFnAHMn1Csly9Jk9JLvjWO5oJUbFzvkG_kGISCg=.0e4e72dc-2fa1-42bb-a480-bb4a853eb5c9@github.com>
 <Fjc5NW1WvgmXXlWZmSQOg_t1TjDHXL9mEMjAedQdZVs=.7d881045-1a89-471d-979c-f07dab7d5dfd@github.com>
 <QfCaZV2EqZ03NpZaExiSTMp2Xn63U9kh7e9PgbZ4FK4=.4392ba57-5180-4db6-ab9d-43b6788db4e5@github.com>
Message-ID: <6Ne9VGSPuAQyE435xzHAJuG8N6wNze_FJjxZuaodl3A=.7b87a34c-3100-4f80-9861-20bd8e725f79@github.com>

On Tue, 12 Sep 2023 16:52:46 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

>> Roman Kennke has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Remove misplaced assert
>
> src/hotspot/share/opto/compile.cpp line 1353:
> 
>> 1351:         // range is OK as-is.
>> 1352:         tj = ta = TypeAryPtr::RANGE;
>> 1353:       } else if( offset == TypeOopPtr::klass_offset_in_bytes() ) {
> 
> Here and everywhere. Not sure why this is here. Why not in `oopDesc::`?

The reason I did it this way is so that I can assert(!UCOH) in oopDesc::klass_offset_in_bytes(). The offset is used in C2 only as a sort of marker (to distinguish memory slice for the klass-word from other memory slices). It is not actually used as offset to load the Klass* - we load the whole mark-word and shift/mask/expand the Klass* from that, including the check for monitor.
In the long run, as soon as the monitor-mapping in the header goes away, we could indeed use the oopDesc::klass_offset_in_bytes() everywhere - unless when we squeeze the narrowKlass in the header at a non-byte boundery, which is bound to happen once we go to 4-byte headers.

-------------

PR Review Comment: https://git.openjdk.org/lilliput-jdk21u/pull/5#discussion_r1324367952

From rkennke at openjdk.org  Wed Sep 13 11:31:41 2023
From: rkennke at openjdk.org (Roman Kennke)
Date: Wed, 13 Sep 2023 11:31:41 GMT
Subject: [lilliput-jdk21u:lilliput] RFR: 8316126: [Lilliput/JDK21]
 Cherry-pick: 8305895: Implementation: JEP 450: Compact Object Headers
 (Experimental) [v4]
In-Reply-To: <5m6vCFnAHMn1Csly9Jk9JLvjWO5oJUbFzvkG_kGISCg=.0e4e72dc-2fa1-42bb-a480-bb4a853eb5c9@github.com>
References: <5m6vCFnAHMn1Csly9Jk9JLvjWO5oJUbFzvkG_kGISCg=.0e4e72dc-2fa1-42bb-a480-bb4a853eb5c9@github.com>
Message-ID: <X8RlU2DKPtIMPqnhs955XdH1-OS61dpxFfSpiU82WfQ=.3fdae677-7c12-4675-8583-6851d5d6d8eb@github.com>

> Let's cherry-pick the current state of upstream https://github.com/openjdk/jdk/pull/13961 into Lilliput/JDK21u.
> 
> Testing:
>  - [ ] tier1 +UCOH
>  - [ ] tier1 -UCOH

Roman Kennke has updated the pull request incrementally with two additional commits since the last revision:

 - Merge remote-tracking branch 'origin/JDK-8316126' into JDK-8316126
 - Bunch of fixes

-------------

Changes:
  - all: https://git.openjdk.org/lilliput-jdk21u/pull/5/files
  - new: https://git.openjdk.org/lilliput-jdk21u/pull/5/files/1040e37a..3fb73cf7

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=lilliput-jdk21u&pr=5&range=03
 - incr: https://webrevs.openjdk.org/?repo=lilliput-jdk21u&pr=5&range=02-03

  Stats: 117 lines in 3 files changed: 1 ins; 113 del; 3 mod
  Patch: https://git.openjdk.org/lilliput-jdk21u/pull/5.diff
  Fetch: git fetch https://git.openjdk.org/lilliput-jdk21u.git pull/5/head:pull/5

PR: https://git.openjdk.org/lilliput-jdk21u/pull/5

From shade at openjdk.org  Thu Sep 14 09:31:37 2023
From: shade at openjdk.org (Aleksey Shipilev)
Date: Thu, 14 Sep 2023 09:31:37 GMT
Subject: [lilliput-jdk21u:lilliput] RFR: 8316126: [Lilliput/JDK21]
 Cherry-pick: 8305895: Implementation: JEP 450: Compact Object Headers
 (Experimental) [v3]
In-Reply-To: <6Ne9VGSPuAQyE435xzHAJuG8N6wNze_FJjxZuaodl3A=.7b87a34c-3100-4f80-9861-20bd8e725f79@github.com>
References: <5m6vCFnAHMn1Csly9Jk9JLvjWO5oJUbFzvkG_kGISCg=.0e4e72dc-2fa1-42bb-a480-bb4a853eb5c9@github.com>
 <Fjc5NW1WvgmXXlWZmSQOg_t1TjDHXL9mEMjAedQdZVs=.7d881045-1a89-471d-979c-f07dab7d5dfd@github.com>
 <QfCaZV2EqZ03NpZaExiSTMp2Xn63U9kh7e9PgbZ4FK4=.4392ba57-5180-4db6-ab9d-43b6788db4e5@github.com>
 <6Ne9VGSPuAQyE435xzHAJuG8N6wNze_FJjxZuaodl3A=.7b87a34c-3100-4f80-9861-20bd8e725f79@github.com>
Message-ID: <FsczBC0cxYOsHWaaXebqCjcWqmFq3iOt4EFu1XrmrhI=.c2c2ab2b-92b2-4161-ab36-35a86b3802e1@github.com>

On Wed, 13 Sep 2023 11:25:00 GMT, Roman Kennke <rkennke at openjdk.org> wrote:

>> src/hotspot/share/opto/compile.cpp line 1353:
>> 
>>> 1351:         // range is OK as-is.
>>> 1352:         tj = ta = TypeAryPtr::RANGE;
>>> 1353:       } else if( offset == TypeOopPtr::klass_offset_in_bytes() ) {
>> 
>> Here and everywhere. Not sure why this is here. Why not in `oopDesc::`?
>
> The reason I did it this way is so that I can assert(!UCOH) in oopDesc::klass_offset_in_bytes(). The offset is used in C2 only as a sort of marker (to distinguish memory slice for the klass-word from other memory slices). It is not actually used as offset to load the Klass* - we load the whole mark-word and shift/mask/expand the Klass* from that, including the check for monitor.
> In the long run, as soon as the monitor-mapping in the header goes away, we could indeed use the oopDesc::klass_offset_in_bytes() everywhere - unless when we squeeze the narrowKlass in the header at a non-byte boundery, which is bound to happen once we go to 4-byte headers.

My concern is that it deviates from what we have in "mainline" version: https://builds.shipilev.net/patch-openjdk-lilliput/src/hotspot/share/opto/compile.cpp.sdiff.html -- which means we would always need to look for these discrepancies when backporting.

How does `openjdk/lilliput` achieve this?

-------------

PR Review Comment: https://git.openjdk.org/lilliput-jdk21u/pull/5#discussion_r1325666572

From rkennke at openjdk.org  Thu Sep 14 09:38:07 2023
From: rkennke at openjdk.org (Roman Kennke)
Date: Thu, 14 Sep 2023 09:38:07 GMT
Subject: [lilliput-jdk21u:lilliput] RFR: 8316126: [Lilliput/JDK21]
 Cherry-pick: 8305895: Implementation: JEP 450: Compact Object Headers
 (Experimental) [v5]
In-Reply-To: <5m6vCFnAHMn1Csly9Jk9JLvjWO5oJUbFzvkG_kGISCg=.0e4e72dc-2fa1-42bb-a480-bb4a853eb5c9@github.com>
References: <5m6vCFnAHMn1Csly9Jk9JLvjWO5oJUbFzvkG_kGISCg=.0e4e72dc-2fa1-42bb-a480-bb4a853eb5c9@github.com>
Message-ID: <eQbDp3sdPc7VqxRfYPezxTqSF4kmlkXmhyjBoOktHU0=.a70af3e7-4c6e-4d0c-8b6a-84b4dc5e454a@github.com>

> Let's cherry-pick the current state of upstream https://github.com/openjdk/jdk/pull/13961 into Lilliput/JDK21u.
> 
> Testing:
>  - [ ] tier1 +UCOH
>  - [ ] tier1 -UCOH

Roman Kennke has updated the pull request incrementally with one additional commit since the last revision:

  Remove bad assert

-------------

Changes:
  - all: https://git.openjdk.org/lilliput-jdk21u/pull/5/files
  - new: https://git.openjdk.org/lilliput-jdk21u/pull/5/files/3fb73cf7..93148bb0

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=lilliput-jdk21u&pr=5&range=04
 - incr: https://webrevs.openjdk.org/?repo=lilliput-jdk21u&pr=5&range=03-04

  Stats: 2 lines in 2 files changed: 0 ins; 2 del; 0 mod
  Patch: https://git.openjdk.org/lilliput-jdk21u/pull/5.diff
  Fetch: git fetch https://git.openjdk.org/lilliput-jdk21u.git pull/5/head:pull/5

PR: https://git.openjdk.org/lilliput-jdk21u/pull/5

From rkennke at openjdk.org  Thu Sep 14 09:40:11 2023
From: rkennke at openjdk.org (Roman Kennke)
Date: Thu, 14 Sep 2023 09:40:11 GMT
Subject: [lilliput-jdk21u:lilliput] RFR: 8316126: [Lilliput/JDK21]
 Cherry-pick: 8305895: Implementation: JEP 450: Compact Object Headers
 (Experimental) [v3]
In-Reply-To: <FsczBC0cxYOsHWaaXebqCjcWqmFq3iOt4EFu1XrmrhI=.c2c2ab2b-92b2-4161-ab36-35a86b3802e1@github.com>
References: <5m6vCFnAHMn1Csly9Jk9JLvjWO5oJUbFzvkG_kGISCg=.0e4e72dc-2fa1-42bb-a480-bb4a853eb5c9@github.com>
 <Fjc5NW1WvgmXXlWZmSQOg_t1TjDHXL9mEMjAedQdZVs=.7d881045-1a89-471d-979c-f07dab7d5dfd@github.com>
 <QfCaZV2EqZ03NpZaExiSTMp2Xn63U9kh7e9PgbZ4FK4=.4392ba57-5180-4db6-ab9d-43b6788db4e5@github.com>
 <6Ne9VGSPuAQyE435xzHAJuG8N6wNze_FJjxZuaodl3A=.7b87a34c-3100-4f80-9861-20bd8e725f79@github.com>
 <FsczBC0cxYOsHWaaXebqCjcWqmFq3iOt4EFu1XrmrhI=.c2c2ab2b-92b2-4161-ab36-35a86b3802e1@github.com>
Message-ID: <CHoadV9Db-arZZSOSs2bsOZ8XxKrcZvqKg5_dNsGaus=.7d4ba054-a16a-4c00-bd90-478cae784d58@github.com>

On Thu, 14 Sep 2023 09:28:00 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

> My concern is that it deviates from what we have in "mainline" version: https://builds.shipilev.net/patch-openjdk-lilliput/src/hotspot/share/opto/compile.cpp.sdiff.html -- which means we would always need to look for these discrepancies when backporting.
> 
> How does `openjdk/lilliput` achieve this?

It doesn't assert !UCOH in oopDesc::klass_offset_in_bytes(). Best approaches will be to either remove the assert and keep the 21 (and jdk upstream) stuff simpler, at the cost of loosing the assert, or bring over the C2 changes.

-------------

PR Review Comment: https://git.openjdk.org/lilliput-jdk21u/pull/5#discussion_r1325681685

From shade at openjdk.org  Thu Sep 14 09:44:04 2023
From: shade at openjdk.org (Aleksey Shipilev)
Date: Thu, 14 Sep 2023 09:44:04 GMT
Subject: [lilliput-jdk21u:lilliput] RFR: 8316126: [Lilliput/JDK21]
 Cherry-pick: 8305895: Implementation: JEP 450: Compact Object Headers
 (Experimental) [v3]
In-Reply-To: <CHoadV9Db-arZZSOSs2bsOZ8XxKrcZvqKg5_dNsGaus=.7d4ba054-a16a-4c00-bd90-478cae784d58@github.com>
References: <5m6vCFnAHMn1Csly9Jk9JLvjWO5oJUbFzvkG_kGISCg=.0e4e72dc-2fa1-42bb-a480-bb4a853eb5c9@github.com>
 <Fjc5NW1WvgmXXlWZmSQOg_t1TjDHXL9mEMjAedQdZVs=.7d881045-1a89-471d-979c-f07dab7d5dfd@github.com>
 <QfCaZV2EqZ03NpZaExiSTMp2Xn63U9kh7e9PgbZ4FK4=.4392ba57-5180-4db6-ab9d-43b6788db4e5@github.com>
 <6Ne9VGSPuAQyE435xzHAJuG8N6wNze_FJjxZuaodl3A=.7b87a34c-3100-4f80-9861-20bd8e725f79@github.com>
 <FsczBC0cxYOsHWaaXebqCjcWqmFq3iOt4EFu1XrmrhI=.c2c2ab2b-92b2-4161-ab36-35a86b3802e1@github.com>
 <CHoadV9Db-arZZSOSs2bsOZ8XxKrcZvqKg5_dNsGaus=.7d4ba054-a16a-4c00-bd90-478cae784d58@github.com>
Message-ID: <lMDqgwNsUKFVAM4USWgf_AJLkDIXmV5_N11VLY10EBE=.cb72cb11-7e65-4098-b459-731839613de2@github.com>

On Thu, 14 Sep 2023 09:37:30 GMT, Roman Kennke <rkennke at openjdk.org> wrote:

>> My concern is that it deviates from what we have in "mainline" version: https://builds.shipilev.net/patch-openjdk-lilliput/src/hotspot/share/opto/compile.cpp.sdiff.html -- which means we would always need to look for these discrepancies when backporting.
>> 
>> How does `openjdk/lilliput` achieve this?
>
>> My concern is that it deviates from what we have in "mainline" version: https://builds.shipilev.net/patch-openjdk-lilliput/src/hotspot/share/opto/compile.cpp.sdiff.html -- which means we would always need to look for these discrepancies when backporting.
>> 
>> How does `openjdk/lilliput` achieve this?
> 
> It doesn't assert !UCOH in oopDesc::klass_offset_in_bytes(). Best approaches will be to either remove the assert and keep the 21 (and jdk upstream) stuff simpler, at the cost of loosing the assert, or bring over the C2 changes.

Lilliput JDK 17 does not do this either, it seems: https://builds.shipilev.net/patch-openjdk-lilliput-jdk17/src/hotspot/share/opto/compile.cpp.sdiff.html

So, I suggest we keep 21u close to both mainline and 17u by not asserting too, and using the usual `oopDesc::`?

-------------

PR Review Comment: https://git.openjdk.org/lilliput-jdk21u/pull/5#discussion_r1325688104

From rkennke at openjdk.org  Thu Sep 14 11:29:56 2023
From: rkennke at openjdk.org (Roman Kennke)
Date: Thu, 14 Sep 2023 11:29:56 GMT
Subject: [lilliput-jdk21u:lilliput] RFR: 8316126: [Lilliput/JDK21]
 Cherry-pick: 8305895: Implementation: JEP 450: Compact Object Headers
 (Experimental) [v6]
In-Reply-To: <5m6vCFnAHMn1Csly9Jk9JLvjWO5oJUbFzvkG_kGISCg=.0e4e72dc-2fa1-42bb-a480-bb4a853eb5c9@github.com>
References: <5m6vCFnAHMn1Csly9Jk9JLvjWO5oJUbFzvkG_kGISCg=.0e4e72dc-2fa1-42bb-a480-bb4a853eb5c9@github.com>
Message-ID: <sFfsyDt4D2QMQ6dP_YvTcAVC6NwlE3UjDF1q3wRFCOY=.a2748f55-bded-4a85-8f6b-07c7ac5eaccb@github.com>

> Let's cherry-pick the current state of upstream https://github.com/openjdk/jdk/pull/13961 into Lilliput/JDK21u.
> 
> Testing:
>  - [ ] tier1 +UCOH
>  - [ ] tier1 -UCOH

Roman Kennke has updated the pull request incrementally with one additional commit since the last revision:

  Revert C2 changes

-------------

Changes:
  - all: https://git.openjdk.org/lilliput-jdk21u/pull/5/files
  - new: https://git.openjdk.org/lilliput-jdk21u/pull/5/files/93148bb0..f19ada4e

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=lilliput-jdk21u&pr=5&range=05
 - incr: https://webrevs.openjdk.org/?repo=lilliput-jdk21u&pr=5&range=04-05

  Stats: 62 lines in 16 files changed: 0 ins; 36 del; 26 mod
  Patch: https://git.openjdk.org/lilliput-jdk21u/pull/5.diff
  Fetch: git fetch https://git.openjdk.org/lilliput-jdk21u.git pull/5/head:pull/5

PR: https://git.openjdk.org/lilliput-jdk21u/pull/5

From rkennke at openjdk.org  Thu Sep 14 11:56:13 2023
From: rkennke at openjdk.org (Roman Kennke)
Date: Thu, 14 Sep 2023 11:56:13 GMT
Subject: [lilliput-jdk21u:lilliput] RFR: 8316126: [Lilliput/JDK21]
 Cherry-pick: 8305895: Implementation: JEP 450: Compact Object Headers
 (Experimental) [v7]
In-Reply-To: <5m6vCFnAHMn1Csly9Jk9JLvjWO5oJUbFzvkG_kGISCg=.0e4e72dc-2fa1-42bb-a480-bb4a853eb5c9@github.com>
References: <5m6vCFnAHMn1Csly9Jk9JLvjWO5oJUbFzvkG_kGISCg=.0e4e72dc-2fa1-42bb-a480-bb4a853eb5c9@github.com>
Message-ID: <sthhw9QZNvxL5yY-1w0YLDL5JGDB_JYdiKgc3yODycc=.8cbf13f4-2a68-4f75-ba28-011b8588a46b@github.com>

> Let's cherry-pick the current state of upstream https://github.com/openjdk/jdk/pull/13961 into Lilliput/JDK21u.
> 
> Testing:
>  - [ ] tier1 +UCOH
>  - [ ] tier1 -UCOH

Roman Kennke has updated the pull request incrementally with two additional commits since the last revision:

 - Fix stuff
 - Revert "Remove bad assert"
   
   This reverts commit 93148bb034365bf91e3a9f7c4ffb81840e001b58.

-------------

Changes:
  - all: https://git.openjdk.org/lilliput-jdk21u/pull/5/files
  - new: https://git.openjdk.org/lilliput-jdk21u/pull/5/files/f19ada4e..2b1acd34

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=lilliput-jdk21u&pr=5&range=06
 - incr: https://webrevs.openjdk.org/?repo=lilliput-jdk21u&pr=5&range=05-06

  Stats: 9 lines in 4 files changed: 8 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/lilliput-jdk21u/pull/5.diff
  Fetch: git fetch https://git.openjdk.org/lilliput-jdk21u.git pull/5/head:pull/5

PR: https://git.openjdk.org/lilliput-jdk21u/pull/5

From shade at openjdk.org  Thu Sep 14 13:07:11 2023
From: shade at openjdk.org (Aleksey Shipilev)
Date: Thu, 14 Sep 2023 13:07:11 GMT
Subject: [lilliput-jdk21u:lilliput] RFR: 8316126: [Lilliput/JDK21]
 Cherry-pick: 8305895: Implementation: JEP 450: Compact Object Headers
 (Experimental) [v7]
In-Reply-To: <sthhw9QZNvxL5yY-1w0YLDL5JGDB_JYdiKgc3yODycc=.8cbf13f4-2a68-4f75-ba28-011b8588a46b@github.com>
References: <5m6vCFnAHMn1Csly9Jk9JLvjWO5oJUbFzvkG_kGISCg=.0e4e72dc-2fa1-42bb-a480-bb4a853eb5c9@github.com>
 <sthhw9QZNvxL5yY-1w0YLDL5JGDB_JYdiKgc3yODycc=.8cbf13f4-2a68-4f75-ba28-011b8588a46b@github.com>
Message-ID: <9ISWlJEZjCia_6xLdWz2BM-EVOeu_8qjBD6-MvWdKdM=.de4e6c70-7fa6-4de1-8a03-f366d7c0523f@github.com>

On Thu, 14 Sep 2023 11:56:13 GMT, Roman Kennke <rkennke at openjdk.org> wrote:

>> Let's cherry-pick the current state of upstream https://github.com/openjdk/jdk/pull/13961 into Lilliput/JDK21u.
>> 
>> Testing:
>>  - [ ] tier1 +UCOH
>>  - [ ] tier1 -UCOH
>
> Roman Kennke has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - Fix stuff
>  - Revert "Remove bad assert"
>    
>    This reverts commit 93148bb034365bf91e3a9f7c4ffb81840e001b58.

I think this looks for integration. We would need to trawl the diff against 21u once everything is in lilliput-jdk21u.

-------------

Marked as reviewed by shade (Reviewer).

PR Review: https://git.openjdk.org/lilliput-jdk21u/pull/5#pullrequestreview-1626840810

From rkennke at openjdk.org  Thu Sep 14 15:51:55 2023
From: rkennke at openjdk.org (Roman Kennke)
Date: Thu, 14 Sep 2023 15:51:55 GMT
Subject: [lilliput-jdk21u:lilliput] RFR: 8316126: [Lilliput/JDK21]
 Cherry-pick: 8305895: Implementation: JEP 450: Compact Object Headers
 (Experimental) [v8]
In-Reply-To: <5m6vCFnAHMn1Csly9Jk9JLvjWO5oJUbFzvkG_kGISCg=.0e4e72dc-2fa1-42bb-a480-bb4a853eb5c9@github.com>
References: <5m6vCFnAHMn1Csly9Jk9JLvjWO5oJUbFzvkG_kGISCg=.0e4e72dc-2fa1-42bb-a480-bb4a853eb5c9@github.com>
Message-ID: <7U19bfdBXdXcl3saDycwCChSsOl1hMlky0wQ0gI1lEo=.62eb5307-9f2e-4004-8f0b-dc29d2d285b8@github.com>

> Let's cherry-pick the current state of upstream https://github.com/openjdk/jdk/pull/13961 into Lilliput/JDK21u.
> 
> Testing:
>  - [ ] tier1 +UCOH
>  - [ ] tier1 -UCOH

Roman Kennke has updated the pull request incrementally with two additional commits since the last revision:

 - Merge remote-tracking branch 'origin/JDK-8316126' into JDK-8316126
 - Fix 32-bit gtest failure

-------------

Changes:
  - all: https://git.openjdk.org/lilliput-jdk21u/pull/5/files
  - new: https://git.openjdk.org/lilliput-jdk21u/pull/5/files/2b1acd34..2d8769e5

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=lilliput-jdk21u&pr=5&range=07
 - incr: https://webrevs.openjdk.org/?repo=lilliput-jdk21u&pr=5&range=06-07

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/lilliput-jdk21u/pull/5.diff
  Fetch: git fetch https://git.openjdk.org/lilliput-jdk21u.git pull/5/head:pull/5

PR: https://git.openjdk.org/lilliput-jdk21u/pull/5

From rkennke at openjdk.org  Thu Sep 14 19:27:16 2023
From: rkennke at openjdk.org (Roman Kennke)
Date: Thu, 14 Sep 2023 19:27:16 GMT
Subject: [lilliput-jdk21u:lilliput] Integrated: 8316126: [Lilliput/JDK21]
 Cherry-pick: 8305895: Implementation: JEP 450: Compact Object Headers
 (Experimental)
In-Reply-To: <5m6vCFnAHMn1Csly9Jk9JLvjWO5oJUbFzvkG_kGISCg=.0e4e72dc-2fa1-42bb-a480-bb4a853eb5c9@github.com>
References: <5m6vCFnAHMn1Csly9Jk9JLvjWO5oJUbFzvkG_kGISCg=.0e4e72dc-2fa1-42bb-a480-bb4a853eb5c9@github.com>
Message-ID: <l5c294VgEM0RjNqqBERlI_i4Q5aQC6_HBiQYdfoT_Dc=.8ef1f37c-a74c-4289-98b1-a3b730882c48@github.com>

On Tue, 12 Sep 2023 15:25:39 GMT, Roman Kennke <rkennke at openjdk.org> wrote:

> Let's cherry-pick the current state of upstream https://github.com/openjdk/jdk/pull/13961 into Lilliput/JDK21u.
> 
> Testing:
>  - [ ] tier1 +UCOH
>  - [ ] tier1 -UCOH

This pull request has now been integrated.

Changeset: 7f167ee2
Author:    Roman Kennke <rkennke at openjdk.org>
URL:       https://git.openjdk.org/lilliput-jdk21u/commit/7f167ee2d59b5d8877657fe2ebcc34f702aa62cc
Stats:     1582 lines in 105 files changed: 1169 ins; 228 del; 185 mod

8316126: [Lilliput/JDK21] Cherry-pick: 8305895: Implementation: JEP 450: Compact Object Headers (Experimental)

Reviewed-by: shade

-------------

PR: https://git.openjdk.org/lilliput-jdk21u/pull/5

From rkennke at openjdk.org  Fri Sep 15 14:34:06 2023
From: rkennke at openjdk.org (Roman Kennke)
Date: Fri, 15 Sep 2023 14:34:06 GMT
Subject: [lilliput-jdk21u:lilliput] RFR: 8316367: [Lilliput/JDK21] Provide
 infrastructure for Lilliput-specific ProblemList
Message-ID: <NeUMIgs8-NLyW8Q4QFuHXzfwljQ_6U7jUNCOlKj2Tfc=.2688881e-a7db-4a57-8041-dd0903e48804@github.com>

We should add the infrastructure for excluding the tests which are known to fail with Lilliput, to get clean test runs.
Same as https://github.com/openjdk/lilliput/pull/100 but for Lilliput/21.

-------------

Commit messages:
 - 8316367: [Lilliput/JDK21] Provide infrastructure for Lilliput-specific ProblemList

Changes: https://git.openjdk.org/lilliput-jdk21u/pull/6/files
 Webrev: https://webrevs.openjdk.org/?repo=lilliput-jdk21u&pr=6&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8316367
  Stats: 33 lines in 2 files changed: 33 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/lilliput-jdk21u/pull/6.diff
  Fetch: git fetch https://git.openjdk.org/lilliput-jdk21u.git pull/6/head:pull/6

PR: https://git.openjdk.org/lilliput-jdk21u/pull/6

From shade at openjdk.org  Fri Sep 15 14:36:11 2023
From: shade at openjdk.org (Aleksey Shipilev)
Date: Fri, 15 Sep 2023 14:36:11 GMT
Subject: [lilliput-jdk21u:lilliput] RFR: 8316367: [Lilliput/JDK21] Provide
 infrastructure for Lilliput-specific ProblemList
In-Reply-To: <NeUMIgs8-NLyW8Q4QFuHXzfwljQ_6U7jUNCOlKj2Tfc=.2688881e-a7db-4a57-8041-dd0903e48804@github.com>
References: <NeUMIgs8-NLyW8Q4QFuHXzfwljQ_6U7jUNCOlKj2Tfc=.2688881e-a7db-4a57-8041-dd0903e48804@github.com>
Message-ID: <RKKCDIWFRGo3f1iDol35pW4mplNxzmVn4wIdy-WSuqc=.c0fe9669-a9dd-48e0-b01c-a28a6e155823@github.com>

On Fri, 15 Sep 2023 14:26:30 GMT, Roman Kennke <rkennke at openjdk.org> wrote:

> We should add the infrastructure for excluding the tests which are known to fail with Lilliput, to get clean test runs.
> Same as https://github.com/openjdk/lilliput/pull/100 but for Lilliput/21.

Looks good!

-------------

Marked as reviewed by shade (Reviewer).

PR Review: https://git.openjdk.org/lilliput-jdk21u/pull/6#pullrequestreview-1629094425

From rkennke at openjdk.org  Fri Sep 15 14:49:11 2023
From: rkennke at openjdk.org (Roman Kennke)
Date: Fri, 15 Sep 2023 14:49:11 GMT
Subject: [lilliput-jdk21u:lilliput] RFR: 8316367: [Lilliput/JDK21] Provide
 infrastructure for Lilliput-specific ProblemList
In-Reply-To: <NeUMIgs8-NLyW8Q4QFuHXzfwljQ_6U7jUNCOlKj2Tfc=.2688881e-a7db-4a57-8041-dd0903e48804@github.com>
References: <NeUMIgs8-NLyW8Q4QFuHXzfwljQ_6U7jUNCOlKj2Tfc=.2688881e-a7db-4a57-8041-dd0903e48804@github.com>
Message-ID: <xhsvth9V53W5JGuSCUdc8Wxl7E7Mw7LTownTQGjsnjY=.feaaf943-5f7c-4e67-8a28-54b96a65442e@github.com>

On Fri, 15 Sep 2023 14:26:30 GMT, Roman Kennke <rkennke at openjdk.org> wrote:

> We should add the infrastructure for excluding the tests which are known to fail with Lilliput, to get clean test runs.
> Same as https://github.com/openjdk/lilliput/pull/100 but for Lilliput/21.

Thanks!

-------------

PR Comment: https://git.openjdk.org/lilliput-jdk21u/pull/6#issuecomment-1721398942

From rkennke at openjdk.org  Fri Sep 15 14:49:11 2023
From: rkennke at openjdk.org (Roman Kennke)
Date: Fri, 15 Sep 2023 14:49:11 GMT
Subject: [lilliput-jdk21u:lilliput] Integrated: 8316367: [Lilliput/JDK21]
 Provide infrastructure for Lilliput-specific ProblemList
In-Reply-To: <NeUMIgs8-NLyW8Q4QFuHXzfwljQ_6U7jUNCOlKj2Tfc=.2688881e-a7db-4a57-8041-dd0903e48804@github.com>
References: <NeUMIgs8-NLyW8Q4QFuHXzfwljQ_6U7jUNCOlKj2Tfc=.2688881e-a7db-4a57-8041-dd0903e48804@github.com>
Message-ID: <JEURdz2q1UidAmTnWxW0NhG1ZNM5efjbIzSobfsVV1I=.176de9fa-8852-4223-b6c0-e3444e24e79f@github.com>

On Fri, 15 Sep 2023 14:26:30 GMT, Roman Kennke <rkennke at openjdk.org> wrote:

> We should add the infrastructure for excluding the tests which are known to fail with Lilliput, to get clean test runs.
> Same as https://github.com/openjdk/lilliput/pull/100 but for Lilliput/21.

This pull request has now been integrated.

Changeset: 2d4b15bf
Author:    Roman Kennke <rkennke at openjdk.org>
URL:       https://git.openjdk.org/lilliput-jdk21u/commit/2d4b15bf52dc8da19fd91a1a2acd29031ed8e4a3
Stats:     33 lines in 2 files changed: 33 ins; 0 del; 0 mod

8316367: [Lilliput/JDK21] Provide infrastructure for Lilliput-specific ProblemList

Reviewed-by: shade

-------------

PR: https://git.openjdk.org/lilliput-jdk21u/pull/6

From rkennke at openjdk.org  Mon Sep 18 12:59:31 2023
From: rkennke at openjdk.org (Roman Kennke)
Date: Mon, 18 Sep 2023 12:59:31 GMT
Subject: [lilliput-jdk21u:lilliput] RFR: 8316424: [Lilliput/JDK21]
 ZGC/CDS-related test fixes
Message-ID: <z5mPrvIHEoyyJs20Wj1qgX8ZTTO5Y7QEVS8sVpL0nmY=.f2ce02be-ebfe-4051-a0a5-bdc3f1dd609c@github.com>

A few tests with ZGC and CDS are failing. Reason is that we disable COH with single-gen-ZGC but not with gen-ZGC, and some tests dump with one and run with the other. This causes unexpected mismatches.

Testing:
 - [x] runtime/cds/appcds/TestZGCWithCDS.java (default)
 - [x] runtime/cds/appcds/TestZGCWithCDS.java (+UCOH)
 - [x] runtime/cds/appcds/TestZGCWithCDS.java (-UCOH)
 - [x] runtime/cds/appcds/loaderConstraints/DynamicLoaderConstraintsTest.java (default)
 - [x] runtime/cds/appcds/loaderConstraints/DynamicLoaderConstraintsTest.java (+UCOH)
 - [x] runtime/cds/appcds/loaderConstraints/DynamicLoaderConstraintsTest.java (-UCOH)

-------------

Commit messages:
 - 8316424: [Lilliput/JDK21] ZGC/CDS-related test fixes

Changes: https://git.openjdk.org/lilliput-jdk21u/pull/7/files
 Webrev: https://webrevs.openjdk.org/?repo=lilliput-jdk21u&pr=7&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8316424
  Stats: 16 lines in 2 files changed: 15 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/lilliput-jdk21u/pull/7.diff
  Fetch: git fetch https://git.openjdk.org/lilliput-jdk21u.git pull/7/head:pull/7

PR: https://git.openjdk.org/lilliput-jdk21u/pull/7

From shade at openjdk.org  Mon Sep 18 13:58:17 2023
From: shade at openjdk.org (Aleksey Shipilev)
Date: Mon, 18 Sep 2023 13:58:17 GMT
Subject: [lilliput-jdk21u:lilliput] RFR: 8316424: [Lilliput/JDK21]
 ZGC/CDS-related test fixes
In-Reply-To: <z5mPrvIHEoyyJs20Wj1qgX8ZTTO5Y7QEVS8sVpL0nmY=.f2ce02be-ebfe-4051-a0a5-bdc3f1dd609c@github.com>
References: <z5mPrvIHEoyyJs20Wj1qgX8ZTTO5Y7QEVS8sVpL0nmY=.f2ce02be-ebfe-4051-a0a5-bdc3f1dd609c@github.com>
Message-ID: <QFRmTdFhrTMW8XwEGXalQtLa0enVa48oTuEMzKopiqU=.27e14885-7032-409f-a410-2ba20cba378c@github.com>

On Mon, 18 Sep 2023 12:52:02 GMT, Roman Kennke <rkennke at openjdk.org> wrote:

> A few tests with ZGC and CDS are failing. Reason is that we disable COH with single-gen-ZGC but not with gen-ZGC, and some tests dump with one and run with the other. This causes unexpected mismatches.
> 
> Testing:
>  - [x] runtime/cds/appcds/TestZGCWithCDS.java (default)
>  - [x] runtime/cds/appcds/TestZGCWithCDS.java (+UCOH)
>  - [x] runtime/cds/appcds/TestZGCWithCDS.java (-UCOH)
>  - [x] runtime/cds/appcds/loaderConstraints/DynamicLoaderConstraintsTest.java (default)
>  - [x] runtime/cds/appcds/loaderConstraints/DynamicLoaderConstraintsTest.java (+UCOH)
>  - [x] runtime/cds/appcds/loaderConstraints/DynamicLoaderConstraintsTest.java (-UCOH)

Would it make more sense to sense `+UCOH` in `VMProps.java` and put appropriate `@requires` in `+ZGenerational` `@run` block?

-------------

PR Review: https://git.openjdk.org/lilliput-jdk21u/pull/7#pullrequestreview-1631127945

From rkennke at openjdk.org  Mon Sep 18 15:05:17 2023
From: rkennke at openjdk.org (Roman Kennke)
Date: Mon, 18 Sep 2023 15:05:17 GMT
Subject: [lilliput-jdk21u:lilliput] RFR: 8316424: [Lilliput/JDK21]
 ZGC/CDS-related test fixes
In-Reply-To: <QFRmTdFhrTMW8XwEGXalQtLa0enVa48oTuEMzKopiqU=.27e14885-7032-409f-a410-2ba20cba378c@github.com>
References: <z5mPrvIHEoyyJs20Wj1qgX8ZTTO5Y7QEVS8sVpL0nmY=.f2ce02be-ebfe-4051-a0a5-bdc3f1dd609c@github.com>
 <QFRmTdFhrTMW8XwEGXalQtLa0enVa48oTuEMzKopiqU=.27e14885-7032-409f-a410-2ba20cba378c@github.com>
Message-ID: <pWp6l8L0da5UCajYlROUt0MPVWu_sWs0D4RiqiuZ5Uc=.8a00708f-da09-4309-9499-35e695a5a230@github.com>

On Mon, 18 Sep 2023 13:54:59 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

> Would it make more sense to sense `+UCOH` in `VMProps.java` and put appropriate `@requires` in `+ZGenerational` `@run` block?

No, I don't think so. The two affected tests spawn new JVMs and ignore the test options - at least sometimes (e.g. when dumping CDS).

-------------

PR Comment: https://git.openjdk.org/lilliput-jdk21u/pull/7#issuecomment-1723627159

From shade at openjdk.org  Mon Sep 18 15:33:12 2023
From: shade at openjdk.org (Aleksey Shipilev)
Date: Mon, 18 Sep 2023 15:33:12 GMT
Subject: [lilliput-jdk21u:lilliput] RFR: 8316424: [Lilliput/JDK21]
 ZGC/CDS-related test fixes
In-Reply-To: <z5mPrvIHEoyyJs20Wj1qgX8ZTTO5Y7QEVS8sVpL0nmY=.f2ce02be-ebfe-4051-a0a5-bdc3f1dd609c@github.com>
References: <z5mPrvIHEoyyJs20Wj1qgX8ZTTO5Y7QEVS8sVpL0nmY=.f2ce02be-ebfe-4051-a0a5-bdc3f1dd609c@github.com>
Message-ID: <BzjsAreP0rnmF5G4iicZd4zN3Yh0G0vD1yO8X_CpIQ0=.efcab137-5426-4871-abf7-7fc59c3772db@github.com>

On Mon, 18 Sep 2023 12:52:02 GMT, Roman Kennke <rkennke at openjdk.org> wrote:

> A few tests with ZGC and CDS are failing. Reason is that we disable COH with single-gen-ZGC but not with gen-ZGC, and some tests dump with one and run with the other. This causes unexpected mismatches.
> 
> Testing:
>  - [x] runtime/cds/appcds/TestZGCWithCDS.java (default)
>  - [x] runtime/cds/appcds/TestZGCWithCDS.java (+UCOH)
>  - [x] runtime/cds/appcds/TestZGCWithCDS.java (-UCOH)
>  - [x] runtime/cds/appcds/loaderConstraints/DynamicLoaderConstraintsTest.java (default)
>  - [x] runtime/cds/appcds/loaderConstraints/DynamicLoaderConstraintsTest.java (+UCOH)
>  - [x] runtime/cds/appcds/loaderConstraints/DynamicLoaderConstraintsTest.java (-UCOH)

All right then.

-------------

Marked as reviewed by shade (Reviewer).

PR Review: https://git.openjdk.org/lilliput-jdk21u/pull/7#pullrequestreview-1631359237

From rkennke at openjdk.org  Mon Sep 18 18:09:06 2023
From: rkennke at openjdk.org (Roman Kennke)
Date: Mon, 18 Sep 2023 18:09:06 GMT
Subject: [lilliput-jdk21u:lilliput] Integrated: 8316424: [Lilliput/JDK21]
 ZGC/CDS-related test fixes
In-Reply-To: <z5mPrvIHEoyyJs20Wj1qgX8ZTTO5Y7QEVS8sVpL0nmY=.f2ce02be-ebfe-4051-a0a5-bdc3f1dd609c@github.com>
References: <z5mPrvIHEoyyJs20Wj1qgX8ZTTO5Y7QEVS8sVpL0nmY=.f2ce02be-ebfe-4051-a0a5-bdc3f1dd609c@github.com>
Message-ID: <ctEuf1dd-HdQR_DLgK1VZVl4147in0Ujjo-_QRovm5Q=.c6eb276b-4651-4de5-9fc7-26211d52a836@github.com>

On Mon, 18 Sep 2023 12:52:02 GMT, Roman Kennke <rkennke at openjdk.org> wrote:

> A few tests with ZGC and CDS are failing. Reason is that we disable COH with single-gen-ZGC but not with gen-ZGC, and some tests dump with one and run with the other. This causes unexpected mismatches.
> 
> Testing:
>  - [x] runtime/cds/appcds/TestZGCWithCDS.java (default)
>  - [x] runtime/cds/appcds/TestZGCWithCDS.java (+UCOH)
>  - [x] runtime/cds/appcds/TestZGCWithCDS.java (-UCOH)
>  - [x] runtime/cds/appcds/loaderConstraints/DynamicLoaderConstraintsTest.java (default)
>  - [x] runtime/cds/appcds/loaderConstraints/DynamicLoaderConstraintsTest.java (+UCOH)
>  - [x] runtime/cds/appcds/loaderConstraints/DynamicLoaderConstraintsTest.java (-UCOH)

This pull request has now been integrated.

Changeset: 5504c7ae
Author:    Roman Kennke <rkennke at openjdk.org>
URL:       https://git.openjdk.org/lilliput-jdk21u/commit/5504c7ae16ca77458785de8ec8851302707c2c37
Stats:     16 lines in 2 files changed: 15 ins; 0 del; 1 mod

8316424: [Lilliput/JDK21] ZGC/CDS-related test fixes

Reviewed-by: shade

-------------

PR: https://git.openjdk.org/lilliput-jdk21u/pull/7

From rkennke at openjdk.org  Mon Sep 18 18:41:24 2023
From: rkennke at openjdk.org (Roman Kennke)
Date: Mon, 18 Sep 2023 18:41:24 GMT
Subject: [lilliput-jdk21u:lilliput] RFR: 8316442: [Lilliput/JDK21] Problem-list
 compiler/ciReplay tests
Message-ID: <_YzZEXoAhVhs2gtshc0Gje_cd5ThCpIJgG58adFk34w=.cc2cf637-6dab-41b0-8f2a-91506712cccc@github.com>

Some tests in compiler/ciReplay seem to be sensitivs to setting of +/-UCOH when generating vs loading compiler replays. This only affects JIT diagnosis and can in practice likely be worked-around by using the correct combination of flags. Let's problem-list the tests for now.

Tests:
 - [x] compiler/ciReplay +UCOH
 - [x] compiler/ciReplay -UCOH

-------------

Commit messages:
 - 8316442: [Lilliput/JDK21] Problem-list compiler/ciReplay tests

Changes: https://git.openjdk.org/lilliput-jdk21u/pull/8/files
 Webrev: https://webrevs.openjdk.org/?repo=lilliput-jdk21u&pr=8&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8316442
  Stats: 12 lines in 1 file changed: 12 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/lilliput-jdk21u/pull/8.diff
  Fetch: git fetch https://git.openjdk.org/lilliput-jdk21u.git pull/8/head:pull/8

PR: https://git.openjdk.org/lilliput-jdk21u/pull/8

From shade at openjdk.org  Mon Sep 18 18:44:16 2023
From: shade at openjdk.org (Aleksey Shipilev)
Date: Mon, 18 Sep 2023 18:44:16 GMT
Subject: [lilliput-jdk21u:lilliput] RFR: 8316442: [Lilliput/JDK21]
 Problem-list compiler/ciReplay tests
In-Reply-To: <_YzZEXoAhVhs2gtshc0Gje_cd5ThCpIJgG58adFk34w=.cc2cf637-6dab-41b0-8f2a-91506712cccc@github.com>
References: <_YzZEXoAhVhs2gtshc0Gje_cd5ThCpIJgG58adFk34w=.cc2cf637-6dab-41b0-8f2a-91506712cccc@github.com>
Message-ID: <7GDuuYqWbeqf-lVydAv2tw5kGFAgR8kmAJwhvWKjG1U=.e818565a-8499-403a-b46d-8fd6518bc900@github.com>

On Mon, 18 Sep 2023 18:34:10 GMT, Roman Kennke <rkennke at openjdk.org> wrote:

> Some tests in compiler/ciReplay seem to be sensitivs to setting of +/-UCOH when generating vs loading compiler replays. This only affects JIT diagnosis and can in practice likely be worked-around by using the correct combination of flags. Let's problem-list the tests for now.
> 
> Tests:
>  - [x] compiler/ciReplay +UCOH
>  - [x] compiler/ciReplay -UCOH

Indenting is a bit off, I would have expected bug IDs to stack nicely.
But this is okay too.

Is this a problem for mainline as well?

-------------

Marked as reviewed by shade (Reviewer).

PR Review: https://git.openjdk.org/lilliput-jdk21u/pull/8#pullrequestreview-1631746623
PR Comment: https://git.openjdk.org/lilliput-jdk21u/pull/8#issuecomment-1724172783

From rkennke at openjdk.org  Tue Sep 19 06:38:10 2023
From: rkennke at openjdk.org (Roman Kennke)
Date: Tue, 19 Sep 2023 06:38:10 GMT
Subject: [lilliput-jdk21u:lilliput] RFR: 8316442: [Lilliput/JDK21]
 Problem-list compiler/ciReplay tests
In-Reply-To: <7GDuuYqWbeqf-lVydAv2tw5kGFAgR8kmAJwhvWKjG1U=.e818565a-8499-403a-b46d-8fd6518bc900@github.com>
References: <_YzZEXoAhVhs2gtshc0Gje_cd5ThCpIJgG58adFk34w=.cc2cf637-6dab-41b0-8f2a-91506712cccc@github.com>
 <7GDuuYqWbeqf-lVydAv2tw5kGFAgR8kmAJwhvWKjG1U=.e818565a-8499-403a-b46d-8fd6518bc900@github.com>
Message-ID: <v_0X859J62h0XJDr97BNxuBrk_GOXV3P12OJ8U0LUnw=.e5b1622a-843a-4695-ad39-1b08032f8917@github.com>

On Mon, 18 Sep 2023 18:40:56 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

> Is this a problem for mainline as well?

Looks like the problem exists in mainline as well. Not in Lilliput/JDK17, though - because the tests do not exist there.

-------------

PR Comment: https://git.openjdk.org/lilliput-jdk21u/pull/8#issuecomment-1724908999

From rkennke at openjdk.org  Thu Sep 21 10:45:42 2023
From: rkennke at openjdk.org (Roman Kennke)
Date: Thu, 21 Sep 2023 10:45:42 GMT
Subject: [lilliput-jdk21u:lilliput] RFR: 8316442: [Lilliput/JDK21]
 Problem-list compiler/ciReplay tests [v2]
In-Reply-To: <_YzZEXoAhVhs2gtshc0Gje_cd5ThCpIJgG58adFk34w=.cc2cf637-6dab-41b0-8f2a-91506712cccc@github.com>
References: <_YzZEXoAhVhs2gtshc0Gje_cd5ThCpIJgG58adFk34w=.cc2cf637-6dab-41b0-8f2a-91506712cccc@github.com>
Message-ID: <nIUSmXu-iOgJt1LCcZieq6LJvFjo97bqd8cfYgw9DZc=.7002bfe0-bb8b-42b9-b478-72f52dcf73ba@github.com>

> Some tests in compiler/ciReplay seem to be sensitivs to setting of +/-UCOH when generating vs loading compiler replays. This only affects JIT diagnosis and can in practice likely be worked-around by using the correct combination of flags. Let's problem-list the tests for now.
> 
> Tests:
>  - [x] compiler/ciReplay +UCOH
>  - [x] compiler/ciReplay -UCOH

Roman Kennke has updated the pull request incrementally with one additional commit since the last revision:

  Move gap init into allocate_header() (x86); Remove unnecessary code (aarch64)

-------------

Changes:
  - all: https://git.openjdk.org/lilliput-jdk21u/pull/8/files
  - new: https://git.openjdk.org/lilliput-jdk21u/pull/8/files/5fda0a4c..d7fd3e8e

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=lilliput-jdk21u&pr=8&range=01
 - incr: https://webrevs.openjdk.org/?repo=lilliput-jdk21u&pr=8&range=00-01

  Stats: 30 lines in 2 files changed: 13 ins; 16 del; 1 mod
  Patch: https://git.openjdk.org/lilliput-jdk21u/pull/8.diff
  Fetch: git fetch https://git.openjdk.org/lilliput-jdk21u.git pull/8/head:pull/8

PR: https://git.openjdk.org/lilliput-jdk21u/pull/8

From rkennke at openjdk.org  Thu Sep 21 14:40:18 2023
From: rkennke at openjdk.org (Roman Kennke)
Date: Thu, 21 Sep 2023 14:40:18 GMT
Subject: [lilliput-jdk21u:lilliput] RFR: 8316442: [Lilliput/JDK21]
 Problem-list compiler/ciReplay tests [v3]
In-Reply-To: <_YzZEXoAhVhs2gtshc0Gje_cd5ThCpIJgG58adFk34w=.cc2cf637-6dab-41b0-8f2a-91506712cccc@github.com>
References: <_YzZEXoAhVhs2gtshc0Gje_cd5ThCpIJgG58adFk34w=.cc2cf637-6dab-41b0-8f2a-91506712cccc@github.com>
Message-ID: <12iYGGdNMG_7A_hktsqkUq6OAcdmaJOJaHZxwPvprwE=.ab085170-2de5-4e05-927d-e0617f92ba55@github.com>

> Some tests in compiler/ciReplay seem to be sensitivs to setting of +/-UCOH when generating vs loading compiler replays. This only affects JIT diagnosis and can in practice likely be worked-around by using the correct combination of flags. Let's problem-list the tests for now.
> 
> Tests:
>  - [x] compiler/ciReplay +UCOH
>  - [x] compiler/ciReplay -UCOH

Roman Kennke has updated the pull request incrementally with one additional commit since the last revision:

  Cleanup and add asserts

-------------

Changes:
  - all: https://git.openjdk.org/lilliput-jdk21u/pull/8/files
  - new: https://git.openjdk.org/lilliput-jdk21u/pull/8/files/d7fd3e8e..bebb01c5

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=lilliput-jdk21u&pr=8&range=02
 - incr: https://webrevs.openjdk.org/?repo=lilliput-jdk21u&pr=8&range=01-02

  Stats: 11 lines in 2 files changed: 4 ins; 5 del; 2 mod
  Patch: https://git.openjdk.org/lilliput-jdk21u/pull/8.diff
  Fetch: git fetch https://git.openjdk.org/lilliput-jdk21u.git pull/8/head:pull/8

PR: https://git.openjdk.org/lilliput-jdk21u/pull/8

From rkennke at openjdk.org  Thu Sep 21 17:53:27 2023
From: rkennke at openjdk.org (Roman Kennke)
Date: Thu, 21 Sep 2023 17:53:27 GMT
Subject: [lilliput-jdk21u:lilliput] RFR: 8316687: [Lilliput/JDK21] Various
 cleanups
Message-ID: <lQ3J6mQzO_x4hXA_vo7hT9FPC0lpPmTlt1A1nTQmke0=.fa67d254-0d76-4625-b051-64d749140467@github.com>

Review of upstream diff has revealed various minor issues. Let's fix them collectively.

Testing:
 - [x] hotspot:tier1 +UCOH

-------------

Commit messages:
 - Various cleanups
 - Cleanup and add asserts
 - Move gap init into allocate_header() (x86); Remove unnecessary code (aarch64)

Changes: https://git.openjdk.org/lilliput-jdk21u/pull/9/files
 Webrev: https://webrevs.openjdk.org/?repo=lilliput-jdk21u&pr=9&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8316687
  Stats: 63 lines in 14 files changed: 22 ins; 29 del; 12 mod
  Patch: https://git.openjdk.org/lilliput-jdk21u/pull/9.diff
  Fetch: git fetch https://git.openjdk.org/lilliput-jdk21u.git pull/9/head:pull/9

PR: https://git.openjdk.org/lilliput-jdk21u/pull/9

From shade at openjdk.org  Thu Sep 21 18:14:00 2023
From: shade at openjdk.org (Aleksey Shipilev)
Date: Thu, 21 Sep 2023 18:14:00 GMT
Subject: [lilliput-jdk21u:lilliput] RFR: 8316687: [Lilliput/JDK21] Various
 cleanups
In-Reply-To: <lQ3J6mQzO_x4hXA_vo7hT9FPC0lpPmTlt1A1nTQmke0=.fa67d254-0d76-4625-b051-64d749140467@github.com>
References: <lQ3J6mQzO_x4hXA_vo7hT9FPC0lpPmTlt1A1nTQmke0=.fa67d254-0d76-4625-b051-64d749140467@github.com>
Message-ID: <R87VaxOHKqXUga0XQFNLuguzd-4aFJy5jWzpmJkseSs=.dc5cc726-db07-4d6f-808c-57a326878aae@github.com>

On Thu, 21 Sep 2023 17:46:29 GMT, Roman Kennke <rkennke at openjdk.org> wrote:

> Review of upstream diff has revealed various minor issues. Let's fix them collectively.
> 
> Testing:
>  - [x] hotspot:tier1 +UCOH

Looks okay.

-------------

Marked as reviewed by shade (Reviewer).

PR Review: https://git.openjdk.org/lilliput-jdk21u/pull/9#pullrequestreview-1638422211

From rkennke at openjdk.org  Thu Sep 21 18:18:22 2023
From: rkennke at openjdk.org (Roman Kennke)
Date: Thu, 21 Sep 2023 18:18:22 GMT
Subject: [lilliput-jdk21u:lilliput] RFR: 8316442: [Lilliput/JDK21]
 Problem-list compiler/ciReplay tests [v4]
In-Reply-To: <_YzZEXoAhVhs2gtshc0Gje_cd5ThCpIJgG58adFk34w=.cc2cf637-6dab-41b0-8f2a-91506712cccc@github.com>
References: <_YzZEXoAhVhs2gtshc0Gje_cd5ThCpIJgG58adFk34w=.cc2cf637-6dab-41b0-8f2a-91506712cccc@github.com>
Message-ID: <VdQNeS_H9NkHq9776r40LGqKR0zmsjjtn3bV-JcoO9k=.d82a3306-5a2d-4864-8cd4-04ca04a1a514@github.com>

> Some tests in compiler/ciReplay seem to be sensitivs to setting of +/-UCOH when generating vs loading compiler replays. This only affects JIT diagnosis and can in practice likely be worked-around by using the correct combination of flags. Let's problem-list the tests for now.
> 
> Tests:
>  - [x] compiler/ciReplay +UCOH
>  - [x] compiler/ciReplay -UCOH

Roman Kennke has refreshed the contents of this pull request, and previous commits have been removed. Incremental views are not available. The pull request now contains one commit:

  8316442: [Lilliput/JDK21] Problem-list compiler/ciReplay tests

-------------

Changes:
  - all: https://git.openjdk.org/lilliput-jdk21u/pull/8/files
  - new: https://git.openjdk.org/lilliput-jdk21u/pull/8/files/bebb01c5..5fda0a4c

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=lilliput-jdk21u&pr=8&range=03
 - incr: https://webrevs.openjdk.org/?repo=lilliput-jdk21u&pr=8&range=02-03

  Stats: 41 lines in 4 files changed: 21 ins; 17 del; 3 mod
  Patch: https://git.openjdk.org/lilliput-jdk21u/pull/8.diff
  Fetch: git fetch https://git.openjdk.org/lilliput-jdk21u.git pull/8/head:pull/8

PR: https://git.openjdk.org/lilliput-jdk21u/pull/8

From rkennke at openjdk.org  Thu Sep 21 18:53:24 2023
From: rkennke at openjdk.org (Roman Kennke)
Date: Thu, 21 Sep 2023 18:53:24 GMT
Subject: [lilliput-jdk21u:lilliput] Integrated: 8316442: [Lilliput/JDK21]
 Problem-list compiler/ciReplay tests
In-Reply-To: <_YzZEXoAhVhs2gtshc0Gje_cd5ThCpIJgG58adFk34w=.cc2cf637-6dab-41b0-8f2a-91506712cccc@github.com>
References: <_YzZEXoAhVhs2gtshc0Gje_cd5ThCpIJgG58adFk34w=.cc2cf637-6dab-41b0-8f2a-91506712cccc@github.com>
Message-ID: <G-CyPv1VWE5BS4lGEdDelKIb3HlWE5ZCUyXrpnt1y7s=.0a8da387-91fa-49eb-a861-cc097f66be85@github.com>

On Mon, 18 Sep 2023 18:34:10 GMT, Roman Kennke <rkennke at openjdk.org> wrote:

> Some tests in compiler/ciReplay seem to be sensitivs to setting of +/-UCOH when generating vs loading compiler replays. This only affects JIT diagnosis and can in practice likely be worked-around by using the correct combination of flags. Let's problem-list the tests for now.
> 
> Tests:
>  - [x] compiler/ciReplay +UCOH
>  - [x] compiler/ciReplay -UCOH

This pull request has now been integrated.

Changeset: 3816aeef
Author:    Roman Kennke <rkennke at openjdk.org>
URL:       https://git.openjdk.org/lilliput-jdk21u/commit/3816aeef3456db32de1116c511fd3b15040d7ed4
Stats:     12 lines in 1 file changed: 12 ins; 0 del; 0 mod

8316442: [Lilliput/JDK21] Problem-list compiler/ciReplay tests

Reviewed-by: shade

-------------

PR: https://git.openjdk.org/lilliput-jdk21u/pull/8

From rkennke at openjdk.org  Thu Sep 21 19:17:00 2023
From: rkennke at openjdk.org (Roman Kennke)
Date: Thu, 21 Sep 2023 19:17:00 GMT
Subject: [lilliput-jdk21u:lilliput] Integrated: 8316687: [Lilliput/JDK21]
 Various cleanups
In-Reply-To: <lQ3J6mQzO_x4hXA_vo7hT9FPC0lpPmTlt1A1nTQmke0=.fa67d254-0d76-4625-b051-64d749140467@github.com>
References: <lQ3J6mQzO_x4hXA_vo7hT9FPC0lpPmTlt1A1nTQmke0=.fa67d254-0d76-4625-b051-64d749140467@github.com>
Message-ID: <TktQ1PE4Kh5hHAMpk8e-QdMTsBVc-nGXyJrY3G7_ELY=.9bb2960b-7931-437b-9270-4c69888d1f28@github.com>

On Thu, 21 Sep 2023 17:46:29 GMT, Roman Kennke <rkennke at openjdk.org> wrote:

> Review of upstream diff has revealed various minor issues. Let's fix them collectively.
> 
> Testing:
>  - [x] hotspot:tier1 +UCOH

This pull request has now been integrated.

Changeset: 852ea4bd
Author:    Roman Kennke <rkennke at openjdk.org>
URL:       https://git.openjdk.org/lilliput-jdk21u/commit/852ea4bdf8add7e87cf7bd5145da8420932bb342
Stats:     63 lines in 14 files changed: 22 ins; 29 del; 12 mod

8316687: [Lilliput/JDK21] Various cleanups

Reviewed-by: shade

-------------

PR: https://git.openjdk.org/lilliput-jdk21u/pull/9