[master] RFR: OMWorld: Remove BasicLock* restrictions

Roman Kennke rkennke at openjdk.org
Tue Apr 23 11:59:05 UTC 2024


On Mon, 22 Apr 2024 12:58:26 GMT, Axel Boldt-Christmas <aboldtch at openjdk.org> wrote:

> This is based on #159 
> 
> The main idea is to remove the restrictions where the `BasicLock*` may be missing when calling into the runtime. This is only an issue on x86_32. For now simply call into the runtime at the places where the registers are lacking. `quick_enter` should take care of the cases where we otherwise would have skipped calling into the runtime, as x86_32 calls into the runtime regardless (to get the thread) this may even be performance neutral.

Nice! Looks reasonable. Yeah I've been thinking the same: if we need to call runtime to fetch the Thread* anyway, we might as well do all the locking stuff there.

-------------

Marked as reviewed by rkennke (Lead).

PR Review: https://git.openjdk.org/lilliput/pull/160#pullrequestreview-2014934931


More information about the lilliput-dev mailing list