[master] RFR: OMWorld: Add LightweightSynchronizer::quick_enter - fix incorrectly setup cache [v2]

[Stefan Karlsson]

On Wed, 24 Apr 2024 08:48:05 GMT, Axel Boldt-Christmas <aboldtch at openjdk.org> wrote:

>> `ObjectSynchronizer::quick_enter` did not setup the BasicLock cache correctly when successful. When x86_32 started calling directly into the VM there are paths which never cleared the cache. Add `LightweightSynchronizer::quick_enter` which correctly clears or sets the cache in all paths.
>
> Axel Boldt-Christmas has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Remove extra newline

Looks good. At some point we need to add some comments explaining why `CacheSetter cache_setter(current, lock)` is placed where it is.

src/hotspot/share/runtime/lightweightSynchronizer.cpp line 1022:

> 1020: }
> 1021: 
> 1022: bool LightweightSynchronizer::quick_enter(oop obj, JavaThread* current, BasicLock * lock) {

Suggestion:

bool LightweightSynchronizer::quick_enter(oop obj, JavaThread* current, BasicLock* lock) {

-------------

Marked as reviewed by stefank (Committer).

PR Review: https://git.openjdk.org/lilliput/pull/169#pullrequestreview-2019291040
PR Review Comment: https://git.openjdk.org/lilliput/pull/169#discussion_r1577535717