[master] RFR: Fix arrays-equals intrinsic on AArch64 [v2]

Roman Kennke rkennke at openjdk.org
Wed Apr 24 16:15:43 UTC 2024


On Wed, 24 Apr 2024 15:24:54 GMT, Axel Boldt-Christmas <aboldtch at openjdk.org> wrote:

>> Roman Kennke has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Simplify
>
> src/hotspot/cpu/aarch64/macroAssembler_aarch64.cpp line 5438:
> 
>> 5436:       br(NE, DONE);
>> 5437:     }
>> 5438:     cbz(cnt1, SAME);
> 
> Was this an optimization? The `cbz` would never be taken if `!is_8aligned `  as it implies `cnt1 > 0`

Yes. The idea is that if the main loop also compares the lenghts, then we don't need to explicitely compare them before the main loop and save a bunch of instructions. I removed the special-handling there for now, for simplicity.

-------------

PR Review Comment: https://git.openjdk.org/lilliput/pull/170#discussion_r1578171005


More information about the lilliput-dev mailing list