[master] RFR: JDK-8325104: Lilliput: Shrink Classpointers [v2]

[Thomas Stuefe]

On Wed, 7 Feb 2024 18:42:00 GMT, Roman Kennke <rkennke at openjdk.org> wrote:

>> Thomas Stuefe has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 16 commits:
>> 
>>  - Merge branch 'master' into Smaller-ClassPointers
>>  - Merge
>>  - Merge commit 'c1281e6b45ed167df69d29a6039d81854c145ae6~1' into Smaller-ClassPointers
>>  - Fix Typo
>>  - Better CDS arch generation
>>  - Fix error in COH archive generation
>>  - Fixes
>>  - Fix Windows-Only bug that was caused by !INCLUDE_CDS_JAVA_HEAP
>>  - fix runtime/cds/appcds/TestCombinedCompressedFlags and runtime/cds/appcds/CommandLineFlagComboNegative.java
>>  - Fix CdsDifferentCompactObjectHeaders
>>  - ... and 6 more: https://git.openjdk.org/lilliput/compare/da4ffa35...f665504c
>
> make/Images.gmk line 196:
> 
>> 194:       )
>> 195:     endif
>> 196:   endif
> 
> Is creating the COH archives necessary for this change to work or work well? If not, I would suggest to make this a separate change or a prerequisite change.

It is necessary for some of the tests. I guess I could make it a prerequisite, but that would not work for the mainline version of this patch, since that one still lacks UseCOH. What would be the advantage of making this a separate change?

-------------

PR Review Comment: https://git.openjdk.org/lilliput/pull/128#discussion_r1485057185