[omworld-jdk] RFR: 8326761: Lilliput: OMWorld: Fix invalid markWord transition
Roman Kennke
rkennke at openjdk.org
Tue Feb 27 10:10:53 UTC 2024
On Tue, 27 Feb 2024 09:11:29 GMT, Axel Boldt-Christmas <aboldtch at openjdk.org> wrote:
> `PlaceholderSynchronizer::inflate_and_enter` currently performs an invalid transition of the markWord away from monitor. This may lead to an ABA issue.
>
> This got opportunistically added at some point to avoid spinning on the deflation thread progress. The issue of guaranteed progress is not something that has been observed as an issue. If guaranteed progress turns out to be required there are solutions which do not have ABA issues, but it requires extra state in the already heavily contested markWord.
>
> The yielding and spinning will be evaluated in a separate issue.
Looks good! Thanks!
-------------
Marked as reviewed by rkennke (Reviewer).
PR Review: https://git.openjdk.org/lilliput/pull/138#pullrequestreview-1903074319
More information about the lilliput-dev
mailing list