[omworld-jdk] RFR: 8326752: Lilliput: OMCache: Add cache lookup unrolling [v2]
Axel Boldt-Christmas
aboldtch at openjdk.org
Tue Feb 27 10:48:28 UTC 2024
On Tue, 27 Feb 2024 10:12:53 GMT, Roman Kennke <rkennke at openjdk.org> wrote:
>> src/hotspot/share/runtime/globals.hpp line 1997:
>>
>>> 1995: product(bool, OMC2UnrollCacheLookupLoopTail, true, "") \
>>> 1996: \
>>> 1997: product(int, OMC2UnrollCacheEntires, 8, "") \
>>
>> There is a typo: Entires -> Entries
>
> Also, could perhaps collapse some flags, e.g. treat OMC2UnrollCacheEntries==0 as OMC2UnrollCacheLookup==false, and get rid of the latter.
It was intentional, because I like`+` vs `-` switching. But maybe unifying them is better so someone does not get confused if they see `-XX:-OMC2UnrollCache -XX:OMC2UnrollCacheEntries=4` as an argument.
I'll change it.
-------------
PR Review Comment: https://git.openjdk.org/lilliput/pull/139#discussion_r1504024910
More information about the lilliput-dev
mailing list