[master] RFR: JDK-8324523: Lilliput: if +UseCOH, always use the archive's encoding base and shift

Thomas Stuefe stuefe at openjdk.org
Tue Jan 23 20:44:05 UTC 2024


On Tue, 23 Jan 2024 15:38:16 GMT, Roman Kennke <rkennke at openjdk.org> wrote:

> Change looks ok.
> 
> Questions, though: what is the impact of this? Is it a bug? Does it improve or regress performance? Should it be backported?

It is a bug, but I saw it only on Windows with my new class pointer patch. I could not reproduce it with the standard JVM, but I did not try very hard. Bug could lead to crashes. Performance impact is nil, since if we do actually run with an encoding scheme mismatch, we won't live very long. If we don't, it does not matter.

-------------

PR Comment: https://git.openjdk.org/lilliput/pull/124#issuecomment-1906883687


More information about the lilliput-dev mailing list