[master] Integrated: 8319185: [Lilliput] Enable and fix vectorization tests
Roman Kennke
rkennke at openjdk.org
Tue Jan 30 18:25:58 UTC 2024
On Tue, 23 Jan 2024 15:56:08 GMT, Roman Kennke <rkennke at openjdk.org> wrote:
> The change does two (related) things:
>
> It white-lists the UseCompactObjectHeaders flag in the IR testing framework. Without this, the flag would not be passed through to any IR framework test.
> That first change makes 3 tests fail. Those are all vectorization tests, and they are failing because 'small' array types (4-byte-elements and smaller) no longer have their elements aligned at 8-byte-boundaries. This throws off vectorization because this only kicks in on aligned accesses. The mitigation is to disable the failing tests for now. #118 offered a more comprehensive solution, but it was also more intrusive. After some discussion with Emmanuel Peter and Maurizio Cimadamore, we came to the conclusion that disabling the tests for now might be a better approach, especially considering that we may soon no longer need special 4-byte-array-alignment anymore.
>
>
> Testing:
> - [x] compiler/c2/irTests/TestVectorizationMismatchedAccess.java +UCOH
> - [x] compiler/c2/irTests/TestVectorizationNotRun.java +UCOH
> - [x] compiler/loopopts/superword/TestIndependentPacksWithCyclicDependency.java +UCOH
> - [x] compiler/c2/irTests/TestVectorizationMismatchedAccess.java -UCOH
> - [x] compiler/c2/irTests/TestVectorizationNotRun.java -UCOH
> - [x] compiler/loopopts/superword/TestIndependentPacksWithCyclicDependency.java -UCOH
> - [x] tier1 +UCOH
> - [x] tier1 -UCOH
This pull request has now been integrated.
Changeset: c0496069
Author: Roman Kennke <rkennke at openjdk.org>
URL: https://git.openjdk.org/lilliput/commit/c04960696376dd226c5efa7eb7b822dbdefc6bd1
Stats: 18 lines in 4 files changed: 9 ins; 0 del; 9 mod
8319185: [Lilliput] Enable and fix vectorization tests
Reviewed-by: shade
-------------
PR: https://git.openjdk.org/lilliput/pull/125
More information about the lilliput-dev
mailing list