[master] RFR: OMWorld: Decouple deflation and table sizing [v3]
Coleen Phillimore
coleenp at openjdk.org
Tue Jun 4 14:17:47 UTC 2024
On Tue, 4 Jun 2024 06:03:17 GMT, Axel Boldt-Christmas <aboldtch at openjdk.org> wrote:
>> The change reverts all changes to deflation and moves the resizing of the OMWorld ConcurrentHashTable to the service thread. Using a similar logic to how we resize the Symbol- and StringTables.
>>
>> The option to shrink the table is taken out and can be reintroduced at a later date as an enhancement. To do it correctly the interactions with deflation needs to be figured out.
>
> Axel Boldt-Christmas has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains three commits:
>
> - Merge remote-tracking branch 'upstream_lilliput/master' into lilliput-decouple-deflation
> - Merge remote-tracking branch 'upstream_lilliput/master' into lilliput-decouple-deflation
> - Decouple deflation and table sizing
The interaction with the OM deflation thread isn't straightforward so it seems better to have this in the ServiceThread for now. Thanks for explaining this @xmas92
-------------
Marked as reviewed by coleenp (Committer).
PR Review: https://git.openjdk.org/lilliput/pull/175#pullrequestreview-2096553858
More information about the lilliput-dev
mailing list