[master] RFR: JDK-8328886: Lilliput: Build COH archives [v2]

Thomas Stuefe stuefe at openjdk.org
Tue Mar 26 13:49:31 UTC 2024


On Tue, 26 Mar 2024 11:22:06 GMT, Roman Kennke <rkennke at openjdk.org> wrote:

>> Thomas Stuefe has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   copyright changes
>
> make/Images.gmk line 137:
> 
>> 135:   $1_$2_COOPS_OPTION := $(if $(findstring _nocoops, $2),-XX:-UseCompressedOops)
>> 136:   # enable and also explicitly disable coh as needed.
>> 137:   ifeq ($(call isTargetCpuBits, 64), true)
> 
> Not all 64-bit platforms currently support COH. Only aarch64 and x86_64 do. Would that be a problem?

Okay, fixed and tested. We now only build COH archives when on x64 or on aarch64, and for the latter, only when not crossbuilding.

Tested on Linux x64 (for x64, x32, aarch64 crossbuild) and Mac m1 (aarch64 native)

-------------

PR Review Comment: https://git.openjdk.org/lilliput/pull/145#discussion_r1539271588


More information about the lilliput-dev mailing list