[master] RFR: OMWorld: Cleanups [v2]

[Coleen Phillimore]

On Thu, 23 May 2024 14:34:37 GMT, Axel Boldt-Christmas <aboldtch at openjdk.org> wrote:

>> This contains a handful of miscellaneous cleanups. Removing dead code, fixes/cleanups todos, cleanup logging and removing all special handling of `x86_32` not having a thread register / lacking registers.
>
> Axel Boldt-Christmas has updated the pull request incrementally with one additional commit since the last revision:
> 
>   LockStackInflateContendedLocks only used for current thread

These cleanups look good.

src/hotspot/cpu/aarch64/c2_MacroAssembler_aarch64.cpp line 502:

> 500:       ldr(t1_monitor, Address(box, BasicLock::object_monitor_cache_offset_in_bytes()));
> 501:       // null check with Flags == NE, no valid pointer below alignof(ObjectMonitor*)
> 502:       cmp(t1_monitor, checked_cast<uint8_t>(alignof(ObjectMonitor*)));

I don't know what this means.

-------------

Marked as reviewed by coleenp (Committer).

PR Review: https://git.openjdk.org/lilliput/pull/178#pullrequestreview-2074868422
PR Review Comment: https://git.openjdk.org/lilliput/pull/178#discussion_r1612224392