[master] RFR: OMWorld: Spin Changes [v2]

[Axel Boldt-Christmas]

On Thu, 23 May 2024 19:38:56 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

> Is this the spinning to delay creating an ObjectMonitor for this lock as long as possible? Or if deflation is observed? This seems like it'd slow down the contended case, like xalan where we want a lot of the threads to quickly park. Or is this spinning because deflation is observed (like the comment says above)?

There are two spinning loops here. The outer which uses the SpinYield which is only to do with deflation. And the inner when the object is fast_lock. But the first_time variable has a bad name. And with the new exponential backoff changes the spinning should be interrupted if inflation is observed.


> Can you make 647-660 a function above this so it doesn't distract from the logic of the rest of enter so much?

Good suggestion. Becomes much cleared. 

Extracted the spinning logic, rename the variables and cleaned up the loop condition.

-------------

PR Review Comment: https://git.openjdk.org/lilliput/pull/177#discussion_r1613626778