[master] RFR: OMWorld: Spin Changes [v4]

[Coleen Phillimore]

On Tue, 28 May 2024 15:07:49 GMT, Axel Boldt-Christmas <aboldtch at openjdk.org> wrote:

>> The fast lock spinning uses `sched_yield` which tends to be discouraged for spin locking code. Instead only use `SpinPause` with exponential backoff. Where after each failed CAS wait for exponentially more time until trying again in an attempt to reduce cache contention. 
>> 
>> This change also makes the spinning aware of safepoints, and tries to fast track the execution to next poll, which is either when successfully locked (VM backedge transition) or when going into blocked to enter the ObjectMonitor.
>> 
>> Have not removed `OMSpins` yet, as the exact value is not determined yet. It may have to be platform specific as `SpinPause` have different characteristics on different hardware. OMSpins is the number of fast lock, with each attempt spinning for twice as much as the last, so the total number of spins are on the order of O(2^OMSpins). It will probably land somewhere on the range of 7-14 (128 -16384 spins)
>
> Axel Boldt-Christmas has updated the pull request incrementally with three additional commits since the last revision:
> 
>  - Add comment
>  - s/responisble/responsible/
>  - s/try_spin/should_spin/

I like the comments.  Thank you!

-------------

Marked as reviewed by coleenp (Committer).

PR Review: https://git.openjdk.org/lilliput/pull/177#pullrequestreview-2083622281