[master] RFR: 8353849: [Lilliput] Avoid race in compact identity hashcode [v4]

William Kemper wkemper at openjdk.org
Tue Apr 8 16:51:53 UTC 2025


On Tue, 8 Apr 2025 11:19:36 GMT, Roman Kennke <rkennke at openjdk.org> wrote:

>> Multiple GC threads can concurrently update an object's mark-word (Parallel, G1 and Shenandoah). We need to be careful when doing object-size calculations and pass-through the pre-loaded, safe mark-word, instead of re-loading the mark-word from the object. In the latter case, we might read a forwarding pointer and interpret the bits as hash-bits which would lead to wrong size-calculation and crash.
>> 
>> Testing:
>> - hotspot_gc (+UCOH)
>
> Roman Kennke has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fix 32 bit build, again

Latest revision passes internal testing pipelines on x86 and aarch64. Looks better to me!

-------------

Marked as reviewed by wkemper (Reviewer).

PR Review: https://git.openjdk.org/lilliput/pull/196#pullrequestreview-2750725621


More information about the lilliput-dev mailing list