[loc-en-dev] Revised Locale API proposal

Yoshito Umaoka y.umaoka at gmail.com
Tue Sep 8 16:10:43 PDT 2009


Steven R. Loomis wrote:
> Hello,
>    I also mostly have readability comments, but they are minor. Here 
> are a few items possibly worth discussing:
>
> - Locale.Builder:    should 'initial, default state' say 'empty 
> state'? We don't want to confuse it with the default locale.
>
> - same comment with Locale.Builder.setScript - if the script is the 
> empty string, the documentation should say what happens (Does it 
> really get the default script for the locale ? Or does it remain 
> empty, with the /effect/ of being default?)
>
>  - Locale.Builder.setExtension:   I think 'x' and 'u' are swapped 
> here, should be LDML_EXTENSION(u) and PRIVATE_USE_EXTENSION('x).
>
I was also wondering if we should clearly state "empty" instead of 
"default state".  Doug actually provided Java doc comments for Builder 
and I made only some necessary changes / minor modifications.  I was 
also considering if we really want to have non-empty default state in 
future, but I do not think we really need such.  So I agree to use the 
term "empty" instead of "default state".

Character key in setExtension is my simple mistake.  I'll fix the problem.

-Yoshito


More information about the locale-enhancement-dev mailing list