RFR: OSX build fails with Xcode 12 due to missing parantheses around sizeo…

kabutz github.com+332398+kabutz at openjdk.java.net
Wed Oct 14 09:56:19 UTC 2020

For some reason, OS X 10.15.7 Catalina with Xcode 12 fails to compile the sharedRuntime.cpp without these extra
parentheses. The tests pass on Linux and OS X with this small change.

Output from the compiler:
* For target hotspot_variant-server_libjvm_objs_sharedRuntime.o:

      buffer.stubs()->initialize_shared_locs((relocInfo*)stubs_locs_buf, sizeof(stubs_locs_buf) / sizeof(relocInfo));
                                                                                ~~~~~~~~~~~~~~  ^

      double stubs_locs_buf[20];

      buffer.stubs()->initialize_shared_locs((relocInfo*)stubs_locs_buf, sizeof(stubs_locs_buf) / sizeof(relocInfo));
1 error generated.


Commit messages:
 - OSX build fails with Xcode 12 due to missing parantheses around sizeof(relocInfo)

Changes: https://git.openjdk.java.net/loom/pull/20/files
 Webrev: https://webrevs.openjdk.java.net/?repo=loom&pr=20&range=00
  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.java.net/loom/pull/20.diff
  Fetch: git fetch https://git.openjdk.java.net/loom pull/20/head:pull/20

PR: https://git.openjdk.java.net/loom/pull/20

More information about the loom-dev mailing list