RFR: OSX build fails with Xcode 12 due to missing parantheses around sizeo… [v2]
kabutz
github.com+332398+kabutz at openjdk.java.net
Wed Oct 14 11:11:35 UTC 2020
> …f(relocInfo)
> For some reason, OS X 10.15.7 Catalina with Xcode 12 fails to compile the sharedRuntime.cpp without these extra
> parentheses. The tests pass on Linux and OS X with this small change.
> Output from the compiler:
> * For target hotspot_variant-server_libjvm_objs_sharedRuntime.o:
>
> buffer.stubs()->initialize_shared_locs((relocInfo*)stubs_locs_buf, sizeof(stubs_locs_buf) / sizeof(relocInfo));
> ~~~~~~~~~~~~~~ ^
>
> double stubs_locs_buf[20];
> ^
>
> buffer.stubs()->initialize_shared_locs((relocInfo*)stubs_locs_buf, sizeof(stubs_locs_buf) / sizeof(relocInfo));
> ^
> 1 error generated.
kabutz has updated the pull request incrementally with one additional commit since the last revision:
changed to using struct like in https://github.com/openjdk/jdk/commit/f80a6066
-------------
Changes:
- all: https://git.openjdk.java.net/loom/pull/20/files
- new: https://git.openjdk.java.net/loom/pull/20/files/7afc6580..2f941745
Webrevs:
- full: https://webrevs.openjdk.java.net/?repo=loom&pr=20&range=01
- incr: https://webrevs.openjdk.java.net/?repo=loom&pr=20&range=00-01
Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod
Patch: https://git.openjdk.java.net/loom/pull/20.diff
Fetch: git fetch https://git.openjdk.java.net/loom pull/20/head:pull/20
PR: https://git.openjdk.java.net/loom/pull/20
More information about the loom-dev
mailing list