RFR: OSX build fails with Xcode 12 due to missing parantheses around sizeo…

kabutz github.com+332398+kabutz at openjdk.java.net
Wed Oct 14 11:11:35 UTC 2020


On Wed, 14 Oct 2020 10:56:48 GMT, Alan Bateman <alanb at openjdk.org> wrote:

>> …f(relocInfo)
>> For some reason, OS X 10.15.7 Catalina with Xcode 12 fails to compile the sharedRuntime.cpp without these extra
>> parentheses. The tests pass on Linux and OS X with this small change.
>> Output from the compiler:
>> * For target hotspot_variant-server_libjvm_objs_sharedRuntime.o:
>> 
>>       buffer.stubs()->initialize_shared_locs((relocInfo*)stubs_locs_buf, sizeof(stubs_locs_buf) / sizeof(relocInfo));
>>                                                                                 ~~~~~~~~~~~~~~  ^
>> 
>>       double stubs_locs_buf[20];
>>              ^
>> 
>>       buffer.stubs()->initialize_shared_locs((relocInfo*)stubs_locs_buf, sizeof(stubs_locs_buf) / sizeof(relocInfo));
>>                                                                                                 ^
>> 1 error generated.
>
> Can you look at the changes for [JDK-8253375](https://bugs.openjdk.java.net/browse/JDK-8253375)
> ([patch](https://github.com/openjdk/jdk/commit/f80a6066e45c3d53a61715abfe71abc3b2e162a1)) to see if the same approach
> should be used for stubs_locs_buf.

Yes, that is better.

-------------

PR: https://git.openjdk.java.net/loom/pull/20


More information about the loom-dev mailing list