RFR: Fix merge error in ShenandoahFullGC
Roman Kennke
rkennke at openjdk.java.net
Mon Feb 15 10:50:58 UTC 2021
On Sat, 13 Feb 2021 06:57:22 GMT, Alan Bateman <alanb at openjdk.org> wrote:
> > Which has been wrongly merged as-is into loom. This patch restores the original version that has been in Loom, with the change to use object size instead of region size.
>
> Sorry about the merge error. There are regularly dozens of conflicts and issues to sort out when sync'ing up the loom repo and it takes a lot of time to get all the builds and the tests working again. To date we've been testing with G1 and ZGC only. We don't test with ShenandoahGC so when there are merge conflicts or build breakages due to that code then I try to leave some breadcrumbs in the form of "FIXME" comments, the minimal to get things to build. There are a few remaining FIXME comments in shenandoahRootProcessor.cpp and shenandoahRootProcessor.inline.hpp to check out. It's great that you have it working now but you will probably want to setup regularly testing to keep it working (due to the ongoing churn in the code).
No problem, Alan. Thanks for the heads-up about FIXMEs, I will check them. Yes, we will also set-up regular testing with our setup to catch problems earlier. Thanks, Roman
-------------
PR: https://git.openjdk.java.net/loom/pull/31
More information about the loom-dev
mailing list