Integrated: Add Handle arguments and fix OopHandle

Coleen Phillimore coleenp at openjdk.java.net
Thu Jul 29 00:44:51 UTC 2021


On Mon, 26 Jul 2021 15:18:24 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

> I changed two things in this PR.  Passing oop to a function then having to make it a Handle later is a recipe for naked oop bugs, so I made JvmtiThreadState::state_for pass a Handle. We try to handle-ize oops earlier in the call stack.  I made state_for_while_locked() take an oop however and added a NSV because it doesn't safepoint, and some callers only had oops, not handles.
> 
> I changed the suspend_list, resume_list to use JvmtiExport::jvmti_oop_storage rather than vm_globals().  Also rewrote some strange looking OopHandle code.  Moving handles in the GrowableArray does require Nulling them out, but not while creating them.
> 
> Tested with mach5 --patch-based --extra-src-dirs /scratch/coleen/hg/loom -j loom-tier1,loom-tier2

This pull request has now been integrated.

Changeset: 9b223540
Author:    Coleen Phillimore <coleenp at openjdk.org>
URL:       https://git.openjdk.java.net/loom/commit/9b2235409675dd050a0ac8558031f2356e10ff51
Stats:     55 lines in 4 files changed: 17 ins; 10 del; 28 mod

Add Handle arguments and fix OopHandle

Reviewed-by: lmesnik

-------------

PR: https://git.openjdk.java.net/loom/pull/55


More information about the loom-dev mailing list