RFR: Loom support for RedefineClasses [v3]

Coleen Phillimore coleenp at openjdk.java.net
Wed May 5 13:08:57 UTC 2021


On Tue, 4 May 2021 23:01:14 GMT, Ron Pressler <rpressler at openjdk.org> wrote:

>> Ok that's much better.  Thanks.  If (!f.is_interpreted) then cb will always be an nmethod? Or do I need to check for that in the else case?
>
> There's one other possibility: a safepoint stub (in the case of forced preemption). But `StackChunkFrameStream` also has `is_compiled` and `is_stub`. Exactly one of those three would be true for each frame. If `is_compiled`, then you have an nmethod.

I changed this so that it checks if it's interpreted, and then in the else check if cb->is_nmethod() to exclude the stub case.  Does it look right?

-------------

PR: https://git.openjdk.java.net/loom/pull/38


More information about the loom-dev mailing list