From duke at openjdk.java.net Fri Oct 1 02:15:04 2021 From: duke at openjdk.java.net (duke) Date: Fri, 1 Oct 2021 02:15:04 GMT Subject: git: openjdk/loom: fibers: 2 new changesets Message-ID: Changeset: 36f6e0b9 Author: Chris Plummer Date: 2021-10-01 02:11:15 +0000 URL: https://git.openjdk.java.net/loom/commit/36f6e0b919c5448e7a2060de8acea453cd86b1af Problem list VMOutOfMemoryException001.java on windows ! test/hotspot/jtreg/ProblemList-vthread.txt Changeset: c23fdcda Author: Chris Plummer Date: 2021-10-01 02:12:39 +0000 URL: https://git.openjdk.java.net/loom/commit/c23fdcda67e160e359697956e3f7eaf40db5a536 Merge branch 'fibers' of https://github.com/openjdk/loom into fibers From shade at openjdk.java.net Fri Oct 1 05:52:50 2021 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Fri, 1 Oct 2021 05:52:50 GMT Subject: RFR: Fix Minimal VM build failures [v4] In-Reply-To: References: Message-ID: <_Kd1zwC-6HuzAcurZHLsVrcvJpTZT_PLOPItI_oV9zc=.ee30dc79-9b56-4f2a-8c83-948fb2e42e5e@github.com> On Wed, 29 Sep 2021 11:13:06 GMT, Aleksey Shipilev wrote: >> Minimal VM configs have no C2 and no JVMTI. New Loom code fails the Minimal VM builds because of this. See for example GHA runs: https://github.com/shipilev/loom/runs/3717293969?check_suite_focus=true >> >> C2 needs just a little bit of protection when reaching to `DerivedPointersTable`. >> >> JVMTI needs a bit more work. `jvmtiExport` and `jvmtiThreadState` headers are usually included even with JVMTI turned off, but `.cpp` would not be compiled without JVMTI. Therefore, non-trivial implementations should go into `.cpp`. Plus, some of the paths that call the actual methods declared but not implemented without JVMTI should be protected with `INCLUDE_JVMTI`. >> >> Additional testing: >> - [x] Linux x86_64 server, `tier1_loom` still passes (includes JVMTI tests) >> - [x] Linux x86_64 minimal now builds, runs `tier1_loom` (cannot pass JVMTI tests without JVMTI) > > Aleksey Shipilev has updated the pull request incrementally with one additional commit since the last revision: > > Remove excessive guard Thank you! ------------- PR: https://git.openjdk.java.net/loom/pull/67 From shade at openjdk.java.net Fri Oct 1 06:39:39 2021 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Fri, 1 Oct 2021 06:39:39 GMT Subject: Integrated: Fix Minimal VM build failures In-Reply-To: References: Message-ID: On Mon, 27 Sep 2021 10:57:07 GMT, Aleksey Shipilev wrote: > Minimal VM configs have no C2 and no JVMTI. New Loom code fails the Minimal VM builds because of this. See for example GHA runs: https://github.com/shipilev/loom/runs/3717293969?check_suite_focus=true > > C2 needs just a little bit of protection when reaching to `DerivedPointersTable`. > > JVMTI needs a bit more work. `jvmtiExport` and `jvmtiThreadState` headers are usually included even with JVMTI turned off, but `.cpp` would not be compiled without JVMTI. Therefore, non-trivial implementations should go into `.cpp`. Plus, some of the paths that call the actual methods declared but not implemented without JVMTI should be protected with `INCLUDE_JVMTI`. > > Additional testing: > - [x] Linux x86_64 server, `tier1_loom` still passes (includes JVMTI tests) > - [x] Linux x86_64 minimal now builds, runs `tier1_loom` (cannot pass JVMTI tests without JVMTI) This pull request has now been integrated. Changeset: 924699a9 Author: Aleksey Shipilev Committer: Alan Bateman URL: https://git.openjdk.java.net/loom/commit/924699a99374629c33d06dede838ff7c4df1f112 Stats: 56 lines in 8 files changed: 46 ins; 3 del; 7 mod Fix Minimal VM build failures Reviewed-by: sspitsyn, cjplummer ------------- PR: https://git.openjdk.java.net/loom/pull/67 From shade at openjdk.java.net Fri Oct 1 07:06:59 2021 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Fri, 1 Oct 2021 07:06:59 GMT Subject: RFR: Make Loom buildable on x86_32 [v2] In-Reply-To: <0-D-rFniyQnPM5gVHXWf4pbg5vnMP8TdAtqkoKbFmSU=.0807e9e7-3439-4133-911e-c8ae83781659@github.com> References: <0-D-rFniyQnPM5gVHXWf4pbg5vnMP8TdAtqkoKbFmSU=.0807e9e7-3439-4133-911e-c8ae83781659@github.com> Message-ID: > This PRs make Loom workspace at least buildable on x86_32. > > Since jlink/jmod run build JDK, the JDK itself has to start well, without touching Loom code. Current patch only does `make images` well, trying to run `tier1` with `x86_32` quickly fails with multiple errors -- I suspect deopt, G1 and other changes are subtly broken on x86_32. I shall continue the fixes in another PR, and this push would unhoard the generic 32-bit fixes in format specifiers. > > Additional testing: > - [x] 10x `CONF=linux-x86-server-fastdebug make clean-images images` Aleksey Shipilev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last revision: - Merge branch 'fibers' into basic-x86-32-builds - More accurate register saving - More precise post_call_nops - Select the register better - Linux x86_32 builds fine ------------- Changes: - all: https://git.openjdk.java.net/loom/pull/65/files - new: https://git.openjdk.java.net/loom/pull/65/files/580f407c..db6a87ae Webrevs: - full: https://webrevs.openjdk.java.net/?repo=loom&pr=65&range=01 - incr: https://webrevs.openjdk.java.net/?repo=loom&pr=65&range=00-01 Stats: 14883 lines in 344 files changed: 10899 ins; 1798 del; 2186 mod Patch: https://git.openjdk.java.net/loom/pull/65.diff Fetch: git fetch https://git.openjdk.java.net/loom pull/65/head:pull/65 PR: https://git.openjdk.java.net/loom/pull/65 From duke at openjdk.java.net Fri Oct 1 17:23:15 2021 From: duke at openjdk.java.net (duke) Date: Fri, 1 Oct 2021 17:23:15 GMT Subject: git: openjdk/loom: fibers: Update tests to compile/run with --enable-preview Message-ID: Changeset: 350dc8ab Author: Alan Bateman Date: 2021-10-01 18:07:14 +0000 URL: https://git.openjdk.java.net/loom/commit/350dc8ab17b331034304ac6f524223965610e8f8 Update tests to compile/run with --enable-preview ! test/hotspot/jtreg/runtime/jni/IsVirtualThread/IsVirtualThread.java ! test/hotspot/jtreg/runtime/vthread/JNIMonitor/JNIMonitor.java ! test/hotspot/jtreg/runtime/vthread/RedefineClass.java ! test/hotspot/jtreg/runtime/vthread/TestObjectAllocationSampleEvent.java ! test/hotspot/jtreg/serviceability/jvmti/GetOwnedMonitorInfo/GetOwnedMonitorInfoTest.java ! test/hotspot/jtreg/serviceability/jvmti/GetOwnedMonitorStackDepthInfo/GetOwnedMonitorStackDepthInfoTest.java ! test/hotspot/jtreg/serviceability/jvmti/HeapMonitor/MyPackage/HeapMonitorVMEventsTest.java ! test/hotspot/jtreg/serviceability/jvmti/RedefineClasses/RedefineRunningMethods.java ! test/hotspot/jtreg/serviceability/jvmti/RedefineClasses/RedefineRunningMethodsWithBacktrace.java ! test/hotspot/jtreg/serviceability/jvmti/events/Breakpoint/breakpoint01/breakpoint01.java ! test/hotspot/jtreg/serviceability/jvmti/events/ClassLoad/classload01/classload01.java ! test/hotspot/jtreg/serviceability/jvmti/events/ClassPrepare/classprep01/classprep01.java ! test/hotspot/jtreg/serviceability/jvmti/events/Exception/exception01/exception01.java ! test/hotspot/jtreg/serviceability/jvmti/events/ExceptionCatch/excatch01/excatch01.java ! test/hotspot/jtreg/serviceability/jvmti/events/FieldAccess/fieldacc01/fieldacc01.java ! test/hotspot/jtreg/serviceability/jvmti/events/FieldAccess/fieldacc02/fieldacc02.java ! test/hotspot/jtreg/serviceability/jvmti/events/FieldAccess/fieldacc03/fieldacc03.java ! test/hotspot/jtreg/serviceability/jvmti/events/FieldAccess/fieldacc04/fieldacc04.java ! test/hotspot/jtreg/serviceability/jvmti/events/FieldModification/fieldmod01/fieldmod01.java ! test/hotspot/jtreg/serviceability/jvmti/events/FieldModification/fieldmod02/fieldmod02.java ! test/hotspot/jtreg/serviceability/jvmti/events/FramePop/framepop01/framepop01.java ! test/hotspot/jtreg/serviceability/jvmti/events/FramePop/framepop02/framepop02.java ! test/hotspot/jtreg/serviceability/jvmti/events/MethodEntry/mentry01/mentry01.java ! test/hotspot/jtreg/serviceability/jvmti/events/MethodEntry/mentry02/mentry02.java ! test/hotspot/jtreg/serviceability/jvmti/events/MethodExit/mexit01/mexit01.java ! test/hotspot/jtreg/serviceability/jvmti/events/MethodExit/mexit02/mexit02.java ! test/hotspot/jtreg/serviceability/jvmti/events/MonitorContendedEnter/mcontenter01/mcontenter01.java ! test/hotspot/jtreg/serviceability/jvmti/events/MonitorContendedEntered/mcontentered01/mcontentered01.java ! test/hotspot/jtreg/serviceability/jvmti/events/MonitorWait/monitorwait01/monitorwait01.java ! test/hotspot/jtreg/serviceability/jvmti/events/MonitorWaited/monitorwaited01/monitorwaited01.java ! test/hotspot/jtreg/serviceability/jvmti/events/SingleStep/singlestep01/singlestep01.java ! test/hotspot/jtreg/serviceability/jvmti/events/SingleStep/singlestep03/singlestep03.java ! test/hotspot/jtreg/serviceability/jvmti/stress/StackTrace/NotSuspended/GetStackTraceNotSuspendedStressTest.java ! test/hotspot/jtreg/serviceability/jvmti/stress/StackTrace/Suspended/GetStackTraceSuspendedStressTest.java ! test/hotspot/jtreg/serviceability/jvmti/stress/ThreadLocalStorage/SetGetThreadLocalStorageStressTest/SetGetThreadLocalStorageStressTest.java ! test/hotspot/jtreg/serviceability/jvmti/thread/GetAllThreads/allthr01/allthr01.java ! test/hotspot/jtreg/serviceability/jvmti/thread/GetCurrentContendedMonitor/contmon01/contmon01.java ! test/hotspot/jtreg/serviceability/jvmti/thread/GetCurrentContendedMonitor/contmon02/contmon02.java ! test/hotspot/jtreg/serviceability/jvmti/thread/GetFrameCount/framecnt01/framecnt01.java ! test/hotspot/jtreg/serviceability/jvmti/thread/GetStackTrace/GetStackTraceCurrentThreadTest/GetStackTraceCurrentThreadTest.java ! test/hotspot/jtreg/serviceability/jvmti/thread/GetStackTrace/getstacktr03/getstacktr03.java ! test/hotspot/jtreg/serviceability/jvmti/thread/GetStackTrace/getstacktr04/getstacktr04.java ! test/hotspot/jtreg/serviceability/jvmti/thread/GetStackTrace/getstacktr05/getstacktr05.java ! test/hotspot/jtreg/serviceability/jvmti/thread/GetStackTrace/getstacktr06/getstacktr06.java ! test/hotspot/jtreg/serviceability/jvmti/thread/GetStackTrace/getstacktr07/getstacktr07.java ! test/hotspot/jtreg/serviceability/jvmti/thread/GetStackTrace/getstacktr08/getstacktr08.java ! test/hotspot/jtreg/serviceability/jvmti/thread/GetThreadInfo/thrinfo01/thrinfo01.java ! test/hotspot/jtreg/serviceability/jvmti/vthread/BreakpointInYieldTest/BreakpointInYieldTest.java ! test/hotspot/jtreg/serviceability/jvmti/vthread/InterruptThreadTest/InterruptThreadTest.java ! test/hotspot/jtreg/serviceability/jvmti/vthread/MethodExitTest/MethodExitTest.java ! test/hotspot/jtreg/serviceability/jvmti/vthread/NullAsCurrentThreadTest/NullAsCurrentThreadTest.java ! test/hotspot/jtreg/serviceability/jvmti/vthread/PinnedTaskTest/PinnedTaskTest.java ! test/hotspot/jtreg/serviceability/jvmti/vthread/RawMonitorTest/RawMonitorTest.java ! test/hotspot/jtreg/serviceability/jvmti/vthread/SelfSuspendDisablerTest/SelfSuspendDisablerTest.java ! test/hotspot/jtreg/serviceability/jvmti/vthread/SuspendResume1/SuspendResume1.java ! test/hotspot/jtreg/serviceability/jvmti/vthread/SuspendResume2/SuspendResume2.java ! test/hotspot/jtreg/serviceability/jvmti/vthread/SuspendResumeAll/SuspendResumeAll.java ! test/hotspot/jtreg/serviceability/jvmti/vthread/VThreadMonitorTest/VThreadMonitorTest.java ! test/hotspot/jtreg/serviceability/jvmti/vthread/VThreadNotifyFramePopTest/VThreadNotifyFramePopTest.java ! test/hotspot/jtreg/serviceability/jvmti/vthread/VThreadTest/VThreadTest.java ! test/hotspot/jtreg/serviceability/jvmti/vthread/VThreadUnsupportedTest/VThreadUnsupportedTest.java ! test/hotspot/jtreg/serviceability/jvmti/vthread/WaitNotifySuspendedVThreadTest/WaitNotifySuspendedVThreadTest.java ! test/hotspot/jtreg/serviceability/jvmti/vthread/premain/AgentWithVThreadTest.java ! test/hotspot/jtreg/vmTestbase/nsk/share/MainWrapper.java ! test/jdk/com/sun/jdi/TestScaffold.java ! test/jdk/java/lang/Thread/BuilderTest.java ! test/jdk/java/lang/Thread/virtual/Collectable.java ! test/jdk/java/lang/Thread/virtual/CustomScheduler.java ! test/jdk/java/lang/Thread/virtual/InterruptHttp.java ! test/jdk/java/lang/Thread/virtual/JfrEvents.java ! test/jdk/java/lang/Thread/virtual/Locking.java ! test/jdk/java/lang/Thread/virtual/NetSockets.java ! test/jdk/java/lang/Thread/virtual/NioChannels.java ! test/jdk/java/lang/Thread/virtual/ParkWithFixedThreadPool.java ! test/jdk/java/lang/Thread/virtual/Parking.java ! test/jdk/java/lang/Thread/virtual/Reflection.java - test/jdk/java/lang/Thread/virtual/SchedulerCocktail.java ! test/jdk/java/lang/Thread/virtual/ShutdownHook.java ! test/jdk/java/lang/Thread/virtual/StackTraces.java ! test/jdk/java/lang/Thread/virtual/TestHelper.java ! test/jdk/java/lang/Thread/virtual/ThreadAPI.java ! test/jdk/java/lang/Thread/virtual/ThreadLocals.java ! test/jdk/java/lang/Thread/virtual/ThreadPerTaskExecutorTest.java ! test/jdk/java/lang/Thread/virtual/TracePinnedThreads.java ! test/jdk/java/lang/Thread/virtual/WaitNotify.java ! test/jdk/java/lang/Thread/virtual/stress/GetStackTraceALot.java ! test/jdk/java/lang/Thread/virtual/stress/HttpALot.java ! test/jdk/java/lang/Thread/virtual/stress/PinALot.java ! test/jdk/java/lang/Thread/virtual/stress/PingPong.java ! test/jdk/java/lang/Thread/virtual/stress/SleepALot.java ! test/jdk/java/lang/Thread/virtual/stress/TimedGet.java ! test/jdk/java/lang/Thread/virtual/stress/YieldALot.java ! test/jdk/java/lang/management/ThreadMXBean/VirtualThreads.java ! test/jdk/java/util/concurrent/ExecutorService/CloseTest.java ! test/jdk/jdk/jfr/event/runtime/TestThreadEndEvent.java ! test/jdk/jdk/jfr/event/runtime/TestThreadSleepEvent.java ! test/jdk/jdk/jfr/event/runtime/TestThreadStartEvent.java ! test/jdk/jdk/jfr/threading/TestDeepVirtualStackTrace.java ! test/jdk/jdk/jfr/threading/TestManyVirtualThreads.java ! test/jdk/jdk/jfr/threading/TestNestedVirtualThreads.java ! test/lib/jdk/test/lib/process/ProcessTools.java ! test/micro/org/openjdk/bench/loom/Skynet.java - test/micro/org/openjdk/bench/loom/obsolete/ContVsThread.java ! test/micro/org/openjdk/bench/loom/ring/Ring.java From duke at openjdk.java.net Fri Oct 1 20:58:42 2021 From: duke at openjdk.java.net (duke) Date: Fri, 1 Oct 2021 20:58:42 GMT Subject: git: openjdk/loom: fibers: add one more detail to the JvmtiVTMTDisabler::print_info Message-ID: <04873a0e-ecc5-4ec8-9050-ec7a6d899f15@openjdk.java.net> Changeset: 20ba20c9 Author: Serguei Spitsyn Date: 2021-10-01 20:57:01 +0000 URL: https://git.openjdk.java.net/loom/commit/20ba20c9cf9a99fc5f958123a2c9483d5d122252 add one more detail to the JvmtiVTMTDisabler::print_info ! src/hotspot/share/prims/jvmtiThreadState.cpp From duke at openjdk.java.net Fri Oct 1 22:59:53 2021 From: duke at openjdk.java.net (duke) Date: Fri, 1 Oct 2021 22:59:53 GMT Subject: git: openjdk/loom: fibers: add one more detail to the start_VTMT debugging code Message-ID: <2eff1553-d8a3-404d-8f6d-c40144921525@openjdk.java.net> Changeset: 2073a62b Author: Serguei Spitsyn Date: 2021-10-01 22:58:48 +0000 URL: https://git.openjdk.java.net/loom/commit/2073a62b983d5c24802b5d02fc89e7f24cdf31bc add one more detail to the start_VTMT debugging code ! src/hotspot/share/prims/jvmtiThreadState.cpp From duke at openjdk.java.net Mon Oct 4 06:36:58 2021 From: duke at openjdk.java.net (duke) Date: Mon, 4 Oct 2021 06:36:58 GMT Subject: git: openjdk/loom: fibers: 10 new changesets Message-ID: <652ceb87-a9ac-4924-aed8-8f4252f92e98@openjdk.java.net> Changeset: 8dd8404f Author: Serguei Spitsyn Date: 2021-10-02 08:38:11 +0000 URL: https://git.openjdk.java.net/loom/commit/8dd8404f057484c016bf9e0e4f225fc707850fb9 add even more details to JvmtiVTMTDisabler debugging info ! src/hotspot/share/prims/jvmtiThreadState.cpp Changeset: 975bd2fc Author: Alan Bateman Date: 2021-10-02 16:08:38 +0000 URL: https://git.openjdk.java.net/loom/commit/975bd2fce02ac5b1bb2291b5610ad3c91cf37bf2 More test updates in preparation for enable-preview ! test/hotspot/jtreg/ProblemList.txt ! test/hotspot/jtreg/vmTestbase/nsk/jvmti/RedefineClasses/StressRedefine.java ! test/hotspot/jtreg/vmTestbase/nsk/share/MainWrapper.java ! test/hotspot/jtreg/vmTestbase/nsk/share/jdi/JDIThreadFactory.java ! test/hotspot/jtreg/vmTestbase/nsk/share/runner/ThreadsRunner.java Changeset: 94a2537f Author: Alan Bateman Date: 2021-10-02 16:10:10 +0000 URL: https://git.openjdk.java.net/loom/commit/94a2537ff9968a480d1c632de1e441defc0da981 sun/security/tools/jarsigner/multiRelease/MVJarSigningTest.java failing ! src/java.base/share/classes/jdk/internal/misc/Gate.java ! test/jdk/ProblemList.txt Changeset: fb226d7f Author: Alan Bateman Date: 2021-10-02 16:11:43 +0000 URL: https://git.openjdk.java.net/loom/commit/fb226d7fd813c334a39cbe686661bdb829e01455 Rename methods to add Now suffix ! src/java.base/share/classes/java/util/concurrent/CompletableFuture.java ! src/java.base/share/classes/java/util/concurrent/ForkJoinTask.java ! src/java.base/share/classes/java/util/concurrent/Future.java ! src/java.base/share/classes/java/util/concurrent/FutureTask.java ! test/jdk/java/lang/Thread/virtual/ThreadPerTaskExecutorTest.java = test/jdk/java/lang/Thread/virtual/ThreadPerTaskExecutorTest.java.orig ! test/jdk/java/util/concurrent/Future/DefaultMethods.java Changeset: 564bc09b Author: Alan Bateman Date: 2021-10-02 16:12:15 +0000 URL: https://git.openjdk.java.net/loom/commit/564bc09b88cdf3bb22b7a6d7a1c85a84373b889f Remove .orig file - test/jdk/java/lang/Thread/virtual/ThreadPerTaskExecutorTest.java.orig Changeset: 31101fcd Author: Alan Bateman Date: 2021-10-02 16:13:58 +0000 URL: https://git.openjdk.java.net/loom/commit/31101fcd287be41d270cc78381fc762ea900ea77 Remove methods from early exploration that are not in first preview ! src/java.base/share/classes/java/util/concurrent/ExecutorService.java - src/java.base/share/classes/java/util/concurrent/ExecutorServiceHelper.java ! src/java.base/share/classes/java/util/concurrent/Executors.java ! test/jdk/java/lang/Thread/virtual/ThreadPerTaskExecutorTest.java - test/jdk/java/util/concurrent/ExecutorService/InvokeAllTest.java - test/jdk/java/util/concurrent/ExecutorService/SubmitTasksTest.java Changeset: cad26ce7 Author: Alan Bateman Date: 2021-10-02 16:19:01 +0000 URL: https://git.openjdk.java.net/loom/commit/cad26ce74c98e28854f02106117fe03741f69ba0 API for custom schedulers not required for initial preview ! src/java.base/share/classes/java/lang/Thread.java ! src/java.base/share/classes/java/lang/ThreadBuilders.java ! src/java.base/share/classes/java/lang/VirtualThread.java ! test/jdk/java/lang/Thread/BuilderTest.java ! test/jdk/java/lang/Thread/virtual/ParkWithFixedThreadPool.java Changeset: 6caee546 Author: Alan Bateman Date: 2021-10-02 17:43:21 +0000 URL: https://git.openjdk.java.net/loom/commit/6caee54654a33666a421a81b82a4dbe47f021956 Add @PreviewFeature to new APIs ! src/java.base/share/classes/java/lang/Thread.java ! src/java.base/share/classes/java/util/concurrent/Executors.java Changeset: 76d876d2 Author: Alan Bateman Date: 2021-10-02 21:47:54 +0000 URL: https://git.openjdk.java.net/loom/commit/76d876d247938f9c5d31524db0370af648826ff0 Add @PreviewFeature to JDK APIs ! src/java.base/share/classes/module-info.java ! src/jdk.jdi/share/classes/com/sun/jdi/ThreadReference.java ! src/jdk.jdi/share/classes/com/sun/jdi/request/ThreadDeathRequest.java ! src/jdk.jdi/share/classes/com/sun/jdi/request/ThreadStartRequest.java ! src/jdk.management/share/classes/com/sun/management/HotSpotDiagnosticMXBean.java - src/jdk.management/share/classes/com/sun/management/Threads.java Changeset: f41be80c Author: Alan Bateman Date: 2021-10-03 16:32:38 +0000 URL: https://git.openjdk.java.net/loom/commit/f41be80c290caef9020ae76c6cfdd99ccdfea6c0 Attached thread may execute arbitrary code before fully initialized ! src/hotspot/share/classfile/javaClasses.cpp From duke at openjdk.java.net Mon Oct 4 18:07:44 2021 From: duke at openjdk.java.net (duke) Date: Mon, 4 Oct 2021 18:07:44 GMT Subject: git: openjdk/loom: fibers: 3 new changesets Message-ID: <6513fa35-9a28-4749-81e6-e07ac52fb626@openjdk.java.net> Changeset: c06e6a28 Author: Alan Bateman Date: 2021-10-04 10:23:04 +0000 URL: https://git.openjdk.java.net/loom/commit/c06e6a28a95be2d59ef08db46b0a572bd2f19306 RecordedThread.isVirtual should be preview API ! src/jdk.jfr/share/classes/jdk/jfr/consumer/RecordedThread.java Changeset: f834a366 Author: Alan Bateman Date: 2021-10-04 10:26:46 +0000 URL: https://git.openjdk.java.net/loom/commit/f834a36670c396c63d6467554dadb308c14c19fc jdk.jfr needs PreviewFeature ! src/java.base/share/classes/module-info.java Changeset: 46690db2 Author: Alan Bateman Date: 2021-10-04 18:00:14 +0000 URL: https://git.openjdk.java.net/loom/commit/46690db2fb1169a87a492299fade3956a9a6d775 Missing checks for null and out of bounds ! src/java.base/share/classes/java/io/PrintWriter.java ! src/java.base/share/classes/java/io/Writer.java From duke at openjdk.java.net Tue Oct 5 08:49:08 2021 From: duke at openjdk.java.net (duke) Date: Tue, 5 Oct 2021 08:49:08 GMT Subject: git: openjdk/loom: fibers: 3 new changesets Message-ID: Changeset: b1a75554 Author: Alan Bateman Date: 2021-10-05 08:41:37 +0000 URL: https://git.openjdk.java.net/loom/commit/b1a75554ee623699ed3799a8efb5877789d8a57c Exclude java/util/Properties/StoreReproducibilityTest.java from tier4, depends on SM ! test/jdk/ProblemList-vthread.txt Changeset: 9f945f81 Author: Alan Bateman Date: 2021-10-05 09:44:07 +0000 URL: https://git.openjdk.java.net/loom/commit/9f945f81ccbe4827c106f3bfdbdcdd53ec18afbc Allow ThreadAPI run with the wrapper in tier4 ! test/jdk/java/lang/Thread/virtual/ThreadAPI.java Changeset: 4406b8ee Author: Alan Bateman Date: 2021-10-05 09:44:50 +0000 URL: https://git.openjdk.java.net/loom/commit/4406b8ee7233d4765f5e1b27d09e9fb0b1e09dbe JNI attached threads should get unique tid; minor javadoc fixes ! src/java.base/share/classes/java/lang/Thread.java From shade at openjdk.java.net Tue Oct 5 10:01:49 2021 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Tue, 5 Oct 2021 10:01:49 GMT Subject: RFR: Make Loom buildable on x86_32 [v3] In-Reply-To: <0-D-rFniyQnPM5gVHXWf4pbg5vnMP8TdAtqkoKbFmSU=.0807e9e7-3439-4133-911e-c8ae83781659@github.com> References: <0-D-rFniyQnPM5gVHXWf4pbg5vnMP8TdAtqkoKbFmSU=.0807e9e7-3439-4133-911e-c8ae83781659@github.com> Message-ID: <2MKmOB3yCIrnyg2SapgSW8596rtKLgoCe_VOF3fhdTk=.bd30c2b8-85bf-43ba-b30c-072a01069222@github.com> > This PRs make Loom workspace at least buildable on x86_32. > > Since jlink/jmod run build JDK, the JDK itself has to start well, without touching Loom code. Current patch only does `make images` well, trying to run `tier1` with `x86_32` quickly fails with multiple errors -- I suspect deopt, G1 and other changes are subtly broken on x86_32. I shall continue the fixes in another PR, and this push would unhoard the generic 32-bit fixes in format specifiers. > > Additional testing: > - [x] 10x `CONF=linux-x86-server-fastdebug make clean-images images` Aleksey Shipilev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains seven additional commits since the last revision: - Fix another register clash on x86_32 (rcx is used later as rthread) - Merge branch 'fibers' into basic-x86-32-builds - Merge branch 'fibers' into basic-x86-32-builds - More accurate register saving - More precise post_call_nops - Select the register better - Linux x86_32 builds fine ------------- Changes: - all: https://git.openjdk.java.net/loom/pull/65/files - new: https://git.openjdk.java.net/loom/pull/65/files/db6a87ae..2d420624 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=loom&pr=65&range=02 - incr: https://webrevs.openjdk.java.net/?repo=loom&pr=65&range=01-02 Stats: 2866 lines in 136 files changed: 385 ins; 2202 del; 279 mod Patch: https://git.openjdk.java.net/loom/pull/65.diff Fetch: git fetch https://git.openjdk.java.net/loom pull/65/head:pull/65 PR: https://git.openjdk.java.net/loom/pull/65 From shade at openjdk.java.net Tue Oct 5 10:49:13 2021 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Tue, 5 Oct 2021 10:49:13 GMT Subject: RFR: Make Loom buildable on x86_32 [v3] In-Reply-To: <2MKmOB3yCIrnyg2SapgSW8596rtKLgoCe_VOF3fhdTk=.bd30c2b8-85bf-43ba-b30c-072a01069222@github.com> References: <0-D-rFniyQnPM5gVHXWf4pbg5vnMP8TdAtqkoKbFmSU=.0807e9e7-3439-4133-911e-c8ae83781659@github.com> <2MKmOB3yCIrnyg2SapgSW8596rtKLgoCe_VOF3fhdTk=.bd30c2b8-85bf-43ba-b30c-072a01069222@github.com> Message-ID: On Tue, 5 Oct 2021 10:01:49 GMT, Aleksey Shipilev wrote: >> This PRs make Loom workspace at least buildable on x86_32. >> >> Since jlink/jmod run build JDK, the JDK itself has to start well, without touching Loom code. Current patch passes `make images` and `tier1` on `x86_32`, with predictable test failures on Loom-specific tests. I shall continue with the actual x86_32 support in another PR. Meanwhile, this PR should make x86_32 builds (e.g. in GHA) and the rest of non-Loom-specific tests happy. This would also protect from introducing more 32-bit uncleanliness in shared code. >> >> Additional testing: >> - [x] 10x `CONF=linux-x86-server-fastdebug make clean-images images` >> - [x] Linux x86_32 `tier1` passes (with Loom-specific test failures) > > Aleksey Shipilev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains seven additional commits since the last revision: > > - Fix another register clash on x86_32 (rcx is used later as rthread) > - Merge branch 'fibers' into basic-x86-32-builds > - Merge branch 'fibers' into basic-x86-32-builds > - More accurate register saving > - More precise post_call_nops > - Select the register better > - Linux x86_32 builds fine All right, I think I nailed most of the generic x86_32 bugs here, and it builds and runs non-Loom code fine. Here it is building Linux x86 cleanly in GHA: https://github.com/shipilev/loom/runs/3801890849 https://github.com/shipilev/loom/runs/3801890884 Please take a look @pron, @AlanBateman. ------------- PR: https://git.openjdk.java.net/loom/pull/65 From duke at openjdk.java.net Tue Oct 5 11:38:26 2021 From: duke at openjdk.java.net (duke) Date: Tue, 5 Oct 2021 11:38:26 GMT Subject: git: openjdk/loom: fibers: Don't allow -Xint with -XX:+SegmentedCodeCache Message-ID: Changeset: 9e0807d7 Author: Rickard B?ckman Date: 2021-10-05 23:36:36 +0000 URL: https://git.openjdk.java.net/loom/commit/9e0807d70ba967f4493d3fe3468c40a7a1731aef Don't allow -Xint with -XX:+SegmentedCodeCache ! src/hotspot/share/runtime/arguments.cpp From shade at openjdk.java.net Tue Oct 5 19:17:58 2021 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Tue, 5 Oct 2021 19:17:58 GMT Subject: RFR: Loom: PPC64, S390, ARM32, Zero stubs Message-ID: This WIP provides enough stubs to make Loom cross-compilable to PPC64, S390, ARM32 and Zero. This should be enough to get the sense where the shared code actually platform-specific (referencing stuff from `frame` that is platform-specific), what should be implemented for a platform, and also should be enough to get GHA build checks green. Note current patch does not implement Loom on these platforms, but merely provides the absolute basic build capabilities. Note that ARM32 builds would not be clean until #65 is integrated with 32-bit cleanliness fixes. Additional testing: - [x] Linux x86_64 tier1_loom still passes - [x] Linux PPC64 cross-compilation - [x] Linux S390 cross-compilation - [x] Linux ARM32 cross-compilation - [x] Linux x86_64 Zero (Hotspot) compilation ------------- Commit messages: - More whitespace - Self-review fixes - PPC64, S390, ARM32, Zero stubs Changes: https://git.openjdk.java.net/loom/pull/72/files Webrev: https://webrevs.openjdk.java.net/?repo=loom&pr=72&range=00 Stats: 2286 lines in 49 files changed: 2203 ins; 33 del; 50 mod Patch: https://git.openjdk.java.net/loom/pull/72.diff Fetch: git fetch https://git.openjdk.java.net/loom pull/72/head:pull/72 PR: https://git.openjdk.java.net/loom/pull/72 From levi at leviaul.com Wed Oct 6 01:34:38 2021 From: levi at leviaul.com (Levi Aul) Date: Tue, 5 Oct 2021 18:34:38 -0700 Subject: Interaction between virtual threads and ForkJoinPool.commonPool Message-ID: I have some work projects that have third-party-lib dependencies which schedule background work by creating ForkJoinTasks, and then explicitly submitting those ForkJoinTasks to the ForkJoinPool.commonPool. These background workloads in turn do blocking IO; and so (with high-enough concurrency) they end up blocking the whole set of ForkJoinPool.commonPool worker threads for long periods, resulting in awful latencies as other quick tasks scheduled to the commonPool never start. I'm looking into Loom's virtual threads to solve this problem. But, from what I've read so far, the Loom changes by themselves don't seem to do anything to "enhance" or "co-opt" the ForkJoinPool.commonPool, and so won't be of much help in my situation. Is this correct, or have I missed something? Is it possible under the Loom-branch JVM to configure the ForkJoinPool.commonPool to act as a dumb proxy for a VirtualThreadExecutor, such that tasks run against the commonPool get unbounded IO concurrency? Or is it even unnecessary (i.e. do *all* ForkJoinPools in Loom park their ForkJoinTasks when they hit low-level runtime blocking-yield-points, such that all ForkJoinTasks are equivalent to "virtual threads" in behavior, even if the ones that are explicitly ForkJoinTasks have no associated isVirtual=true Thread object)? Also, to clarify: if a CompletableFuture/Callable/etc. is scheduled onto a Loom virtual thread (which is running on a ForkJoinPool-based scheduler), is that workload then implicitly running in the scope of a ForkJoinTask, such that it has a thread-local reference to its (carrier thread's) ForkJoinPool, such that calls that implicitly schedule "through" that reference if available (e.g. stream().parallel()) will schedule as Loom virtual threads? Or do these just end up using the ForkJoinPool.commonPool as well? From Alan.Bateman at oracle.com Wed Oct 6 08:21:10 2021 From: Alan.Bateman at oracle.com (Alan Bateman) Date: Wed, 6 Oct 2021 09:21:10 +0100 Subject: Interaction between virtual threads and ForkJoinPool.commonPool In-Reply-To: References: Message-ID: On 06/10/2021 02:34, Levi Aul wrote: > I have some work projects that have third-party-lib dependencies which > schedule background work by creating ForkJoinTasks, and then explicitly > submitting those ForkJoinTasks to the ForkJoinPool.commonPool. These > background workloads in turn do blocking IO; and so (with high-enough > concurrency) they end up blocking the whole set of ForkJoinPool.commonPool > worker threads for long periods, resulting in awful latencies as other > quick tasks scheduled to the commonPool never start. > > I'm looking into Loom's virtual threads to solve this problem. But, from > what I've read so far, the Loom changes by themselves don't seem to do > anything to "enhance" or "co-opt" the ForkJoinPool.commonPool, and so won't > be of much help in my situation. > > Is this correct, or have I missed something? That is correct, the FJP common pool works as before. > Is it possible under the > Loom-branch JVM to configure the ForkJoinPool.commonPool to act as a dumb > proxy for a VirtualThreadExecutor, such that tasks run against the > commonPool get unbounded IO concurrency? Or is it even unnecessary (i.e. do > *all* ForkJoinPools in Loom park their ForkJoinTasks when they hit > low-level runtime blocking-yield-points, such that all ForkJoinTasks are > equivalent to "virtual threads" in behavior, even if the ones that are > explicitly ForkJoinTasks have no associated isVirtual=true Thread object)? > > Also, to clarify: if a CompletableFuture/Callable/etc. is scheduled onto a > Loom virtual thread (which is running on a ForkJoinPool-based scheduler), > is that workload then implicitly running in the scope of a ForkJoinTask, > such that it has a thread-local reference to its (carrier thread's) > ForkJoinPool, such that calls that implicitly schedule "through" that > reference if available (e.g. stream().parallel()) will schedule as Loom > virtual threads? Or do these just end up using the ForkJoinPool.commonPool > as well? If code executing in a virtual thread uses stream parallel() or CF.xxAsync then the tasks run in the common pool as before (or the CF default executor if overridden). Yes, this is area that needs further attention and exploration. There was some discussion about it early on but it was kicked down the road to give time to figure out the programming model and core implementation. So I expect it will come back. -Alan From shade at openjdk.java.net Fri Oct 8 08:31:28 2021 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Fri, 8 Oct 2021 08:31:28 GMT Subject: RFR: Loom: PPC64, S390, ARM32, Zero stubs In-Reply-To: References: Message-ID: On Tue, 5 Oct 2021 16:44:01 GMT, Aleksey Shipilev wrote: > This WIP provides enough stubs to make Loom cross-compilable to PPC64, S390, ARM32 and Zero. This should be enough to get the sense where the shared code actually platform-specific (referencing stuff from `frame` that is platform-specific), what should be implemented for a platform, and also should be enough to get GHA build checks green. Note current patch does not implement Loom on these platforms, but merely provides the absolute basic build capabilities. > > Note that ARM32 builds would not be clean until #65 is integrated with 32-bit cleanliness fixes. > > Additional testing: > - [x] Linux x86_64 tier1_loom still passes > - [x] Linux PPC64 cross-compilation > - [x] Linux S390 cross-compilation > - [x] Linux ARM32 cross-compilation > - [x] Linux x86_64 Zero (Hotspot) compilation Any comments? I would like to have it integrated. ------------- PR: https://git.openjdk.java.net/loom/pull/72 From shade at openjdk.java.net Fri Oct 8 08:31:31 2021 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Fri, 8 Oct 2021 08:31:31 GMT Subject: RFR: Make Loom buildable on x86_32 [v3] In-Reply-To: <2MKmOB3yCIrnyg2SapgSW8596rtKLgoCe_VOF3fhdTk=.bd30c2b8-85bf-43ba-b30c-072a01069222@github.com> References: <0-D-rFniyQnPM5gVHXWf4pbg5vnMP8TdAtqkoKbFmSU=.0807e9e7-3439-4133-911e-c8ae83781659@github.com> <2MKmOB3yCIrnyg2SapgSW8596rtKLgoCe_VOF3fhdTk=.bd30c2b8-85bf-43ba-b30c-072a01069222@github.com> Message-ID: On Tue, 5 Oct 2021 10:01:49 GMT, Aleksey Shipilev wrote: >> This PRs make Loom workspace at least buildable on x86_32. >> >> Since jlink/jmod run build JDK, the JDK itself has to start well, without touching Loom code. Current patch passes `make images` and `tier1` on `x86_32`, with predictable test failures on Loom-specific tests. I shall continue with the actual x86_32 support in another PR. Meanwhile, this PR should make x86_32 builds (e.g. in GHA) and the rest of non-Loom-specific tests happy. This would also protect from introducing more 32-bit uncleanliness in shared code. >> >> Additional testing: >> - [x] 10x `CONF=linux-x86-server-fastdebug make clean-images images` >> - [x] Linux x86_32 `tier1` passes (with Loom-specific test failures) > > Aleksey Shipilev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains seven additional commits since the last revision: > > - Fix another register clash on x86_32 (rcx is used later as rthread) > - Merge branch 'fibers' into basic-x86-32-builds > - Merge branch 'fibers' into basic-x86-32-builds > - More accurate register saving > - More precise post_call_nops > - Select the register better > - Linux x86_32 builds fine Any comments? I would like to have it integrated. ------------- PR: https://git.openjdk.java.net/loom/pull/65 From duke at openjdk.java.net Fri Oct 8 09:32:26 2021 From: duke at openjdk.java.net (duke) Date: Fri, 8 Oct 2021 09:32:26 GMT Subject: git: openjdk/loom: fibers: Re-include tests that failed because of OOME in CodeCache Message-ID: <98e56114-4709-4a8a-bd02-43cc08acfac9@openjdk.java.net> Changeset: 63f3163c Author: Ron Pressler Date: 2021-10-08 10:31:38 +0000 URL: https://git.openjdk.java.net/loom/commit/63f3163c82a7681bf872d91d4329e7e5d3518ac6 Re-include tests that failed because of OOME in CodeCache ! test/hotspot/jtreg/ProblemList-vthread-Xcomp.txt ! test/jdk/ProblemList-vthread-Xcomp.txt From rpressler at openjdk.java.net Fri Oct 8 10:06:23 2021 From: rpressler at openjdk.java.net (Ron Pressler) Date: Fri, 8 Oct 2021 10:06:23 GMT Subject: RFR: Make Loom buildable on x86_32 [v3] In-Reply-To: <2MKmOB3yCIrnyg2SapgSW8596rtKLgoCe_VOF3fhdTk=.bd30c2b8-85bf-43ba-b30c-072a01069222@github.com> References: <0-D-rFniyQnPM5gVHXWf4pbg5vnMP8TdAtqkoKbFmSU=.0807e9e7-3439-4133-911e-c8ae83781659@github.com> <2MKmOB3yCIrnyg2SapgSW8596rtKLgoCe_VOF3fhdTk=.bd30c2b8-85bf-43ba-b30c-072a01069222@github.com> Message-ID: On Tue, 5 Oct 2021 10:01:49 GMT, Aleksey Shipilev wrote: >> This PRs make Loom workspace at least buildable on x86_32. >> >> Since jlink/jmod run build JDK, the JDK itself has to start well, without touching Loom code. Current patch passes `make images` and `tier1` on `x86_32`, with predictable test failures on Loom-specific tests. I shall continue with the actual x86_32 support in another PR. Meanwhile, this PR should make x86_32 builds (e.g. in GHA) and the rest of non-Loom-specific tests happy. This would also protect from introducing more 32-bit uncleanliness in shared code. >> >> Additional testing: >> - [x] 10x `CONF=linux-x86-server-fastdebug make clean-images images` >> - [x] Linux x86_32 `tier1` passes (with Loom-specific test failures) > > Aleksey Shipilev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains seven additional commits since the last revision: > > - Fix another register clash on x86_32 (rcx is used later as rthread) > - Merge branch 'fibers' into basic-x86-32-builds > - Merge branch 'fibers' into basic-x86-32-builds > - More accurate register saving > - More precise post_call_nops > - Select the register better > - Linux x86_32 builds fine Sorry, I expect I'll have time to review it next week. ------------- PR: https://git.openjdk.java.net/loom/pull/65 From shade at openjdk.java.net Fri Oct 8 14:23:38 2021 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Fri, 8 Oct 2021 14:23:38 GMT Subject: RFR: Remove the remaining mentions of AOT Message-ID: I am looking at [current Loom webrev against mainline](https://builds.shipilev.net/patch-openjdk-loom-fibers/), and notice there are left-overs after [JDK-8264805](https://bugs.openjdk.java.net/browse/JDK-8264805) removed AOT in mainline. This is probably the result of the merge that kept stale Loom-repo files whereas they were removed upstream. Additional testing: - [x] Linux x86_64 fastdebug `tier1_loom` still passes. ------------- Commit messages: - Remove the remaining mentions of AOT Changes: https://git.openjdk.java.net/loom/pull/73/files Webrev: https://webrevs.openjdk.java.net/?repo=loom&pr=73&range=00 Stats: 432 lines in 3 files changed: 0 ins; 430 del; 2 mod Patch: https://git.openjdk.java.net/loom/pull/73.diff Fetch: git fetch https://git.openjdk.java.net/loom pull/73/head:pull/73 PR: https://git.openjdk.java.net/loom/pull/73 From levi at leviaul.com Fri Oct 8 20:19:14 2021 From: levi at leviaul.com (Levi Aul) Date: Fri, 8 Oct 2021 13:19:14 -0700 Subject: Interaction between virtual threads and ForkJoinPool.commonPool In-Reply-To: References: Message-ID: Thanks, this is useful information. Specifically for parallel stream operations in code we control (which we have a lot of), is it currently possible, with considerable effort, to build a proxy object around a threadPerTaskExecutor, that "looks like" a ForkJoinPool to java.util.stream.AbstractTask et al, so that we could submit parallel-stream workloads to this fake FJP and have it schedule the ForkJoinTasks onto virtual-threads? I can't see any way of accomplishing this myself (save for forking the JVM further), as ForkJoinWorkerThread isn't an interface but a subclass; but I'm hoping you folks know more secrets of the internals of java.util.concurrent than I do. Given the current state of the Loom API, what would you recommend as the current/tentative "most idiomatic" approach for explicitly using virtual threads to parallelize e.g. an expensive IO-blocking call inside a mapping closure in a stream pipeline? Would it be the obvious?i.e. lift the expensive IO-blocking calls out of the pipeline, with code before the pipeline first scheduling the operations onto a virtualThreadExecutor, blocking for all those futures to resolve, and then accessing the resolved futures from within the pipeline once there's no longer a possibility of IO-blocking? Or is there something cleaner/simpler that can be done here? On Wed, Oct 6, 2021 at 1:21 AM Alan Bateman wrote: > On 06/10/2021 02:34, Levi Aul wrote: > > I have some work projects that have third-party-lib dependencies which > > schedule background work by creating ForkJoinTasks, and then explicitly > > submitting those ForkJoinTasks to the ForkJoinPool.commonPool. These > > background workloads in turn do blocking IO; and so (with high-enough > > concurrency) they end up blocking the whole set of > ForkJoinPool.commonPool > > worker threads for long periods, resulting in awful latencies as other > > quick tasks scheduled to the commonPool never start. > > > > I'm looking into Loom's virtual threads to solve this problem. But, from > > what I've read so far, the Loom changes by themselves don't seem to do > > anything to "enhance" or "co-opt" the ForkJoinPool.commonPool, and so > won't > > be of much help in my situation. > > > > Is this correct, or have I missed something? > That is correct, the FJP common pool works as before. > > > > Is it possible under the > > Loom-branch JVM to configure the ForkJoinPool.commonPool to act as a dumb > > proxy for a VirtualThreadExecutor, such that tasks run against the > > commonPool get unbounded IO concurrency? Or is it even unnecessary (i.e. > do > > *all* ForkJoinPools in Loom park their ForkJoinTasks when they hit > > low-level runtime blocking-yield-points, such that all ForkJoinTasks are > > equivalent to "virtual threads" in behavior, even if the ones that are > > explicitly ForkJoinTasks have no associated isVirtual=true Thread > object)? > > > > Also, to clarify: if a CompletableFuture/Callable/etc. is scheduled onto > a > > Loom virtual thread (which is running on a ForkJoinPool-based scheduler), > > is that workload then implicitly running in the scope of a ForkJoinTask, > > such that it has a thread-local reference to its (carrier thread's) > > ForkJoinPool, such that calls that implicitly schedule "through" that > > reference if available (e.g. stream().parallel()) will schedule as Loom > > virtual threads? Or do these just end up using the > ForkJoinPool.commonPool > > as well? > If code executing in a virtual thread uses stream parallel() or > CF.xxAsync then the tasks run in the common pool as before (or the CF > default executor if overridden). Yes, this is area that needs further > attention and exploration. There was some discussion about it early on > but it was kicked down the road to give time to figure out the > programming model and core implementation. So I expect it will come back. > > -Alan > > > From alanb at openjdk.java.net Sat Oct 9 06:03:22 2021 From: alanb at openjdk.java.net (Alan Bateman) Date: Sat, 9 Oct 2021 06:03:22 GMT Subject: RFR: Remove the remaining mentions of AOT In-Reply-To: References: Message-ID: On Fri, 8 Oct 2021 14:17:32 GMT, Aleksey Shipilev wrote: > I am looking at [current Loom webrev against mainline](https://builds.shipilev.net/patch-openjdk-loom-fibers/), and notice there are left-overs after [JDK-8264805](https://bugs.openjdk.java.net/browse/JDK-8264805) removed AOT in mainline. This is probably the result of the merge that kept stale Loom-repo files whereas they were removed upstream. > > Additional testing: > - [x] Linux x86_64 fastdebug `tier1_loom` still passes. I noticed these two sources recently too and was wondering why they were still in the repo. ------------- Marked as reviewed by alanb (Committer). PR: https://git.openjdk.java.net/loom/pull/73 From duke at openjdk.java.net Sun Oct 10 07:50:14 2021 From: duke at openjdk.java.net (duke) Date: Sun, 10 Oct 2021 07:50:14 GMT Subject: git: openjdk/loom: fibers: 7 new changesets Message-ID: <55c22b63-7c75-4cfd-b7b5-cb5616268619@openjdk.java.net> Changeset: 959d10c4 Author: Alan Bateman Date: 2021-10-08 13:31:15 +0000 URL: https://git.openjdk.java.net/loom/commit/959d10c4170561dc2d1733999eacf7a14667cd52 Clarified wording ! src/java.base/share/classes/java/lang/Thread.java Changeset: 63564ada Author: Alan Bateman Date: 2021-10-09 15:05:54 +0000 URL: https://git.openjdk.java.net/loom/commit/63564adadedd7f42be89a1095bb6b5f69c424113 Default to 1 unparker ! src/java.base/share/classes/java/lang/VirtualThread.java Changeset: 723ac25a Author: Alan Bateman Date: 2021-10-09 15:44:10 +0000 URL: https://git.openjdk.java.net/loom/commit/723ac25a15d4bd157e522c752ab53c40619c90b4 Test needs --enable-preview ! test/jdk/com/sun/management/HotSpotDiagnosticMXBean/DumpThreads.java Changeset: e014a923 Author: Alan Bateman Date: 2021-10-09 15:50:34 +0000 URL: https://git.openjdk.java.net/loom/commit/e014a9231b75e3690ad4c348403335d7f786456e ThreadMXBean/VirtualThreads.java test needs to set scheduler ! test/jdk/java/lang/management/ThreadMXBean/VirtualThreads.java Changeset: 3a735c6f Author: Alan Bateman Date: 2021-10-09 17:13:52 +0000 URL: https://git.openjdk.java.net/loom/commit/3a735c6f776f32161f982b7f15f4dd01f7e68ffc Fix copyright header ! src/hotspot/cpu/aarch64/continuation_aarch64.inline.hpp Changeset: e429b52f Author: Alan Bateman Date: 2021-10-09 19:30:17 +0000 URL: https://git.openjdk.java.net/loom/commit/e429b52f8c136604a22ddda5615ac5466ef5c6be Fix copyright header ! src/jdk.jdi/share/classes/com/sun/jdi/ThreadReference.java Changeset: e71a1e2f Author: Alan Bateman Date: 2021-10-10 08:44:10 +0000 URL: https://git.openjdk.java.net/loom/commit/e71a1e2f2c5b80265b76cbdd62c0d4239ee550f0 Unexclude potentially stale entries, re-order/cleanup ! test/hotspot/jtreg/ProblemList.txt From shade at openjdk.java.net Mon Oct 11 06:12:35 2021 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Mon, 11 Oct 2021 06:12:35 GMT Subject: Integrated: Remove the remaining mentions of AOT In-Reply-To: References: Message-ID: <4djA9ThYdJNmBBw9X9Ktec7EkWT44DivFrR3Hm8F3VI=.3e4013a4-ba27-47ce-8b4a-ffd06d2d19c5@github.com> On Fri, 8 Oct 2021 14:17:32 GMT, Aleksey Shipilev wrote: > I am looking at [current Loom webrev against mainline](https://builds.shipilev.net/patch-openjdk-loom-fibers/), and notice there are left-overs after [JDK-8264805](https://bugs.openjdk.java.net/browse/JDK-8264805) removed AOT in mainline. This is probably the result of the merge that kept stale Loom-repo files whereas they were removed upstream. > > Additional testing: > - [x] Linux x86_64 fastdebug `tier1_loom` still passes. This pull request has now been integrated. Changeset: 2fed93f2 Author: Aleksey Shipilev Committer: Alan Bateman URL: https://git.openjdk.java.net/loom/commit/2fed93f2954bb5dc6edef4b7e38733b093c4cdc5 Stats: 432 lines in 3 files changed: 0 ins; 430 del; 2 mod Remove the remaining mentions of AOT Reviewed-by: alanb ------------- PR: https://git.openjdk.java.net/loom/pull/73 From rpressler at openjdk.java.net Mon Oct 11 09:25:28 2021 From: rpressler at openjdk.java.net (Ron Pressler) Date: Mon, 11 Oct 2021 09:25:28 GMT Subject: RFR: Make Loom buildable on x86_32 [v3] In-Reply-To: <2MKmOB3yCIrnyg2SapgSW8596rtKLgoCe_VOF3fhdTk=.bd30c2b8-85bf-43ba-b30c-072a01069222@github.com> References: <0-D-rFniyQnPM5gVHXWf4pbg5vnMP8TdAtqkoKbFmSU=.0807e9e7-3439-4133-911e-c8ae83781659@github.com> <2MKmOB3yCIrnyg2SapgSW8596rtKLgoCe_VOF3fhdTk=.bd30c2b8-85bf-43ba-b30c-072a01069222@github.com> Message-ID: On Tue, 5 Oct 2021 10:01:49 GMT, Aleksey Shipilev wrote: >> This PRs make Loom workspace at least buildable on x86_32. >> >> Since jlink/jmod run build JDK, the JDK itself has to start well, without touching Loom code. Current patch passes `make images` and `tier1` on `x86_32`, with predictable test failures on Loom-specific tests. I shall continue with the actual x86_32 support in another PR. Meanwhile, this PR should make x86_32 builds (e.g. in GHA) and the rest of non-Loom-specific tests happy. This would also protect from introducing more 32-bit uncleanliness in shared code. >> >> Additional testing: >> - [x] 10x `CONF=linux-x86-server-fastdebug make clean-images images` >> - [x] Linux x86_32 `tier1` passes (with Loom-specific test failures) > > Aleksey Shipilev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains seven additional commits since the last revision: > > - Fix another register clash on x86_32 (rcx is used later as rthread) > - Merge branch 'fibers' into basic-x86-32-builds > - Merge branch 'fibers' into basic-x86-32-builds > - More accurate register saving > - More precise post_call_nops > - Select the register better > - Linux x86_32 builds fine Marked as reviewed by rpressler (Lead). You're good to go. Thank you for this! ------------- PR: https://git.openjdk.java.net/loom/pull/65 From shade at openjdk.java.net Mon Oct 11 09:30:23 2021 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Mon, 11 Oct 2021 09:30:23 GMT Subject: RFR: Make Loom buildable on x86_32 [v3] In-Reply-To: <2MKmOB3yCIrnyg2SapgSW8596rtKLgoCe_VOF3fhdTk=.bd30c2b8-85bf-43ba-b30c-072a01069222@github.com> References: <0-D-rFniyQnPM5gVHXWf4pbg5vnMP8TdAtqkoKbFmSU=.0807e9e7-3439-4133-911e-c8ae83781659@github.com> <2MKmOB3yCIrnyg2SapgSW8596rtKLgoCe_VOF3fhdTk=.bd30c2b8-85bf-43ba-b30c-072a01069222@github.com> Message-ID: <0dBsw2ejcqxKWjLlAYg_bl6b_GJpKLBDuDzO6Ly3pSU=.37b24d76-6862-4f60-8fd6-c4302bc40140@github.com> On Tue, 5 Oct 2021 10:01:49 GMT, Aleksey Shipilev wrote: >> This PRs make Loom workspace at least buildable on x86_32. >> >> Since jlink/jmod run build JDK, the JDK itself has to start well, without touching Loom code. Current patch passes `make images` and `tier1` on `x86_32`, with predictable test failures on Loom-specific tests. I shall continue with the actual x86_32 support in another PR. Meanwhile, this PR should make x86_32 builds (e.g. in GHA) and the rest of non-Loom-specific tests happy. This would also protect from introducing more 32-bit uncleanliness in shared code. >> >> Additional testing: >> - [x] 10x `CONF=linux-x86-server-fastdebug make clean-images images` >> - [x] Linux x86_32 `tier1` passes (with Loom-specific test failures) > > Aleksey Shipilev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains seven additional commits since the last revision: > > - Fix another register clash on x86_32 (rcx is used later as rthread) > - Merge branch 'fibers' into basic-x86-32-builds > - Merge branch 'fibers' into basic-x86-32-builds > - More accurate register saving > - More precise post_call_nops > - Select the register better > - Linux x86_32 builds fine Cheers. ------------- PR: https://git.openjdk.java.net/loom/pull/65 From shade at openjdk.java.net Mon Oct 11 15:42:26 2021 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Mon, 11 Oct 2021 15:42:26 GMT Subject: Integrated: Make Loom buildable on x86_32 In-Reply-To: <0-D-rFniyQnPM5gVHXWf4pbg5vnMP8TdAtqkoKbFmSU=.0807e9e7-3439-4133-911e-c8ae83781659@github.com> References: <0-D-rFniyQnPM5gVHXWf4pbg5vnMP8TdAtqkoKbFmSU=.0807e9e7-3439-4133-911e-c8ae83781659@github.com> Message-ID: On Fri, 24 Sep 2021 17:04:18 GMT, Aleksey Shipilev wrote: > This PRs make Loom workspace at least buildable on x86_32. > > Since jlink/jmod run build JDK, the JDK itself has to start well, without touching Loom code. Current patch passes `make images` and `tier1` on `x86_32`, with predictable test failures on Loom-specific tests. I shall continue with the actual x86_32 support in another PR. Meanwhile, this PR should make x86_32 builds (e.g. in GHA) and the rest of non-Loom-specific tests happy. This would also protect from introducing more 32-bit uncleanliness in shared code. > > Additional testing: > - [x] 10x `CONF=linux-x86-server-fastdebug make clean-images images` > - [x] Linux x86_32 `tier1` passes (with Loom-specific test failures) This pull request has now been integrated. Changeset: e8316e7b Author: Aleksey Shipilev Committer: Ron Pressler URL: https://git.openjdk.java.net/loom/commit/e8316e7b6bed287662bb3d5aab471e4ae7a7227e Stats: 116 lines in 15 files changed: 63 ins; 3 del; 50 mod Make Loom buildable on x86_32 Reviewed-by: rpressler ------------- PR: https://git.openjdk.java.net/loom/pull/65 From shade at openjdk.java.net Mon Oct 11 15:55:33 2021 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Mon, 11 Oct 2021 15:55:33 GMT Subject: RFR: More tests in tier1_loom Message-ID: Porting/development work would be much simpler if we had a comprehensive test group with Loom-specific tests. There is such a group in hotspot, `tier1_loom`. We can revamp it with more tests. I basically went and added tests that are added/substantially-modified by Loom, judging by a [recent webrev](https://builds.shipilev.net/patch-openjdk-loom-fibers/). Sample run: $ time CONF=linux-x86_64-server-fastdebug make run-test TEST=tier1_loom ... ============================== Test summary ============================== TEST TOTAL PASS FAIL ERROR jtreg:test/hotspot/jtreg:tier1_loom 63 63 0 0 jtreg:test/jdk:tier1_loom 83 83 0 0 ============================== TEST SUCCESS Finished building target 'run-test' in configuration 'linux-x86_64-server-fastdebug' real 6m57.212s user 33m52.605s sys 1m32.212s Excluding `java/lang/Thread/virtual/stress` would make the run at least twice as fast, but I don't think that would be reasonable to do at this stage in development. ------------- Commit messages: - More tests in tier1_loom Changes: https://git.openjdk.java.net/loom/pull/74/files Webrev: https://webrevs.openjdk.java.net/?repo=loom&pr=74&range=00 Stats: 16 lines in 2 files changed: 14 ins; 0 del; 2 mod Patch: https://git.openjdk.java.net/loom/pull/74.diff Fetch: git fetch https://git.openjdk.java.net/loom pull/74/head:pull/74 PR: https://git.openjdk.java.net/loom/pull/74 From alanb at openjdk.java.net Mon Oct 11 16:05:24 2021 From: alanb at openjdk.java.net (Alan Bateman) Date: Mon, 11 Oct 2021 16:05:24 GMT Subject: RFR: More tests in tier1_loom In-Reply-To: References: Message-ID: On Mon, 11 Oct 2021 15:50:02 GMT, Aleksey Shipilev wrote: > Porting/development work would be much simpler if we had a comprehensive test group with Loom-specific tests. There is such a group in hotspot, `tier1_loom`. We can revamp it with more tests. I basically went and added tests that are added/substantially-modified by Loom, judging by a [recent webrev](https://builds.shipilev.net/patch-openjdk-loom-fibers/). > > Sample run: > > > $ time CONF=linux-x86_64-server-fastdebug make run-test TEST=tier1_loom > ... > ============================== > Test summary > ============================== > TEST TOTAL PASS FAIL ERROR > jtreg:test/hotspot/jtreg:tier1_loom 63 63 0 0 > jtreg:test/jdk:tier1_loom 83 83 0 0 > ============================== > TEST SUCCESS > > Finished building target 'run-test' in configuration 'linux-x86_64-server-fastdebug' > > real 6m57.212s > user 33m52.605s > sys 1m32.212s > > > Excluding `java/lang/Thread/virtual/stress` would make the run at least twice as fast, but I don't think that would be reasonable to do at this stage in development. Ugh, tier1_loom in jdk/TEST.group is a not very maintainable. Let's wait until Leonid gets back as this is going to conflict with the testing we do in the Oracle CI system. Also I think we are close to the point where loom-tierX can go away. ------------- PR: https://git.openjdk.java.net/loom/pull/74 From shade at openjdk.java.net Mon Oct 11 16:27:21 2021 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Mon, 11 Oct 2021 16:27:21 GMT Subject: RFR: More tests in tier1_loom In-Reply-To: References: Message-ID: On Mon, 11 Oct 2021 16:01:53 GMT, Alan Bateman wrote: > Ugh, tier1_loom in jdk/TEST.group is a not very maintainable. Let's wait until Leonid gets back as this is going to conflict with the testing we do in the Oracle CI system. Also I think we are close to the point where loom-tierX can go away. This looks like a custom test group, are you saying Oracle runs it in CI testing? I would have expected the regular tiered testing captured all the tests, Loom included. Either way, as I said in the PR description, it would be useful for development/porting work to have a test group that captures Loom tests, pretty much like other component test groups we have. Maybe it would not be called "tier1_loom", though, but just "hotspot_loom" and "jdk_loom"? ------------- PR: https://git.openjdk.java.net/loom/pull/74 From shade at openjdk.java.net Mon Oct 11 16:34:54 2021 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Mon, 11 Oct 2021 16:34:54 GMT Subject: RFR: Loom: PPC64, S390, ARM32, Zero stubs [v2] In-Reply-To: References: Message-ID: > This WIP provides enough stubs to make Loom cross-compilable to PPC64, S390, ARM32 and Zero. This should be enough to get the sense where the shared code actually platform-specific (referencing stuff from `frame` that is platform-specific), what should be implemented for a platform, and also should be enough to get GHA build checks green. Note current patch does not implement Loom on these platforms, but merely provides the absolute basic build capabilities. > > Note that ARM32 builds would not be clean until #65 is integrated with 32-bit cleanliness fixes. > > Additional testing: > - [x] Linux x86_64 tier1_loom still passes > - [x] Linux PPC64 cross-compilation > - [x] Linux S390 cross-compilation > - [x] Linux ARM32 cross-compilation > - [x] Linux x86_64 Zero (Hotspot) compilation Aleksey Shipilev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision: - Merge branch 'fibers' into platform-stubs - More whitespace - Self-review fixes - PPC64, S390, ARM32, Zero stubs ------------- Changes: - all: https://git.openjdk.java.net/loom/pull/72/files - new: https://git.openjdk.java.net/loom/pull/72/files/7195f357..a0906d48 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=loom&pr=72&range=01 - incr: https://webrevs.openjdk.java.net/?repo=loom&pr=72&range=00-01 Stats: 672 lines in 28 files changed: 110 ins; 473 del; 89 mod Patch: https://git.openjdk.java.net/loom/pull/72.diff Fetch: git fetch https://git.openjdk.java.net/loom pull/72/head:pull/72 PR: https://git.openjdk.java.net/loom/pull/72 From alanb at openjdk.java.net Mon Oct 11 17:29:12 2021 From: alanb at openjdk.java.net (Alan Bateman) Date: Mon, 11 Oct 2021 17:29:12 GMT Subject: RFR: More tests in tier1_loom In-Reply-To: References: Message-ID: On Mon, 11 Oct 2021 16:23:53 GMT, Aleksey Shipilev wrote: > This looks like a custom test group, are you saying Oracle runs it in CI testing? I would have expected the regular tiered testing captured all the tests, Loom included. > > Either way, as I said in the PR description, it would be useful for development/porting work to have a test group that captures Loom tests, pretty much like other component test groups we have. Maybe it would not be called "tier1_loom", though, but just "hotspot_loom" and "jdk_loom"? I think we've ended up with historical configuration that dates from early days of this project. It works with hotspot/jtreg/:tier1_loom but not jdk/jtreg/:tier1_loom, it's something we need to fix. So I don't object to adding something short term to define a group for porters to run but it's probably not something we'd bring into the main line.. If you can keep "tier1" out of the name for now then it gives us a chance to the fix our setup. ------------- PR: https://git.openjdk.java.net/loom/pull/74 From shade at openjdk.java.net Tue Oct 12 07:23:27 2021 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Tue, 12 Oct 2021 07:23:27 GMT Subject: RFR: Loom test groups for development/porting use [v2] In-Reply-To: References: Message-ID: > Porting/development work would be much simpler if we had a comprehensive test group with Loom-specific tests. There is `tier1_loom`, but it probably has a separate meaning. We can add some test groups with Loom-specific tests. I basically went and added tests that are added/substantially-modified by Loom, judging by a [recent webrev](https://builds.shipilev.net/patch-openjdk-loom-fibers/). > > Sample run: > > > $ time CONF=linux-x86_64-server-fastdebug make test TEST="hotspot_loom jdk_loom" > ... > ============================== > Test summary > ============================== > TEST TOTAL PASS FAIL ERROR > jtreg:test/hotspot/jtreg:hotspot_loom 62 62 0 0 > jtreg:test/jdk:jdk_loom 83 83 0 0 > ============================== > TEST SUCCESS > > Finished building target 'test' in configuration 'linux-x86_64-server-fastdebug' > > real 9m32.660s > user 103m5.744s > sys 5m37.864s Aleksey Shipilev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains one additional commit since the last revision: Do separate test groups ------------- Changes: - all: https://git.openjdk.java.net/loom/pull/74/files - new: https://git.openjdk.java.net/loom/pull/74/files/25fb4bd7..b3ed47dc Webrevs: - full: https://webrevs.openjdk.java.net/?repo=loom&pr=74&range=01 - incr: https://webrevs.openjdk.java.net/?repo=loom&pr=74&range=00-01 Stats: 147 lines in 17 files changed: 79 ins; 16 del; 52 mod Patch: https://git.openjdk.java.net/loom/pull/74.diff Fetch: git fetch https://git.openjdk.java.net/loom pull/74/head:pull/74 PR: https://git.openjdk.java.net/loom/pull/74 From shade at openjdk.java.net Tue Oct 12 07:23:29 2021 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Tue, 12 Oct 2021 07:23:29 GMT Subject: RFR: Loom test groups for development/porting use In-Reply-To: References: Message-ID: On Mon, 11 Oct 2021 17:25:52 GMT, Alan Bateman wrote: > If you can keep "tier1" out of the name for now then it gives us a chance to the fix our setup. Yes, we can do `hotspot_loom` and `jdk_loom` instead. See new commit and new PR description. ------------- PR: https://git.openjdk.java.net/loom/pull/74 From duke at openjdk.java.net Tue Oct 12 07:59:59 2021 From: duke at openjdk.java.net (duke) Date: Tue, 12 Oct 2021 07:59:59 GMT Subject: git: openjdk/loom: fibers: enhance jvmtiVTMTDisabler debug info Message-ID: <62dd34bd-6bba-4a42-a5c8-a5a69059f647@openjdk.java.net> Changeset: f77e5475 Author: Serguei Spitsyn Date: 2021-10-12 07:58:23 +0000 URL: https://git.openjdk.java.net/loom/commit/f77e5475751c155caedf52859f71f8ccdb3c9445 enhance jvmtiVTMTDisabler debug info ! src/hotspot/share/prims/jvmtiEnvBase.cpp ! src/hotspot/share/prims/jvmtiEnvBase.hpp ! src/hotspot/share/prims/jvmtiThreadState.cpp ! src/hotspot/share/prims/jvmtiThreadState.hpp ! test/hotspot/jtreg/serviceability/jvmti/vthread/SuspendResume2/libSuspendResume2.cpp From alanb at openjdk.java.net Tue Oct 12 08:07:12 2021 From: alanb at openjdk.java.net (Alan Bateman) Date: Tue, 12 Oct 2021 08:07:12 GMT Subject: RFR: Loom test groups for development/porting use [v2] In-Reply-To: References: Message-ID: <-b-GbNk9g36C-MhW_fZFR4uDVx8yZXgRa67whbhUcbA=.5870c35d-60d1-4944-9760-7a4875748f64@github.com> On Tue, 12 Oct 2021 07:23:27 GMT, Aleksey Shipilev wrote: >> Porting/development work would be much simpler if we had a comprehensive test group with Loom-specific tests. There is `tier1_loom`, but it probably has a separate meaning. We can add some test groups with Loom-specific tests. I basically went and added tests that are added/substantially-modified by Loom, judging by a [recent webrev](https://builds.shipilev.net/patch-openjdk-loom-fibers/). >> >> Sample run: >> >> >> $ time CONF=linux-x86_64-server-fastdebug make test TEST="hotspot_loom jdk_loom" >> ... >> ============================== >> Test summary >> ============================== >> TEST TOTAL PASS FAIL ERROR >> jtreg:test/hotspot/jtreg:hotspot_loom 62 62 0 0 >> jtreg:test/jdk:jdk_loom 83 83 0 0 >> ============================== >> TEST SUCCESS >> >> Finished building target 'test' in configuration 'linux-x86_64-server-fastdebug' >> >> real 9m32.660s >> user 103m5.744s >> sys 5m37.864s > > Aleksey Shipilev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains one additional commit since the last revision: > > Do separate test groups test/hotspot/jtreg/TEST.groups line 111: > 109: :tier1_loom \ > 110: runtime/jni/IsVirtualThread \ > 111: serviceability/dcmd/thread It would be okay to include these in tier1_loom_runtime and tier1_loom_serviceability as you had them. test/jdk/TEST.groups line 105: > 103: java/util/concurrent/Future \ > 104: jdk/internal/vm/Continuation \ > 105: jdk/jfr/threading Probably better to run java/util/concurrent rater than specific directories, it will otherwise get unwieldy once the tests move to the right place. You can probably drop Throwable, it's not interesting to run have its tests in this test group. Not sure about the JFR threading tests, we've been using the jdk_jfr group for that. ------------- PR: https://git.openjdk.java.net/loom/pull/74 From shade at openjdk.java.net Tue Oct 12 08:19:22 2021 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Tue, 12 Oct 2021 08:19:22 GMT Subject: RFR: Loom test groups for development/porting use [v3] In-Reply-To: References: Message-ID: > Porting/development work would be much simpler if we had a comprehensive test group with Loom-specific tests. There is `tier1_loom`, but it probably has a separate meaning. We can add some test groups with Loom-specific tests. I basically went and added tests that are added/substantially-modified by Loom, judging by a [recent webrev](https://builds.shipilev.net/patch-openjdk-loom-fibers/). > > Sample run: > > > $ time CONF=linux-x86_64-server-fastdebug make test TEST="hotspot_loom jdk_loom" > ... > ============================== > Test summary > ============================== > TEST TOTAL PASS FAIL ERROR > jtreg:test/hotspot/jtreg:hotspot_loom 63 63 0 0 > jtreg:test/jdk:jdk_loom 187 187 0 0 > ============================== > TEST SUCCESS > > Finished building target 'test' in configuration 'linux-x86_64-server-fastdebug' > > real 6m37.938s > user 54m13.043s > sys 2m12.437s Aleksey Shipilev has updated the pull request incrementally with one additional commit since the last revision: More reviews ------------- Changes: - all: https://git.openjdk.java.net/loom/pull/74/files - new: https://git.openjdk.java.net/loom/pull/74/files/b3ed47dc..4764f62d Webrevs: - full: https://webrevs.openjdk.java.net/?repo=loom&pr=74&range=02 - incr: https://webrevs.openjdk.java.net/?repo=loom&pr=74&range=01-02 Stats: 10 lines in 2 files changed: 2 ins; 4 del; 4 mod Patch: https://git.openjdk.java.net/loom/pull/74.diff Fetch: git fetch https://git.openjdk.java.net/loom pull/74/head:pull/74 PR: https://git.openjdk.java.net/loom/pull/74 From shade at openjdk.java.net Tue Oct 12 08:19:28 2021 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Tue, 12 Oct 2021 08:19:28 GMT Subject: RFR: Loom test groups for development/porting use [v2] In-Reply-To: <-b-GbNk9g36C-MhW_fZFR4uDVx8yZXgRa67whbhUcbA=.5870c35d-60d1-4944-9760-7a4875748f64@github.com> References: <-b-GbNk9g36C-MhW_fZFR4uDVx8yZXgRa67whbhUcbA=.5870c35d-60d1-4944-9760-7a4875748f64@github.com> Message-ID: On Tue, 12 Oct 2021 08:04:23 GMT, Alan Bateman wrote: >> Aleksey Shipilev has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit: >> >> Do separate test groups > > test/hotspot/jtreg/TEST.groups line 111: > >> 109: :tier1_loom \ >> 110: runtime/jni/IsVirtualThread \ >> 111: serviceability/dcmd/thread > > It would be okay to include these in tier1_loom_runtime and tier1_loom_serviceability as you had them. Fixed, see new commit. > test/jdk/TEST.groups line 105: > >> 103: java/util/concurrent/Future \ >> 104: jdk/internal/vm/Continuation \ >> 105: jdk/jfr/threading > > Probably better to run java/util/concurrent rater than specific directories, it will otherwise get unwieldy once the tests move to the right place. You can probably drop Throwable, it's not interesting to run have its tests in this test group. Not sure about the JFR threading tests, we've been using the jdk_jfr group for that. Fixed. I'd like to have JFR "thread" tests in this group to test thread events. ------------- PR: https://git.openjdk.java.net/loom/pull/74 From rpressler at openjdk.java.net Tue Oct 12 09:33:54 2021 From: rpressler at openjdk.java.net (Ron Pressler) Date: Tue, 12 Oct 2021 09:33:54 GMT Subject: RFR: Loom: PPC64, S390, ARM32, Zero stubs [v2] In-Reply-To: References: Message-ID: On Mon, 11 Oct 2021 16:34:54 GMT, Aleksey Shipilev wrote: >> This WIP provides enough stubs to make Loom cross-compilable to PPC64, S390, ARM32 and Zero. This should be enough to get the sense where the shared code actually platform-specific (referencing stuff from `frame` that is platform-specific), what should be implemented for a platform, and also should be enough to get GHA build checks green. Note current patch does not implement Loom on these platforms, but merely provides the absolute basic build capabilities. >> >> Note that ARM32 builds would not be clean until #65 is integrated with 32-bit cleanliness fixes. >> >> Additional testing: >> - [x] Linux x86_64 tier1_loom still passes >> - [x] Linux PPC64 cross-compilation >> - [x] Linux S390 cross-compilation >> - [x] Linux ARM32 cross-compilation >> - [x] Linux x86_64 Zero (Hotspot) compilation > > Aleksey Shipilev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision: > > - Merge branch 'fibers' into platform-stubs > - More whitespace > - Self-review fixes > - PPC64, S390, ARM32, Zero stubs Marked as reviewed by rpressler (Lead). Good to go. Thank you! ------------- PR: https://git.openjdk.java.net/loom/pull/72 From shade at openjdk.java.net Tue Oct 12 10:08:59 2021 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Tue, 12 Oct 2021 10:08:59 GMT Subject: RFR: Loom: PPC64, S390, ARM32, Zero stubs [v2] In-Reply-To: References: Message-ID: <2_BjnngmJvDVHMeyTSWFyIkMqrWCvS4vpTC78XSrMWE=.6571d062-a7f6-4192-a141-c49c3da6131f@github.com> On Mon, 11 Oct 2021 16:34:54 GMT, Aleksey Shipilev wrote: >> This WIP provides enough stubs to make Loom cross-compilable to PPC64, S390, ARM32 and Zero. This should be enough to get the sense where the shared code actually platform-specific (referencing stuff from `frame` that is platform-specific), what should be implemented for a platform, and also should be enough to get GHA build checks green. Note current patch does not implement Loom on these platforms, but merely provides the absolute basic build capabilities. >> >> Note that ARM32 builds would not be clean until #65 is integrated with 32-bit cleanliness fixes. >> >> Additional testing: >> - [x] Linux x86_64 tier1_loom still passes >> - [x] Linux PPC64 cross-compilation >> - [x] Linux S390 cross-compilation >> - [x] Linux ARM32 cross-compilation >> - [x] Linux x86_64 Zero (Hotspot) compilation > > Aleksey Shipilev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision: > > - Merge branch 'fibers' into platform-stubs > - More whitespace > - Self-review fixes > - PPC64, S390, ARM32, Zero stubs Cheers! ------------- PR: https://git.openjdk.java.net/loom/pull/72 From shade at openjdk.java.net Tue Oct 12 12:42:56 2021 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Tue, 12 Oct 2021 12:42:56 GMT Subject: Integrated: Loom: PPC64, S390, ARM32, Zero stubs In-Reply-To: References: Message-ID: On Tue, 5 Oct 2021 16:44:01 GMT, Aleksey Shipilev wrote: > This WIP provides enough stubs to make Loom cross-compilable to PPC64, S390, ARM32 and Zero. This should be enough to get the sense where the shared code actually platform-specific (referencing stuff from `frame` that is platform-specific), what should be implemented for a platform, and also should be enough to get GHA build checks green. Note current patch does not implement Loom on these platforms, but merely provides the absolute basic build capabilities. > > Note that ARM32 builds would not be clean until #65 is integrated with 32-bit cleanliness fixes. > > Additional testing: > - [x] Linux x86_64 tier1_loom still passes > - [x] Linux PPC64 cross-compilation > - [x] Linux S390 cross-compilation > - [x] Linux ARM32 cross-compilation > - [x] Linux x86_64 Zero (Hotspot) compilation This pull request has now been integrated. Changeset: 3a89cd5a Author: Aleksey Shipilev Committer: Ron Pressler URL: https://git.openjdk.java.net/loom/commit/3a89cd5a85acca136cc3329a9b11253280435bb4 Stats: 2286 lines in 49 files changed: 2203 ins; 33 del; 50 mod Loom: PPC64, S390, ARM32, Zero stubs Reviewed-by: rpressler ------------- PR: https://git.openjdk.java.net/loom/pull/72 From alanb at openjdk.java.net Tue Oct 12 13:18:56 2021 From: alanb at openjdk.java.net (Alan Bateman) Date: Tue, 12 Oct 2021 13:18:56 GMT Subject: RFR: Loom test groups for development/porting use [v3] In-Reply-To: References: Message-ID: <6K5oABmk0_BsQ0HMsQtJZ7gYmVb57jlAhdeepga49-o=.e862b47f-d6d2-41b7-b354-0a418688d9ee@github.com> On Tue, 12 Oct 2021 08:19:22 GMT, Aleksey Shipilev wrote: >> Porting/development work would be much simpler if we had a comprehensive test group with Loom-specific tests. There is `tier1_loom`, but it probably has a separate meaning. We can add some test groups with Loom-specific tests. I basically went and added tests that are added/substantially-modified by Loom, judging by a [recent webrev](https://builds.shipilev.net/patch-openjdk-loom-fibers/). >> >> Sample run: >> >> >> $ time CONF=linux-x86_64-server-fastdebug make test TEST="hotspot_loom jdk_loom" >> ... >> ============================== >> Test summary >> ============================== >> TEST TOTAL PASS FAIL ERROR >> jtreg:test/hotspot/jtreg:hotspot_loom 63 63 0 0 >> jtreg:test/jdk:jdk_loom 187 187 0 0 >> ============================== >> TEST SUCCESS >> >> Finished building target 'test' in configuration 'linux-x86_64-server-fastdebug' >> >> real 6m37.938s >> user 54m13.043s >> sys 2m12.437s > > Aleksey Shipilev has updated the pull request incrementally with one additional commit since the last revision: > > More reviews Marked as reviewed by alanb (Committer). ------------- PR: https://git.openjdk.java.net/loom/pull/74 From alanb at openjdk.java.net Tue Oct 12 13:18:57 2021 From: alanb at openjdk.java.net (Alan Bateman) Date: Tue, 12 Oct 2021 13:18:57 GMT Subject: RFR: Loom test groups for development/porting use [v2] In-Reply-To: References: <-b-GbNk9g36C-MhW_fZFR4uDVx8yZXgRa67whbhUcbA=.5870c35d-60d1-4944-9760-7a4875748f64@github.com> Message-ID: <4HPzDIqaxmbrkwvnUHetgMouymXeTtlhhwELQ1pp9A0=.d9df1000-c590-4bfd-bff2-51631339dc47@github.com> On Tue, 12 Oct 2021 08:14:31 GMT, Aleksey Shipilev wrote: >> test/jdk/TEST.groups line 105: >> >>> 103: java/util/concurrent/Future \ >>> 104: jdk/internal/vm/Continuation \ >>> 105: jdk/jfr/threading >> >> Probably better to run java/util/concurrent rater than specific directories, it will otherwise get unwieldy once the tests move to the right place. You can probably drop Throwable, it's not interesting to run have its tests in this test group. Not sure about the JFR threading tests, we've been using the jdk_jfr group for that. > > Fixed. I'd like to have JFR "thread" tests in this group to test thread events. There are also tests for the JFR events in jfr/event/runtime but they on the exclude list right now. We need to go back over these tests as they date from an initial set of events emitted from the VM. We've since changed to emit them from the Java code. They are exercised by Thread/virtual/JfrEvents.java, which will move at some point once the tests in that directory move to the right place. ------------- PR: https://git.openjdk.java.net/loom/pull/74 From alanb at openjdk.java.net Tue Oct 12 13:18:57 2021 From: alanb at openjdk.java.net (Alan Bateman) Date: Tue, 12 Oct 2021 13:18:57 GMT Subject: RFR: Loom test groups for development/porting use [v2] In-Reply-To: <4HPzDIqaxmbrkwvnUHetgMouymXeTtlhhwELQ1pp9A0=.d9df1000-c590-4bfd-bff2-51631339dc47@github.com> References: <-b-GbNk9g36C-MhW_fZFR4uDVx8yZXgRa67whbhUcbA=.5870c35d-60d1-4944-9760-7a4875748f64@github.com> <4HPzDIqaxmbrkwvnUHetgMouymXeTtlhhwELQ1pp9A0=.d9df1000-c590-4bfd-bff2-51631339dc47@github.com> Message-ID: On Tue, 12 Oct 2021 13:14:19 GMT, Alan Bateman wrote: >> Fixed. I'd like to have JFR "thread" tests in this group to test thread events. > > There are also tests for the JFR events in jfr/event/runtime but they on the exclude list right now. We need to go back over these tests as they date from an initial set of events emitted from the VM. We've since changed to emit them from the Java code. They are exercised by Thread/virtual/JfrEvents.java, which will move at some point once the tests in that directory move to the right place. When Leonid is back then we can see about sorting out our configuration and then we can see if jdk_loom can be renamed to have it be a temporary loom tier1 group. ------------- PR: https://git.openjdk.java.net/loom/pull/74 From shade at openjdk.java.net Tue Oct 12 13:18:57 2021 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Tue, 12 Oct 2021 13:18:57 GMT Subject: RFR: Loom test groups for development/porting use [v2] In-Reply-To: References: <-b-GbNk9g36C-MhW_fZFR4uDVx8yZXgRa67whbhUcbA=.5870c35d-60d1-4944-9760-7a4875748f64@github.com> <4HPzDIqaxmbrkwvnUHetgMouymXeTtlhhwELQ1pp9A0=.d9df1000-c590-4bfd-bff2-51631339dc47@github.com> Message-ID: On Tue, 12 Oct 2021 13:15:19 GMT, Alan Bateman wrote: >> There are also tests for the JFR events in jfr/event/runtime but they on the exclude list right now. We need to go back over these tests as they date from an initial set of events emitted from the VM. We've since changed to emit them from the Java code. They are exercised by Thread/virtual/JfrEvents.java, which will move at some point once the tests in that directory move to the right place. > > When Leonid is back then we can see about sorting out our configuration and then we can see if jdk_loom can be renamed to have it be a temporary loom tier1 group. All right, sounds good. ------------- PR: https://git.openjdk.java.net/loom/pull/74 From shade at openjdk.java.net Tue Oct 12 15:23:03 2021 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Tue, 12 Oct 2021 15:23:03 GMT Subject: Integrated: Loom test groups for development/porting use In-Reply-To: References: Message-ID: On Mon, 11 Oct 2021 15:50:02 GMT, Aleksey Shipilev wrote: > Porting/development work would be much simpler if we had a comprehensive test group with Loom-specific tests. There is `tier1_loom`, but it probably has a separate meaning. We can add some test groups with Loom-specific tests. I basically went and added tests that are added/substantially-modified by Loom, judging by a [recent webrev](https://builds.shipilev.net/patch-openjdk-loom-fibers/). > > Sample run: > > > $ time CONF=linux-x86_64-server-fastdebug make test TEST="hotspot_loom jdk_loom" > ... > ============================== > Test summary > ============================== > TEST TOTAL PASS FAIL ERROR > jtreg:test/hotspot/jtreg:hotspot_loom 63 63 0 0 > jtreg:test/jdk:jdk_loom 187 187 0 0 > ============================== > TEST SUCCESS > > Finished building target 'test' in configuration 'linux-x86_64-server-fastdebug' > > real 6m37.938s > user 54m13.043s > sys 2m12.437s This pull request has now been integrated. Changeset: e470f967 Author: Aleksey Shipilev Committer: Alan Bateman URL: https://git.openjdk.java.net/loom/commit/e470f96787332f6cc353a57a39e17841c68714fd Stats: 17 lines in 2 files changed: 15 ins; 0 del; 2 mod Loom test groups for development/porting use Reviewed-by: alanb ------------- PR: https://git.openjdk.java.net/loom/pull/74 From duke at openjdk.java.net Wed Oct 13 17:24:23 2021 From: duke at openjdk.java.net (duke) Date: Wed, 13 Oct 2021 17:24:23 GMT Subject: git: openjdk/loom: fibers: 3 new changesets Message-ID: <114a77ad-2895-4669-b605-9aa7e14daae3@openjdk.java.net> Changeset: 7e20fe30 Author: Alan Bateman Date: 2021-10-11 16:55:04 +0000 URL: https://git.openjdk.java.net/loom/commit/7e20fe30c25f18efeaea56e39e061937c73d5589 Improve javadoc ! src/java.base/share/classes/java/net/DatagramSocket.java Changeset: 962f629b Author: Alan Bateman Date: 2021-10-12 19:14:04 +0000 URL: https://git.openjdk.java.net/loom/commit/962f629b0da263fc52135145fd3cab0780295643 Don't signal worker when queue in empty for limited cases ! src/java.base/share/classes/java/lang/System.java ! src/java.base/share/classes/java/lang/VirtualThread.java ! src/java.base/share/classes/java/util/concurrent/ForkJoinPool.java ! src/java.base/share/classes/jdk/internal/access/JavaLangAccess.java ! src/java.base/share/classes/jdk/internal/misc/VirtualThreads.java ! src/java.base/share/classes/sun/nio/ch/Poller.java Changeset: 51419e70 Author: Alan Bateman Date: 2021-10-13 10:22:02 +0000 URL: https://git.openjdk.java.net/loom/commit/51419e70f322a00de65cceb66be8447958e7d938 Remove commeneted excludes and other sync up of exclude lists ! test/hotspot/jtreg/ProblemList.txt ! test/jdk/ProblemList-vthread.txt From duke at openjdk.java.net Thu Oct 14 04:38:26 2021 From: duke at openjdk.java.net (duke) Date: Thu, 14 Oct 2021 04:38:26 GMT Subject: git: openjdk/loom: fibers: fixed rooot cause of SuspendResume2 and SuspendResumeAll test failures Message-ID: <66a49d5a-bb08-4435-8c22-26d51320e836@openjdk.java.net> Changeset: 310bfc46 Author: Serguei Spitsyn Date: 2021-10-14 04:37:11 +0000 URL: https://git.openjdk.java.net/loom/commit/310bfc46bc52770760efeb02d773074819e6cd74 fixed rooot cause of SuspendResume2 and SuspendResumeAll test failures ! src/hotspot/share/prims/jvm.cpp ! src/hotspot/share/prims/jvmtiEnvBase.cpp ! test/hotspot/jtreg/ProblemList-vthread.txt From shade at openjdk.java.net Thu Oct 14 13:43:23 2021 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Thu, 14 Oct 2021 13:43:23 GMT Subject: RFR: Fix non-supported platforms release builds Message-ID: <4ALToKK5nTNr6xX3Z4TqAL_N5y81Iv8ppuVywnQFZH0=.8f7217be-605a-4a63-8555-8880356cdc4f@github.com> It seems when doing #72, I missed a spot that makes release builds fail for non-supported platforms. I am not sure why fastdebug passes, but oh well. The fix is to platform-ifdef the offending block, like we do in other places. Additional testing: - [x] Linux x86_64 Zero release builds now - [ ] Linux x86_64 Server fastdebug/release pass `jdk_loom hotspot_loom` ------------- Commit messages: - Fix non-supported platforms release builds Changes: https://git.openjdk.java.net/loom/pull/75/files Webrev: https://webrevs.openjdk.java.net/?repo=loom&pr=75&range=00 Stats: 5 lines in 1 file changed: 5 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/loom/pull/75.diff Fetch: git fetch https://git.openjdk.java.net/loom pull/75/head:pull/75 PR: https://git.openjdk.java.net/loom/pull/75 From shade at openjdk.java.net Thu Oct 14 14:15:09 2021 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Thu, 14 Oct 2021 14:15:09 GMT Subject: RFR: Remove -XX:ContPerfTest Message-ID: When porting to x86_32, I noticed there is a diagnostic `ContPerfTest` option which effectively takes different paths, depending on diagnostic setting. Is it still useful? For a cleanup/preparation-for-upstreaming, I propose we roll it back. Additional testing: - [x] Linux x86_64 fastdebug `jdk_loom hotspot_loom` ------------- Commit messages: - Fix Changes: https://git.openjdk.java.net/loom/pull/76/files Webrev: https://webrevs.openjdk.java.net/?repo=loom&pr=76&range=00 Stats: 22 lines in 2 files changed: 0 ins; 11 del; 11 mod Patch: https://git.openjdk.java.net/loom/pull/76.diff Fetch: git fetch https://git.openjdk.java.net/loom pull/76/head:pull/76 PR: https://git.openjdk.java.net/loom/pull/76 From rpressler at openjdk.java.net Thu Oct 14 14:25:55 2021 From: rpressler at openjdk.java.net (Ron Pressler) Date: Thu, 14 Oct 2021 14:25:55 GMT Subject: RFR: Fix non-supported platforms release builds In-Reply-To: <4ALToKK5nTNr6xX3Z4TqAL_N5y81Iv8ppuVywnQFZH0=.8f7217be-605a-4a63-8555-8880356cdc4f@github.com> References: <4ALToKK5nTNr6xX3Z4TqAL_N5y81Iv8ppuVywnQFZH0=.8f7217be-605a-4a63-8555-8880356cdc4f@github.com> Message-ID: On Thu, 14 Oct 2021 13:36:45 GMT, Aleksey Shipilev wrote: > It seems when doing #72, I missed a spot that makes release builds fail for non-supported platforms. I am not sure why fastdebug passes, but oh well. The fix is to platform-ifdef the offending block, like we do in other places. > > Additional testing: > - [x] Linux x86_64 Zero release builds now > - [x] Linux x86_64 Server fastdebug/release pass `jdk_loom hotspot_loom` Marked as reviewed by rpressler (Lead). ------------- PR: https://git.openjdk.java.net/loom/pull/75 From shade at openjdk.java.net Thu Oct 14 14:25:55 2021 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Thu, 14 Oct 2021 14:25:55 GMT Subject: RFR: Fix non-supported platforms release builds In-Reply-To: <4ALToKK5nTNr6xX3Z4TqAL_N5y81Iv8ppuVywnQFZH0=.8f7217be-605a-4a63-8555-8880356cdc4f@github.com> References: <4ALToKK5nTNr6xX3Z4TqAL_N5y81Iv8ppuVywnQFZH0=.8f7217be-605a-4a63-8555-8880356cdc4f@github.com> Message-ID: On Thu, 14 Oct 2021 13:36:45 GMT, Aleksey Shipilev wrote: > It seems when doing #72, I missed a spot that makes release builds fail for non-supported platforms. I am not sure why fastdebug passes, but oh well. The fix is to platform-ifdef the offending block, like we do in other places. > > Additional testing: > - [x] Linux x86_64 Zero release builds now > - [x] Linux x86_64 Server fastdebug/release pass `jdk_loom hotspot_loom` Thanks! ------------- PR: https://git.openjdk.java.net/loom/pull/75 From shade at openjdk.java.net Thu Oct 14 14:35:19 2021 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Thu, 14 Oct 2021 14:35:19 GMT Subject: RFR: Drop x86_32 code from x86_64-specific files Message-ID: There are instances of x86_32 code in x86_64-specific files. That code would not be ever used and thus would bit rot, as it would never be compiled on x86_32. The porting to x86_32 would make the x86_32-specific versions of the StubGenerator. This simplifies x86_64 StubGenerator a bit. Additional testing: - [x] Linux x86_64 fastdebug `jdk_loom hotspot_loom` ------------- Commit messages: - Reinstate r15_thread reinitialization - Drop x86_32 code from x86_64-specific files Changes: https://git.openjdk.java.net/loom/pull/77/files Webrev: https://webrevs.openjdk.java.net/?repo=loom&pr=77&range=00 Stats: 32 lines in 1 file changed: 0 ins; 16 del; 16 mod Patch: https://git.openjdk.java.net/loom/pull/77.diff Fetch: git fetch https://git.openjdk.java.net/loom pull/77/head:pull/77 PR: https://git.openjdk.java.net/loom/pull/77 From shade at openjdk.java.net Thu Oct 14 15:05:57 2021 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Thu, 14 Oct 2021 15:05:57 GMT Subject: Integrated: Fix non-supported platforms release builds In-Reply-To: <4ALToKK5nTNr6xX3Z4TqAL_N5y81Iv8ppuVywnQFZH0=.8f7217be-605a-4a63-8555-8880356cdc4f@github.com> References: <4ALToKK5nTNr6xX3Z4TqAL_N5y81Iv8ppuVywnQFZH0=.8f7217be-605a-4a63-8555-8880356cdc4f@github.com> Message-ID: On Thu, 14 Oct 2021 13:36:45 GMT, Aleksey Shipilev wrote: > It seems when doing #72, I missed a spot that makes release builds fail for non-supported platforms. I am not sure why fastdebug passes, but oh well. The fix is to platform-ifdef the offending block, like we do in other places. > > Additional testing: > - [x] Linux x86_64 Zero release builds now > - [x] Linux x86_64 Server fastdebug/release pass `jdk_loom hotspot_loom` This pull request has now been integrated. Changeset: 5b1a3a61 Author: Aleksey Shipilev Committer: Ron Pressler URL: https://git.openjdk.java.net/loom/commit/5b1a3a61071ea4e651acb7d113f37a6c3ff45094 Stats: 5 lines in 1 file changed: 5 ins; 0 del; 0 mod Fix non-supported platforms release builds Reviewed-by: rpressler ------------- PR: https://git.openjdk.java.net/loom/pull/75 From rpressler at openjdk.java.net Thu Oct 14 15:15:54 2021 From: rpressler at openjdk.java.net (Ron Pressler) Date: Thu, 14 Oct 2021 15:15:54 GMT Subject: RFR: Remove -XX:ContPerfTest In-Reply-To: References: Message-ID: <26_6wxZ9oZvO1c_AfOxPpshq-gid2PxXjlhAKaWhCvM=.b9868683-f149-4161-bc22-62dfa009f183@github.com> On Thu, 14 Oct 2021 14:09:46 GMT, Aleksey Shipilev wrote: > When porting to x86_32, I noticed there is a diagnostic `ContPerfTest` option which effectively takes different paths, depending on diagnostic setting. Is it still useful? For a cleanup/preparation-for-upstreaming, I propose we roll it back. > > Additional testing: > - [x] Linux x86_64 fastdebug `jdk_loom hotspot_loom` I intend to remove it at a later date, of course prior to upstreaming. ------------- PR: https://git.openjdk.java.net/loom/pull/76 From duke at openjdk.java.net Thu Oct 14 15:27:10 2021 From: duke at openjdk.java.net (duke) Date: Thu, 14 Oct 2021 15:27:10 GMT Subject: git: openjdk/loom: fibers: minor tweak in VThreadMonitorTest to avoid a JNI IsSameObject assert Message-ID: Changeset: d54d1604 Author: Serguei Spitsyn Date: 2021-10-14 15:25:18 +0000 URL: https://git.openjdk.java.net/loom/commit/d54d16048c67ff0e467462f2fd989c1ea84c13c4 minor tweak in VThreadMonitorTest to avoid a JNI IsSameObject assert ! test/hotspot/jtreg/serviceability/jvmti/vthread/VThreadMonitorTest/libVThreadMonitorTest.cpp From shade at openjdk.java.net Thu Oct 14 15:29:08 2021 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Thu, 14 Oct 2021 15:29:08 GMT Subject: RFR: Harmonize actual and expected signature of Continuation.doYield Message-ID: Found this inconsistency when reading the Loom code during x86_32 porting. `Continuation.doYield` has an `int` argument, yet C2's `OptoRuntime::continuation_doYield_Type` does not declare it. I think this is basically asking for trouble in C2, as the optimizations may ask the function type, discover there is an input of type `int`, but no such input is actually present. Runtime stubs seem to be also oblivious there is an argument, and calling conventions probably put it in the register on x86_64 and AArch64. On other arches, that might not be true. I don't believe it breaks anything now, but let's fix it, while we are at it. It looks to me that `Continuation.doYield` is ever called with `0`, so we might just drop its `int` argument? Not sure if `scopes` is something Java code plans to use. Additional testing: - [x] Linux x86_64 fastdebug, `jdk_loom hotspot_loom` ------------- Commit messages: - Fix Changes: https://git.openjdk.java.net/loom/pull/78/files Webrev: https://webrevs.openjdk.java.net/?repo=loom&pr=78&range=00 Stats: 12 lines in 5 files changed: 2 ins; 4 del; 6 mod Patch: https://git.openjdk.java.net/loom/pull/78.diff Fetch: git fetch https://git.openjdk.java.net/loom pull/78/head:pull/78 PR: https://git.openjdk.java.net/loom/pull/78 From rpressler at openjdk.java.net Thu Oct 14 16:12:57 2021 From: rpressler at openjdk.java.net (Ron Pressler) Date: Thu, 14 Oct 2021 16:12:57 GMT Subject: RFR: Harmonize actual and expected signature of Continuation.doYield In-Reply-To: References: Message-ID: On Thu, 14 Oct 2021 15:23:17 GMT, Aleksey Shipilev wrote: > Found this inconsistency when reading the Loom code during x86_32 porting. `Continuation.doYield` has an `int` argument, yet C2's `OptoRuntime::continuation_doYield_Type` does not declare it. I think this is basically asking for trouble in C2, as the optimizations may ask the function type, discover there is an input of type `int`, but no such input is actually present. Runtime stubs seem to be also oblivious there is an argument, and calling conventions probably put it in the register on x86_64 and AArch64. On other arches, that might not be true. > > I don't believe it breaks anything now, but let's fix it, while we are at it. It looks to me that `Continuation.doYield` is ever called with `0`, so we might just drop its `int` argument? Not sure if `scopes` is something Java code plans to use. > > Additional testing: > - [x] Linux x86_64 fastdebug, `jdk_loom hotspot_loom` Marked as reviewed by rpressler (Lead). Yeah, a vestige of older prototypes. Might as well clean this up now. ------------- PR: https://git.openjdk.java.net/loom/pull/78 From shade at openjdk.java.net Fri Oct 15 06:24:59 2021 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Fri, 15 Oct 2021 06:24:59 GMT Subject: RFR: Harmonize actual and expected signature of Continuation.doYield In-Reply-To: References: Message-ID: On Thu, 14 Oct 2021 15:23:17 GMT, Aleksey Shipilev wrote: > Found this inconsistency when reading the Loom code during x86_32 porting. `Continuation.doYield` has an `int` argument, yet C2's `OptoRuntime::continuation_doYield_Type` does not declare it. I think this is basically asking for trouble in C2, as the optimizations may ask the function type, discover there is an input of type `int`, but no such input is actually present. Runtime stubs seem to be also oblivious there is an argument, and calling conventions probably put it in the register on x86_64 and AArch64. On other arches, that might not be true. > > I don't believe it breaks anything now, but let's fix it, while we are at it. It looks to me that `Continuation.doYield` is ever called with `0`, so we might just drop its `int` argument? Not sure if `scopes` is something Java code plans to use. > > Additional testing: > - [x] Linux x86_64 fastdebug, `jdk_loom hotspot_loom` Cheers. ------------- PR: https://git.openjdk.java.net/loom/pull/78 From shade at openjdk.java.net Fri Oct 15 11:25:11 2021 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Fri, 15 Oct 2021 11:25:11 GMT Subject: RFR: Remove -XX:ContPerfTest In-Reply-To: <26_6wxZ9oZvO1c_AfOxPpshq-gid2PxXjlhAKaWhCvM=.b9868683-f149-4161-bc22-62dfa009f183@github.com> References: <26_6wxZ9oZvO1c_AfOxPpshq-gid2PxXjlhAKaWhCvM=.b9868683-f149-4161-bc22-62dfa009f183@github.com> Message-ID: On Thu, 14 Oct 2021 15:13:12 GMT, Ron Pressler wrote: > I intend to remove it at a later date, of course prior to upstreaming. All right, you want me to close this PR, or leave it hanging until we decide to integrate it? ------------- PR: https://git.openjdk.java.net/loom/pull/76 From duke at openjdk.java.net Fri Oct 15 14:21:55 2021 From: duke at openjdk.java.net (duke) Date: Fri, 15 Oct 2021 14:21:55 GMT Subject: git: openjdk/loom: fibers: 169 new changesets Message-ID: <48afe312-c478-4e7f-bc79-92c7629b5540@openjdk.java.net> Changeset: 980c50dc Author: Roland Westrelin Date: 2021-09-29 14:51:33 +0000 URL: https://git.openjdk.java.net/loom/commit/980c50dc607e60e12879bd6fb7ff4034469e88d8 8272562: C2: assert(false) failed: Bad graph detected in build_loop_late Reviewed-by: chagedorn, kvn ! src/hotspot/share/opto/loopopts.cpp + test/hotspot/jtreg/compiler/loopopts/TestSunkCastOnUnreachablePath.java Changeset: edd9d1c9 Author: Weijun Wang Date: 2021-09-29 15:37:16 +0000 URL: https://git.openjdk.java.net/loom/commit/edd9d1c97b7fb50e76abc05d298c9d55db39cc1b 8274330: Incorrect encoding of the DistributionPointName object in IssuingDistributionPointExtension Reviewed-by: ascarpino ! src/java.base/share/classes/sun/security/x509/IssuingDistributionPointExtension.java + test/jdk/sun/security/x509/Extensions/IssuingDistributionPointExtensionEncoding.java Changeset: b1b66965 Author: Aleksey Shipilev Date: 2021-09-29 16:57:40 +0000 URL: https://git.openjdk.java.net/loom/commit/b1b66965f1ec6eae547cc4f70f8271bd39ded6da 8274453: (sctp) com/sun/nio/sctp/SctpChannel/CloseDescriptors.java test should be resilient to lsof warnings Reviewed-by: dfuchs ! test/jdk/com/sun/nio/sctp/SctpChannel/CloseDescriptors.java Changeset: 97b28742 Author: Pavel Rappo Date: 2021-09-29 17:09:08 +0000 URL: https://git.openjdk.java.net/loom/commit/97b28742b4d3083cadbe4dc10b625ec9fb944353 8274509: Remove stray * and stylistic . from doc comments Reviewed-by: alanb, dfuchs, lancea, iris, bpb ! src/java.base/share/classes/java/nio/file/Files.java ! src/java.base/share/classes/java/nio/file/Path.java Changeset: 79cebe2c Author: Andrey Turbanov Committer: Valerie Peng Date: 2021-09-29 18:22:40 +0000 URL: https://git.openjdk.java.net/loom/commit/79cebe2c1b1e7f43377633b62c970528cac0a786 8274050: Unnecessary Vector usage in javax.crypto Reviewed-by: valeriep ! src/java.base/share/classes/javax/crypto/CryptoPermissions.java ! src/java.base/share/classes/javax/crypto/CryptoPolicyParser.java Changeset: 97385d4f Author: Joe Darcy Date: 2021-09-29 23:02:20 +0000 URL: https://git.openjdk.java.net/loom/commit/97385d4f166fbd63a7c91d2ee28b5ed75cb02518 8274405: Suppress warnings on non-serializable non-transient instance fields in javac and javadoc Reviewed-by: prappo, jjg ! src/jdk.compiler/share/classes/com/sun/source/util/DocTreePath.java ! src/jdk.compiler/share/classes/com/sun/source/util/TreePath.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/tree/TreeInfo.java ! src/jdk.compiler/share/classes/com/sun/tools/sjavac/pubapi/PubApi.java ! src/jdk.compiler/share/classes/com/sun/tools/sjavac/pubapi/PubApiTypeParam.java ! src/jdk.compiler/share/classes/com/sun/tools/sjavac/pubapi/PubMethod.java ! src/jdk.compiler/share/classes/com/sun/tools/sjavac/pubapi/PubType.java ! src/jdk.compiler/share/classes/com/sun/tools/sjavac/pubapi/PubVar.java ! src/jdk.compiler/share/classes/com/sun/tools/sjavac/server/CompilationSubResult.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/util/DocFileIOException.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/util/ResourceIOException.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/tool/OptionException.java Changeset: 355356c4 Author: Andrey Turbanov Committer: Naoto Sato Date: 2021-09-29 23:08:23 +0000 URL: https://git.openjdk.java.net/loom/commit/355356c405adb9287b786b0b045c2eb974d2ffca 8273435: Remove redundant zero-length check in ClassDesc.of Reviewed-by: rriggs ! src/java.base/share/classes/java/lang/constant/ClassDesc.java Changeset: f8415a9b Author: Aleksey Shipilev Date: 2021-09-30 06:54:13 +0000 URL: https://git.openjdk.java.net/loom/commit/f8415a9b2f610ed431e6948c8174f6d982e5b31f 8274523: java/lang/management/MemoryMXBean/MemoryTest.java test should handle Shenandoah Reviewed-by: mchung, cjplummer ! test/jdk/java/lang/management/MemoryMXBean/MemoryTest.java Changeset: c0533ef2 Author: Aleksey Shipilev Date: 2021-09-30 06:55:24 +0000 URL: https://git.openjdk.java.net/loom/commit/c0533ef2d8e526aaec0eebe862f4bbefc159ea37 8274522: java/lang/management/ManagementFactory/MXBeanException.java test fails with Shenandoah Reviewed-by: alanb, mchung ! test/jdk/java/lang/management/ManagementFactory/MXBeanException.java Changeset: dfc557cb Author: Christian Hagedorn Date: 2021-09-30 08:29:43 +0000 URL: https://git.openjdk.java.net/loom/commit/dfc557cbea342b2991f9d129235470ac789b50a2 8274406: RunThese30M.java failed "assert(!LCA_orig->dominates(pred_block) || early->dominates(pred_block)) failed: early is high enough" Reviewed-by: kvn, thartmann ! src/hotspot/share/opto/loopopts.cpp ! test/hotspot/jtreg/compiler/loopopts/TestSinkingDivisorLostPin.java Changeset: a8210c53 Author: Martin Doerr Date: 2021-09-30 08:41:03 +0000 URL: https://git.openjdk.java.net/loom/commit/a8210c53e7af1cb558251fcb420de1b8a5461b25 8274401: C2: GraphKit::load_array_element bypasses Access API Reviewed-by: kvn, goetz, thartmann ! src/hotspot/share/opto/graphKit.cpp ! src/hotspot/share/opto/graphKit.hpp ! src/hotspot/share/opto/library_call.cpp ! src/hotspot/share/opto/stringopts.cpp Changeset: 94e31e5c Author: Severin Gehwolf Date: 2021-09-30 08:53:31 +0000 URL: https://git.openjdk.java.net/loom/commit/94e31e5ca51d1c4c253cf7ac5acd950d10c22267 8274506: TestPids.java and TestPidsLimit.java fail with podman run as root Reviewed-by: mbaesken, cjplummer ! test/hotspot/jtreg/containers/docker/TestPids.java ! test/jdk/jdk/internal/platform/docker/TestPidsLimit.java Changeset: 2f955d6f Author: Mahendra Chhipa Committer: Michael McMahon Date: 2021-09-30 11:29:20 +0000 URL: https://git.openjdk.java.net/loom/commit/2f955d6f5ba15fc2c06eaf683d1ffa3ade97521b 8273142: Remove dependancy of TestHttpServer, HttpTransaction, HttpCallback from open/test/jdk/sun/net/www/protocol/http/ tests Reviewed-by: michaelm ! test/jdk/sun/net/www/protocol/http/B6296310.java ! test/jdk/sun/net/www/protocol/http/RelativeRedirect.java ! test/jdk/sun/net/www/protocol/http/ResponseCacheStream.java ! test/jdk/sun/net/www/protocol/http/SetChunkedStreamingMode.java Changeset: bb95dda0 Author: Masanori Yano Committer: Hannes Walln?fer Date: 2021-09-30 11:33:21 +0000 URL: https://git.openjdk.java.net/loom/commit/bb95dda0ac5032e4df582f2903dcbbbbaef9e8c4 8248001: javadoc generates invalid HTML pages whose ftp:// links are broken Reviewed-by: hannesw ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/HtmlDocletWriter.java ! test/langtools/jdk/javadoc/doclet/testHrefInDocComment/TestHrefInDocComment.java + test/langtools/jdk/javadoc/doclet/testHrefInDocComment/pkg/J1.java Changeset: bfd61634 Author: Lin Zang Date: 2021-09-30 14:44:59 +0000 URL: https://git.openjdk.java.net/loom/commit/bfd616347126a802c641326a6be5a14c4cd7af90 8274196: Crashes in VM_HeapDumper::work after JDK-8252842 8274245: sun/tools/jmap/BasicJMapTest.java Mutex rank failures Reviewed-by: coleenp, pliden, cjplummer ! src/hotspot/share/services/heapDumper.cpp ! test/hotspot/jtreg/ProblemList-zgc.txt ! test/jdk/ProblemList.txt Changeset: 3e0d7c33 Author: Alex Kasko Committer: Severin Gehwolf Date: 2021-09-30 15:21:18 +0000 URL: https://git.openjdk.java.net/loom/commit/3e0d7c33d41a93496bfa6a47d1508e415930adf9 8270290: NTLM authentication fails if HEAD request is used Reviewed-by: dfuchs, michaelm ! src/java.base/share/classes/sun/net/www/protocol/http/HttpURLConnection.java + test/jdk/sun/net/www/protocol/http/NTLMHeadTest.java Changeset: 9180d9a2 Author: Severin Gehwolf Date: 2021-09-30 15:23:44 +0000 URL: https://git.openjdk.java.net/loom/commit/9180d9a2f990e71ca6ac9c14e55a21f7372929ac 8273216: JCMD does not work across container boundaries with Podman Reviewed-by: mseledtsov, hseigel ! test/hotspot/jtreg/containers/docker/TestJcmd.java Changeset: c57ed22e Author: Bradford Wetmore Date: 2021-09-30 15:46:29 +0000 URL: https://git.openjdk.java.net/loom/commit/c57ed22e779e7efc8ff7f3c7ec08ce2cb1a738cb 8274528: Add comment to explain an HKDF optimization in SSLSecretDerivation Reviewed-by: jnimeh ! src/java.base/share/classes/sun/security/ssl/SSLSecretDerivation.java Changeset: f08180f3 Author: Erik ?sterlund Date: 2021-09-30 15:52:36 +0000 URL: https://git.openjdk.java.net/loom/commit/f08180f35f18263e33d96b6d1f06e5129328f01a 8274501: c2i entry barriers read int as long on AArch64 Reviewed-by: shade, kbarrett, aph ! src/hotspot/cpu/aarch64/gc/shared/barrierSetAssembler_aarch64.cpp Changeset: 95730229 Author: Patricio Chilano Mateo Date: 2021-09-30 16:02:14 +0000 URL: https://git.openjdk.java.net/loom/commit/9573022978bfeff55b51fa6f30027f59a0783d31 8253197: vmTestbase/nsk/jvmti/StopThread/stopthrd007/TestDescription.java fails with "ERROR: DebuggeeSleepingThread: ThreadDeath lost" Reviewed-by: dholmes, cjplummer, sspitsyn ! test/hotspot/jtreg/vmTestbase/nsk/jvmti/StopThread/stopthrd007.java Changeset: 8215b2eb Author: Joe Darcy Date: 2021-09-30 16:58:53 +0000 URL: https://git.openjdk.java.net/loom/commit/8215b2eb61bd89c4041420e1c5c673603d6b2119 8274398: Suppress more warnings on non-serializable non-transient instance fields in management libs Reviewed-by: sspitsyn ! src/java.management/share/classes/javax/management/loading/MLet.java ! src/jdk.jdi/share/classes/com/sun/tools/jdi/ConnectorImpl.java ! src/jdk.jdi/share/classes/com/sun/tools/jdi/EventSetImpl.java ! src/jdk.jdi/share/classes/com/sun/tools/jdi/VMAction.java ! src/jdk.management.agent/share/classes/sun/management/jmxremote/SingleEntryRegistry.java ! src/jdk.management/share/classes/com/sun/management/internal/GarbageCollectionNotifInfoCompositeData.java ! src/jdk.management/share/classes/com/sun/management/internal/GcInfoCompositeData.java ! src/jdk.management/share/classes/com/sun/management/internal/VMOptionCompositeData.java Changeset: 73264811 Author: Joe Darcy Date: 2021-09-30 17:39:05 +0000 URL: https://git.openjdk.java.net/loom/commit/7326481143c1321700cbf2caa9e068c5077e22c4 8274393: Suppress more warnings on non-serializable non-transient instance fields in security libs Reviewed-by: weijun ! src/java.base/share/classes/com/sun/crypto/provider/PBKDF2KeyImpl.java ! src/java.xml.crypto/share/classes/com/sun/org/apache/xml/internal/security/signature/MissingResourceFailureException.java ! src/java.xml.crypto/share/classes/javax/xml/crypto/URIReferenceException.java ! src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/P11Key.java ! src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/SunPKCS11.java ! src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/Token.java ! src/jdk.crypto.ec/share/classes/sun/security/ec/ECPrivateKeyImpl.java ! src/jdk.crypto.ec/share/classes/sun/security/ec/ECPublicKeyImpl.java ! src/jdk.crypto.ec/share/classes/sun/security/ec/XDHPrivateKeyImpl.java ! src/jdk.crypto.ec/share/classes/sun/security/ec/XDHPublicKeyImpl.java ! src/jdk.crypto.ec/share/classes/sun/security/ec/ed/EdDSAPrivateKeyImpl.java ! src/jdk.crypto.ec/share/classes/sun/security/ec/ed/EdDSAPublicKeyImpl.java Changeset: a8edd1b3 Author: Jie Fu Date: 2021-09-30 23:11:56 +0000 URL: https://git.openjdk.java.net/loom/commit/a8edd1b360d4e5f35aff371a91fda42eeb00d395 8274527: Minimal VM build fails after JDK-8273459 Reviewed-by: kvn ! src/hotspot/cpu/x86/macroAssembler_x86.cpp ! src/hotspot/cpu/x86/macroAssembler_x86.hpp ! src/hotspot/cpu/x86/macroAssembler_x86_adler.cpp ! src/hotspot/cpu/x86/stubGenerator_x86_64.cpp Changeset: 2e690ba8 Author: Kim Barrett Date: 2021-10-01 00:25:35 +0000 URL: https://git.openjdk.java.net/loom/commit/2e690ba8bda30902f1188cabad63fb60f4eb828f 8274322: Problems with oopDesc construction Reviewed-by: dholmes, stefank ! src/hotspot/share/oops/instanceOop.hpp ! src/hotspot/share/oops/markWord.hpp ! src/hotspot/share/oops/objArrayOop.hpp ! src/hotspot/share/oops/oop.hpp ! src/hotspot/share/oops/typeArrayOop.hpp Changeset: 5e4b514e Author: Martin Doerr Date: 2021-10-01 08:20:51 +0000 URL: https://git.openjdk.java.net/loom/commit/5e4b514e6e7e1b9f51fac1983b6c12a988f7f5a8 8274550: c2i entry barriers read int as long on PPC Reviewed-by: eosterlund, shade ! src/hotspot/cpu/ppc/gc/shared/barrierSetAssembler_ppc.cpp Changeset: b7b78ff1 Author: Ao Qi Committer: Jie Fu Date: 2021-10-01 08:52:04 +0000 URL: https://git.openjdk.java.net/loom/commit/b7b78ff1f380d19214dbca48455772bc87cc137d 8274561: sun/net/ftp/TestFtpTimeValue.java timed out on slow machines Reviewed-by: jiefu, dfuchs ! test/jdk/sun/net/ftp/TestFtpTimeValue.java Changeset: 18870284 Author: Jan Lahoda Date: 2021-10-01 08:53:04 +0000 URL: https://git.openjdk.java.net/loom/commit/18870284084aaaf729640de0105ce21e253546b9 8269113: Javac throws when compiling switch (null) Co-authored-by: Guoxiong Li Reviewed-by: vromero ! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/TransPatterns.java ! test/langtools/tools/javac/patterns/SwitchErrors.java ! test/langtools/tools/javac/patterns/SwitchErrors.out ! test/langtools/tools/javac/patterns/Switches.java Changeset: 292d7bb1 Author: Jan Lahoda Date: 2021-10-01 08:54:18 +0000 URL: https://git.openjdk.java.net/loom/commit/292d7bb1d5d311b517b2cd6d0f6dc77e35b3f649 8274363: Transitively sealed classes not considered exhaustive in switches Reviewed-by: vromero ! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Flow.java ! test/langtools/tools/javac/patterns/Exhaustiveness.java Changeset: cc14c6f0 Author: Aleksei Efimov Date: 2021-10-01 09:48:09 +0000 URL: https://git.openjdk.java.net/loom/commit/cc14c6f076356731f78aea4e890027f4e2a91642 8274227: Remove "impl.prefix" jdk system property usage from InetAddress Reviewed-by: alanb, dfuchs ! src/java.base/share/classes/java/net/Inet4AddressImpl.java ! src/java.base/share/classes/java/net/Inet6AddressImpl.java ! src/java.base/share/classes/java/net/InetAddress.java ! src/java.base/share/classes/java/net/InetAddressImpl.java Changeset: c05dc268 Author: Ekaterina Vergizova Committer: Yuri Nesterenko Date: 2021-10-01 12:53:08 +0000 URL: https://git.openjdk.java.net/loom/commit/c05dc268acaf87236f30cf700ea3ac778e3b20e5 8274435: EXCEPTION_ACCESS_VIOLATION in BFSClosure::closure_impl Reviewed-by: stefank ! src/hotspot/share/jfr/leakprofiler/chains/bitset.cpp Changeset: 3d7671b6 Author: Brian Burkhalter Date: 2021-10-01 15:30:55 +0000 URL: https://git.openjdk.java.net/loom/commit/3d7671b65e8491f3b1fcac8b96401401f783c9f4 8274562: (fs) UserDefinedFileAttributeView doesn't correctly determine if supported when using OverlayFS Reviewed-by: alanb ! src/java.base/unix/native/libnio/fs/UnixNativeDispatcher.c Changeset: 05d38604 Author: Pavel Rappo Date: 2021-10-01 16:15:48 +0000 URL: https://git.openjdk.java.net/loom/commit/05d38604a2c620dcaf8682f02dae2fddab8e0c0b 8274605: Fix predicate guarantees on returned values in (Doc)SourcePositions Reviewed-by: jlahoda, jjg ! src/jdk.compiler/share/classes/com/sun/source/util/DocSourcePositions.java ! src/jdk.compiler/share/classes/com/sun/source/util/SourcePositions.java Changeset: bb4500d0 Author: Alexey Ivanov Date: 2021-10-01 18:41:51 +0000 URL: https://git.openjdk.java.net/loom/commit/bb4500d0d227cbb238bd6c862e143f864106a31a 8274465: Fix javax/swing/text/ParagraphView/6364882/bug6364882.java failures Reviewed-by: jiefu, serb ! test/jdk/javax/swing/text/ParagraphView/6364882/bug6364882.java Changeset: 0786d8b7 Author: Brian Burkhalter Date: 2021-10-01 20:15:44 +0000 URL: https://git.openjdk.java.net/loom/commit/0786d8b7b367e3aa3ffa54a3e339572938378dca 8268435: (ch) ChannelInputStream could override readAllBytes Reviewed-by: alanb, lancea ! src/java.base/share/classes/java/io/FileInputStream.java ! src/java.base/share/classes/sun/nio/ch/ChannelInputStream.java + test/jdk/java/nio/channels/Channels/ReadXBytes.java Changeset: 9ca6bf0d Author: Andrey Turbanov Committer: Sergey Bylokhov Date: 2021-10-02 03:06:29 +0000 URL: https://git.openjdk.java.net/loom/commit/9ca6bf0d22ac39d4ee29c756903038f09087ca12 8274505: Too weak variable type leads to unnecessary cast in java.desktop Reviewed-by: serb, kizune, pbansal ! src/java.desktop/share/classes/com/sun/media/sound/SoftSynthesizer.java ! src/java.desktop/share/classes/javax/swing/JFormattedTextField.java ! src/java.desktop/share/classes/javax/swing/JRootPane.java ! src/java.desktop/share/classes/javax/swing/JTree.java ! src/java.desktop/share/classes/javax/swing/plaf/synth/SynthParser.java ! src/java.desktop/share/classes/javax/swing/text/html/AccessibleHTML.java ! src/java.desktop/share/classes/javax/swing/text/html/HTMLDocument.java ! src/java.desktop/share/classes/javax/swing/text/html/HTMLEditorKit.java ! src/java.desktop/share/classes/javax/swing/text/rtf/RTFGenerator.java ! src/java.desktop/share/classes/sun/awt/SunToolkit.java ! src/java.desktop/share/classes/sun/java2d/Disposer.java Changeset: 79579942 Author: Robbin Ehn Date: 2021-10-04 06:47:27 +0000 URL: https://git.openjdk.java.net/loom/commit/7957994273e20d541b8f2a873781be7fedf712f1 8273695: Safepoint deadlock on VMOperation_lock Reviewed-by: dcubed, pchilanomate, eosterlund ! src/hotspot/share/runtime/safepointMechanism.hpp ! src/hotspot/share/runtime/safepointMechanism.inline.hpp ! src/hotspot/share/runtime/stackWatermarkSet.cpp ! src/hotspot/share/runtime/stackWatermarkSet.hpp ! test/hotspot/jtreg/ProblemList.txt Changeset: 32811026 Author: Prasanta Sadhukhan Date: 2021-10-04 06:49:10 +0000 URL: https://git.openjdk.java.net/loom/commit/32811026ce5ecb1d27d835eac33de9ccbd51fcbf 8268084: [macos] Disabled JMenuItem arrow is not disabled Reviewed-by: serb, jdv ! src/java.desktop/macosx/classes/com/apple/laf/AquaImageFactory.java + test/jdk/javax/swing/plaf/aqua/JMenuItemDisableArrowButtonTest.java Changeset: 6726c592 Author: Andrey Turbanov Committer: Pankaj Bansal Date: 2021-10-04 10:27:20 +0000 URL: https://git.openjdk.java.net/loom/commit/6726c592ed01b112f5eb85d8f1e4406b25c8df2b 8274634: Use String.equals instead of String.compareTo in java.desktop Reviewed-by: serb, pbansal ! src/java.desktop/macosx/classes/sun/lwawt/macosx/CAccessible.java ! src/java.desktop/share/classes/javax/swing/JList.java ! src/java.desktop/share/classes/javax/swing/JTable.java Changeset: 0828273b Author: Aleksey Shipilev Date: 2021-10-04 12:22:55 +0000 URL: https://git.openjdk.java.net/loom/commit/0828273b898cca5368344e75f1c3f4c3a29dde80 8274521: jdk/jfr/event/gc/detailed/TestGCLockerEvent.java fails when other GC is selected Reviewed-by: kbarrett, tschatzl ! test/jdk/jdk/jfr/event/gc/detailed/TestGCLockerEvent.java Changeset: 47bfc8aa Author: Aleksey Shipilev Date: 2021-10-04 12:35:58 +0000 URL: https://git.openjdk.java.net/loom/commit/47bfc8aa9367ff852ea5d901f1fa3c6ef316913e 8274563: jfr/event/oldobject/TestClassLoaderLeak.java fails when GC cycles are not happening Reviewed-by: egahlin ! test/jdk/jdk/jfr/event/oldobject/TestClassLoaderLeak.java Changeset: 7eb0372e Author: Alex Kasko Committer: Aleksey Shipilev Date: 2021-10-04 12:38:34 +0000 URL: https://git.openjdk.java.net/loom/commit/7eb0372e55f23275b12470593adc97f1b79bc965 8274606: Fix jaxp/javax/xml/jaxp/unittest/transform/SurrogateTest.java test Reviewed-by: joehw, shade ! test/jaxp/javax/xml/jaxp/unittest/transform/SurrogateTest.java Changeset: f2404d60 Author: Naoto Sato Date: 2021-10-04 15:06:48 +0000 URL: https://git.openjdk.java.net/loom/commit/f2404d60de2b58c590bf885f5cce50c289073673 8274658: ISO 4217 Amendment 170 Update Reviewed-by: lancea, iris ! make/data/currency/CurrencyData.properties ! src/java.base/share/classes/sun/util/resources/CurrencyNames.properties ! test/jdk/java/util/Currency/ValidateISO4217.java ! test/jdk/java/util/Currency/tablea1.txt ! test/jdk/sun/text/resources/LocaleData ! test/jdk/sun/text/resources/LocaleDataTest.java Changeset: f63c4a83 Author: Weijun Wang Date: 2021-10-04 15:30:44 +0000 URL: https://git.openjdk.java.net/loom/commit/f63c4a832a1aea451f47aaf86d5361e970c6a28f 8274471: Verification of OCSP Response signed with RSASSA-PSS fails Reviewed-by: hchao, jnimeh ! src/java.base/share/classes/sun/security/provider/certpath/OCSP.java ! src/java.base/share/classes/sun/security/provider/certpath/OCSPResponse.java ! src/java.base/share/classes/sun/security/util/SignatureUtil.java ! src/java.base/share/classes/sun/security/x509/AlgorithmId.java ! src/java.base/share/classes/sun/security/x509/X509CRLImpl.java ! src/java.base/share/classes/sun/security/x509/X509CertImpl.java ! test/jdk/java/security/testlibrary/CertificateBuilder.java ! test/jdk/java/security/testlibrary/SimpleOCSPServer.java ! test/jdk/javax/net/ssl/Stapling/HttpsUrlConnClient.java Changeset: 139a8334 Author: Adam Sotona Date: 2021-10-04 15:48:09 +0000 URL: https://git.openjdk.java.net/loom/commit/139a8334cbc0c8e1a7a708efe18bd488d28292fd 8268869: java in source-file mode suggests javac-only Xlint flags Reviewed-by: jjg ! src/jdk.compiler/share/classes/com/sun/tools/javac/launcher/Main.java ! test/langtools/tools/javac/launcher/SourceLauncherTest.java Changeset: 6f727d83 Author: Jonathan Gibbons Date: 2021-10-04 16:58:23 +0000 URL: https://git.openjdk.java.net/loom/commit/6f727d831d8f8fb9b44f4c6bdbdd6ae44316a5d8 8274666: rename HtmlStyle.descfrmTypeLabel to be less cryptic Reviewed-by: hannesw ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/Contents.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/MethodWriterImpl.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/PropertyWriterImpl.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/markup/HtmlStyle.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/resources/stylesheet.css ! test/langtools/jdk/javadoc/doclet/testInterface/TestInterface.java ! test/langtools/jdk/javadoc/doclet/testOptions/custom-stylesheet.css ! test/langtools/jdk/javadoc/doclet/testOverriddenMethods/TestOverriddenMethodDocCopy.java ! test/langtools/jdk/javadoc/doclet/testOverriddenMethods/TestOverrideMethods.java ! test/langtools/jdk/javadoc/doclet/testPrivateClasses/TestPrivateClasses.java ! test/langtools/jdk/javadoc/doclet/testReturnTag/TestReturnTag.java Changeset: 0ca094bc Author: Jonathan Gibbons Date: 2021-10-04 16:59:30 +0000 URL: https://git.openjdk.java.net/loom/commit/0ca094bc5f568842b1619229206ec4a385e5ebf6 8273244: Improve diagnostic output related to ErroneousTree Reviewed-by: prappo ! src/jdk.compiler/share/classes/com/sun/tools/javac/api/JavacTrees.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/parser/DocCommentParser.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/parser/ReferenceParser.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/tree/DCTree.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/tree/DocTreeMaker.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/util/AbstractLog.java ! src/jdk.compiler/share/classes/jdk/internal/shellsupport/doc/JavadocHelper.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclint/DocLint.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/tool/JavadocLog.java ! test/langtools/tools/doclint/CrashInAnnotateTest.out ! test/langtools/tools/doclint/EndWithIdentifierTest.out ! test/langtools/tools/doclint/UnfinishedInlineTagTest.out ! test/langtools/tools/doclint/tidy/README.txt ! test/langtools/tools/doclint/tidy/UnescapedOrUnknownEntity.out ! test/langtools/tools/javac/doctree/AttrTest.java ! test/langtools/tools/javac/doctree/AuthorTest.java ! test/langtools/tools/javac/doctree/BadTest.java ! test/langtools/tools/javac/doctree/CodeTest.java + test/langtools/tools/javac/doctree/CoverageTest.java ! test/langtools/tools/javac/doctree/DeprecatedTest.java ! test/langtools/tools/javac/doctree/DocCommentTester.java ! test/langtools/tools/javac/doctree/DocRootTest.java ! test/langtools/tools/javac/doctree/ElementTest.java ! test/langtools/tools/javac/doctree/EntityTest.java ! test/langtools/tools/javac/doctree/ExceptionTest.java ! test/langtools/tools/javac/doctree/FirstSentenceTest.java ! test/langtools/tools/javac/doctree/HiddenTest.java ! test/langtools/tools/javac/doctree/InPreTest.java ! test/langtools/tools/javac/doctree/IndexTest.java ! test/langtools/tools/javac/doctree/InheritDocTest.java ! test/langtools/tools/javac/doctree/LinkPlainTest.java ! test/langtools/tools/javac/doctree/LinkTest.java ! test/langtools/tools/javac/doctree/LiteralTest.java ! test/langtools/tools/javac/doctree/ParamTest.java ! test/langtools/tools/javac/doctree/ProvidesTest.java ! test/langtools/tools/javac/doctree/ReturnTest.java ! test/langtools/tools/javac/doctree/SeeTest.java ! test/langtools/tools/javac/doctree/SerialDataTest.java ! test/langtools/tools/javac/doctree/SerialFieldTest.java ! test/langtools/tools/javac/doctree/SerialTest.java ! test/langtools/tools/javac/doctree/SinceTest.java ! test/langtools/tools/javac/doctree/SummaryTest.java ! test/langtools/tools/javac/doctree/SystemPropertyTest.java ! test/langtools/tools/javac/doctree/TagTest.java ! test/langtools/tools/javac/doctree/ThrowableTest.java ! test/langtools/tools/javac/doctree/UsesTest.java ! test/langtools/tools/javac/doctree/ValueTest.java ! test/langtools/tools/javac/doctree/VersionTest.java ! test/langtools/tools/javac/doctree/positions/TestPosition.java ! test/langtools/tools/javac/tree/AbstractTreeScannerTest.java Changeset: 9914e5c4 Author: Mikhailo Seledtsov Date: 2021-10-04 17:20:05 +0000 URL: https://git.openjdk.java.net/loom/commit/9914e5c416b518f408837e31ba0a35138bfcadc7 8274610: Add linux-aarch64 to bootcycle build profiles Reviewed-by: erikj ! make/conf/jib-profiles.js Changeset: 75d6688d Author: Jonathan Gibbons Date: 2021-10-04 19:00:21 +0000 URL: https://git.openjdk.java.net/loom/commit/75d6688df9845ecb8f370b4cd2d5a36f13d3cdc0 8274745: ProblemList TestSnippetTag.java Reviewed-by: prappo ! test/langtools/ProblemList.txt Changeset: 7e757f6a Author: Erik Gahlin Date: 2021-10-04 21:19:19 +0000 URL: https://git.openjdk.java.net/loom/commit/7e757f6a2cbfd03ba9ac602b800d15ba33f6f5f4 8274559: JFR: Typo in 'jfr help configure' text Reviewed-by: iris, mikael ! src/jdk.jfr/share/classes/jdk/jfr/internal/tool/Configure.java Changeset: 2e542e33 Author: David Holmes Date: 2021-10-04 23:14:12 +0000 URL: https://git.openjdk.java.net/loom/commit/2e542e33b81a53652956bb5e9636e7f4af5540f7 8274349: ForkJoinPool.commonPool() does not work with 1 CPU Co-authored-by: Doug Lea
Reviewed-by: shade, martin ! src/java.base/share/classes/java/util/concurrent/ForkJoinPool.java + test/jdk/java/util/concurrent/forkjoin/Uniprocessor.java ! test/jdk/java/util/concurrent/tck/ForkJoinPoolTest.java Changeset: e43f540c Author: Andrey Turbanov Committer: Sergey Bylokhov Date: 2021-10-05 00:53:17 +0000 URL: https://git.openjdk.java.net/loom/commit/e43f540cde58ee973b97a943f14d3c60e064b801 8274651: Possible race in FontDesignMetrics.KeyReference.dispose Reviewed-by: prr, serb ! src/java.desktop/share/classes/sun/font/FontDesignMetrics.java Changeset: 53d7e95b Author: Andrey Turbanov Committer: Sergey Bylokhov Date: 2021-10-05 06:39:29 +0000 URL: https://git.openjdk.java.net/loom/commit/53d7e95bc637c8b629efc4587b2ae7961d719b00 8274635: Use String.equals instead of String.compareTo in jdk.accessibility Reviewed-by: serb ! src/jdk.accessibility/share/classes/com/sun/java/accessibility/util/AccessibilityEventMonitor.java ! src/jdk.accessibility/windows/classes/com/sun/java/accessibility/internal/AccessBridge.java Changeset: 3953e077 Author: Christian Hagedorn Date: 2021-10-05 07:02:06 +0000 URL: https://git.openjdk.java.net/loom/commit/3953e0774c59c5e936e752aa08b6b6778e232994 8271459: C2: Missing NegativeArraySizeException when creating StringBuilder with negative capacity Reviewed-by: roland, thartmann, neliasso ! src/hotspot/share/opto/stringopts.cpp + test/hotspot/jtreg/compiler/c2/irTests/stringopts/TestNegativeArraySize.java ! test/hotspot/jtreg/compiler/lib/ir_framework/IRNode.java ! test/hotspot/jtreg/testlibrary_tests/ir_framework/tests/TestIRMatching.java Changeset: 8f7a37c9 Author: Matthias Baesken Date: 2021-10-05 07:25:00 +0000 URL: https://git.openjdk.java.net/loom/commit/8f7a37c92f5713f7728f54d4a5924484a535e968 8274434: move os::get_default_process_handle and os::dll_lookup to os_posix for POSIX platforms Reviewed-by: dholmes, lucy ! src/hotspot/os/aix/os_aix.cpp ! src/hotspot/os/bsd/os_bsd.cpp ! src/hotspot/os/linux/os_linux.cpp ! src/hotspot/os/posix/os_posix.cpp Changeset: a914ee72 Author: Kim Barrett Date: 2021-10-05 08:07:02 +0000 URL: https://git.openjdk.java.net/loom/commit/a914ee72167f642b76b1c1cdddd7ff0698d061cc 8274632: Possible pointer overflow in PretouchTask chunk claiming Reviewed-by: tschatzl, ayang ! src/hotspot/share/gc/shared/pretouchTask.cpp ! src/hotspot/share/gc/shared/pretouchTask.hpp Changeset: a5080eff Author: Jan Lahoda Date: 2021-10-05 10:17:24 +0000 URL: https://git.openjdk.java.net/loom/commit/a5080effc7ec7e260e84e3169c36c5217f18d231 8272564: Incorrect attribution of method invocations of Object methods on interfaces Reviewed-by: jlaskey, mcimadamore, vromero ! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Attr.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Resolve.java ! test/langtools/tools/javac/api/TestGetElementReference.java ! test/langtools/tools/javac/api/TestGetElementReferenceData.java + test/langtools/tools/javac/api/TestIsAccessible.java + test/langtools/tools/javac/resolve/NoObjectToString.java Changeset: 8609ea55 Author: Harold Seigel Date: 2021-10-05 12:39:56 +0000 URL: https://git.openjdk.java.net/loom/commit/8609ea55acdcc203408f58f7bf96ea9228aef613 8273342: Null pointer dereference in classFileParser.cpp:2817 Reviewed-by: coleenp, dholmes ! src/hotspot/share/runtime/fieldDescriptor.cpp Changeset: 1459180f Author: Andrey Turbanov Committer: Weijun Wang Date: 2021-10-05 13:36:37 +0000 URL: https://git.openjdk.java.net/loom/commit/1459180f352a5632c0afca2ed55abf31e4b0bfb0 8274079: Cleanup unnecessary calls to Throwable.initCause() in java.base module Reviewed-by: weijun ! src/java.base/share/classes/com/sun/crypto/provider/AESCipher.java ! src/java.base/share/classes/com/sun/crypto/provider/ConstructKeys.java ! src/java.base/share/classes/com/sun/crypto/provider/DESedeWrapCipher.java ! src/java.base/share/classes/com/sun/crypto/provider/DHPrivateKey.java ! src/java.base/share/classes/com/sun/crypto/provider/PBES2Core.java ! src/java.base/share/classes/com/sun/crypto/provider/PBEWithMD5AndDESCipher.java ! src/java.base/share/classes/com/sun/crypto/provider/PBEWithMD5AndTripleDESCipher.java ! src/java.base/share/classes/com/sun/crypto/provider/PBKDF2Core.java ! src/java.base/share/classes/com/sun/crypto/provider/PBKDF2HmacSHA1Factory.java ! src/java.base/share/classes/com/sun/crypto/provider/PBKDF2KeyImpl.java ! src/java.base/share/classes/com/sun/crypto/provider/PBMAC1Core.java ! src/java.base/share/classes/com/sun/crypto/provider/RSACipher.java ! src/java.base/share/classes/java/io/ObjectStreamClass.java ! src/java.base/share/classes/java/security/cert/TrustAnchor.java ! src/java.base/share/classes/java/security/cert/X509CRLSelector.java ! src/java.base/share/classes/java/time/Duration.java ! src/java.base/share/classes/javax/net/ssl/SSLContext.java ! src/java.base/share/classes/javax/security/auth/login/Configuration.java ! src/java.base/share/classes/javax/security/auth/x500/X500Principal.java ! src/java.base/share/classes/sun/security/provider/DigestBase.java ! src/java.base/share/classes/sun/security/provider/JavaKeyStore.java ! src/java.base/share/classes/sun/security/util/HostnameChecker.java Changeset: 7ad74d82 Author: Peter Levart Date: 2021-10-05 14:16:20 +0000 URL: https://git.openjdk.java.net/loom/commit/7ad74d82d7117113dd73966a0dd96168adfd6463 8274299: Make Method/Constructor/Field accessors @Stable Reviewed-by: redestad, mchung ! src/java.base/share/classes/java/lang/reflect/Constructor.java ! src/java.base/share/classes/java/lang/reflect/Field.java ! src/java.base/share/classes/java/lang/reflect/Method.java ! src/java.base/share/classes/jdk/internal/reflect/DelegatingConstructorAccessorImpl.java ! src/java.base/share/classes/jdk/internal/reflect/DelegatingMethodAccessorImpl.java ! src/java.base/share/classes/jdk/internal/reflect/FieldAccessorImpl.java ! src/java.base/share/classes/jdk/internal/reflect/NativeConstructorAccessorImpl.java ! src/java.base/share/classes/jdk/internal/reflect/NativeMethodAccessorImpl.java ! src/java.base/share/classes/jdk/internal/reflect/ReflectionFactory.java ! src/java.base/share/classes/jdk/internal/reflect/UnsafeFieldAccessorImpl.java ! src/java.base/share/classes/jdk/internal/reflect/UnsafeStaticFieldAccessorImpl.java + test/micro/org/openjdk/bench/java/lang/reflect/ReflectionColdstartBenchmark.java + test/micro/org/openjdk/bench/java/lang/reflect/ReflectionSpeedBenchmark.java Changeset: bb0bab57 Author: Albert Mingkun Yang Date: 2021-10-05 14:31:17 +0000 URL: https://git.openjdk.java.net/loom/commit/bb0bab57a1ff447bfb41cfe10c91838a6812b93d 8274286: Skip null for make_referent_alive in referenceProcessor Reviewed-by: kbarrett, tschatzl ! src/hotspot/share/gc/shared/referenceProcessor.cpp Changeset: 90a5ae80 Author: Coleen Phillimore Date: 2021-10-05 15:13:54 +0000 URL: https://git.openjdk.java.net/loom/commit/90a5ae802e6ef0a6d0a5096a595b0680069960c3 8274282: Clarify special wait assert Reviewed-by: dholmes, pchilanomate ! src/hotspot/share/runtime/mutex.cpp ! test/hotspot/gtest/runtime/test_mutex.cpp Changeset: 92b64a20 Author: Jonathan Gibbons Date: 2021-10-05 15:21:44 +0000 URL: https://git.openjdk.java.net/loom/commit/92b64a2053e3f3e0314ed489b92afd37c285ac5f 8273745: VerifyLocale.java occasionally times out Reviewed-by: prappo ! test/langtools/jdk/javadoc/tool/VerifyLocale.java Changeset: 4e3948f1 Author: Jonathan Gibbons Date: 2021-10-05 15:27:02 +0000 URL: https://git.openjdk.java.net/loom/commit/4e3948f18b9b8dab96239ad24473134b712ada1a 8274744: TestSnippetTag test fails after recent integration Reviewed-by: prappo ! test/langtools/ProblemList.txt ! test/langtools/jdk/javadoc/doclet/testSnippetTag/TestSnippetTag.java Changeset: e1f0df0d Author: Hannes Walln?fer Date: 2021-10-05 16:57:12 +0000 URL: https://git.openjdk.java.net/loom/commit/e1f0df0de3b205cecdb1aa1d74562536c06097dd 8267853: Remove unused styles from stylesheet Reviewed-by: prappo ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/resources/stylesheet.css ! test/langtools/jdk/javadoc/doclet/checkStylesheetClasses/CheckStylesheetClasses.java ! test/langtools/jdk/javadoc/doclet/testStylesheet/TestStylesheet.java Changeset: 37890650 Author: Phil Race Date: 2021-10-05 17:30:31 +0000 URL: https://git.openjdk.java.net/loom/commit/37890650a7c97d484b6b520d909f677dac4e46e1 8274397: [macOS] Stop setting env. var JAVA_MAIN_CLASS_ in launcher code Reviewed-by: rriggs, serb ! src/java.base/macosx/native/libjli/java_md_macosx.m ! src/java.desktop/macosx/native/libosxapp/NSApplicationAWT.m + test/jdk/tools/launcher/MacOSAppNamePropertyTest.java + test/jdk/tools/launcher/SystemPropertyTest.java ! test/jdk/tools/launcher/TestSpecialArgs.java Changeset: c391e59e Author: Joe Darcy Date: 2021-10-05 17:31:57 +0000 URL: https://git.openjdk.java.net/loom/commit/c391e59ea6fe6759553425e342b2d97824dd9323 8274244: ReportOnImportedModuleAnnotation.java fails on rerun Reviewed-by: jjg ! test/langtools/tools/javac/processing/ReportOnImportedModuleAnnotation/ReportOnImportedModuleAnnotation.java Changeset: 03d3c033 Author: Weijun Wang Date: 2021-10-05 18:18:51 +0000 URL: https://git.openjdk.java.net/loom/commit/03d3c0338437bf10b631881c8910ca85985742f6 8273670: Remove weak etypes from default krb5 etype list Reviewed-by: valeriep, mullan ! src/java.security.jgss/share/classes/sun/security/krb5/internal/crypto/EType.java ! test/jdk/sun/security/krb5/auto/DupEtypes.java ! test/jdk/sun/security/krb5/auto/OneKDC.java ! test/jdk/sun/security/krb5/auto/W83.java ! test/jdk/sun/security/krb5/config/YesNo.java ! test/jdk/sun/security/krb5/config/yesno.conf ! test/jdk/sun/security/krb5/etype/WeakCrypto.java Changeset: 1e752033 Author: Weijun Wang Date: 2021-10-05 18:19:45 +0000 URL: https://git.openjdk.java.net/loom/commit/1e75203356666a3213deddd775ad1e883ea6d78d 8274656: Remove default_checksum and safe_checksum_type from krb5.conf Reviewed-by: valeriep ! src/java.security.jgss/share/classes/sun/security/krb5/Checksum.java ! src/java.security.jgss/share/classes/sun/security/krb5/Config.java ! src/java.security.jgss/share/classes/sun/security/krb5/EncryptedData.java - src/java.security.jgss/share/classes/sun/security/krb5/KrbAppMessage.java - src/java.security.jgss/share/classes/sun/security/krb5/KrbPriv.java - src/java.security.jgss/share/classes/sun/security/krb5/KrbSafe.java ! src/java.security.jgss/share/classes/sun/security/krb5/KrbTgsReq.java - src/java.security.jgss/share/classes/sun/security/krb5/internal/AuthContext.java - src/java.security.jgss/share/classes/sun/security/krb5/internal/EncKrbPrivPart.java - src/java.security.jgss/share/classes/sun/security/krb5/internal/KRBPriv.java - src/java.security.jgss/share/classes/sun/security/krb5/internal/KRBSafe.java - src/java.security.jgss/share/classes/sun/security/krb5/internal/KRBSafeBody.java - src/java.security.jgss/share/classes/sun/security/krb5/internal/MethodData.java Changeset: 332f0673 Author: Jonathan Gibbons Date: 2021-10-05 18:54:19 +0000 URL: https://git.openjdk.java.net/loom/commit/332f0673880d547a5f09cb4efd3b952868a84b91 8274729: Define Position.NOPOS == Diagnostic.NOPOS Reviewed-by: jlahoda ! src/jdk.compiler/share/classes/com/sun/tools/javac/util/Position.java Changeset: d34ec6cc Author: Joe Darcy Date: 2021-10-05 19:10:29 +0000 URL: https://git.openjdk.java.net/loom/commit/d34ec6ccfc27d9401acce0e03595b910764fbfaf 8274793: Suppress warnings on non-serializable non-transient instance fields in sun.net Reviewed-by: alanb ! src/java.base/share/classes/sun/net/www/http/KeepAliveCache.java ! src/java.base/unix/classes/sun/net/www/protocol/http/ntlm/NTLMAuthentication.java Changeset: 83b22192 Author: Igor Veresov Date: 2021-10-05 19:44:17 +0000 URL: https://git.openjdk.java.net/loom/commit/83b2219220266c1365466970d08606fef766c4fa 8273612: Fix for JDK-8272873 causes timeout in running some tests with -Xcomp Reviewed-by: kvn, neliasso ! src/hotspot/share/compiler/compilationPolicy.cpp ! test/hotspot/jtreg/compiler/jvmci/compilerToVM/IsMatureTest.java ! test/hotspot/jtreg/compiler/jvmci/compilerToVM/IsMatureVsReprofileTest.java Changeset: 47262670 Author: Christoph Langer Date: 2021-10-05 21:06:52 +0000 URL: https://git.openjdk.java.net/loom/commit/47262670f371923a704ec521da40010c2a46be5a 8274642: jdk/jshell/CommandCompletionTest.java fails with NoSuchElementException after JDK-8271287 Reviewed-by: jlahoda ! test/langtools/jdk/jshell/CommandCompletionTest.java Changeset: d4e8712c Author: Daniel D. Daugherty Date: 2021-10-05 21:47:18 +0000 URL: https://git.openjdk.java.net/loom/commit/d4e8712c0acc786e64f81ad29e54e6e50134f0e0 8274797: ProblemList resourcehogs/serviceability/sa/TestHeapDumpForLargeArray.java on macosx-x64 Reviewed-by: darcy ! test/hotspot/jtreg/ProblemList.txt Changeset: df7b0c70 Author: Sergey Tsypanov Committer: Martin Buchholz Date: 2021-10-05 22:19:35 +0000 URL: https://git.openjdk.java.net/loom/commit/df7b0c707713195c93ff4e745c89155ee8e4c571 8274715: Implement forEach in Collections.CopiesList Reviewed-by: martin ! src/java.base/share/classes/java/util/Collections.java + test/micro/org/openjdk/bench/java/util/NCopiesBenchmarks.java Changeset: 986ee5d0 Author: Yasumasa Suenaga Date: 2021-10-06 00:36:50 +0000 URL: https://git.openjdk.java.net/loom/commit/986ee5d0bfd407dc1b7ce75c7c94b6585bfb497d 8274670: Improve version string handling in SA Reviewed-by: cjplummer, sspitsyn ! src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/runtime/VM.java ! src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/runtime/VMVersionMismatchException.java Changeset: 8a4d2b4a Author: Andrey Turbanov Committer: Sergey Bylokhov Date: 2021-10-06 02:53:09 +0000 URL: https://git.openjdk.java.net/loom/commit/8a4d2b4aa76e6aae1cb27f476c6cc71dcd9779f0 8274680: Remove unnecessary conversion to String in java.desktop Reviewed-by: pbansal, jdv, serb, kizune ! src/java.desktop/share/classes/com/sun/imageio/plugins/jpeg/DHTMarkerSegment.java ! src/java.desktop/share/classes/com/sun/imageio/plugins/jpeg/DQTMarkerSegment.java ! src/java.desktop/share/classes/com/sun/imageio/plugins/jpeg/DRIMarkerSegment.java ! src/java.desktop/share/classes/com/sun/imageio/plugins/jpeg/JFIFMarkerSegment.java ! src/java.desktop/share/classes/com/sun/imageio/plugins/png/PNGMetadata.java ! src/java.desktop/share/classes/javax/imageio/plugins/tiff/TIFFField.java ! src/java.desktop/share/classes/javax/swing/DefaultListSelectionModel.java ! src/java.desktop/share/classes/javax/swing/GroupLayout.java ! src/java.desktop/share/classes/javax/swing/event/TreeModelEvent.java ! src/java.desktop/share/classes/javax/swing/text/TabStop.java ! src/java.desktop/share/classes/javax/swing/text/html/OptionListModel.java ! src/java.desktop/share/classes/javax/swing/tree/DefaultTreeSelectionModel.java ! src/java.desktop/share/classes/sun/java2d/marlin/RendererContext.java ! src/java.desktop/share/classes/sun/print/PSPrinterJob.java ! src/java.desktop/share/classes/sun/swing/plaf/synth/DefaultSynthStyle.java ! src/java.desktop/windows/classes/sun/awt/windows/WDesktopProperties.java Changeset: 2faced09 Author: Per Liden Date: 2021-10-06 07:44:47 +0000 URL: https://git.openjdk.java.net/loom/commit/2faced09ce0f6901dcdc969e6c85f2a5b55778f1 8274738: ZGC: Use relaxed atomic load when reading bits in the live map Reviewed-by: stefank, eosterlund ! src/hotspot/share/gc/z/zLiveMap.inline.hpp Changeset: c74726db Author: Andrew Haley Date: 2021-10-06 08:18:10 +0000 URL: https://git.openjdk.java.net/loom/commit/c74726dbd0767d02abf9535361a86ffb69b646d9 8274730: AArch64: AES/GCM acceleration is broken by the fix for JDK-8273297 Reviewed-by: adinn, roland, kvn ! src/hotspot/cpu/aarch64/matcher_aarch64.hpp ! src/hotspot/cpu/aarch64/stubGenerator_aarch64.cpp ! src/hotspot/share/opto/library_call.cpp Changeset: df125f68 Author: Christian Hagedorn Date: 2021-10-06 08:21:18 +0000 URL: https://git.openjdk.java.net/loom/commit/df125f680b6a4517109be80512a113064ca6281d 8273410: IR verification framework fails with "Should find method name in validIrRulesMap" Reviewed-by: thartmann, neliasso ! test/hotspot/jtreg/compiler/lib/ir_framework/test/TestVM.java ! test/hotspot/jtreg/testlibrary_tests/ir_framework/tests/TestBadFormat.java + test/hotspot/jtreg/testlibrary_tests/ir_framework/tests/TestCheckedTests.java Changeset: cdf89304 Author: Hannes Walln?fer Date: 2021-10-06 09:28:37 +0000 URL: https://git.openjdk.java.net/loom/commit/cdf89304eafce58e66127d4e277f5fcaf07c9954 8274625: Search field placeholder behavior Reviewed-by: prappo ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/Navigation.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/markup/HtmlAttr.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/markup/HtmlTree.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/resources/search.js.template ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/resources/doclets.properties ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/resources/stylesheet.css ! test/langtools/jdk/javadoc/doclet/checkStylesheetClasses/CheckStylesheetClasses.java ! test/langtools/jdk/javadoc/doclet/testSearch/TestSearch.java ! test/langtools/jdk/javadoc/doclet/testStylesheet/TestStylesheet.java Changeset: 9759fcb1 Author: Andrey Turbanov Committer: Pankaj Bansal Date: 2021-10-06 10:50:38 +0000 URL: https://git.openjdk.java.net/loom/commit/9759fcb17b62d76d75b893481bbd4ef45e7ad366 8274496: Use String.contains() instead of String.indexOf() in java.desktop Reviewed-by: pbansal, serb ! src/java.desktop/share/classes/javax/swing/text/html/CSS.java ! src/java.desktop/share/classes/javax/swing/text/html/HTMLDocument.java ! src/java.desktop/share/classes/javax/swing/text/html/HTMLWriter.java ! src/java.desktop/share/classes/javax/swing/text/html/InlineView.java ! src/java.desktop/share/classes/sun/font/Font2D.java ! src/java.desktop/unix/classes/sun/awt/X11/XWM.java ! src/java.desktop/unix/classes/sun/font/NativeFont.java ! src/java.desktop/unix/classes/sun/font/XMap.java ! src/java.desktop/unix/classes/sun/print/IPPPrintService.java ! src/java.desktop/windows/classes/sun/awt/windows/WDataTransferer.java Changeset: c80a6127 Author: Kim Barrett Date: 2021-10-06 11:14:26 +0000 URL: https://git.openjdk.java.net/loom/commit/c80a612709f1e483575e2843c1f0ea84e1b9a257 8273381: Assert in PtrQueueBufferAllocatorTest.stress_free_list_allocator_vm Reviewed-by: sjohanss, tschatzl ! test/hotspot/gtest/gc/shared/test_ptrQueueBufferAllocator.cpp Changeset: b8af6a9b Author: Coleen Phillimore Date: 2021-10-06 12:14:33 +0000 URL: https://git.openjdk.java.net/loom/commit/b8af6a9bfb28aaf0fea0cfdaba13236dc8cbaa3a 8273917: Remove 'leaf' ranking for Mutex Reviewed-by: eosterlund, dholmes ! src/hotspot/share/compiler/compileTask.hpp ! src/hotspot/share/gc/shared/space.cpp ! src/hotspot/share/gc/shenandoah/shenandoahControlThread.cpp ! src/hotspot/share/gc/shenandoah/shenandoahPacer.hpp ! src/hotspot/share/oops/methodData.cpp ! src/hotspot/share/runtime/mutex.cpp ! src/hotspot/share/runtime/mutex.hpp ! src/hotspot/share/runtime/mutexLocker.cpp ! src/hotspot/share/services/heapDumper.cpp ! test/hotspot/gtest/runtime/test_mutex.cpp ! test/hotspot/gtest/runtime/test_safepoint_locks.cpp Changeset: c10de353 Author: Christian Stein Committer: Alan Bateman Date: 2021-10-06 15:11:28 +0000 URL: https://git.openjdk.java.net/loom/commit/c10de3538b47c182d7bfeb02f348fac9b2ad0641 8262944: Improve exception message when automatic module lists provider class not in JAR file Reviewed-by: dfuchs, jvernee, alanb, lancea, mchung ! src/java.base/share/classes/jdk/internal/module/ModulePath.java ! test/jdk/java/lang/module/AutomaticModulesTest.java Changeset: f3cedbe9 Author: Andrey Turbanov Committer: Daniel Fuchs Date: 2021-10-06 18:11:07 +0000 URL: https://git.openjdk.java.net/loom/commit/f3cedbe9288e7aea8d5603a2dc9bdc2661c391a6 8274464: Remove redundant stream() call before forEach in java.* modules Reviewed-by: dfuchs, amenkov, vtewari ! src/java.management.rmi/share/classes/javax/management/remote/rmi/RMIJRMPServerImpl.java ! src/java.management/share/classes/java/lang/management/DefaultPlatformMBeanProvider.java ! src/java.xml/share/classes/javax/xml/catalog/CatalogFeatures.java ! src/java.xml/share/classes/javax/xml/catalog/CatalogImpl.java Changeset: 4e7d7caa Author: Andrey Turbanov Committer: Daniel Fuchs Date: 2021-10-06 18:17:58 +0000 URL: https://git.openjdk.java.net/loom/commit/4e7d7caa0ce1a3c9fc45ca6a85b1a7ec209775b2 8273711: Remove redundant stream() call before forEach in jdk.jlink Reviewed-by: alanb, psandoz, dfuchs ! src/jdk.jlink/share/classes/jdk/tools/jlink/internal/ImageFileCreator.java ! src/jdk.jlink/share/classes/jdk/tools/jlink/internal/ImagePluginConfiguration.java ! src/jdk.jlink/share/classes/jdk/tools/jlink/internal/ImagePluginStack.java ! src/jdk.jlink/share/classes/jdk/tools/jlink/internal/PerfectHashBuilder.java ! src/jdk.jlink/share/classes/jdk/tools/jlink/internal/PluginRepository.java ! src/jdk.jlink/share/classes/jdk/tools/jlink/internal/ResourcePoolConfiguration.java ! src/jdk.jlink/share/classes/jdk/tools/jlink/internal/plugins/ReleaseInfoPlugin.java ! src/jdk.jlink/share/classes/jdk/tools/jlink/internal/plugins/ResourceFilter.java ! src/jdk.jlink/share/classes/jdk/tools/jlink/internal/plugins/StringSharingPlugin.java Changeset: 754bc82c Author: Andrey Turbanov Committer: Daniel Fuchs Date: 2021-10-06 18:20:18 +0000 URL: https://git.openjdk.java.net/loom/commit/754bc82c4c03e1bedb4b36b5c52873b0a78a6ceb 8274525: Replace uses of StringBuffer with StringBuilder in java.xml Reviewed-by: joehw, iris, naoto, dfuchs ! src/java.xml/share/classes/com/sun/xml/internal/stream/Entity.java ! src/java.xml/share/classes/com/sun/xml/internal/stream/StaxErrorReporter.java ! src/java.xml/share/classes/com/sun/xml/internal/stream/XMLEventReaderImpl.java ! src/java.xml/share/classes/com/sun/xml/internal/stream/events/LocationImpl.java ! src/java.xml/share/classes/javax/xml/datatype/Duration.java Changeset: 9945f7a0 Author: Andrey Turbanov Committer: Daniel Fuchs Date: 2021-10-06 18:23:46 +0000 URL: https://git.openjdk.java.net/loom/commit/9945f7a0744db2470bcfa856e8f831b6a6eb2de8 8274318: Replace 'for' cycles with iterator with enhanced-for in java.management Reviewed-by: cjplummer, sspitsyn, dfuchs ! src/java.management.rmi/share/classes/javax/management/remote/rmi/RMIServerImpl.java ! src/java.management/share/classes/com/sun/jmx/remote/security/MBeanServerFileAccessController.java ! src/java.management/share/classes/javax/management/relation/RoleResult.java Changeset: 9561fea7 Author: Sergey Bylokhov Date: 2021-10-06 22:31:23 +0000 URL: https://git.openjdk.java.net/loom/commit/9561fea79035f23ca3a6619c9e150433cdf4a232 8273102: Delete deprecated for removal the empty finalize() in java.desktop module Reviewed-by: pbansal, aivanov, iris, prr ! src/java.desktop/share/classes/java/awt/color/ICC_Profile.java ! src/java.desktop/share/classes/java/awt/image/ColorModel.java ! src/java.desktop/share/classes/java/awt/image/IndexColorModel.java Changeset: 734d1fbd Author: Jonathan Gibbons Date: 2021-10-06 22:40:44 +0000 URL: https://git.openjdk.java.net/loom/commit/734d1fbd33be0aa20b26e6e8c776709f478069de 8274211: Test man page that options are documented Reviewed-by: prappo + test/langtools/jdk/javadoc/tool/CheckManPageOptions.java Changeset: d57fb6f6 Author: lawrence.andrews Committer: Sergey Bylokhov Date: 2021-10-06 23:12:56 +0000 URL: https://git.openjdk.java.net/loom/commit/d57fb6f684eac5a7e68842dcf3284309e3867521 8274456: Remove jtreg tag manual=yesno java/awt/print/PrinterJob/PageDialogTest.java Reviewed-by: serb ! test/jdk/java/awt/print/PrinterJob/PageDialogTest.java Changeset: c833b4d1 Author: Jie Fu Date: 2021-10-06 23:22:04 +0000 URL: https://git.openjdk.java.net/loom/commit/c833b4d130fabfa6a6f3a38313f76eb7e392c6a5 8274329: Fix non-portable HotSpot code in MethodMatcher::parse_method_pattern Reviewed-by: iklam, ihse, kvn ! src/hotspot/share/compiler/methodMatcher.cpp Changeset: 4e960fe5 Author: Andrey Turbanov Committer: Sergey Bylokhov Date: 2021-10-07 03:42:50 +0000 URL: https://git.openjdk.java.net/loom/commit/4e960fe53f0948c0b0decfeb13f6dd8f74bf3d6f 8274497: Unnecessary Vector usage in AquaFileSystemModel Reviewed-by: serb, pbansal ! src/java.desktop/macosx/classes/com/apple/laf/AquaFileSystemModel.java Changeset: 5762ec25 Author: Florian Weimer Committer: Alan Bateman Date: 2021-10-07 07:02:01 +0000 URL: https://git.openjdk.java.net/loom/commit/5762ec25877ab9207a2fb05888f952690737e318 8274780: ChannelInputStream.readNBytes(int) incorrectly calls readAllBytes() Reviewed-by: alanb, bpb ! src/java.base/share/classes/sun/nio/ch/ChannelInputStream.java ! test/jdk/java/nio/channels/Channels/ReadXBytes.java Changeset: 29dcbb72 Author: Richard Reingruber Date: 2021-10-07 08:20:20 +0000 URL: https://git.openjdk.java.net/loom/commit/29dcbb72a2d9b224203d92ad3224cf149a7d08de 8274716: JDWP Spec: the description for the Dispose command confuses suspend with resume. Reviewed-by: alanb, cjplummer, sspitsyn ! make/data/jdwp/jdwp.spec Changeset: d5ccfa2a Author: Andrey Turbanov Committer: Serguei Spitsyn Date: 2021-10-07 09:38:42 +0000 URL: https://git.openjdk.java.net/loom/commit/d5ccfa2ae965a9ae0f3597b0b90d702a3e0ea558 8274755: Replace 'while' cycles with iterator with enhanced-for in jdk.jdi Reviewed-by: alanb, amenkov, sspitsyn, cjplummer ! src/jdk.jdi/share/classes/com/sun/tools/jdi/ConcreteMethodImpl.java ! src/jdk.jdi/share/classes/com/sun/tools/jdi/ConnectorImpl.java ! src/jdk.jdi/share/classes/com/sun/tools/jdi/EventRequestManagerImpl.java ! src/jdk.jdi/share/classes/com/sun/tools/jdi/InvokableTypeImpl.java ! src/jdk.jdi/share/classes/com/sun/tools/jdi/ReferenceTypeImpl.java ! src/jdk.jdi/share/classes/com/sun/tools/jdi/TargetVM.java ! src/jdk.jdi/share/classes/com/sun/tools/jdi/ThreadReferenceImpl.java ! src/jdk.jdi/share/classes/com/sun/tools/jdi/VMState.java ! src/jdk.jdi/share/classes/com/sun/tools/jdi/VirtualMachineImpl.java Changeset: 83198361 Author: Yude Lin Committer: Thomas Schatzl Date: 2021-10-07 11:28:49 +0000 URL: https://git.openjdk.java.net/loom/commit/8319836152cbd0aa5bf6c93d3ba04733cacf83b4 8274546: Shenandoah: Remove unused ShenandoahUpdateRootsTask copy Reviewed-by: zgu, tschatzl ! src/hotspot/share/gc/shenandoah/shenandoahConcurrentMark.cpp Changeset: 340c715c Author: Lin Zang Date: 2021-10-07 11:57:18 +0000 URL: https://git.openjdk.java.net/loom/commit/340c715c3b0f5ad5204f9dddb17a787b07426543 8273929: Remove GzipRandomAccess in heap dump test Reviewed-by: cjplummer, sspitsyn - test/lib/jdk/test/lib/hprof/parser/GzipRandomAccess.java ! test/lib/jdk/test/lib/hprof/parser/Reader.java Changeset: 722d639f Author: Jie Fu Date: 2021-10-07 12:42:16 +0000 URL: https://git.openjdk.java.net/loom/commit/722d639fad2e4fc6eb2aabd427e2719501899cfe 8274838: runtime/cds/appcds/TestSerialGCWithCDS.java fails on Windows Reviewed-by: iklam, hseigel ! test/hotspot/jtreg/runtime/cds/appcds/TestSerialGCWithCDS.java Changeset: 03a8d342 Author: Sean Coffey Date: 2021-10-07 15:12:13 +0000 URL: https://git.openjdk.java.net/loom/commit/03a8d342b86e720d3cba08d540182b4ab161fba3 8273826: Correct Manifest file name and NPE checks Reviewed-by: weijun, hchao, mullan ! src/java.base/share/classes/java/util/jar/JarFile.java ! src/java.base/share/classes/java/util/jar/JarInputStream.java ! src/java.base/share/classes/java/util/jar/JarVerifier.java ! src/java.base/share/classes/sun/security/util/ManifestEntryVerifier.java + test/jdk/sun/security/tools/jarsigner/warnings/LowerCaseManifest.java Changeset: 4ab274ac Author: Coleen Phillimore Date: 2021-10-07 15:24:00 +0000 URL: https://git.openjdk.java.net/loom/commit/4ab274ac1a241b2d63f46084ec23aa7cff4bc28e 8274858: Remove unused dictionary_classes_do functions Reviewed-by: dholmes, hseigel ! src/hotspot/share/classfile/classLoaderDataGraph.cpp ! src/hotspot/share/classfile/classLoaderDataGraph.hpp ! src/hotspot/share/memory/universe.cpp Changeset: 8ca08461 Author: Naoto Sato Date: 2021-10-07 15:32:11 +0000 URL: https://git.openjdk.java.net/loom/commit/8ca084617f331b6af934179f3f776c8158da5bba 8274407: (tz) Update Timezone Data to 2021c 8274467: TestZoneInfo310.java fails with tzdata2021b 8274468: TimeZoneTest.java fails with tzdata2021b Reviewed-by: rriggs, iris, coffeys ! make/data/tzdata/VERSION ! make/data/tzdata/africa ! make/data/tzdata/antarctica ! make/data/tzdata/asia ! make/data/tzdata/australasia ! make/data/tzdata/backward ! make/data/tzdata/europe ! make/data/tzdata/leapseconds ! make/data/tzdata/northamerica ! make/data/tzdata/southamerica ! make/data/tzdata/zone.tab ! src/java.base/share/classes/sun/util/calendar/ZoneInfoFile.java ! test/jdk/java/util/TimeZone/TimeZoneTest.java Changeset: 7de2cf85 Author: Andrey Turbanov Committer: Daniel Fuchs Date: 2021-10-07 16:55:45 +0000 URL: https://git.openjdk.java.net/loom/commit/7de2cf852d75ea6eb039e69067d4e32421283de5 8273910: Redundant condition and assignment in java.net.URI Reviewed-by: dfuchs ! src/java.base/share/classes/java/net/URI.java Changeset: 920e7070 Author: Daniel D. Daugherty Date: 2021-10-07 17:14:26 +0000 URL: https://git.openjdk.java.net/loom/commit/920e70701da9699765c993e11feba3cc0fd0362c 8274920: ProblemList 2 VectorAPI tests failing due to "assert(!vbox->is_Phi()) failed" Reviewed-by: kvn ! test/hotspot/jtreg/ProblemList-Xcomp.txt Changeset: 8de77634 Author: Yumin Qi Date: 2021-10-07 21:33:32 +0000 URL: https://git.openjdk.java.net/loom/commit/8de77634c414cc348a6eb7b28fd6339befdb12d7 8273152: Refactor CDS FileMapHeader loading code Reviewed-by: ccheung, iklam ! src/hotspot/share/cds/archiveBuilder.cpp ! src/hotspot/share/cds/cdsConstants.cpp ! src/hotspot/share/cds/dynamicArchive.cpp ! src/hotspot/share/cds/filemap.cpp ! src/hotspot/share/cds/filemap.hpp ! src/hotspot/share/include/cds.h ! src/hotspot/share/runtime/arguments.cpp ! src/jdk.hotspot.agent/share/native/libsaproc/ps_core_common.c ! test/hotspot/jtreg/runtime/cds/appcds/SharedArchiveConsistency.java ! test/hotspot/jtreg/runtime/cds/appcds/dynamicArchive/ArchiveConsistency.java ! test/lib/jdk/test/lib/cds/CDSArchiveUtils.java Changeset: 97ea9dd2 Author: Matthias Baesken Date: 2021-10-08 06:40:18 +0000 URL: https://git.openjdk.java.net/loom/commit/97ea9dd2f24f9f1fb9b9345a4202a825ee28e014 8274840: Update OS detection code to recognize Windows 11 Co-authored-by: Arno Zeller Reviewed-by: clanger, dholmes ! src/hotspot/os/windows/os_windows.cpp ! src/java.base/windows/native/libjava/java_props_md.c Changeset: b60837a7 Author: Doug Simon Date: 2021-10-08 08:06:53 +0000 URL: https://git.openjdk.java.net/loom/commit/b60837a7d5d6f920d2fb968369564df155dc1018 8272586: emit abstract machine code in hs-err logs Reviewed-by: kvn, dholmes ! src/hotspot/share/code/nmethod.cpp ! src/hotspot/share/compiler/compileTask.cpp ! src/hotspot/share/compiler/compileTask.hpp ! src/hotspot/share/compiler/disassembler.cpp ! src/hotspot/share/utilities/vmError.cpp ! src/hotspot/share/utilities/vmError.hpp + test/hotspot/jtreg/runtime/ErrorHandling/MachCodeFramesInErrorFile.java Changeset: 6364719c Author: Coleen Phillimore Date: 2021-10-08 12:23:19 +0000 URL: https://git.openjdk.java.net/loom/commit/6364719cd1c57220769ea580d958da8dc2fdf7f9 8274004: Change 'nonleaf' rank name 8273956: Add checking for rank values Reviewed-by: dholmes, pchilanomate ! src/hotspot/os/aix/osThread_aix.cpp ! src/hotspot/os/bsd/osThread_bsd.cpp ! src/hotspot/os/linux/osThread_linux.cpp ! src/hotspot/share/classfile/classLoaderData.cpp ! src/hotspot/share/compiler/compileTask.hpp ! src/hotspot/share/gc/g1/g1RegionToSpaceMapper.cpp ! src/hotspot/share/gc/g1/g1ServiceThread.cpp ! src/hotspot/share/gc/g1/heapRegion.cpp ! src/hotspot/share/gc/g1/heapRegionRemSet.cpp ! src/hotspot/share/gc/parallel/psCompactionManager.cpp ! src/hotspot/share/gc/shared/gcLogPrecious.cpp ! src/hotspot/share/gc/shared/oopStorage.cpp ! src/hotspot/share/gc/shared/space.cpp ! src/hotspot/share/gc/shared/taskTerminator.cpp ! src/hotspot/share/gc/shared/workgroup.cpp ! src/hotspot/share/gc/shenandoah/shenandoahControlThread.cpp ! src/hotspot/share/gc/shenandoah/shenandoahPacer.hpp ! src/hotspot/share/gc/z/zMessagePort.inline.hpp ! src/hotspot/share/gc/z/zMetronome.cpp ! src/hotspot/share/memory/heapInspection.hpp ! src/hotspot/share/memory/metaspace/testHelpers.cpp ! src/hotspot/share/oops/methodData.cpp ! src/hotspot/share/prims/jvmtiTagMap.cpp ! src/hotspot/share/runtime/handshake.cpp ! src/hotspot/share/runtime/mutex.cpp ! src/hotspot/share/runtime/mutex.hpp ! src/hotspot/share/runtime/mutexLocker.cpp ! src/hotspot/share/runtime/stackWatermark.cpp ! src/hotspot/share/runtime/vmOperations.cpp ! src/hotspot/share/runtime/vmThread.cpp ! src/hotspot/share/services/heapDumper.cpp ! src/hotspot/share/services/heapDumperCompression.cpp ! src/hotspot/share/services/memoryManager.cpp ! src/hotspot/share/utilities/concurrentHashTable.inline.hpp ! src/hotspot/share/utilities/events.hpp ! test/hotspot/gtest/metaspace/test_is_metaspace_obj.cpp ! test/hotspot/gtest/metaspace/test_metaspacearena.cpp ! test/hotspot/gtest/metaspace/test_metaspacearena_stress.cpp ! test/hotspot/gtest/runtime/test_mutex.cpp - test/hotspot/gtest/runtime/test_safepoint_locks.cpp ! test/hotspot/gtest/utilities/test_filterQueue.cpp Changeset: 2aacd422 Author: Roland Westrelin Date: 2021-10-08 14:48:35 +0000 URL: https://git.openjdk.java.net/loom/commit/2aacd4220a01b467de671212c7a74e6c81a2ad3c 8274145: C2: condition incorrectly made redundant with dominating main loop exit condition Reviewed-by: kvn, neliasso ! src/hotspot/share/opto/loopnode.hpp ! src/hotspot/share/opto/loopopts.cpp + test/hotspot/jtreg/compiler/loopopts/TestIfReplacedByMainLoopExit.java Changeset: 36b89a18 Author: Christian Hagedorn Date: 2021-10-08 14:51:18 +0000 URL: https://git.openjdk.java.net/loom/commit/36b89a18931d42b8002a843ec8218b5c1ba54374 8274785: ciReplay: Potential crash due to uninitialized Compile::_ilt variable Reviewed-by: neliasso, kvn ! src/hotspot/share/opto/compile.cpp Changeset: ccbce107 Author: Sergey Tsypanov Committer: Jayathirth D V Date: 2021-10-08 15:58:36 +0000 URL: https://git.openjdk.java.net/loom/commit/ccbce107f299c3b1c444e819c1fda7ae3c4866b5 8272756: Remove unnecessary explicit initialization of volatile variables in java.desktop Reviewed-by: jdv, aivanov ! src/java.desktop/macosx/classes/sun/lwawt/LWLightweightFramePeer.java ! src/java.desktop/macosx/classes/sun/lwawt/LWWindowPeer.java ! src/java.desktop/macosx/classes/sun/lwawt/macosx/CCheckboxMenuItem.java ! src/java.desktop/macosx/classes/sun/lwawt/macosx/CPlatformEmbeddedFrame.java ! src/java.desktop/macosx/classes/sun/lwawt/macosx/CWarningWindow.java ! src/java.desktop/share/classes/com/sun/imageio/plugins/tiff/TIFFIFD.java ! src/java.desktop/share/classes/com/sun/media/sound/DirectAudioDevice.java ! src/java.desktop/share/classes/com/sun/media/sound/SoftAudioPusher.java ! src/java.desktop/share/classes/com/sun/media/sound/SoftSynthesizer.java ! src/java.desktop/share/classes/java/awt/Component.java ! src/java.desktop/share/classes/java/awt/Container.java ! src/java.desktop/share/classes/java/awt/Dialog.java ! src/java.desktop/share/classes/java/awt/Window.java ! src/java.desktop/share/classes/java/awt/event/InvocationEvent.java ! src/java.desktop/share/classes/java/awt/font/NumericShaper.java ! src/java.desktop/share/classes/javax/swing/JComponent.java ! src/java.desktop/share/classes/sun/awt/AppContext.java ! src/java.desktop/share/classes/sun/awt/datatransfer/SunClipboard.java ! src/java.desktop/share/classes/sun/awt/dnd/SunDragSourceContextPeer.java ! src/java.desktop/share/classes/sun/java2d/Disposer.java ! src/java.desktop/share/classes/sun/java2d/marlin/RendererStats.java ! src/java.desktop/unix/classes/sun/awt/X11/GtkFileDialogPeer.java ! src/java.desktop/unix/classes/sun/awt/X11/ListHelper.java ! src/java.desktop/unix/classes/sun/awt/X11/XInputMethod.java ! src/java.desktop/unix/classes/sun/awt/X11/XLightweightFramePeer.java ! src/java.desktop/unix/classes/sun/awt/X11/XWarningWindow.java ! src/java.desktop/windows/classes/sun/awt/windows/ThemeReader.java ! src/java.desktop/windows/classes/sun/awt/windows/WObjectPeer.java Changeset: ec199072 Author: Naoto Sato Date: 2021-10-08 16:11:22 +0000 URL: https://git.openjdk.java.net/loom/commit/ec199072c5867624d66840238cc8828e16ae8da7 8274864: Remove Amman/Cairo hacks in ZoneInfoFile Reviewed-by: iris, joehw ! src/java.base/share/classes/sun/util/calendar/ZoneInfoFile.java Changeset: 239a35aa Author: Brian Burkhalter Date: 2021-10-08 16:43:16 +0000 URL: https://git.openjdk.java.net/loom/commit/239a35aa9166d0cb0b20850e1b52ad23b653d8d0 8233749: Files.exists javadoc doesn't mention eating IOException Reviewed-by: lancea, alanb ! src/java.base/share/classes/java/nio/file/Files.java Changeset: 3cb9724e Author: Coleen Phillimore Date: 2021-10-08 21:10:42 +0000 URL: https://git.openjdk.java.net/loom/commit/3cb9724ed94a7267853c5cddb18b4ae868ecf2e9 8274934: Attempting to acquire lock JNICritical_lock/41 out of order with lock MultiArray_lock/41 Reviewed-by: dcubed, iklam ! src/hotspot/share/runtime/mutexLocker.cpp Changeset: 9c431dd1 Author: Andrey Turbanov Committer: Pavel Rappo Date: 2021-10-08 23:08:05 +0000 URL: https://git.openjdk.java.net/loom/commit/9c431dd168c8a752d4aa1bde2268db0425d76990 8274900: Too weak variable type leads to unnecessary cast in jdk.javadoc Reviewed-by: prappo ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/SourceToHTMLConverter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/builders/SerializedFormBuilder.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/util/SummaryAPIListBuilder.java Changeset: f640c7aa Author: Andrey Turbanov Committer: Sergey Bylokhov Date: 2021-10-09 00:46:20 +0000 URL: https://git.openjdk.java.net/loom/commit/f640c7aaa852b6c0e9144654b7222a6777201370 8274806: Simplify equals() call on nullable variable and a constant in java.desktop Reviewed-by: serb, pbansal ! src/java.desktop/macosx/classes/sun/lwawt/macosx/CMenuItem.java ! src/java.desktop/share/classes/java/awt/Window.java ! src/java.desktop/share/classes/javax/swing/DefaultDesktopManager.java ! src/java.desktop/share/classes/javax/swing/JLayeredPane.java ! src/java.desktop/share/classes/javax/swing/filechooser/FileSystemView.java ! src/java.desktop/share/classes/javax/swing/text/html/HTMLEditorKit.java ! src/java.desktop/share/classes/sun/java2d/SurfaceDataProxy.java ! src/java.desktop/share/classes/sun/print/RasterPrinterJob.java ! src/java.desktop/unix/classes/sun/awt/X11/XTaskbarPeer.java ! src/java.desktop/unix/classes/sun/print/UnixPrintJob.java ! src/java.desktop/windows/classes/sun/awt/windows/WDesktopProperties.java Changeset: aac6c4ea Author: Pankaj Bansal Date: 2021-10-09 03:52:53 +0000 URL: https://git.openjdk.java.net/loom/commit/aac6c4ea707fa592b2bcd7586c1fe61a19e3725e 8272229: BasicSplitPaneDivider:oneTouchExpandableChanged() returns leftButton and rightButton as null with GTKLookAndFeel Reviewed-by: serb, jdv, kizune ! src/java.desktop/share/classes/javax/swing/plaf/basic/BasicSplitPaneDivider.java Changeset: 6d1d4d52 Author: Wang Huang Committer: Hamlin Li Date: 2021-10-09 08:19:17 +0000 URL: https://git.openjdk.java.net/loom/commit/6d1d4d52928ed38bbc73ddcbede5389995a8e65f 8268231: Aarch64: Use ldp in intrinsics for String.compareTo Co-authored-by: Wang Huang Co-authored-by: Sun Jianye Co-authored-by: Wu Yan Reviewed-by: ngasson, aph ! src/hotspot/cpu/aarch64/stubGenerator_aarch64.cpp Changeset: 2c83559e Author: Andrey Turbanov Committer: Sergey Bylokhov Date: 2021-10-10 08:41:52 +0000 URL: https://git.openjdk.java.net/loom/commit/2c83559eda410d268c6d8a56d7fd1c34f817cb83 8274882: Cleanup redundant boxing in java.desktop Reviewed-by: serb, pbansal ! src/java.desktop/share/classes/com/sun/java/swing/plaf/gtk/Metacity.java ! src/java.desktop/share/classes/javax/swing/SwingUtilities.java ! src/java.desktop/share/classes/javax/swing/plaf/metal/MetalLookAndFeel.java ! src/java.desktop/share/classes/sun/awt/SunToolkit.java ! src/java.desktop/share/classes/sun/awt/image/VSyncedBSManager.java ! src/java.desktop/share/classes/sun/java2d/marlin/MarlinProperties.java ! src/java.desktop/unix/classes/sun/awt/X11/MotifColorUtilities.java ! src/java.desktop/windows/classes/com/sun/java/swing/plaf/windows/WindowsLookAndFeel.java ! src/java.desktop/windows/classes/sun/awt/windows/TranslucentWindowPainter.java Changeset: 296f8537 Author: lawrence.andrews Committer: Sergey Bylokhov Date: 2021-10-10 08:46:04 +0000 URL: https://git.openjdk.java.net/loom/commit/296f8537f71b84f194cf2718ac9b85ba6843cfa3 8274029: Remove jtreg tag manual=yesno for java/awt/print/Dialog/DialogOrient.java Reviewed-by: serb ! test/jdk/java/awt/print/Dialog/DialogOrient.java Changeset: 2ff3977a Author: Jie Fu Date: 2021-10-10 14:00:58 +0000 URL: https://git.openjdk.java.net/loom/commit/2ff3977a66c8d8b521cd0ad266ba954682a268ce 8275004: CDS build failure with gcc11 Reviewed-by: shade ! src/hotspot/share/cds/cdsConstants.hpp Changeset: 5ecc99bb Author: Lin Zang Date: 2021-10-11 01:56:34 +0000 URL: https://git.openjdk.java.net/loom/commit/5ecc99bbf55e631b5bfa07e2c36b38e820682363 8274620: resourcehogs/serviceability/sa/TestHeapDumpForLargeArray.java is timing out Reviewed-by: cjplummer, dholmes ! src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/utilities/HeapHprofBinWriter.java ! test/hotspot/jtreg/ProblemList.txt Changeset: a05873a2 Author: Ao Qi Committer: Jie Fu Date: 2021-10-11 02:17:56 +0000 URL: https://git.openjdk.java.net/loom/commit/a05873a225c40d12e60870794b9c993d1ea89cfe 8274952: jdk/jfr/api/consumer/TestRecordedFrameType.java failed when c1 disabled Reviewed-by: egahlin, jiefu ! test/jdk/jdk/jfr/api/consumer/TestRecordedFrameType.java Changeset: c032186b Author: Fei Gao Committer: Pengfei Li Date: 2021-10-11 06:59:37 +0000 URL: https://git.openjdk.java.net/loom/commit/c032186b421c64b44397cb7aa101b40e5f93dfff 8272968: AArch64: Remove redundant matching rules for commutative ops Reviewed-by: ngasson ! src/hotspot/cpu/aarch64/aarch64.ad Changeset: 49f8ce6e Author: Martin Doerr Date: 2021-10-11 10:31:54 +0000 URL: https://git.openjdk.java.net/loom/commit/49f8ce6e9c797cd11ea586e3cf87398888bc8cf1 8274773: [TESTBUG] UnsafeIntrinsicsTest intermittently fails on weak memory model platform Reviewed-by: eosterlund, goetz ! test/hotspot/jtreg/compiler/gcbarriers/UnsafeIntrinsicsTest.java Changeset: 3edee1e1 Author: Roman Kennke Date: 2021-10-11 10:37:54 +0000 URL: https://git.openjdk.java.net/loom/commit/3edee1e1feed564397ac47a32c0394d7798bac17 8272723: Don't use Access API to access primitive fields Reviewed-by: stefank, eosterlund ! src/hotspot/share/classfile/javaClasses.cpp ! src/hotspot/share/classfile/javaClasses.inline.hpp ! src/hotspot/share/jvmci/jvmciJavaClasses.cpp ! src/hotspot/share/oops/instanceKlass.inline.hpp ! src/hotspot/share/oops/oop.cpp ! src/hotspot/share/oops/oop.hpp ! src/hotspot/share/oops/oop.inline.hpp ! src/hotspot/share/oops/typeArrayOop.inline.hpp ! src/hotspot/share/prims/unsafe.cpp Changeset: c55dd365 Author: Jie Fu Date: 2021-10-11 10:51:39 +0000 URL: https://git.openjdk.java.net/loom/commit/c55dd365e3463670697b09de0ff70877203e5a69 8275008: gtest build failure due to stringop-overflow warning with gcc11 Reviewed-by: dholmes, ihse ! make/hotspot/lib/CompileGtest.gmk Changeset: aaf2401b Author: Thomas Schatzl Date: 2021-10-11 11:46:46 +0000 URL: https://git.openjdk.java.net/loom/commit/aaf2401bc7d766dee5ffc623db86c4723c7e3760 8274927: Remove unnecessary G1ArchiveAllocator code Reviewed-by: kbarrett, ayang ! src/hotspot/share/gc/g1/g1Allocator.cpp ! src/hotspot/share/gc/g1/g1Allocator.hpp ! src/hotspot/share/gc/g1/g1CollectedHeap.cpp Changeset: b7af8905 Author: Thomas Schatzl Date: 2021-10-11 11:48:50 +0000 URL: https://git.openjdk.java.net/loom/commit/b7af890574b3c13122fe7de987a8c9458c05f625 8274430: Remove some debug error printing code added in JDK-8017163 Reviewed-by: sjohanss, ayang ! src/hotspot/share/gc/g1/heapRegion.cpp Changeset: 110e38de Author: Coleen Phillimore Date: 2021-10-11 12:11:11 +0000 URL: https://git.openjdk.java.net/loom/commit/110e38ded8e09361f24c582c770d35f5cfdabf82 8274753: ZGC: SEGV in MetaspaceShared::link_shared_classes 8274935: dumptime_table has stale entry Reviewed-by: eosterlund, iklam ! src/hotspot/share/cds/metaspaceShared.cpp ! src/hotspot/share/classfile/classLoaderData.cpp ! test/hotspot/jtreg/runtime/cds/appcds/loaderConstraints/DynamicLoaderConstraintsTest.java Changeset: b870468b Author: Jan Lahoda Date: 2021-10-11 12:38:08 +0000 URL: https://git.openjdk.java.net/loom/commit/b870468bdc99938fbb19a41b0ede0a3e3769ace2 8274347: Passing a *nested* switch expression as a parameter causes an NPE during compile Reviewed-by: vromero ! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Attr.java ! test/langtools/tools/javac/api/TestGetScopeResult.java ! test/langtools/tools/javac/switchexpr/ExpressionSwitchInfer.java Changeset: 0d80f6cf Author: Patricio Chilano Mateo Date: 2021-10-11 13:34:42 +0000 URL: https://git.openjdk.java.net/loom/commit/0d80f6cf82ddab85f2461c7cc663a93bb222e988 8274379: Allow process of unsafe access errors in check_special_condition_for_native_trans Reviewed-by: rehn, dholmes ! src/hotspot/share/prims/jvm.cpp ! src/hotspot/share/prims/jvmtiEnv.cpp ! src/hotspot/share/runtime/safepoint.hpp ! src/hotspot/share/runtime/thread.cpp ! src/hotspot/share/runtime/thread.hpp ! src/hotspot/share/runtime/thread.inline.hpp ! src/hotspot/share/runtime/vmStructs.cpp Changeset: 3f073377 Author: Zhengyu Gu Date: 2021-10-11 15:10:57 +0000 URL: https://git.openjdk.java.net/loom/commit/3f07337722a0c8c6b452a44745598268d67c0864 8273614: Shenandoah: intermittent timeout with ConcurrentGCBreakpoint tests Reviewed-by: shade ! src/hotspot/share/gc/shenandoah/shenandoahConcurrentGC.cpp Changeset: 3f01d03a Author: Lin Zang Date: 2021-10-11 15:27:28 +0000 URL: https://git.openjdk.java.net/loom/commit/3f01d03a10cb3f647735ed4bbea1768ff18bf8f2 8275021: Test serviceability/sa/TestJmapCore.java fails with: java.io.IOException: Stack frame 0x4 not found Reviewed-by: dholmes, dcubed ! src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/utilities/HeapHprofBinWriter.java Changeset: 83c37719 Author: Thomas Stuefe Date: 2021-10-11 15:48:10 +0000 URL: https://git.openjdk.java.net/loom/commit/83c37719290039672cf261701028c8eb044a2e77 8273881: Metaspace: test repeated deallocations Reviewed-by: dholmes, shade ! test/hotspot/gtest/metaspace/test_metaspacearena.cpp Changeset: 75f5145e Author: Zhengyu Gu Date: 2021-10-11 16:58:53 +0000 URL: https://git.openjdk.java.net/loom/commit/75f5145e21a1320c1a08080af861497ce7c3f266 8274925: Shenandoah: shenandoah/TestAllocHumongousFragment.java test failed on lock rank check Reviewed-by: shade ! src/hotspot/share/gc/shenandoah/shenandoahControlThread.cpp Changeset: 829dea45 Author: Andrey Turbanov Committer: Pankaj Bansal Date: 2021-10-11 19:19:39 +0000 URL: https://git.openjdk.java.net/loom/commit/829dea45c9ab90518f03a66aad7e681cd4fda8b3 8274945: Cleanup unnecessary calls to Throwable.initCause() in java.desktop Reviewed-by: jdv, serb, pbansal ! src/java.desktop/share/classes/com/sun/imageio/plugins/jpeg/MarkerSegment.java ! src/java.desktop/share/classes/javax/imageio/metadata/IIOMetadata.java ! src/java.desktop/share/classes/javax/imageio/spi/ImageReaderWriterSpi.java ! src/java.desktop/share/classes/sun/awt/datatransfer/TransferableProxy.java Changeset: dd93c6e2 Author: Sergey Bylokhov Date: 2021-10-12 00:14:00 +0000 URL: https://git.openjdk.java.net/loom/commit/dd93c6e27b66acebb221583fd28d03c65bfc1f24 8272167: AbsPathsInImage.java should skip *.dSYM directories Reviewed-by: ihse, erikj ! test/jdk/build/AbsPathsInImage.java Changeset: 1e306959 Author: Hamlin Li Date: 2021-10-12 01:25:00 +0000 URL: https://git.openjdk.java.net/loom/commit/1e3069593e6f56714e1ee557b70930c2749d820c 8274466: G1: use field directly rather than method in G1CollectorState::in_mixed_phase Reviewed-by: ayang, sjohanss ! src/hotspot/share/gc/g1/g1CollectorState.hpp Changeset: ef0922e8 Author: Aleksey Shipilev Date: 2021-10-12 05:56:15 +0000 URL: https://git.openjdk.java.net/loom/commit/ef0922e88528bdf4fe75537ddf4e82123e3f58b3 8274560: JFR: Add test for OldObjectSample event when using Shenandoah Reviewed-by: mgronlun ! test/jdk/jdk/jfr/event/oldobject/TestObjectDescription.java + test/jdk/jdk/jfr/event/oldobject/TestShenandoah.java Changeset: a5f09d10 Author: Aleksey Shipilev Date: 2021-10-12 06:22:13 +0000 URL: https://git.openjdk.java.net/loom/commit/a5f09d1088d9dd610139370739e9fbd6e34416cb 8275031: runtime/ErrorHandling/MachCodeFramesInErrorFile.java fails when hsdis is present Reviewed-by: dholmes, dnsimon ! src/hotspot/share/code/nmethod.cpp ! test/hotspot/jtreg/runtime/ErrorHandling/MachCodeFramesInErrorFile.java Changeset: cfe7471f Author: Aleksey Shipilev Date: 2021-10-12 07:24:15 +0000 URL: https://git.openjdk.java.net/loom/commit/cfe7471f1769eca2a4e623f5ba9cddceb005f0bf 8177814: jdk/editpad is not in jdk TEST.groups Reviewed-by: serb ! test/jdk/TEST.groups Changeset: 7d2633f7 Author: Andrey Turbanov Committer: Pavel Rappo Date: 2021-10-12 09:37:54 +0000 URL: https://git.openjdk.java.net/loom/commit/7d2633f795c27edc2dfbbd7a9d9e44bdb23ec6a1 8275002: Remove unused AbstractStringBuilder.MAX_ARRAY_SIZE Reviewed-by: prappo, jlaskey, martin ! src/java.base/share/classes/java/lang/AbstractStringBuilder.java Changeset: 8de26361 Author: Kim Barrett Date: 2021-10-12 09:40:35 +0000 URL: https://git.openjdk.java.net/loom/commit/8de26361f7d789c7b317536198c891756038a8ea 8274615: Support relaxed atomic add for linux-aarch64 Reviewed-by: aph, dholmes ! src/hotspot/cpu/aarch64/atomic_aarch64.hpp ! src/hotspot/cpu/aarch64/stubGenerator_aarch64.cpp ! src/hotspot/os_cpu/linux_aarch64/atomic_linux_aarch64.S ! src/hotspot/os_cpu/linux_aarch64/atomic_linux_aarch64.hpp Changeset: 33050f80 Author: Doug Simon Date: 2021-10-12 09:49:50 +0000 URL: https://git.openjdk.java.net/loom/commit/33050f8013366f5e3a01ab1a75ba3fee9cc73089 8274986: max code printed in hs-err logs should be configurable Reviewed-by: never, dholmes ! src/hotspot/share/code/codeBlob.cpp ! src/hotspot/share/runtime/flags/jvmFlagLimit.cpp ! src/hotspot/share/runtime/globals.hpp ! src/hotspot/share/utilities/vmError.cpp ! src/hotspot/share/utilities/vmError.hpp ! test/hotspot/jtreg/runtime/ErrorHandling/MachCodeFramesInErrorFile.java Changeset: d04d4ee2 Author: Andrey Turbanov Committer: Daniel Fuchs Date: 2021-10-12 11:14:31 +0000 URL: https://git.openjdk.java.net/loom/commit/d04d4ee2c193baf4339ee3025e3fbcd31d62f484 8274894: Use Optional.empty() instead of ofNullable(null) in HttpResponse.BodySubscribers.discarding Reviewed-by: dfuchs ! src/java.net.http/share/classes/java/net/http/HttpResponse.java Changeset: b460d6dd Author: kabutz Committer: Markus Gr?nlund Date: 2021-10-12 11:38:21 +0000 URL: https://git.openjdk.java.net/loom/commit/b460d6ddafcd1be76bcf407254f843df6bbfb70b 8275091: /src/jdk.management.jfr/share/classes/module-info.java has non-canonical order Reviewed-by: mgronlun ! src/jdk.management.jfr/share/classes/module-info.java Changeset: 1ab64143 Author: Zhengyu Gu Date: 2021-10-12 11:58:35 +0000 URL: https://git.openjdk.java.net/loom/commit/1ab64143c06e33e23172dd77c39e434443347364 8275051: Shenandoah: Correct ordering of requested gc cause and gc request flag Reviewed-by: shade ! src/hotspot/share/gc/shenandoah/shenandoahControlThread.cpp Changeset: e16b93ad Author: Martin Doerr Date: 2021-10-12 12:18:49 +0000 URL: https://git.openjdk.java.net/loom/commit/e16b93ad52c96fddd9097c2cb0fa78ae781c547b 8274770: [PPC64] resolve_jobject needs a generic implementation to support load barriers Reviewed-by: goetz, nradomski ! src/hotspot/cpu/ppc/gc/shared/barrierSetAssembler_ppc.cpp ! src/hotspot/cpu/ppc/gc/shared/modRefBarrierSetAssembler_ppc.cpp ! src/hotspot/cpu/ppc/gc/shared/modRefBarrierSetAssembler_ppc.hpp Changeset: e393c5ea Author: Roman Kennke Date: 2021-10-12 13:16:20 +0000 URL: https://git.openjdk.java.net/loom/commit/e393c5ea9d9a254cdacbd311498c55c560e8ab25 8275074: Cleanup unused code in JFR LeakProfiler Reviewed-by: mgronlun ! src/hotspot/share/jfr/leakprofiler/chains/edgeUtils.cpp ! src/hotspot/share/jfr/leakprofiler/chains/edgeUtils.hpp - src/hotspot/share/jfr/leakprofiler/utilities/saveRestore.cpp - src/hotspot/share/jfr/leakprofiler/utilities/saveRestore.hpp Changeset: f6234606 Author: Christian Hagedorn Date: 2021-10-12 13:21:35 +0000 URL: https://git.openjdk.java.net/loom/commit/f62346066869b681d1cc9f63775393b11a48722a 8274911: testlibrary_tests/ir_framework/tests/TestIRMatching.java fails with "java.lang.RuntimeException: Should have thrown exception" Reviewed-by: kvn, thartmann ! test/hotspot/jtreg/compiler/lib/ir_framework/driver/IRMatcher.java ! test/hotspot/jtreg/testlibrary_tests/ir_framework/tests/TestIRMatching.java ! test/hotspot/jtreg/testlibrary_tests/ir_framework/tests/TestRunTests.java ! test/hotspot/jtreg/testlibrary_tests/ir_framework/tests/Utils.java Changeset: 07b1f1c2 Author: Brian Burkhalter Date: 2021-10-12 15:25:53 +0000 URL: https://git.openjdk.java.net/loom/commit/07b1f1c282ee0a7df6a6b0f240962a032ea3a413 8274548: (fc) FileChannel gathering write fails with IOException "Invalid argument" on macOS 11.6 Reviewed-by: alanb ! src/java.base/share/classes/sun/nio/ch/IOUtil.java ! src/java.base/unix/native/libnio/ch/IOUtil.c ! src/java.base/windows/native/libnio/ch/IOUtil.c + test/jdk/java/nio/channels/FileChannel/LargeGatheringWrite.java Changeset: 89999f70 Author: Dmitry Batrak Date: 2021-10-12 15:36:41 +0000 URL: https://git.openjdk.java.net/loom/commit/89999f70e06b41704c7c5b0f9a19582f90806a10 8275131: Exceptions after a touchpad gesture on macOS Reviewed-by: dmarkov, prr ! src/java.desktop/macosx/native/libawt_lwawt/awt/AWTWindow.m Changeset: b8bd259b Author: Evgeny Astigeevich Committer: Paul Hohensee Date: 2021-10-12 16:56:06 +0000 URL: https://git.openjdk.java.net/loom/commit/b8bd259bb83096f8727222a4e5cd84e80e096275 8271737: Only normalize the cached user.dir property once Reviewed-by: phh ! src/java.base/windows/classes/java/io/WinNTFileSystem.java Changeset: 8657f776 Author: Daniel D. Daugherty Date: 2021-10-12 17:05:47 +0000 URL: https://git.openjdk.java.net/loom/commit/8657f77608f37d7ff5254032858f2f16c7c204d5 8271514: support JFR use of new ThreadsList::Iterator Co-authored-by: Kim Barrett Reviewed-by: sspitsyn, mgronlun ! src/hotspot/share/jfr/utilities/jfrThreadIterator.cpp ! src/hotspot/share/jfr/utilities/jfrThreadIterator.hpp Changeset: 124f8237 Author: Sergey Tsypanov Committer: Sergey Bylokhov Date: 2021-10-12 19:13:17 +0000 URL: https://git.openjdk.java.net/loom/commit/124f82377ba93359bc59118ee315ba194080fa92 8268764: Use Long.hashCode() instead of int-cast where applicable Reviewed-by: kevinw, prr, kizune, serb ! src/java.desktop/share/classes/com/sun/media/sound/DLSSoundbank.java ! src/java.desktop/share/classes/com/sun/media/sound/WaveExtensibleFileReader.java ! src/java.rmi/share/classes/java/rmi/server/ObjID.java ! src/jdk.internal.vm.ci/share/classes/jdk.vm.ci.hotspot/src/jdk/vm/ci/hotspot/HotSpotResolvedJavaMethodImpl.java ! src/jdk.jdi/share/classes/com/sun/tools/jdi/FieldImpl.java ! src/jdk.jdi/share/classes/com/sun/tools/jdi/MethodImpl.java ! src/jdk.jdi/share/classes/com/sun/tools/jdi/ObjectReferenceImpl.java ! src/jdk.jdi/share/classes/com/sun/tools/jdi/ReferenceTypeImpl.java ! src/jdk.security.auth/share/classes/com/sun/security/auth/NTNumericCredential.java Changeset: 03c2b73e Author: Magnus Ihse Bursie Date: 2021-10-12 23:28:53 +0000 URL: https://git.openjdk.java.net/loom/commit/03c2b73e2112cdbcbd1230009de0a15a9bd31815 8275128: Build hsdis using normal build system Reviewed-by: erikj + make/Hsdis.gmk ! make/Main.gmk ! make/autoconf/configure.ac ! make/autoconf/help.m4 ! make/autoconf/jdk-options.m4 ! make/autoconf/spec.gmk.in ! src/utils/hsdis/README - src/utils/hsdis/hsdis-demo.c Changeset: b1b83500 Author: Daniel D. Daugherty Date: 2021-10-12 23:43:40 +0000 URL: https://git.openjdk.java.net/loom/commit/b1b83500a9c3a74bf39894e49eefd031d208b9b9 8275171: ProblemList compiler/codegen/aes/TestAESMain.java on linux-x64 and windows-x64 in -Xcomp mode Reviewed-by: iignatyev ! test/hotspot/jtreg/ProblemList-Xcomp.txt Changeset: ab34cced Author: Joe Darcy Date: 2021-10-13 05:26:33 +0000 URL: https://git.openjdk.java.net/loom/commit/ab34cced3beae765fe9d6b6acfef7e6a7f3082cd 8275186: Suppress warnings on non-serializable array component types in xml Reviewed-by: joehw ! src/java.xml/share/classes/com/sun/org/apache/bcel/internal/generic/TargetLostException.java ! src/java.xml/share/classes/com/sun/org/apache/xerces/internal/impl/dv/DatatypeException.java ! src/java.xml/share/classes/com/sun/org/apache/xerces/internal/impl/io/MalformedByteSequenceException.java ! src/java.xml/share/classes/com/sun/org/apache/xerces/internal/impl/xs/XMLSchemaException.java ! src/java.xml/share/classes/com/sun/org/apache/xerces/internal/impl/xs/traversers/XSDComplexTypeTraverser.java ! src/java.xml/share/classes/com/sun/org/apache/xpath/internal/axes/UnionPathIterator.java Changeset: cf828673 Author: Martin Doerr Date: 2021-10-13 07:12:52 +0000 URL: https://git.openjdk.java.net/loom/commit/cf828673a9b76fd3f26db9a3f714166861a65c9e 8275049: [ZGC] missing null check in ZNMethod::log_register Reviewed-by: nradomski, eosterlund, pliden ! src/hotspot/share/gc/z/zNMethod.cpp Changeset: 337b73a4 Author: Niklas Radomski Committer: Martin Doerr Date: 2021-10-13 07:36:52 +0000 URL: https://git.openjdk.java.net/loom/commit/337b73a459ba24aa529b7b097617434be1d0030e 8274851: [PPC64] Port zgc to linux on ppc64le Reviewed-by: ihse, pliden, mdoerr, eosterlund ! make/autoconf/jvm-features.m4 ! make/hotspot/gensrc/GensrcAdlc.gmk ! src/hotspot/cpu/ppc/assembler_ppc.hpp + src/hotspot/cpu/ppc/gc/z/zBarrierSetAssembler_ppc.cpp + src/hotspot/cpu/ppc/gc/z/zBarrierSetAssembler_ppc.hpp + src/hotspot/cpu/ppc/gc/z/zGlobals_ppc.cpp + src/hotspot/cpu/ppc/gc/z/zGlobals_ppc.hpp + src/hotspot/cpu/ppc/gc/z/z_ppc.ad ! src/hotspot/cpu/ppc/ppc.ad ! src/hotspot/cpu/ppc/vmreg_ppc.hpp + src/hotspot/os_cpu/linux_ppc/gc/z/zSyscall_linux_ppc.hpp Changeset: c3b75c6c Author: Thomas Schatzl Date: 2021-10-13 08:10:55 +0000 URL: https://git.openjdk.java.net/loom/commit/c3b75c6cdf03ffa3c887bf3db29e17668b228f79 8274516: [REDO] JDK-8271880: Tighten condition for excluding regions from collecting cards with cross-references Reviewed-by: sjohanss, ayang ! src/hotspot/share/gc/g1/g1CollectedHeap.cpp ! src/hotspot/share/gc/g1/g1CollectedHeap.hpp ! src/hotspot/share/gc/g1/g1CollectedHeap.inline.hpp ! src/hotspot/share/gc/g1/g1EvacFailure.cpp ! src/hotspot/share/gc/g1/g1EvacFailure.hpp ! src/hotspot/share/gc/g1/g1HeapRegionAttr.hpp ! src/hotspot/share/gc/g1/g1OopClosures.hpp ! src/hotspot/share/gc/g1/g1ParScanThreadState.cpp ! src/hotspot/share/gc/g1/g1ParScanThreadState.hpp ! src/hotspot/share/gc/g1/g1ParScanThreadState.inline.hpp ! src/hotspot/share/gc/g1/g1YoungCollector.cpp ! src/hotspot/share/gc/g1/g1YoungCollector.hpp ! src/hotspot/share/gc/g1/g1YoungGCPostEvacuateTasks.cpp ! src/hotspot/share/gc/g1/g1YoungGCPostEvacuateTasks.hpp ! src/hotspot/share/gc/shared/referenceProcessor.cpp ! src/hotspot/share/gc/shared/referenceProcessor.hpp Changeset: dcf428c7 Author: Andrey Turbanov Committer: Serguei Spitsyn Date: 2021-10-13 09:07:07 +0000 URL: https://git.openjdk.java.net/loom/commit/dcf428c7a74e568deaededfc11d3c4e1bf7821f2 8275075: Remove unnecessary conversion to String in jdk.hotspot.agent Reviewed-by: sspitsyn, cjplummer ! src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/HSDB.java ! src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/interpreter/BytecodeLoadConstant.java ! src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/runtime/PerfDataEntry.java ! src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/ui/classbrowser/HTMLGenerator.java Changeset: b8cb76ad Author: Jan Lahoda Date: 2021-10-13 10:15:54 +0000 URL: https://git.openjdk.java.net/loom/commit/b8cb76ad210cb3e7524c7f5b13cfe57746ac05d4 8273682: Upgrade Jline to 3.20.0 Reviewed-by: sundar ! src/jdk.internal.le/share/classes/jdk/internal/org/jline/reader/Candidate.java + src/jdk.internal.le/share/classes/jdk/internal/org/jline/reader/CompletionMatcher.java - src/jdk.internal.le/share/classes/jdk/internal/org/jline/reader/ConfigurationPath.java ! src/jdk.internal.le/share/classes/jdk/internal/org/jline/reader/EndOfFileException.java ! src/jdk.internal.le/share/classes/jdk/internal/org/jline/reader/LineReader.java ! src/jdk.internal.le/share/classes/jdk/internal/org/jline/reader/LineReaderBuilder.java ! src/jdk.internal.le/share/classes/jdk/internal/org/jline/reader/Parser.java + src/jdk.internal.le/share/classes/jdk/internal/org/jline/reader/PrintAboveWriter.java - src/jdk.internal.le/share/classes/jdk/internal/org/jline/reader/ScriptEngine.java + src/jdk.internal.le/share/classes/jdk/internal/org/jline/reader/impl/CompletionMatcherImpl.java ! src/jdk.internal.le/share/classes/jdk/internal/org/jline/reader/impl/DefaultHighlighter.java ! src/jdk.internal.le/share/classes/jdk/internal/org/jline/reader/impl/DefaultParser.java ! src/jdk.internal.le/share/classes/jdk/internal/org/jline/reader/impl/LineReaderImpl.java ! src/jdk.internal.le/share/classes/jdk/internal/org/jline/reader/impl/ReaderUtils.java ! src/jdk.internal.le/share/classes/jdk/internal/org/jline/reader/impl/completer/StringsCompleter.java + src/jdk.internal.le/share/classes/jdk/internal/org/jline/reader/impl/completer/SystemCompleter.java ! src/jdk.internal.le/share/classes/jdk/internal/org/jline/reader/impl/history/DefaultHistory.java ! src/jdk.internal.le/share/classes/jdk/internal/org/jline/terminal/Terminal.java ! src/jdk.internal.le/share/classes/jdk/internal/org/jline/terminal/TerminalBuilder.java ! src/jdk.internal.le/share/classes/jdk/internal/org/jline/terminal/impl/AbstractTerminal.java ! src/jdk.internal.le/share/classes/jdk/internal/org/jline/terminal/impl/AbstractWindowsTerminal.java ! src/jdk.internal.le/share/classes/jdk/internal/org/jline/terminal/spi/JansiSupport.java ! src/jdk.internal.le/share/classes/jdk/internal/org/jline/terminal/spi/JnaSupport.java ! src/jdk.internal.le/share/classes/jdk/internal/org/jline/utils/AttributedCharSequence.java ! src/jdk.internal.le/share/classes/jdk/internal/org/jline/utils/AttributedString.java ! src/jdk.internal.le/share/classes/jdk/internal/org/jline/utils/AttributedStringBuilder.java ! src/jdk.internal.le/share/classes/jdk/internal/org/jline/utils/AttributedStyle.java + src/jdk.internal.le/share/classes/jdk/internal/org/jline/utils/ColorPalette.java ! src/jdk.internal.le/share/classes/jdk/internal/org/jline/utils/Colors.java ! src/jdk.internal.le/share/classes/jdk/internal/org/jline/utils/Curses.java ! src/jdk.internal.le/share/classes/jdk/internal/org/jline/utils/Display.java ! src/jdk.internal.le/share/classes/jdk/internal/org/jline/utils/InfoCmp.java ! src/jdk.internal.le/share/classes/jdk/internal/org/jline/utils/Log.java ! src/jdk.internal.le/share/classes/jdk/internal/org/jline/utils/NonBlockingPumpInputStream.java ! src/jdk.internal.le/share/classes/jdk/internal/org/jline/utils/NonBlockingPumpReader.java ! src/jdk.internal.le/share/classes/jdk/internal/org/jline/utils/PumpReader.java ! src/jdk.internal.le/share/classes/jdk/internal/org/jline/utils/Signals.java ! src/jdk.internal.le/share/classes/jdk/internal/org/jline/utils/StyleResolver.java + src/jdk.internal.le/share/classes/jdk/internal/org/jline/utils/rxvt-basic.caps + src/jdk.internal.le/share/classes/jdk/internal/org/jline/utils/rxvt-unicode-256color.caps + src/jdk.internal.le/share/classes/jdk/internal/org/jline/utils/rxvt-unicode.caps + src/jdk.internal.le/share/classes/jdk/internal/org/jline/utils/rxvt.caps ! src/jdk.internal.le/share/legal/jline.md ! src/jdk.internal.le/windows/classes/jdk/internal/org/jline/terminal/impl/jna/JnaSupportImpl.java ! src/jdk.internal.le/windows/classes/jdk/internal/org/jline/terminal/impl/jna/win/JnaWinSysTerminal.java ! test/jdk/jdk/internal/jline/AbstractWindowsTerminalTest.java ! test/jdk/jdk/internal/jline/KeyConversionTest.java Changeset: 5ffb5d10 Author: Andrey Turbanov Committer: Pavel Rappo Date: 2021-10-13 11:34:24 +0000 URL: https://git.openjdk.java.net/loom/commit/5ffb5d100f3383f9afaf20c8a659971522153505 8272992: Replace usages of Collections.sort with List.sort call in jdk.* modules Reviewed-by: cjplummer, prappo ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/ClassUseWriter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/util/Group.java ! src/jdk.jcmd/share/classes/sun/tools/jstat/JStatLogger.java ! src/jdk.jcmd/share/classes/sun/tools/jstat/Jstat.java ! src/jdk.jconsole/share/classes/sun/tools/jconsole/inspector/XOpenTypeViewer.java Changeset: 451a2965 Author: Jie Fu Date: 2021-10-13 14:30:11 +0000 URL: https://git.openjdk.java.net/loom/commit/451a296510994ff9fe1e0381900ffa9a8a1caa54 8275173: testlibrary_tests/ir_framework/tests/TestCheckedTests.java fails after JDK-8274911 Reviewed-by: chagedorn, thartmann ! test/hotspot/jtreg/testlibrary_tests/ir_framework/tests/TestCheckedTests.java Changeset: d8f6b6c1 Author: Fairoz Matte Committer: Ioi Lam Date: 2021-10-13 15:38:36 +0000 URL: https://git.openjdk.java.net/loom/commit/d8f6b6c19a591512ff4e956823cb87a83e088ae8 8274718: runtime/cds/appcds/LambdaEagerInit.java fails with -XX:-CompactStrings Reviewed-by: iklam, ccheung ! test/hotspot/jtreg/runtime/cds/appcds/LambdaEagerInit.java Changeset: 7deef414 Author: Ron Pressler Date: 2021-10-15 15:07:34 +0000 URL: https://git.openjdk.java.net/loom/commit/7deef414ec750529beaf37fffc7e1b57393e648a Merge branch 'master' into fibers ! make/autoconf/configure.ac ! make/autoconf/spec.gmk.in ! make/conf/jib-profiles.js ! make/data/jdwp/jdwp.spec ! src/hotspot/cpu/aarch64/aarch64.ad ! src/hotspot/cpu/aarch64/stubGenerator_aarch64.cpp ! src/hotspot/cpu/x86/macroAssembler_x86.cpp ! src/hotspot/cpu/x86/macroAssembler_x86.hpp ! src/hotspot/cpu/x86/stubGenerator_x86_64.cpp ! src/hotspot/os/windows/os_windows.cpp ! src/hotspot/share/classfile/javaClasses.cpp ! src/hotspot/share/classfile/javaClasses.inline.hpp ! src/hotspot/share/code/codeBlob.cpp ! src/hotspot/share/code/nmethod.cpp ! src/hotspot/share/gc/g1/g1CollectedHeap.hpp ! src/hotspot/share/gc/g1/g1CollectedHeap.inline.hpp ! src/hotspot/share/gc/g1/g1ParScanThreadState.cpp ! src/hotspot/share/gc/shared/space.cpp ! src/hotspot/share/gc/z/zNMethod.cpp ! src/hotspot/share/memory/universe.cpp ! src/hotspot/share/oops/instanceStackChunkKlass.inline.hpp ! src/hotspot/share/oops/objArrayOop.hpp ! src/hotspot/share/oops/oop.cpp ! src/hotspot/share/oops/oop.hpp ! src/hotspot/share/oops/oop.inline.hpp ! src/hotspot/share/oops/stackChunkOop.inline.hpp ! src/hotspot/share/oops/typeArrayOop.hpp ! src/hotspot/share/opto/compile.cpp ! src/hotspot/share/opto/library_call.cpp ! src/hotspot/share/prims/jvm.cpp ! src/hotspot/share/prims/jvmtiEnv.cpp ! src/hotspot/share/runtime/arguments.cpp ! src/hotspot/share/runtime/globals.hpp ! src/hotspot/share/runtime/handshake.cpp ! src/hotspot/share/runtime/mutexLocker.cpp ! src/hotspot/share/runtime/safepoint.hpp ! src/hotspot/share/runtime/thread.cpp ! src/hotspot/share/runtime/thread.hpp ! src/hotspot/share/runtime/thread.inline.hpp ! src/hotspot/share/runtime/vmOperations.cpp ! src/hotspot/share/runtime/vmStructs.cpp ! src/hotspot/share/services/heapDumper.cpp ! src/hotspot/share/utilities/vmError.cpp ! src/java.base/share/classes/java/io/FileInputStream.java ! src/java.base/share/classes/java/net/InetAddress.java ! src/java.base/share/classes/java/util/concurrent/ForkJoinPool.java ! src/java.base/share/classes/java/util/jar/JarFile.java ! src/java.base/share/classes/jdk/internal/reflect/NativeConstructorAccessorImpl.java ! src/java.base/share/classes/jdk/internal/reflect/NativeMethodAccessorImpl.java ! src/java.base/unix/native/libnio/fs/UnixNativeDispatcher.c ! src/java.base/windows/classes/java/io/WinNTFileSystem.java ! src/jdk.jdi/share/classes/com/sun/tools/jdi/EventRequestManagerImpl.java ! src/jdk.jdi/share/classes/com/sun/tools/jdi/ThreadReferenceImpl.java ! src/jdk.jdi/share/classes/com/sun/tools/jdi/VirtualMachineImpl.java ! test/hotspot/jtreg/ProblemList.txt ! test/jdk/ProblemList.txt ! test/jdk/TEST.groups ! make/autoconf/configure.ac ! make/autoconf/spec.gmk.in ! make/conf/jib-profiles.js ! make/data/jdwp/jdwp.spec ! src/hotspot/cpu/aarch64/aarch64.ad ! src/hotspot/cpu/aarch64/stubGenerator_aarch64.cpp ! src/hotspot/cpu/x86/macroAssembler_x86.cpp ! src/hotspot/cpu/x86/macroAssembler_x86.hpp ! src/hotspot/cpu/x86/stubGenerator_x86_64.cpp ! src/hotspot/os/windows/os_windows.cpp ! src/hotspot/share/classfile/javaClasses.cpp ! src/hotspot/share/classfile/javaClasses.inline.hpp ! src/hotspot/share/code/codeBlob.cpp ! src/hotspot/share/code/nmethod.cpp ! src/hotspot/share/gc/g1/g1CollectedHeap.hpp ! src/hotspot/share/gc/g1/g1CollectedHeap.inline.hpp ! src/hotspot/share/gc/g1/g1ParScanThreadState.cpp ! src/hotspot/share/gc/shared/space.cpp ! src/hotspot/share/gc/z/zNMethod.cpp ! src/hotspot/share/memory/universe.cpp + src/hotspot/share/oops/instanceStackChunkKlass.inline.hpp ! src/hotspot/share/oops/objArrayOop.hpp ! src/hotspot/share/oops/oop.cpp ! src/hotspot/share/oops/oop.hpp ! src/hotspot/share/oops/oop.inline.hpp + src/hotspot/share/oops/stackChunkOop.inline.hpp ! src/hotspot/share/oops/typeArrayOop.hpp ! src/hotspot/share/opto/compile.cpp ! src/hotspot/share/opto/library_call.cpp ! src/hotspot/share/prims/jvm.cpp ! src/hotspot/share/prims/jvmtiEnv.cpp ! src/hotspot/share/runtime/arguments.cpp ! src/hotspot/share/runtime/globals.hpp ! src/hotspot/share/runtime/handshake.cpp ! src/hotspot/share/runtime/mutexLocker.cpp ! src/hotspot/share/runtime/safepoint.hpp ! src/hotspot/share/runtime/thread.cpp ! src/hotspot/share/runtime/thread.hpp ! src/hotspot/share/runtime/thread.inline.hpp ! src/hotspot/share/runtime/vmOperations.cpp ! src/hotspot/share/runtime/vmStructs.cpp ! src/hotspot/share/services/heapDumper.cpp ! src/hotspot/share/utilities/vmError.cpp ! src/java.base/share/classes/java/io/FileInputStream.java ! src/java.base/share/classes/java/net/InetAddress.java ! src/java.base/share/classes/java/util/concurrent/ForkJoinPool.java ! src/java.base/share/classes/java/util/jar/JarFile.java ! src/java.base/share/classes/jdk/internal/reflect/NativeConstructorAccessorImpl.java ! src/java.base/share/classes/jdk/internal/reflect/NativeMethodAccessorImpl.java ! src/java.base/unix/native/libnio/fs/UnixNativeDispatcher.c ! src/java.base/windows/classes/java/io/WinNTFileSystem.java ! src/jdk.jdi/share/classes/com/sun/tools/jdi/EventRequestManagerImpl.java ! src/jdk.jdi/share/classes/com/sun/tools/jdi/ThreadReferenceImpl.java ! src/jdk.jdi/share/classes/com/sun/tools/jdi/VirtualMachineImpl.java ! test/hotspot/jtreg/ProblemList.txt ! test/jdk/ProblemList.txt ! test/jdk/TEST.groups Changeset: 5175c85b Author: Ron Pressler Date: 2021-10-15 15:10:05 +0000 URL: https://git.openjdk.java.net/loom/commit/5175c85b7485d54812b1c43da3d7e20e66589960 Merge remote-tracking branch 'origin/fibers' into fibers ! src/hotspot/share/prims/jvm.cpp ! src/java.base/share/classes/java/util/concurrent/ForkJoinPool.java ! test/hotspot/jtreg/ProblemList.txt ! src/hotspot/share/prims/jvm.cpp ! src/java.base/share/classes/java/util/concurrent/ForkJoinPool.java ! test/hotspot/jtreg/ProblemList.txt From duke at openjdk.java.net Fri Oct 15 14:31:30 2021 From: duke at openjdk.java.net (duke) Date: Fri, 15 Oct 2021 14:31:30 GMT Subject: git: openjdk/loom: master: 167 new changesets Message-ID: Changeset: 980c50dc Author: Roland Westrelin Date: 2021-09-29 14:51:33 +0000 URL: https://git.openjdk.java.net/loom/commit/980c50dc607e60e12879bd6fb7ff4034469e88d8 8272562: C2: assert(false) failed: Bad graph detected in build_loop_late Reviewed-by: chagedorn, kvn ! src/hotspot/share/opto/loopopts.cpp + test/hotspot/jtreg/compiler/loopopts/TestSunkCastOnUnreachablePath.java Changeset: edd9d1c9 Author: Weijun Wang Date: 2021-09-29 15:37:16 +0000 URL: https://git.openjdk.java.net/loom/commit/edd9d1c97b7fb50e76abc05d298c9d55db39cc1b 8274330: Incorrect encoding of the DistributionPointName object in IssuingDistributionPointExtension Reviewed-by: ascarpino ! src/java.base/share/classes/sun/security/x509/IssuingDistributionPointExtension.java + test/jdk/sun/security/x509/Extensions/IssuingDistributionPointExtensionEncoding.java Changeset: b1b66965 Author: Aleksey Shipilev Date: 2021-09-29 16:57:40 +0000 URL: https://git.openjdk.java.net/loom/commit/b1b66965f1ec6eae547cc4f70f8271bd39ded6da 8274453: (sctp) com/sun/nio/sctp/SctpChannel/CloseDescriptors.java test should be resilient to lsof warnings Reviewed-by: dfuchs ! test/jdk/com/sun/nio/sctp/SctpChannel/CloseDescriptors.java Changeset: 97b28742 Author: Pavel Rappo Date: 2021-09-29 17:09:08 +0000 URL: https://git.openjdk.java.net/loom/commit/97b28742b4d3083cadbe4dc10b625ec9fb944353 8274509: Remove stray * and stylistic . from doc comments Reviewed-by: alanb, dfuchs, lancea, iris, bpb ! src/java.base/share/classes/java/nio/file/Files.java ! src/java.base/share/classes/java/nio/file/Path.java Changeset: 79cebe2c Author: Andrey Turbanov Committer: Valerie Peng Date: 2021-09-29 18:22:40 +0000 URL: https://git.openjdk.java.net/loom/commit/79cebe2c1b1e7f43377633b62c970528cac0a786 8274050: Unnecessary Vector usage in javax.crypto Reviewed-by: valeriep ! src/java.base/share/classes/javax/crypto/CryptoPermissions.java ! src/java.base/share/classes/javax/crypto/CryptoPolicyParser.java Changeset: 97385d4f Author: Joe Darcy Date: 2021-09-29 23:02:20 +0000 URL: https://git.openjdk.java.net/loom/commit/97385d4f166fbd63a7c91d2ee28b5ed75cb02518 8274405: Suppress warnings on non-serializable non-transient instance fields in javac and javadoc Reviewed-by: prappo, jjg ! src/jdk.compiler/share/classes/com/sun/source/util/DocTreePath.java ! src/jdk.compiler/share/classes/com/sun/source/util/TreePath.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/tree/TreeInfo.java ! src/jdk.compiler/share/classes/com/sun/tools/sjavac/pubapi/PubApi.java ! src/jdk.compiler/share/classes/com/sun/tools/sjavac/pubapi/PubApiTypeParam.java ! src/jdk.compiler/share/classes/com/sun/tools/sjavac/pubapi/PubMethod.java ! src/jdk.compiler/share/classes/com/sun/tools/sjavac/pubapi/PubType.java ! src/jdk.compiler/share/classes/com/sun/tools/sjavac/pubapi/PubVar.java ! src/jdk.compiler/share/classes/com/sun/tools/sjavac/server/CompilationSubResult.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/util/DocFileIOException.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/util/ResourceIOException.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/tool/OptionException.java Changeset: 355356c4 Author: Andrey Turbanov Committer: Naoto Sato Date: 2021-09-29 23:08:23 +0000 URL: https://git.openjdk.java.net/loom/commit/355356c405adb9287b786b0b045c2eb974d2ffca 8273435: Remove redundant zero-length check in ClassDesc.of Reviewed-by: rriggs ! src/java.base/share/classes/java/lang/constant/ClassDesc.java Changeset: f8415a9b Author: Aleksey Shipilev Date: 2021-09-30 06:54:13 +0000 URL: https://git.openjdk.java.net/loom/commit/f8415a9b2f610ed431e6948c8174f6d982e5b31f 8274523: java/lang/management/MemoryMXBean/MemoryTest.java test should handle Shenandoah Reviewed-by: mchung, cjplummer ! test/jdk/java/lang/management/MemoryMXBean/MemoryTest.java Changeset: c0533ef2 Author: Aleksey Shipilev Date: 2021-09-30 06:55:24 +0000 URL: https://git.openjdk.java.net/loom/commit/c0533ef2d8e526aaec0eebe862f4bbefc159ea37 8274522: java/lang/management/ManagementFactory/MXBeanException.java test fails with Shenandoah Reviewed-by: alanb, mchung ! test/jdk/java/lang/management/ManagementFactory/MXBeanException.java Changeset: dfc557cb Author: Christian Hagedorn Date: 2021-09-30 08:29:43 +0000 URL: https://git.openjdk.java.net/loom/commit/dfc557cbea342b2991f9d129235470ac789b50a2 8274406: RunThese30M.java failed "assert(!LCA_orig->dominates(pred_block) || early->dominates(pred_block)) failed: early is high enough" Reviewed-by: kvn, thartmann ! src/hotspot/share/opto/loopopts.cpp ! test/hotspot/jtreg/compiler/loopopts/TestSinkingDivisorLostPin.java Changeset: a8210c53 Author: Martin Doerr Date: 2021-09-30 08:41:03 +0000 URL: https://git.openjdk.java.net/loom/commit/a8210c53e7af1cb558251fcb420de1b8a5461b25 8274401: C2: GraphKit::load_array_element bypasses Access API Reviewed-by: kvn, goetz, thartmann ! src/hotspot/share/opto/graphKit.cpp ! src/hotspot/share/opto/graphKit.hpp ! src/hotspot/share/opto/library_call.cpp ! src/hotspot/share/opto/stringopts.cpp Changeset: 94e31e5c Author: Severin Gehwolf Date: 2021-09-30 08:53:31 +0000 URL: https://git.openjdk.java.net/loom/commit/94e31e5ca51d1c4c253cf7ac5acd950d10c22267 8274506: TestPids.java and TestPidsLimit.java fail with podman run as root Reviewed-by: mbaesken, cjplummer ! test/hotspot/jtreg/containers/docker/TestPids.java ! test/jdk/jdk/internal/platform/docker/TestPidsLimit.java Changeset: 2f955d6f Author: Mahendra Chhipa Committer: Michael McMahon Date: 2021-09-30 11:29:20 +0000 URL: https://git.openjdk.java.net/loom/commit/2f955d6f5ba15fc2c06eaf683d1ffa3ade97521b 8273142: Remove dependancy of TestHttpServer, HttpTransaction, HttpCallback from open/test/jdk/sun/net/www/protocol/http/ tests Reviewed-by: michaelm ! test/jdk/sun/net/www/protocol/http/B6296310.java ! test/jdk/sun/net/www/protocol/http/RelativeRedirect.java ! test/jdk/sun/net/www/protocol/http/ResponseCacheStream.java ! test/jdk/sun/net/www/protocol/http/SetChunkedStreamingMode.java Changeset: bb95dda0 Author: Masanori Yano Committer: Hannes Walln?fer Date: 2021-09-30 11:33:21 +0000 URL: https://git.openjdk.java.net/loom/commit/bb95dda0ac5032e4df582f2903dcbbbbaef9e8c4 8248001: javadoc generates invalid HTML pages whose ftp:// links are broken Reviewed-by: hannesw ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/HtmlDocletWriter.java ! test/langtools/jdk/javadoc/doclet/testHrefInDocComment/TestHrefInDocComment.java + test/langtools/jdk/javadoc/doclet/testHrefInDocComment/pkg/J1.java Changeset: bfd61634 Author: Lin Zang Date: 2021-09-30 14:44:59 +0000 URL: https://git.openjdk.java.net/loom/commit/bfd616347126a802c641326a6be5a14c4cd7af90 8274196: Crashes in VM_HeapDumper::work after JDK-8252842 8274245: sun/tools/jmap/BasicJMapTest.java Mutex rank failures Reviewed-by: coleenp, pliden, cjplummer ! src/hotspot/share/services/heapDumper.cpp ! test/hotspot/jtreg/ProblemList-zgc.txt ! test/jdk/ProblemList.txt Changeset: 3e0d7c33 Author: Alex Kasko Committer: Severin Gehwolf Date: 2021-09-30 15:21:18 +0000 URL: https://git.openjdk.java.net/loom/commit/3e0d7c33d41a93496bfa6a47d1508e415930adf9 8270290: NTLM authentication fails if HEAD request is used Reviewed-by: dfuchs, michaelm ! src/java.base/share/classes/sun/net/www/protocol/http/HttpURLConnection.java + test/jdk/sun/net/www/protocol/http/NTLMHeadTest.java Changeset: 9180d9a2 Author: Severin Gehwolf Date: 2021-09-30 15:23:44 +0000 URL: https://git.openjdk.java.net/loom/commit/9180d9a2f990e71ca6ac9c14e55a21f7372929ac 8273216: JCMD does not work across container boundaries with Podman Reviewed-by: mseledtsov, hseigel ! test/hotspot/jtreg/containers/docker/TestJcmd.java Changeset: c57ed22e Author: Bradford Wetmore Date: 2021-09-30 15:46:29 +0000 URL: https://git.openjdk.java.net/loom/commit/c57ed22e779e7efc8ff7f3c7ec08ce2cb1a738cb 8274528: Add comment to explain an HKDF optimization in SSLSecretDerivation Reviewed-by: jnimeh ! src/java.base/share/classes/sun/security/ssl/SSLSecretDerivation.java Changeset: f08180f3 Author: Erik ?sterlund Date: 2021-09-30 15:52:36 +0000 URL: https://git.openjdk.java.net/loom/commit/f08180f35f18263e33d96b6d1f06e5129328f01a 8274501: c2i entry barriers read int as long on AArch64 Reviewed-by: shade, kbarrett, aph ! src/hotspot/cpu/aarch64/gc/shared/barrierSetAssembler_aarch64.cpp Changeset: 95730229 Author: Patricio Chilano Mateo Date: 2021-09-30 16:02:14 +0000 URL: https://git.openjdk.java.net/loom/commit/9573022978bfeff55b51fa6f30027f59a0783d31 8253197: vmTestbase/nsk/jvmti/StopThread/stopthrd007/TestDescription.java fails with "ERROR: DebuggeeSleepingThread: ThreadDeath lost" Reviewed-by: dholmes, cjplummer, sspitsyn ! test/hotspot/jtreg/vmTestbase/nsk/jvmti/StopThread/stopthrd007.java Changeset: 8215b2eb Author: Joe Darcy Date: 2021-09-30 16:58:53 +0000 URL: https://git.openjdk.java.net/loom/commit/8215b2eb61bd89c4041420e1c5c673603d6b2119 8274398: Suppress more warnings on non-serializable non-transient instance fields in management libs Reviewed-by: sspitsyn ! src/java.management/share/classes/javax/management/loading/MLet.java ! src/jdk.jdi/share/classes/com/sun/tools/jdi/ConnectorImpl.java ! src/jdk.jdi/share/classes/com/sun/tools/jdi/EventSetImpl.java ! src/jdk.jdi/share/classes/com/sun/tools/jdi/VMAction.java ! src/jdk.management.agent/share/classes/sun/management/jmxremote/SingleEntryRegistry.java ! src/jdk.management/share/classes/com/sun/management/internal/GarbageCollectionNotifInfoCompositeData.java ! src/jdk.management/share/classes/com/sun/management/internal/GcInfoCompositeData.java ! src/jdk.management/share/classes/com/sun/management/internal/VMOptionCompositeData.java Changeset: 73264811 Author: Joe Darcy Date: 2021-09-30 17:39:05 +0000 URL: https://git.openjdk.java.net/loom/commit/7326481143c1321700cbf2caa9e068c5077e22c4 8274393: Suppress more warnings on non-serializable non-transient instance fields in security libs Reviewed-by: weijun ! src/java.base/share/classes/com/sun/crypto/provider/PBKDF2KeyImpl.java ! src/java.xml.crypto/share/classes/com/sun/org/apache/xml/internal/security/signature/MissingResourceFailureException.java ! src/java.xml.crypto/share/classes/javax/xml/crypto/URIReferenceException.java ! src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/P11Key.java ! src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/SunPKCS11.java ! src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/Token.java ! src/jdk.crypto.ec/share/classes/sun/security/ec/ECPrivateKeyImpl.java ! src/jdk.crypto.ec/share/classes/sun/security/ec/ECPublicKeyImpl.java ! src/jdk.crypto.ec/share/classes/sun/security/ec/XDHPrivateKeyImpl.java ! src/jdk.crypto.ec/share/classes/sun/security/ec/XDHPublicKeyImpl.java ! src/jdk.crypto.ec/share/classes/sun/security/ec/ed/EdDSAPrivateKeyImpl.java ! src/jdk.crypto.ec/share/classes/sun/security/ec/ed/EdDSAPublicKeyImpl.java Changeset: a8edd1b3 Author: Jie Fu Date: 2021-09-30 23:11:56 +0000 URL: https://git.openjdk.java.net/loom/commit/a8edd1b360d4e5f35aff371a91fda42eeb00d395 8274527: Minimal VM build fails after JDK-8273459 Reviewed-by: kvn ! src/hotspot/cpu/x86/macroAssembler_x86.cpp ! src/hotspot/cpu/x86/macroAssembler_x86.hpp ! src/hotspot/cpu/x86/macroAssembler_x86_adler.cpp ! src/hotspot/cpu/x86/stubGenerator_x86_64.cpp Changeset: 2e690ba8 Author: Kim Barrett Date: 2021-10-01 00:25:35 +0000 URL: https://git.openjdk.java.net/loom/commit/2e690ba8bda30902f1188cabad63fb60f4eb828f 8274322: Problems with oopDesc construction Reviewed-by: dholmes, stefank ! src/hotspot/share/oops/instanceOop.hpp ! src/hotspot/share/oops/markWord.hpp ! src/hotspot/share/oops/objArrayOop.hpp ! src/hotspot/share/oops/oop.hpp ! src/hotspot/share/oops/typeArrayOop.hpp Changeset: 5e4b514e Author: Martin Doerr Date: 2021-10-01 08:20:51 +0000 URL: https://git.openjdk.java.net/loom/commit/5e4b514e6e7e1b9f51fac1983b6c12a988f7f5a8 8274550: c2i entry barriers read int as long on PPC Reviewed-by: eosterlund, shade ! src/hotspot/cpu/ppc/gc/shared/barrierSetAssembler_ppc.cpp Changeset: b7b78ff1 Author: Ao Qi Committer: Jie Fu Date: 2021-10-01 08:52:04 +0000 URL: https://git.openjdk.java.net/loom/commit/b7b78ff1f380d19214dbca48455772bc87cc137d 8274561: sun/net/ftp/TestFtpTimeValue.java timed out on slow machines Reviewed-by: jiefu, dfuchs ! test/jdk/sun/net/ftp/TestFtpTimeValue.java Changeset: 18870284 Author: Jan Lahoda Date: 2021-10-01 08:53:04 +0000 URL: https://git.openjdk.java.net/loom/commit/18870284084aaaf729640de0105ce21e253546b9 8269113: Javac throws when compiling switch (null) Co-authored-by: Guoxiong Li Reviewed-by: vromero ! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/TransPatterns.java ! test/langtools/tools/javac/patterns/SwitchErrors.java ! test/langtools/tools/javac/patterns/SwitchErrors.out ! test/langtools/tools/javac/patterns/Switches.java Changeset: 292d7bb1 Author: Jan Lahoda Date: 2021-10-01 08:54:18 +0000 URL: https://git.openjdk.java.net/loom/commit/292d7bb1d5d311b517b2cd6d0f6dc77e35b3f649 8274363: Transitively sealed classes not considered exhaustive in switches Reviewed-by: vromero ! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Flow.java ! test/langtools/tools/javac/patterns/Exhaustiveness.java Changeset: cc14c6f0 Author: Aleksei Efimov Date: 2021-10-01 09:48:09 +0000 URL: https://git.openjdk.java.net/loom/commit/cc14c6f076356731f78aea4e890027f4e2a91642 8274227: Remove "impl.prefix" jdk system property usage from InetAddress Reviewed-by: alanb, dfuchs ! src/java.base/share/classes/java/net/Inet4AddressImpl.java ! src/java.base/share/classes/java/net/Inet6AddressImpl.java ! src/java.base/share/classes/java/net/InetAddress.java ! src/java.base/share/classes/java/net/InetAddressImpl.java Changeset: c05dc268 Author: Ekaterina Vergizova Committer: Yuri Nesterenko Date: 2021-10-01 12:53:08 +0000 URL: https://git.openjdk.java.net/loom/commit/c05dc268acaf87236f30cf700ea3ac778e3b20e5 8274435: EXCEPTION_ACCESS_VIOLATION in BFSClosure::closure_impl Reviewed-by: stefank ! src/hotspot/share/jfr/leakprofiler/chains/bitset.cpp Changeset: 3d7671b6 Author: Brian Burkhalter Date: 2021-10-01 15:30:55 +0000 URL: https://git.openjdk.java.net/loom/commit/3d7671b65e8491f3b1fcac8b96401401f783c9f4 8274562: (fs) UserDefinedFileAttributeView doesn't correctly determine if supported when using OverlayFS Reviewed-by: alanb ! src/java.base/unix/native/libnio/fs/UnixNativeDispatcher.c Changeset: 05d38604 Author: Pavel Rappo Date: 2021-10-01 16:15:48 +0000 URL: https://git.openjdk.java.net/loom/commit/05d38604a2c620dcaf8682f02dae2fddab8e0c0b 8274605: Fix predicate guarantees on returned values in (Doc)SourcePositions Reviewed-by: jlahoda, jjg ! src/jdk.compiler/share/classes/com/sun/source/util/DocSourcePositions.java ! src/jdk.compiler/share/classes/com/sun/source/util/SourcePositions.java Changeset: bb4500d0 Author: Alexey Ivanov Date: 2021-10-01 18:41:51 +0000 URL: https://git.openjdk.java.net/loom/commit/bb4500d0d227cbb238bd6c862e143f864106a31a 8274465: Fix javax/swing/text/ParagraphView/6364882/bug6364882.java failures Reviewed-by: jiefu, serb ! test/jdk/javax/swing/text/ParagraphView/6364882/bug6364882.java Changeset: 0786d8b7 Author: Brian Burkhalter Date: 2021-10-01 20:15:44 +0000 URL: https://git.openjdk.java.net/loom/commit/0786d8b7b367e3aa3ffa54a3e339572938378dca 8268435: (ch) ChannelInputStream could override readAllBytes Reviewed-by: alanb, lancea ! src/java.base/share/classes/java/io/FileInputStream.java ! src/java.base/share/classes/sun/nio/ch/ChannelInputStream.java + test/jdk/java/nio/channels/Channels/ReadXBytes.java Changeset: 9ca6bf0d Author: Andrey Turbanov Committer: Sergey Bylokhov Date: 2021-10-02 03:06:29 +0000 URL: https://git.openjdk.java.net/loom/commit/9ca6bf0d22ac39d4ee29c756903038f09087ca12 8274505: Too weak variable type leads to unnecessary cast in java.desktop Reviewed-by: serb, kizune, pbansal ! src/java.desktop/share/classes/com/sun/media/sound/SoftSynthesizer.java ! src/java.desktop/share/classes/javax/swing/JFormattedTextField.java ! src/java.desktop/share/classes/javax/swing/JRootPane.java ! src/java.desktop/share/classes/javax/swing/JTree.java ! src/java.desktop/share/classes/javax/swing/plaf/synth/SynthParser.java ! src/java.desktop/share/classes/javax/swing/text/html/AccessibleHTML.java ! src/java.desktop/share/classes/javax/swing/text/html/HTMLDocument.java ! src/java.desktop/share/classes/javax/swing/text/html/HTMLEditorKit.java ! src/java.desktop/share/classes/javax/swing/text/rtf/RTFGenerator.java ! src/java.desktop/share/classes/sun/awt/SunToolkit.java ! src/java.desktop/share/classes/sun/java2d/Disposer.java Changeset: 79579942 Author: Robbin Ehn Date: 2021-10-04 06:47:27 +0000 URL: https://git.openjdk.java.net/loom/commit/7957994273e20d541b8f2a873781be7fedf712f1 8273695: Safepoint deadlock on VMOperation_lock Reviewed-by: dcubed, pchilanomate, eosterlund ! src/hotspot/share/runtime/safepointMechanism.hpp ! src/hotspot/share/runtime/safepointMechanism.inline.hpp ! src/hotspot/share/runtime/stackWatermarkSet.cpp ! src/hotspot/share/runtime/stackWatermarkSet.hpp ! test/hotspot/jtreg/ProblemList.txt Changeset: 32811026 Author: Prasanta Sadhukhan Date: 2021-10-04 06:49:10 +0000 URL: https://git.openjdk.java.net/loom/commit/32811026ce5ecb1d27d835eac33de9ccbd51fcbf 8268084: [macos] Disabled JMenuItem arrow is not disabled Reviewed-by: serb, jdv ! src/java.desktop/macosx/classes/com/apple/laf/AquaImageFactory.java + test/jdk/javax/swing/plaf/aqua/JMenuItemDisableArrowButtonTest.java Changeset: 6726c592 Author: Andrey Turbanov Committer: Pankaj Bansal Date: 2021-10-04 10:27:20 +0000 URL: https://git.openjdk.java.net/loom/commit/6726c592ed01b112f5eb85d8f1e4406b25c8df2b 8274634: Use String.equals instead of String.compareTo in java.desktop Reviewed-by: serb, pbansal ! src/java.desktop/macosx/classes/sun/lwawt/macosx/CAccessible.java ! src/java.desktop/share/classes/javax/swing/JList.java ! src/java.desktop/share/classes/javax/swing/JTable.java Changeset: 0828273b Author: Aleksey Shipilev Date: 2021-10-04 12:22:55 +0000 URL: https://git.openjdk.java.net/loom/commit/0828273b898cca5368344e75f1c3f4c3a29dde80 8274521: jdk/jfr/event/gc/detailed/TestGCLockerEvent.java fails when other GC is selected Reviewed-by: kbarrett, tschatzl ! test/jdk/jdk/jfr/event/gc/detailed/TestGCLockerEvent.java Changeset: 47bfc8aa Author: Aleksey Shipilev Date: 2021-10-04 12:35:58 +0000 URL: https://git.openjdk.java.net/loom/commit/47bfc8aa9367ff852ea5d901f1fa3c6ef316913e 8274563: jfr/event/oldobject/TestClassLoaderLeak.java fails when GC cycles are not happening Reviewed-by: egahlin ! test/jdk/jdk/jfr/event/oldobject/TestClassLoaderLeak.java Changeset: 7eb0372e Author: Alex Kasko Committer: Aleksey Shipilev Date: 2021-10-04 12:38:34 +0000 URL: https://git.openjdk.java.net/loom/commit/7eb0372e55f23275b12470593adc97f1b79bc965 8274606: Fix jaxp/javax/xml/jaxp/unittest/transform/SurrogateTest.java test Reviewed-by: joehw, shade ! test/jaxp/javax/xml/jaxp/unittest/transform/SurrogateTest.java Changeset: f2404d60 Author: Naoto Sato Date: 2021-10-04 15:06:48 +0000 URL: https://git.openjdk.java.net/loom/commit/f2404d60de2b58c590bf885f5cce50c289073673 8274658: ISO 4217 Amendment 170 Update Reviewed-by: lancea, iris ! make/data/currency/CurrencyData.properties ! src/java.base/share/classes/sun/util/resources/CurrencyNames.properties ! test/jdk/java/util/Currency/ValidateISO4217.java ! test/jdk/java/util/Currency/tablea1.txt ! test/jdk/sun/text/resources/LocaleData ! test/jdk/sun/text/resources/LocaleDataTest.java Changeset: f63c4a83 Author: Weijun Wang Date: 2021-10-04 15:30:44 +0000 URL: https://git.openjdk.java.net/loom/commit/f63c4a832a1aea451f47aaf86d5361e970c6a28f 8274471: Verification of OCSP Response signed with RSASSA-PSS fails Reviewed-by: hchao, jnimeh ! src/java.base/share/classes/sun/security/provider/certpath/OCSP.java ! src/java.base/share/classes/sun/security/provider/certpath/OCSPResponse.java ! src/java.base/share/classes/sun/security/util/SignatureUtil.java ! src/java.base/share/classes/sun/security/x509/AlgorithmId.java ! src/java.base/share/classes/sun/security/x509/X509CRLImpl.java ! src/java.base/share/classes/sun/security/x509/X509CertImpl.java ! test/jdk/java/security/testlibrary/CertificateBuilder.java ! test/jdk/java/security/testlibrary/SimpleOCSPServer.java ! test/jdk/javax/net/ssl/Stapling/HttpsUrlConnClient.java Changeset: 139a8334 Author: Adam Sotona Date: 2021-10-04 15:48:09 +0000 URL: https://git.openjdk.java.net/loom/commit/139a8334cbc0c8e1a7a708efe18bd488d28292fd 8268869: java in source-file mode suggests javac-only Xlint flags Reviewed-by: jjg ! src/jdk.compiler/share/classes/com/sun/tools/javac/launcher/Main.java ! test/langtools/tools/javac/launcher/SourceLauncherTest.java Changeset: 6f727d83 Author: Jonathan Gibbons Date: 2021-10-04 16:58:23 +0000 URL: https://git.openjdk.java.net/loom/commit/6f727d831d8f8fb9b44f4c6bdbdd6ae44316a5d8 8274666: rename HtmlStyle.descfrmTypeLabel to be less cryptic Reviewed-by: hannesw ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/Contents.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/MethodWriterImpl.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/PropertyWriterImpl.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/markup/HtmlStyle.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/resources/stylesheet.css ! test/langtools/jdk/javadoc/doclet/testInterface/TestInterface.java ! test/langtools/jdk/javadoc/doclet/testOptions/custom-stylesheet.css ! test/langtools/jdk/javadoc/doclet/testOverriddenMethods/TestOverriddenMethodDocCopy.java ! test/langtools/jdk/javadoc/doclet/testOverriddenMethods/TestOverrideMethods.java ! test/langtools/jdk/javadoc/doclet/testPrivateClasses/TestPrivateClasses.java ! test/langtools/jdk/javadoc/doclet/testReturnTag/TestReturnTag.java Changeset: 0ca094bc Author: Jonathan Gibbons Date: 2021-10-04 16:59:30 +0000 URL: https://git.openjdk.java.net/loom/commit/0ca094bc5f568842b1619229206ec4a385e5ebf6 8273244: Improve diagnostic output related to ErroneousTree Reviewed-by: prappo ! src/jdk.compiler/share/classes/com/sun/tools/javac/api/JavacTrees.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/parser/DocCommentParser.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/parser/ReferenceParser.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/tree/DCTree.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/tree/DocTreeMaker.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/util/AbstractLog.java ! src/jdk.compiler/share/classes/jdk/internal/shellsupport/doc/JavadocHelper.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclint/DocLint.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/tool/JavadocLog.java ! test/langtools/tools/doclint/CrashInAnnotateTest.out ! test/langtools/tools/doclint/EndWithIdentifierTest.out ! test/langtools/tools/doclint/UnfinishedInlineTagTest.out ! test/langtools/tools/doclint/tidy/README.txt ! test/langtools/tools/doclint/tidy/UnescapedOrUnknownEntity.out ! test/langtools/tools/javac/doctree/AttrTest.java ! test/langtools/tools/javac/doctree/AuthorTest.java ! test/langtools/tools/javac/doctree/BadTest.java ! test/langtools/tools/javac/doctree/CodeTest.java + test/langtools/tools/javac/doctree/CoverageTest.java ! test/langtools/tools/javac/doctree/DeprecatedTest.java ! test/langtools/tools/javac/doctree/DocCommentTester.java ! test/langtools/tools/javac/doctree/DocRootTest.java ! test/langtools/tools/javac/doctree/ElementTest.java ! test/langtools/tools/javac/doctree/EntityTest.java ! test/langtools/tools/javac/doctree/ExceptionTest.java ! test/langtools/tools/javac/doctree/FirstSentenceTest.java ! test/langtools/tools/javac/doctree/HiddenTest.java ! test/langtools/tools/javac/doctree/InPreTest.java ! test/langtools/tools/javac/doctree/IndexTest.java ! test/langtools/tools/javac/doctree/InheritDocTest.java ! test/langtools/tools/javac/doctree/LinkPlainTest.java ! test/langtools/tools/javac/doctree/LinkTest.java ! test/langtools/tools/javac/doctree/LiteralTest.java ! test/langtools/tools/javac/doctree/ParamTest.java ! test/langtools/tools/javac/doctree/ProvidesTest.java ! test/langtools/tools/javac/doctree/ReturnTest.java ! test/langtools/tools/javac/doctree/SeeTest.java ! test/langtools/tools/javac/doctree/SerialDataTest.java ! test/langtools/tools/javac/doctree/SerialFieldTest.java ! test/langtools/tools/javac/doctree/SerialTest.java ! test/langtools/tools/javac/doctree/SinceTest.java ! test/langtools/tools/javac/doctree/SummaryTest.java ! test/langtools/tools/javac/doctree/SystemPropertyTest.java ! test/langtools/tools/javac/doctree/TagTest.java ! test/langtools/tools/javac/doctree/ThrowableTest.java ! test/langtools/tools/javac/doctree/UsesTest.java ! test/langtools/tools/javac/doctree/ValueTest.java ! test/langtools/tools/javac/doctree/VersionTest.java ! test/langtools/tools/javac/doctree/positions/TestPosition.java ! test/langtools/tools/javac/tree/AbstractTreeScannerTest.java Changeset: 9914e5c4 Author: Mikhailo Seledtsov Date: 2021-10-04 17:20:05 +0000 URL: https://git.openjdk.java.net/loom/commit/9914e5c416b518f408837e31ba0a35138bfcadc7 8274610: Add linux-aarch64 to bootcycle build profiles Reviewed-by: erikj ! make/conf/jib-profiles.js Changeset: 75d6688d Author: Jonathan Gibbons Date: 2021-10-04 19:00:21 +0000 URL: https://git.openjdk.java.net/loom/commit/75d6688df9845ecb8f370b4cd2d5a36f13d3cdc0 8274745: ProblemList TestSnippetTag.java Reviewed-by: prappo ! test/langtools/ProblemList.txt Changeset: 7e757f6a Author: Erik Gahlin Date: 2021-10-04 21:19:19 +0000 URL: https://git.openjdk.java.net/loom/commit/7e757f6a2cbfd03ba9ac602b800d15ba33f6f5f4 8274559: JFR: Typo in 'jfr help configure' text Reviewed-by: iris, mikael ! src/jdk.jfr/share/classes/jdk/jfr/internal/tool/Configure.java Changeset: 2e542e33 Author: David Holmes Date: 2021-10-04 23:14:12 +0000 URL: https://git.openjdk.java.net/loom/commit/2e542e33b81a53652956bb5e9636e7f4af5540f7 8274349: ForkJoinPool.commonPool() does not work with 1 CPU Co-authored-by: Doug Lea
Reviewed-by: shade, martin ! src/java.base/share/classes/java/util/concurrent/ForkJoinPool.java + test/jdk/java/util/concurrent/forkjoin/Uniprocessor.java ! test/jdk/java/util/concurrent/tck/ForkJoinPoolTest.java Changeset: e43f540c Author: Andrey Turbanov Committer: Sergey Bylokhov Date: 2021-10-05 00:53:17 +0000 URL: https://git.openjdk.java.net/loom/commit/e43f540cde58ee973b97a943f14d3c60e064b801 8274651: Possible race in FontDesignMetrics.KeyReference.dispose Reviewed-by: prr, serb ! src/java.desktop/share/classes/sun/font/FontDesignMetrics.java Changeset: 53d7e95b Author: Andrey Turbanov Committer: Sergey Bylokhov Date: 2021-10-05 06:39:29 +0000 URL: https://git.openjdk.java.net/loom/commit/53d7e95bc637c8b629efc4587b2ae7961d719b00 8274635: Use String.equals instead of String.compareTo in jdk.accessibility Reviewed-by: serb ! src/jdk.accessibility/share/classes/com/sun/java/accessibility/util/AccessibilityEventMonitor.java ! src/jdk.accessibility/windows/classes/com/sun/java/accessibility/internal/AccessBridge.java Changeset: 3953e077 Author: Christian Hagedorn Date: 2021-10-05 07:02:06 +0000 URL: https://git.openjdk.java.net/loom/commit/3953e0774c59c5e936e752aa08b6b6778e232994 8271459: C2: Missing NegativeArraySizeException when creating StringBuilder with negative capacity Reviewed-by: roland, thartmann, neliasso ! src/hotspot/share/opto/stringopts.cpp + test/hotspot/jtreg/compiler/c2/irTests/stringopts/TestNegativeArraySize.java ! test/hotspot/jtreg/compiler/lib/ir_framework/IRNode.java ! test/hotspot/jtreg/testlibrary_tests/ir_framework/tests/TestIRMatching.java Changeset: 8f7a37c9 Author: Matthias Baesken Date: 2021-10-05 07:25:00 +0000 URL: https://git.openjdk.java.net/loom/commit/8f7a37c92f5713f7728f54d4a5924484a535e968 8274434: move os::get_default_process_handle and os::dll_lookup to os_posix for POSIX platforms Reviewed-by: dholmes, lucy ! src/hotspot/os/aix/os_aix.cpp ! src/hotspot/os/bsd/os_bsd.cpp ! src/hotspot/os/linux/os_linux.cpp ! src/hotspot/os/posix/os_posix.cpp Changeset: a914ee72 Author: Kim Barrett Date: 2021-10-05 08:07:02 +0000 URL: https://git.openjdk.java.net/loom/commit/a914ee72167f642b76b1c1cdddd7ff0698d061cc 8274632: Possible pointer overflow in PretouchTask chunk claiming Reviewed-by: tschatzl, ayang ! src/hotspot/share/gc/shared/pretouchTask.cpp ! src/hotspot/share/gc/shared/pretouchTask.hpp Changeset: a5080eff Author: Jan Lahoda Date: 2021-10-05 10:17:24 +0000 URL: https://git.openjdk.java.net/loom/commit/a5080effc7ec7e260e84e3169c36c5217f18d231 8272564: Incorrect attribution of method invocations of Object methods on interfaces Reviewed-by: jlaskey, mcimadamore, vromero ! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Attr.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Resolve.java ! test/langtools/tools/javac/api/TestGetElementReference.java ! test/langtools/tools/javac/api/TestGetElementReferenceData.java + test/langtools/tools/javac/api/TestIsAccessible.java + test/langtools/tools/javac/resolve/NoObjectToString.java Changeset: 8609ea55 Author: Harold Seigel Date: 2021-10-05 12:39:56 +0000 URL: https://git.openjdk.java.net/loom/commit/8609ea55acdcc203408f58f7bf96ea9228aef613 8273342: Null pointer dereference in classFileParser.cpp:2817 Reviewed-by: coleenp, dholmes ! src/hotspot/share/runtime/fieldDescriptor.cpp Changeset: 1459180f Author: Andrey Turbanov Committer: Weijun Wang Date: 2021-10-05 13:36:37 +0000 URL: https://git.openjdk.java.net/loom/commit/1459180f352a5632c0afca2ed55abf31e4b0bfb0 8274079: Cleanup unnecessary calls to Throwable.initCause() in java.base module Reviewed-by: weijun ! src/java.base/share/classes/com/sun/crypto/provider/AESCipher.java ! src/java.base/share/classes/com/sun/crypto/provider/ConstructKeys.java ! src/java.base/share/classes/com/sun/crypto/provider/DESedeWrapCipher.java ! src/java.base/share/classes/com/sun/crypto/provider/DHPrivateKey.java ! src/java.base/share/classes/com/sun/crypto/provider/PBES2Core.java ! src/java.base/share/classes/com/sun/crypto/provider/PBEWithMD5AndDESCipher.java ! src/java.base/share/classes/com/sun/crypto/provider/PBEWithMD5AndTripleDESCipher.java ! src/java.base/share/classes/com/sun/crypto/provider/PBKDF2Core.java ! src/java.base/share/classes/com/sun/crypto/provider/PBKDF2HmacSHA1Factory.java ! src/java.base/share/classes/com/sun/crypto/provider/PBKDF2KeyImpl.java ! src/java.base/share/classes/com/sun/crypto/provider/PBMAC1Core.java ! src/java.base/share/classes/com/sun/crypto/provider/RSACipher.java ! src/java.base/share/classes/java/io/ObjectStreamClass.java ! src/java.base/share/classes/java/security/cert/TrustAnchor.java ! src/java.base/share/classes/java/security/cert/X509CRLSelector.java ! src/java.base/share/classes/java/time/Duration.java ! src/java.base/share/classes/javax/net/ssl/SSLContext.java ! src/java.base/share/classes/javax/security/auth/login/Configuration.java ! src/java.base/share/classes/javax/security/auth/x500/X500Principal.java ! src/java.base/share/classes/sun/security/provider/DigestBase.java ! src/java.base/share/classes/sun/security/provider/JavaKeyStore.java ! src/java.base/share/classes/sun/security/util/HostnameChecker.java Changeset: 7ad74d82 Author: Peter Levart Date: 2021-10-05 14:16:20 +0000 URL: https://git.openjdk.java.net/loom/commit/7ad74d82d7117113dd73966a0dd96168adfd6463 8274299: Make Method/Constructor/Field accessors @Stable Reviewed-by: redestad, mchung ! src/java.base/share/classes/java/lang/reflect/Constructor.java ! src/java.base/share/classes/java/lang/reflect/Field.java ! src/java.base/share/classes/java/lang/reflect/Method.java ! src/java.base/share/classes/jdk/internal/reflect/DelegatingConstructorAccessorImpl.java ! src/java.base/share/classes/jdk/internal/reflect/DelegatingMethodAccessorImpl.java ! src/java.base/share/classes/jdk/internal/reflect/FieldAccessorImpl.java ! src/java.base/share/classes/jdk/internal/reflect/NativeConstructorAccessorImpl.java ! src/java.base/share/classes/jdk/internal/reflect/NativeMethodAccessorImpl.java ! src/java.base/share/classes/jdk/internal/reflect/ReflectionFactory.java ! src/java.base/share/classes/jdk/internal/reflect/UnsafeFieldAccessorImpl.java ! src/java.base/share/classes/jdk/internal/reflect/UnsafeStaticFieldAccessorImpl.java + test/micro/org/openjdk/bench/java/lang/reflect/ReflectionColdstartBenchmark.java + test/micro/org/openjdk/bench/java/lang/reflect/ReflectionSpeedBenchmark.java Changeset: bb0bab57 Author: Albert Mingkun Yang Date: 2021-10-05 14:31:17 +0000 URL: https://git.openjdk.java.net/loom/commit/bb0bab57a1ff447bfb41cfe10c91838a6812b93d 8274286: Skip null for make_referent_alive in referenceProcessor Reviewed-by: kbarrett, tschatzl ! src/hotspot/share/gc/shared/referenceProcessor.cpp Changeset: 90a5ae80 Author: Coleen Phillimore Date: 2021-10-05 15:13:54 +0000 URL: https://git.openjdk.java.net/loom/commit/90a5ae802e6ef0a6d0a5096a595b0680069960c3 8274282: Clarify special wait assert Reviewed-by: dholmes, pchilanomate ! src/hotspot/share/runtime/mutex.cpp ! test/hotspot/gtest/runtime/test_mutex.cpp Changeset: 92b64a20 Author: Jonathan Gibbons Date: 2021-10-05 15:21:44 +0000 URL: https://git.openjdk.java.net/loom/commit/92b64a2053e3f3e0314ed489b92afd37c285ac5f 8273745: VerifyLocale.java occasionally times out Reviewed-by: prappo ! test/langtools/jdk/javadoc/tool/VerifyLocale.java Changeset: 4e3948f1 Author: Jonathan Gibbons Date: 2021-10-05 15:27:02 +0000 URL: https://git.openjdk.java.net/loom/commit/4e3948f18b9b8dab96239ad24473134b712ada1a 8274744: TestSnippetTag test fails after recent integration Reviewed-by: prappo ! test/langtools/ProblemList.txt ! test/langtools/jdk/javadoc/doclet/testSnippetTag/TestSnippetTag.java Changeset: e1f0df0d Author: Hannes Walln?fer Date: 2021-10-05 16:57:12 +0000 URL: https://git.openjdk.java.net/loom/commit/e1f0df0de3b205cecdb1aa1d74562536c06097dd 8267853: Remove unused styles from stylesheet Reviewed-by: prappo ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/resources/stylesheet.css ! test/langtools/jdk/javadoc/doclet/checkStylesheetClasses/CheckStylesheetClasses.java ! test/langtools/jdk/javadoc/doclet/testStylesheet/TestStylesheet.java Changeset: 37890650 Author: Phil Race Date: 2021-10-05 17:30:31 +0000 URL: https://git.openjdk.java.net/loom/commit/37890650a7c97d484b6b520d909f677dac4e46e1 8274397: [macOS] Stop setting env. var JAVA_MAIN_CLASS_ in launcher code Reviewed-by: rriggs, serb ! src/java.base/macosx/native/libjli/java_md_macosx.m ! src/java.desktop/macosx/native/libosxapp/NSApplicationAWT.m + test/jdk/tools/launcher/MacOSAppNamePropertyTest.java + test/jdk/tools/launcher/SystemPropertyTest.java ! test/jdk/tools/launcher/TestSpecialArgs.java Changeset: c391e59e Author: Joe Darcy Date: 2021-10-05 17:31:57 +0000 URL: https://git.openjdk.java.net/loom/commit/c391e59ea6fe6759553425e342b2d97824dd9323 8274244: ReportOnImportedModuleAnnotation.java fails on rerun Reviewed-by: jjg ! test/langtools/tools/javac/processing/ReportOnImportedModuleAnnotation/ReportOnImportedModuleAnnotation.java Changeset: 03d3c033 Author: Weijun Wang Date: 2021-10-05 18:18:51 +0000 URL: https://git.openjdk.java.net/loom/commit/03d3c0338437bf10b631881c8910ca85985742f6 8273670: Remove weak etypes from default krb5 etype list Reviewed-by: valeriep, mullan ! src/java.security.jgss/share/classes/sun/security/krb5/internal/crypto/EType.java ! test/jdk/sun/security/krb5/auto/DupEtypes.java ! test/jdk/sun/security/krb5/auto/OneKDC.java ! test/jdk/sun/security/krb5/auto/W83.java ! test/jdk/sun/security/krb5/config/YesNo.java ! test/jdk/sun/security/krb5/config/yesno.conf ! test/jdk/sun/security/krb5/etype/WeakCrypto.java Changeset: 1e752033 Author: Weijun Wang Date: 2021-10-05 18:19:45 +0000 URL: https://git.openjdk.java.net/loom/commit/1e75203356666a3213deddd775ad1e883ea6d78d 8274656: Remove default_checksum and safe_checksum_type from krb5.conf Reviewed-by: valeriep ! src/java.security.jgss/share/classes/sun/security/krb5/Checksum.java ! src/java.security.jgss/share/classes/sun/security/krb5/Config.java ! src/java.security.jgss/share/classes/sun/security/krb5/EncryptedData.java - src/java.security.jgss/share/classes/sun/security/krb5/KrbAppMessage.java - src/java.security.jgss/share/classes/sun/security/krb5/KrbPriv.java - src/java.security.jgss/share/classes/sun/security/krb5/KrbSafe.java ! src/java.security.jgss/share/classes/sun/security/krb5/KrbTgsReq.java - src/java.security.jgss/share/classes/sun/security/krb5/internal/AuthContext.java - src/java.security.jgss/share/classes/sun/security/krb5/internal/EncKrbPrivPart.java - src/java.security.jgss/share/classes/sun/security/krb5/internal/KRBPriv.java - src/java.security.jgss/share/classes/sun/security/krb5/internal/KRBSafe.java - src/java.security.jgss/share/classes/sun/security/krb5/internal/KRBSafeBody.java - src/java.security.jgss/share/classes/sun/security/krb5/internal/MethodData.java Changeset: 332f0673 Author: Jonathan Gibbons Date: 2021-10-05 18:54:19 +0000 URL: https://git.openjdk.java.net/loom/commit/332f0673880d547a5f09cb4efd3b952868a84b91 8274729: Define Position.NOPOS == Diagnostic.NOPOS Reviewed-by: jlahoda ! src/jdk.compiler/share/classes/com/sun/tools/javac/util/Position.java Changeset: d34ec6cc Author: Joe Darcy Date: 2021-10-05 19:10:29 +0000 URL: https://git.openjdk.java.net/loom/commit/d34ec6ccfc27d9401acce0e03595b910764fbfaf 8274793: Suppress warnings on non-serializable non-transient instance fields in sun.net Reviewed-by: alanb ! src/java.base/share/classes/sun/net/www/http/KeepAliveCache.java ! src/java.base/unix/classes/sun/net/www/protocol/http/ntlm/NTLMAuthentication.java Changeset: 83b22192 Author: Igor Veresov Date: 2021-10-05 19:44:17 +0000 URL: https://git.openjdk.java.net/loom/commit/83b2219220266c1365466970d08606fef766c4fa 8273612: Fix for JDK-8272873 causes timeout in running some tests with -Xcomp Reviewed-by: kvn, neliasso ! src/hotspot/share/compiler/compilationPolicy.cpp ! test/hotspot/jtreg/compiler/jvmci/compilerToVM/IsMatureTest.java ! test/hotspot/jtreg/compiler/jvmci/compilerToVM/IsMatureVsReprofileTest.java Changeset: 47262670 Author: Christoph Langer Date: 2021-10-05 21:06:52 +0000 URL: https://git.openjdk.java.net/loom/commit/47262670f371923a704ec521da40010c2a46be5a 8274642: jdk/jshell/CommandCompletionTest.java fails with NoSuchElementException after JDK-8271287 Reviewed-by: jlahoda ! test/langtools/jdk/jshell/CommandCompletionTest.java Changeset: d4e8712c Author: Daniel D. Daugherty Date: 2021-10-05 21:47:18 +0000 URL: https://git.openjdk.java.net/loom/commit/d4e8712c0acc786e64f81ad29e54e6e50134f0e0 8274797: ProblemList resourcehogs/serviceability/sa/TestHeapDumpForLargeArray.java on macosx-x64 Reviewed-by: darcy ! test/hotspot/jtreg/ProblemList.txt Changeset: df7b0c70 Author: Sergey Tsypanov Committer: Martin Buchholz Date: 2021-10-05 22:19:35 +0000 URL: https://git.openjdk.java.net/loom/commit/df7b0c707713195c93ff4e745c89155ee8e4c571 8274715: Implement forEach in Collections.CopiesList Reviewed-by: martin ! src/java.base/share/classes/java/util/Collections.java + test/micro/org/openjdk/bench/java/util/NCopiesBenchmarks.java Changeset: 986ee5d0 Author: Yasumasa Suenaga Date: 2021-10-06 00:36:50 +0000 URL: https://git.openjdk.java.net/loom/commit/986ee5d0bfd407dc1b7ce75c7c94b6585bfb497d 8274670: Improve version string handling in SA Reviewed-by: cjplummer, sspitsyn ! src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/runtime/VM.java ! src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/runtime/VMVersionMismatchException.java Changeset: 8a4d2b4a Author: Andrey Turbanov Committer: Sergey Bylokhov Date: 2021-10-06 02:53:09 +0000 URL: https://git.openjdk.java.net/loom/commit/8a4d2b4aa76e6aae1cb27f476c6cc71dcd9779f0 8274680: Remove unnecessary conversion to String in java.desktop Reviewed-by: pbansal, jdv, serb, kizune ! src/java.desktop/share/classes/com/sun/imageio/plugins/jpeg/DHTMarkerSegment.java ! src/java.desktop/share/classes/com/sun/imageio/plugins/jpeg/DQTMarkerSegment.java ! src/java.desktop/share/classes/com/sun/imageio/plugins/jpeg/DRIMarkerSegment.java ! src/java.desktop/share/classes/com/sun/imageio/plugins/jpeg/JFIFMarkerSegment.java ! src/java.desktop/share/classes/com/sun/imageio/plugins/png/PNGMetadata.java ! src/java.desktop/share/classes/javax/imageio/plugins/tiff/TIFFField.java ! src/java.desktop/share/classes/javax/swing/DefaultListSelectionModel.java ! src/java.desktop/share/classes/javax/swing/GroupLayout.java ! src/java.desktop/share/classes/javax/swing/event/TreeModelEvent.java ! src/java.desktop/share/classes/javax/swing/text/TabStop.java ! src/java.desktop/share/classes/javax/swing/text/html/OptionListModel.java ! src/java.desktop/share/classes/javax/swing/tree/DefaultTreeSelectionModel.java ! src/java.desktop/share/classes/sun/java2d/marlin/RendererContext.java ! src/java.desktop/share/classes/sun/print/PSPrinterJob.java ! src/java.desktop/share/classes/sun/swing/plaf/synth/DefaultSynthStyle.java ! src/java.desktop/windows/classes/sun/awt/windows/WDesktopProperties.java Changeset: 2faced09 Author: Per Liden Date: 2021-10-06 07:44:47 +0000 URL: https://git.openjdk.java.net/loom/commit/2faced09ce0f6901dcdc969e6c85f2a5b55778f1 8274738: ZGC: Use relaxed atomic load when reading bits in the live map Reviewed-by: stefank, eosterlund ! src/hotspot/share/gc/z/zLiveMap.inline.hpp Changeset: c74726db Author: Andrew Haley Date: 2021-10-06 08:18:10 +0000 URL: https://git.openjdk.java.net/loom/commit/c74726dbd0767d02abf9535361a86ffb69b646d9 8274730: AArch64: AES/GCM acceleration is broken by the fix for JDK-8273297 Reviewed-by: adinn, roland, kvn ! src/hotspot/cpu/aarch64/matcher_aarch64.hpp ! src/hotspot/cpu/aarch64/stubGenerator_aarch64.cpp ! src/hotspot/share/opto/library_call.cpp Changeset: df125f68 Author: Christian Hagedorn Date: 2021-10-06 08:21:18 +0000 URL: https://git.openjdk.java.net/loom/commit/df125f680b6a4517109be80512a113064ca6281d 8273410: IR verification framework fails with "Should find method name in validIrRulesMap" Reviewed-by: thartmann, neliasso ! test/hotspot/jtreg/compiler/lib/ir_framework/test/TestVM.java ! test/hotspot/jtreg/testlibrary_tests/ir_framework/tests/TestBadFormat.java + test/hotspot/jtreg/testlibrary_tests/ir_framework/tests/TestCheckedTests.java Changeset: cdf89304 Author: Hannes Walln?fer Date: 2021-10-06 09:28:37 +0000 URL: https://git.openjdk.java.net/loom/commit/cdf89304eafce58e66127d4e277f5fcaf07c9954 8274625: Search field placeholder behavior Reviewed-by: prappo ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/Navigation.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/markup/HtmlAttr.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/markup/HtmlTree.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/resources/search.js.template ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/resources/doclets.properties ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/resources/stylesheet.css ! test/langtools/jdk/javadoc/doclet/checkStylesheetClasses/CheckStylesheetClasses.java ! test/langtools/jdk/javadoc/doclet/testSearch/TestSearch.java ! test/langtools/jdk/javadoc/doclet/testStylesheet/TestStylesheet.java Changeset: 9759fcb1 Author: Andrey Turbanov Committer: Pankaj Bansal Date: 2021-10-06 10:50:38 +0000 URL: https://git.openjdk.java.net/loom/commit/9759fcb17b62d76d75b893481bbd4ef45e7ad366 8274496: Use String.contains() instead of String.indexOf() in java.desktop Reviewed-by: pbansal, serb ! src/java.desktop/share/classes/javax/swing/text/html/CSS.java ! src/java.desktop/share/classes/javax/swing/text/html/HTMLDocument.java ! src/java.desktop/share/classes/javax/swing/text/html/HTMLWriter.java ! src/java.desktop/share/classes/javax/swing/text/html/InlineView.java ! src/java.desktop/share/classes/sun/font/Font2D.java ! src/java.desktop/unix/classes/sun/awt/X11/XWM.java ! src/java.desktop/unix/classes/sun/font/NativeFont.java ! src/java.desktop/unix/classes/sun/font/XMap.java ! src/java.desktop/unix/classes/sun/print/IPPPrintService.java ! src/java.desktop/windows/classes/sun/awt/windows/WDataTransferer.java Changeset: c80a6127 Author: Kim Barrett Date: 2021-10-06 11:14:26 +0000 URL: https://git.openjdk.java.net/loom/commit/c80a612709f1e483575e2843c1f0ea84e1b9a257 8273381: Assert in PtrQueueBufferAllocatorTest.stress_free_list_allocator_vm Reviewed-by: sjohanss, tschatzl ! test/hotspot/gtest/gc/shared/test_ptrQueueBufferAllocator.cpp Changeset: b8af6a9b Author: Coleen Phillimore Date: 2021-10-06 12:14:33 +0000 URL: https://git.openjdk.java.net/loom/commit/b8af6a9bfb28aaf0fea0cfdaba13236dc8cbaa3a 8273917: Remove 'leaf' ranking for Mutex Reviewed-by: eosterlund, dholmes ! src/hotspot/share/compiler/compileTask.hpp ! src/hotspot/share/gc/shared/space.cpp ! src/hotspot/share/gc/shenandoah/shenandoahControlThread.cpp ! src/hotspot/share/gc/shenandoah/shenandoahPacer.hpp ! src/hotspot/share/oops/methodData.cpp ! src/hotspot/share/runtime/mutex.cpp ! src/hotspot/share/runtime/mutex.hpp ! src/hotspot/share/runtime/mutexLocker.cpp ! src/hotspot/share/services/heapDumper.cpp ! test/hotspot/gtest/runtime/test_mutex.cpp ! test/hotspot/gtest/runtime/test_safepoint_locks.cpp Changeset: c10de353 Author: Christian Stein Committer: Alan Bateman Date: 2021-10-06 15:11:28 +0000 URL: https://git.openjdk.java.net/loom/commit/c10de3538b47c182d7bfeb02f348fac9b2ad0641 8262944: Improve exception message when automatic module lists provider class not in JAR file Reviewed-by: dfuchs, jvernee, alanb, lancea, mchung ! src/java.base/share/classes/jdk/internal/module/ModulePath.java ! test/jdk/java/lang/module/AutomaticModulesTest.java Changeset: f3cedbe9 Author: Andrey Turbanov Committer: Daniel Fuchs Date: 2021-10-06 18:11:07 +0000 URL: https://git.openjdk.java.net/loom/commit/f3cedbe9288e7aea8d5603a2dc9bdc2661c391a6 8274464: Remove redundant stream() call before forEach in java.* modules Reviewed-by: dfuchs, amenkov, vtewari ! src/java.management.rmi/share/classes/javax/management/remote/rmi/RMIJRMPServerImpl.java ! src/java.management/share/classes/java/lang/management/DefaultPlatformMBeanProvider.java ! src/java.xml/share/classes/javax/xml/catalog/CatalogFeatures.java ! src/java.xml/share/classes/javax/xml/catalog/CatalogImpl.java Changeset: 4e7d7caa Author: Andrey Turbanov Committer: Daniel Fuchs Date: 2021-10-06 18:17:58 +0000 URL: https://git.openjdk.java.net/loom/commit/4e7d7caa0ce1a3c9fc45ca6a85b1a7ec209775b2 8273711: Remove redundant stream() call before forEach in jdk.jlink Reviewed-by: alanb, psandoz, dfuchs ! src/jdk.jlink/share/classes/jdk/tools/jlink/internal/ImageFileCreator.java ! src/jdk.jlink/share/classes/jdk/tools/jlink/internal/ImagePluginConfiguration.java ! src/jdk.jlink/share/classes/jdk/tools/jlink/internal/ImagePluginStack.java ! src/jdk.jlink/share/classes/jdk/tools/jlink/internal/PerfectHashBuilder.java ! src/jdk.jlink/share/classes/jdk/tools/jlink/internal/PluginRepository.java ! src/jdk.jlink/share/classes/jdk/tools/jlink/internal/ResourcePoolConfiguration.java ! src/jdk.jlink/share/classes/jdk/tools/jlink/internal/plugins/ReleaseInfoPlugin.java ! src/jdk.jlink/share/classes/jdk/tools/jlink/internal/plugins/ResourceFilter.java ! src/jdk.jlink/share/classes/jdk/tools/jlink/internal/plugins/StringSharingPlugin.java Changeset: 754bc82c Author: Andrey Turbanov Committer: Daniel Fuchs Date: 2021-10-06 18:20:18 +0000 URL: https://git.openjdk.java.net/loom/commit/754bc82c4c03e1bedb4b36b5c52873b0a78a6ceb 8274525: Replace uses of StringBuffer with StringBuilder in java.xml Reviewed-by: joehw, iris, naoto, dfuchs ! src/java.xml/share/classes/com/sun/xml/internal/stream/Entity.java ! src/java.xml/share/classes/com/sun/xml/internal/stream/StaxErrorReporter.java ! src/java.xml/share/classes/com/sun/xml/internal/stream/XMLEventReaderImpl.java ! src/java.xml/share/classes/com/sun/xml/internal/stream/events/LocationImpl.java ! src/java.xml/share/classes/javax/xml/datatype/Duration.java Changeset: 9945f7a0 Author: Andrey Turbanov Committer: Daniel Fuchs Date: 2021-10-06 18:23:46 +0000 URL: https://git.openjdk.java.net/loom/commit/9945f7a0744db2470bcfa856e8f831b6a6eb2de8 8274318: Replace 'for' cycles with iterator with enhanced-for in java.management Reviewed-by: cjplummer, sspitsyn, dfuchs ! src/java.management.rmi/share/classes/javax/management/remote/rmi/RMIServerImpl.java ! src/java.management/share/classes/com/sun/jmx/remote/security/MBeanServerFileAccessController.java ! src/java.management/share/classes/javax/management/relation/RoleResult.java Changeset: 9561fea7 Author: Sergey Bylokhov Date: 2021-10-06 22:31:23 +0000 URL: https://git.openjdk.java.net/loom/commit/9561fea79035f23ca3a6619c9e150433cdf4a232 8273102: Delete deprecated for removal the empty finalize() in java.desktop module Reviewed-by: pbansal, aivanov, iris, prr ! src/java.desktop/share/classes/java/awt/color/ICC_Profile.java ! src/java.desktop/share/classes/java/awt/image/ColorModel.java ! src/java.desktop/share/classes/java/awt/image/IndexColorModel.java Changeset: 734d1fbd Author: Jonathan Gibbons Date: 2021-10-06 22:40:44 +0000 URL: https://git.openjdk.java.net/loom/commit/734d1fbd33be0aa20b26e6e8c776709f478069de 8274211: Test man page that options are documented Reviewed-by: prappo + test/langtools/jdk/javadoc/tool/CheckManPageOptions.java Changeset: d57fb6f6 Author: lawrence.andrews Committer: Sergey Bylokhov Date: 2021-10-06 23:12:56 +0000 URL: https://git.openjdk.java.net/loom/commit/d57fb6f684eac5a7e68842dcf3284309e3867521 8274456: Remove jtreg tag manual=yesno java/awt/print/PrinterJob/PageDialogTest.java Reviewed-by: serb ! test/jdk/java/awt/print/PrinterJob/PageDialogTest.java Changeset: c833b4d1 Author: Jie Fu Date: 2021-10-06 23:22:04 +0000 URL: https://git.openjdk.java.net/loom/commit/c833b4d130fabfa6a6f3a38313f76eb7e392c6a5 8274329: Fix non-portable HotSpot code in MethodMatcher::parse_method_pattern Reviewed-by: iklam, ihse, kvn ! src/hotspot/share/compiler/methodMatcher.cpp Changeset: 4e960fe5 Author: Andrey Turbanov Committer: Sergey Bylokhov Date: 2021-10-07 03:42:50 +0000 URL: https://git.openjdk.java.net/loom/commit/4e960fe53f0948c0b0decfeb13f6dd8f74bf3d6f 8274497: Unnecessary Vector usage in AquaFileSystemModel Reviewed-by: serb, pbansal ! src/java.desktop/macosx/classes/com/apple/laf/AquaFileSystemModel.java Changeset: 5762ec25 Author: Florian Weimer Committer: Alan Bateman Date: 2021-10-07 07:02:01 +0000 URL: https://git.openjdk.java.net/loom/commit/5762ec25877ab9207a2fb05888f952690737e318 8274780: ChannelInputStream.readNBytes(int) incorrectly calls readAllBytes() Reviewed-by: alanb, bpb ! src/java.base/share/classes/sun/nio/ch/ChannelInputStream.java ! test/jdk/java/nio/channels/Channels/ReadXBytes.java Changeset: 29dcbb72 Author: Richard Reingruber Date: 2021-10-07 08:20:20 +0000 URL: https://git.openjdk.java.net/loom/commit/29dcbb72a2d9b224203d92ad3224cf149a7d08de 8274716: JDWP Spec: the description for the Dispose command confuses suspend with resume. Reviewed-by: alanb, cjplummer, sspitsyn ! make/data/jdwp/jdwp.spec Changeset: d5ccfa2a Author: Andrey Turbanov Committer: Serguei Spitsyn Date: 2021-10-07 09:38:42 +0000 URL: https://git.openjdk.java.net/loom/commit/d5ccfa2ae965a9ae0f3597b0b90d702a3e0ea558 8274755: Replace 'while' cycles with iterator with enhanced-for in jdk.jdi Reviewed-by: alanb, amenkov, sspitsyn, cjplummer ! src/jdk.jdi/share/classes/com/sun/tools/jdi/ConcreteMethodImpl.java ! src/jdk.jdi/share/classes/com/sun/tools/jdi/ConnectorImpl.java ! src/jdk.jdi/share/classes/com/sun/tools/jdi/EventRequestManagerImpl.java ! src/jdk.jdi/share/classes/com/sun/tools/jdi/InvokableTypeImpl.java ! src/jdk.jdi/share/classes/com/sun/tools/jdi/ReferenceTypeImpl.java ! src/jdk.jdi/share/classes/com/sun/tools/jdi/TargetVM.java ! src/jdk.jdi/share/classes/com/sun/tools/jdi/ThreadReferenceImpl.java ! src/jdk.jdi/share/classes/com/sun/tools/jdi/VMState.java ! src/jdk.jdi/share/classes/com/sun/tools/jdi/VirtualMachineImpl.java Changeset: 83198361 Author: Yude Lin Committer: Thomas Schatzl Date: 2021-10-07 11:28:49 +0000 URL: https://git.openjdk.java.net/loom/commit/8319836152cbd0aa5bf6c93d3ba04733cacf83b4 8274546: Shenandoah: Remove unused ShenandoahUpdateRootsTask copy Reviewed-by: zgu, tschatzl ! src/hotspot/share/gc/shenandoah/shenandoahConcurrentMark.cpp Changeset: 340c715c Author: Lin Zang Date: 2021-10-07 11:57:18 +0000 URL: https://git.openjdk.java.net/loom/commit/340c715c3b0f5ad5204f9dddb17a787b07426543 8273929: Remove GzipRandomAccess in heap dump test Reviewed-by: cjplummer, sspitsyn - test/lib/jdk/test/lib/hprof/parser/GzipRandomAccess.java ! test/lib/jdk/test/lib/hprof/parser/Reader.java Changeset: 722d639f Author: Jie Fu Date: 2021-10-07 12:42:16 +0000 URL: https://git.openjdk.java.net/loom/commit/722d639fad2e4fc6eb2aabd427e2719501899cfe 8274838: runtime/cds/appcds/TestSerialGCWithCDS.java fails on Windows Reviewed-by: iklam, hseigel ! test/hotspot/jtreg/runtime/cds/appcds/TestSerialGCWithCDS.java Changeset: 03a8d342 Author: Sean Coffey Date: 2021-10-07 15:12:13 +0000 URL: https://git.openjdk.java.net/loom/commit/03a8d342b86e720d3cba08d540182b4ab161fba3 8273826: Correct Manifest file name and NPE checks Reviewed-by: weijun, hchao, mullan ! src/java.base/share/classes/java/util/jar/JarFile.java ! src/java.base/share/classes/java/util/jar/JarInputStream.java ! src/java.base/share/classes/java/util/jar/JarVerifier.java ! src/java.base/share/classes/sun/security/util/ManifestEntryVerifier.java + test/jdk/sun/security/tools/jarsigner/warnings/LowerCaseManifest.java Changeset: 4ab274ac Author: Coleen Phillimore Date: 2021-10-07 15:24:00 +0000 URL: https://git.openjdk.java.net/loom/commit/4ab274ac1a241b2d63f46084ec23aa7cff4bc28e 8274858: Remove unused dictionary_classes_do functions Reviewed-by: dholmes, hseigel ! src/hotspot/share/classfile/classLoaderDataGraph.cpp ! src/hotspot/share/classfile/classLoaderDataGraph.hpp ! src/hotspot/share/memory/universe.cpp Changeset: 8ca08461 Author: Naoto Sato Date: 2021-10-07 15:32:11 +0000 URL: https://git.openjdk.java.net/loom/commit/8ca084617f331b6af934179f3f776c8158da5bba 8274407: (tz) Update Timezone Data to 2021c 8274467: TestZoneInfo310.java fails with tzdata2021b 8274468: TimeZoneTest.java fails with tzdata2021b Reviewed-by: rriggs, iris, coffeys ! make/data/tzdata/VERSION ! make/data/tzdata/africa ! make/data/tzdata/antarctica ! make/data/tzdata/asia ! make/data/tzdata/australasia ! make/data/tzdata/backward ! make/data/tzdata/europe ! make/data/tzdata/leapseconds ! make/data/tzdata/northamerica ! make/data/tzdata/southamerica ! make/data/tzdata/zone.tab ! src/java.base/share/classes/sun/util/calendar/ZoneInfoFile.java ! test/jdk/java/util/TimeZone/TimeZoneTest.java Changeset: 7de2cf85 Author: Andrey Turbanov Committer: Daniel Fuchs Date: 2021-10-07 16:55:45 +0000 URL: https://git.openjdk.java.net/loom/commit/7de2cf852d75ea6eb039e69067d4e32421283de5 8273910: Redundant condition and assignment in java.net.URI Reviewed-by: dfuchs ! src/java.base/share/classes/java/net/URI.java Changeset: 920e7070 Author: Daniel D. Daugherty Date: 2021-10-07 17:14:26 +0000 URL: https://git.openjdk.java.net/loom/commit/920e70701da9699765c993e11feba3cc0fd0362c 8274920: ProblemList 2 VectorAPI tests failing due to "assert(!vbox->is_Phi()) failed" Reviewed-by: kvn ! test/hotspot/jtreg/ProblemList-Xcomp.txt Changeset: 8de77634 Author: Yumin Qi Date: 2021-10-07 21:33:32 +0000 URL: https://git.openjdk.java.net/loom/commit/8de77634c414cc348a6eb7b28fd6339befdb12d7 8273152: Refactor CDS FileMapHeader loading code Reviewed-by: ccheung, iklam ! src/hotspot/share/cds/archiveBuilder.cpp ! src/hotspot/share/cds/cdsConstants.cpp ! src/hotspot/share/cds/dynamicArchive.cpp ! src/hotspot/share/cds/filemap.cpp ! src/hotspot/share/cds/filemap.hpp ! src/hotspot/share/include/cds.h ! src/hotspot/share/runtime/arguments.cpp ! src/jdk.hotspot.agent/share/native/libsaproc/ps_core_common.c ! test/hotspot/jtreg/runtime/cds/appcds/SharedArchiveConsistency.java ! test/hotspot/jtreg/runtime/cds/appcds/dynamicArchive/ArchiveConsistency.java ! test/lib/jdk/test/lib/cds/CDSArchiveUtils.java Changeset: 97ea9dd2 Author: Matthias Baesken Date: 2021-10-08 06:40:18 +0000 URL: https://git.openjdk.java.net/loom/commit/97ea9dd2f24f9f1fb9b9345a4202a825ee28e014 8274840: Update OS detection code to recognize Windows 11 Co-authored-by: Arno Zeller Reviewed-by: clanger, dholmes ! src/hotspot/os/windows/os_windows.cpp ! src/java.base/windows/native/libjava/java_props_md.c Changeset: b60837a7 Author: Doug Simon Date: 2021-10-08 08:06:53 +0000 URL: https://git.openjdk.java.net/loom/commit/b60837a7d5d6f920d2fb968369564df155dc1018 8272586: emit abstract machine code in hs-err logs Reviewed-by: kvn, dholmes ! src/hotspot/share/code/nmethod.cpp ! src/hotspot/share/compiler/compileTask.cpp ! src/hotspot/share/compiler/compileTask.hpp ! src/hotspot/share/compiler/disassembler.cpp ! src/hotspot/share/utilities/vmError.cpp ! src/hotspot/share/utilities/vmError.hpp + test/hotspot/jtreg/runtime/ErrorHandling/MachCodeFramesInErrorFile.java Changeset: 6364719c Author: Coleen Phillimore Date: 2021-10-08 12:23:19 +0000 URL: https://git.openjdk.java.net/loom/commit/6364719cd1c57220769ea580d958da8dc2fdf7f9 8274004: Change 'nonleaf' rank name 8273956: Add checking for rank values Reviewed-by: dholmes, pchilanomate ! src/hotspot/os/aix/osThread_aix.cpp ! src/hotspot/os/bsd/osThread_bsd.cpp ! src/hotspot/os/linux/osThread_linux.cpp ! src/hotspot/share/classfile/classLoaderData.cpp ! src/hotspot/share/compiler/compileTask.hpp ! src/hotspot/share/gc/g1/g1RegionToSpaceMapper.cpp ! src/hotspot/share/gc/g1/g1ServiceThread.cpp ! src/hotspot/share/gc/g1/heapRegion.cpp ! src/hotspot/share/gc/g1/heapRegionRemSet.cpp ! src/hotspot/share/gc/parallel/psCompactionManager.cpp ! src/hotspot/share/gc/shared/gcLogPrecious.cpp ! src/hotspot/share/gc/shared/oopStorage.cpp ! src/hotspot/share/gc/shared/space.cpp ! src/hotspot/share/gc/shared/taskTerminator.cpp ! src/hotspot/share/gc/shared/workgroup.cpp ! src/hotspot/share/gc/shenandoah/shenandoahControlThread.cpp ! src/hotspot/share/gc/shenandoah/shenandoahPacer.hpp ! src/hotspot/share/gc/z/zMessagePort.inline.hpp ! src/hotspot/share/gc/z/zMetronome.cpp ! src/hotspot/share/memory/heapInspection.hpp ! src/hotspot/share/memory/metaspace/testHelpers.cpp ! src/hotspot/share/oops/methodData.cpp ! src/hotspot/share/prims/jvmtiTagMap.cpp ! src/hotspot/share/runtime/handshake.cpp ! src/hotspot/share/runtime/mutex.cpp ! src/hotspot/share/runtime/mutex.hpp ! src/hotspot/share/runtime/mutexLocker.cpp ! src/hotspot/share/runtime/stackWatermark.cpp ! src/hotspot/share/runtime/vmOperations.cpp ! src/hotspot/share/runtime/vmThread.cpp ! src/hotspot/share/services/heapDumper.cpp ! src/hotspot/share/services/heapDumperCompression.cpp ! src/hotspot/share/services/memoryManager.cpp ! src/hotspot/share/utilities/concurrentHashTable.inline.hpp ! src/hotspot/share/utilities/events.hpp ! test/hotspot/gtest/metaspace/test_is_metaspace_obj.cpp ! test/hotspot/gtest/metaspace/test_metaspacearena.cpp ! test/hotspot/gtest/metaspace/test_metaspacearena_stress.cpp ! test/hotspot/gtest/runtime/test_mutex.cpp - test/hotspot/gtest/runtime/test_safepoint_locks.cpp ! test/hotspot/gtest/utilities/test_filterQueue.cpp Changeset: 2aacd422 Author: Roland Westrelin Date: 2021-10-08 14:48:35 +0000 URL: https://git.openjdk.java.net/loom/commit/2aacd4220a01b467de671212c7a74e6c81a2ad3c 8274145: C2: condition incorrectly made redundant with dominating main loop exit condition Reviewed-by: kvn, neliasso ! src/hotspot/share/opto/loopnode.hpp ! src/hotspot/share/opto/loopopts.cpp + test/hotspot/jtreg/compiler/loopopts/TestIfReplacedByMainLoopExit.java Changeset: 36b89a18 Author: Christian Hagedorn Date: 2021-10-08 14:51:18 +0000 URL: https://git.openjdk.java.net/loom/commit/36b89a18931d42b8002a843ec8218b5c1ba54374 8274785: ciReplay: Potential crash due to uninitialized Compile::_ilt variable Reviewed-by: neliasso, kvn ! src/hotspot/share/opto/compile.cpp Changeset: ccbce107 Author: Sergey Tsypanov Committer: Jayathirth D V Date: 2021-10-08 15:58:36 +0000 URL: https://git.openjdk.java.net/loom/commit/ccbce107f299c3b1c444e819c1fda7ae3c4866b5 8272756: Remove unnecessary explicit initialization of volatile variables in java.desktop Reviewed-by: jdv, aivanov ! src/java.desktop/macosx/classes/sun/lwawt/LWLightweightFramePeer.java ! src/java.desktop/macosx/classes/sun/lwawt/LWWindowPeer.java ! src/java.desktop/macosx/classes/sun/lwawt/macosx/CCheckboxMenuItem.java ! src/java.desktop/macosx/classes/sun/lwawt/macosx/CPlatformEmbeddedFrame.java ! src/java.desktop/macosx/classes/sun/lwawt/macosx/CWarningWindow.java ! src/java.desktop/share/classes/com/sun/imageio/plugins/tiff/TIFFIFD.java ! src/java.desktop/share/classes/com/sun/media/sound/DirectAudioDevice.java ! src/java.desktop/share/classes/com/sun/media/sound/SoftAudioPusher.java ! src/java.desktop/share/classes/com/sun/media/sound/SoftSynthesizer.java ! src/java.desktop/share/classes/java/awt/Component.java ! src/java.desktop/share/classes/java/awt/Container.java ! src/java.desktop/share/classes/java/awt/Dialog.java ! src/java.desktop/share/classes/java/awt/Window.java ! src/java.desktop/share/classes/java/awt/event/InvocationEvent.java ! src/java.desktop/share/classes/java/awt/font/NumericShaper.java ! src/java.desktop/share/classes/javax/swing/JComponent.java ! src/java.desktop/share/classes/sun/awt/AppContext.java ! src/java.desktop/share/classes/sun/awt/datatransfer/SunClipboard.java ! src/java.desktop/share/classes/sun/awt/dnd/SunDragSourceContextPeer.java ! src/java.desktop/share/classes/sun/java2d/Disposer.java ! src/java.desktop/share/classes/sun/java2d/marlin/RendererStats.java ! src/java.desktop/unix/classes/sun/awt/X11/GtkFileDialogPeer.java ! src/java.desktop/unix/classes/sun/awt/X11/ListHelper.java ! src/java.desktop/unix/classes/sun/awt/X11/XInputMethod.java ! src/java.desktop/unix/classes/sun/awt/X11/XLightweightFramePeer.java ! src/java.desktop/unix/classes/sun/awt/X11/XWarningWindow.java ! src/java.desktop/windows/classes/sun/awt/windows/ThemeReader.java ! src/java.desktop/windows/classes/sun/awt/windows/WObjectPeer.java Changeset: ec199072 Author: Naoto Sato Date: 2021-10-08 16:11:22 +0000 URL: https://git.openjdk.java.net/loom/commit/ec199072c5867624d66840238cc8828e16ae8da7 8274864: Remove Amman/Cairo hacks in ZoneInfoFile Reviewed-by: iris, joehw ! src/java.base/share/classes/sun/util/calendar/ZoneInfoFile.java Changeset: 239a35aa Author: Brian Burkhalter Date: 2021-10-08 16:43:16 +0000 URL: https://git.openjdk.java.net/loom/commit/239a35aa9166d0cb0b20850e1b52ad23b653d8d0 8233749: Files.exists javadoc doesn't mention eating IOException Reviewed-by: lancea, alanb ! src/java.base/share/classes/java/nio/file/Files.java Changeset: 3cb9724e Author: Coleen Phillimore Date: 2021-10-08 21:10:42 +0000 URL: https://git.openjdk.java.net/loom/commit/3cb9724ed94a7267853c5cddb18b4ae868ecf2e9 8274934: Attempting to acquire lock JNICritical_lock/41 out of order with lock MultiArray_lock/41 Reviewed-by: dcubed, iklam ! src/hotspot/share/runtime/mutexLocker.cpp Changeset: 9c431dd1 Author: Andrey Turbanov Committer: Pavel Rappo Date: 2021-10-08 23:08:05 +0000 URL: https://git.openjdk.java.net/loom/commit/9c431dd168c8a752d4aa1bde2268db0425d76990 8274900: Too weak variable type leads to unnecessary cast in jdk.javadoc Reviewed-by: prappo ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/SourceToHTMLConverter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/builders/SerializedFormBuilder.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/util/SummaryAPIListBuilder.java Changeset: f640c7aa Author: Andrey Turbanov Committer: Sergey Bylokhov Date: 2021-10-09 00:46:20 +0000 URL: https://git.openjdk.java.net/loom/commit/f640c7aaa852b6c0e9144654b7222a6777201370 8274806: Simplify equals() call on nullable variable and a constant in java.desktop Reviewed-by: serb, pbansal ! src/java.desktop/macosx/classes/sun/lwawt/macosx/CMenuItem.java ! src/java.desktop/share/classes/java/awt/Window.java ! src/java.desktop/share/classes/javax/swing/DefaultDesktopManager.java ! src/java.desktop/share/classes/javax/swing/JLayeredPane.java ! src/java.desktop/share/classes/javax/swing/filechooser/FileSystemView.java ! src/java.desktop/share/classes/javax/swing/text/html/HTMLEditorKit.java ! src/java.desktop/share/classes/sun/java2d/SurfaceDataProxy.java ! src/java.desktop/share/classes/sun/print/RasterPrinterJob.java ! src/java.desktop/unix/classes/sun/awt/X11/XTaskbarPeer.java ! src/java.desktop/unix/classes/sun/print/UnixPrintJob.java ! src/java.desktop/windows/classes/sun/awt/windows/WDesktopProperties.java Changeset: aac6c4ea Author: Pankaj Bansal Date: 2021-10-09 03:52:53 +0000 URL: https://git.openjdk.java.net/loom/commit/aac6c4ea707fa592b2bcd7586c1fe61a19e3725e 8272229: BasicSplitPaneDivider:oneTouchExpandableChanged() returns leftButton and rightButton as null with GTKLookAndFeel Reviewed-by: serb, jdv, kizune ! src/java.desktop/share/classes/javax/swing/plaf/basic/BasicSplitPaneDivider.java Changeset: 6d1d4d52 Author: Wang Huang Committer: Hamlin Li Date: 2021-10-09 08:19:17 +0000 URL: https://git.openjdk.java.net/loom/commit/6d1d4d52928ed38bbc73ddcbede5389995a8e65f 8268231: Aarch64: Use ldp in intrinsics for String.compareTo Co-authored-by: Wang Huang Co-authored-by: Sun Jianye Co-authored-by: Wu Yan Reviewed-by: ngasson, aph ! src/hotspot/cpu/aarch64/stubGenerator_aarch64.cpp Changeset: 2c83559e Author: Andrey Turbanov Committer: Sergey Bylokhov Date: 2021-10-10 08:41:52 +0000 URL: https://git.openjdk.java.net/loom/commit/2c83559eda410d268c6d8a56d7fd1c34f817cb83 8274882: Cleanup redundant boxing in java.desktop Reviewed-by: serb, pbansal ! src/java.desktop/share/classes/com/sun/java/swing/plaf/gtk/Metacity.java ! src/java.desktop/share/classes/javax/swing/SwingUtilities.java ! src/java.desktop/share/classes/javax/swing/plaf/metal/MetalLookAndFeel.java ! src/java.desktop/share/classes/sun/awt/SunToolkit.java ! src/java.desktop/share/classes/sun/awt/image/VSyncedBSManager.java ! src/java.desktop/share/classes/sun/java2d/marlin/MarlinProperties.java ! src/java.desktop/unix/classes/sun/awt/X11/MotifColorUtilities.java ! src/java.desktop/windows/classes/com/sun/java/swing/plaf/windows/WindowsLookAndFeel.java ! src/java.desktop/windows/classes/sun/awt/windows/TranslucentWindowPainter.java Changeset: 296f8537 Author: lawrence.andrews Committer: Sergey Bylokhov Date: 2021-10-10 08:46:04 +0000 URL: https://git.openjdk.java.net/loom/commit/296f8537f71b84f194cf2718ac9b85ba6843cfa3 8274029: Remove jtreg tag manual=yesno for java/awt/print/Dialog/DialogOrient.java Reviewed-by: serb ! test/jdk/java/awt/print/Dialog/DialogOrient.java Changeset: 2ff3977a Author: Jie Fu Date: 2021-10-10 14:00:58 +0000 URL: https://git.openjdk.java.net/loom/commit/2ff3977a66c8d8b521cd0ad266ba954682a268ce 8275004: CDS build failure with gcc11 Reviewed-by: shade ! src/hotspot/share/cds/cdsConstants.hpp Changeset: 5ecc99bb Author: Lin Zang Date: 2021-10-11 01:56:34 +0000 URL: https://git.openjdk.java.net/loom/commit/5ecc99bbf55e631b5bfa07e2c36b38e820682363 8274620: resourcehogs/serviceability/sa/TestHeapDumpForLargeArray.java is timing out Reviewed-by: cjplummer, dholmes ! src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/utilities/HeapHprofBinWriter.java ! test/hotspot/jtreg/ProblemList.txt Changeset: a05873a2 Author: Ao Qi Committer: Jie Fu Date: 2021-10-11 02:17:56 +0000 URL: https://git.openjdk.java.net/loom/commit/a05873a225c40d12e60870794b9c993d1ea89cfe 8274952: jdk/jfr/api/consumer/TestRecordedFrameType.java failed when c1 disabled Reviewed-by: egahlin, jiefu ! test/jdk/jdk/jfr/api/consumer/TestRecordedFrameType.java Changeset: c032186b Author: Fei Gao Committer: Pengfei Li Date: 2021-10-11 06:59:37 +0000 URL: https://git.openjdk.java.net/loom/commit/c032186b421c64b44397cb7aa101b40e5f93dfff 8272968: AArch64: Remove redundant matching rules for commutative ops Reviewed-by: ngasson ! src/hotspot/cpu/aarch64/aarch64.ad Changeset: 49f8ce6e Author: Martin Doerr Date: 2021-10-11 10:31:54 +0000 URL: https://git.openjdk.java.net/loom/commit/49f8ce6e9c797cd11ea586e3cf87398888bc8cf1 8274773: [TESTBUG] UnsafeIntrinsicsTest intermittently fails on weak memory model platform Reviewed-by: eosterlund, goetz ! test/hotspot/jtreg/compiler/gcbarriers/UnsafeIntrinsicsTest.java Changeset: 3edee1e1 Author: Roman Kennke Date: 2021-10-11 10:37:54 +0000 URL: https://git.openjdk.java.net/loom/commit/3edee1e1feed564397ac47a32c0394d7798bac17 8272723: Don't use Access API to access primitive fields Reviewed-by: stefank, eosterlund ! src/hotspot/share/classfile/javaClasses.cpp ! src/hotspot/share/classfile/javaClasses.inline.hpp ! src/hotspot/share/jvmci/jvmciJavaClasses.cpp ! src/hotspot/share/oops/instanceKlass.inline.hpp ! src/hotspot/share/oops/oop.cpp ! src/hotspot/share/oops/oop.hpp ! src/hotspot/share/oops/oop.inline.hpp ! src/hotspot/share/oops/typeArrayOop.inline.hpp ! src/hotspot/share/prims/unsafe.cpp Changeset: c55dd365 Author: Jie Fu Date: 2021-10-11 10:51:39 +0000 URL: https://git.openjdk.java.net/loom/commit/c55dd365e3463670697b09de0ff70877203e5a69 8275008: gtest build failure due to stringop-overflow warning with gcc11 Reviewed-by: dholmes, ihse ! make/hotspot/lib/CompileGtest.gmk Changeset: aaf2401b Author: Thomas Schatzl Date: 2021-10-11 11:46:46 +0000 URL: https://git.openjdk.java.net/loom/commit/aaf2401bc7d766dee5ffc623db86c4723c7e3760 8274927: Remove unnecessary G1ArchiveAllocator code Reviewed-by: kbarrett, ayang ! src/hotspot/share/gc/g1/g1Allocator.cpp ! src/hotspot/share/gc/g1/g1Allocator.hpp ! src/hotspot/share/gc/g1/g1CollectedHeap.cpp Changeset: b7af8905 Author: Thomas Schatzl Date: 2021-10-11 11:48:50 +0000 URL: https://git.openjdk.java.net/loom/commit/b7af890574b3c13122fe7de987a8c9458c05f625 8274430: Remove some debug error printing code added in JDK-8017163 Reviewed-by: sjohanss, ayang ! src/hotspot/share/gc/g1/heapRegion.cpp Changeset: 110e38de Author: Coleen Phillimore Date: 2021-10-11 12:11:11 +0000 URL: https://git.openjdk.java.net/loom/commit/110e38ded8e09361f24c582c770d35f5cfdabf82 8274753: ZGC: SEGV in MetaspaceShared::link_shared_classes 8274935: dumptime_table has stale entry Reviewed-by: eosterlund, iklam ! src/hotspot/share/cds/metaspaceShared.cpp ! src/hotspot/share/classfile/classLoaderData.cpp ! test/hotspot/jtreg/runtime/cds/appcds/loaderConstraints/DynamicLoaderConstraintsTest.java Changeset: b870468b Author: Jan Lahoda Date: 2021-10-11 12:38:08 +0000 URL: https://git.openjdk.java.net/loom/commit/b870468bdc99938fbb19a41b0ede0a3e3769ace2 8274347: Passing a *nested* switch expression as a parameter causes an NPE during compile Reviewed-by: vromero ! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Attr.java ! test/langtools/tools/javac/api/TestGetScopeResult.java ! test/langtools/tools/javac/switchexpr/ExpressionSwitchInfer.java Changeset: 0d80f6cf Author: Patricio Chilano Mateo Date: 2021-10-11 13:34:42 +0000 URL: https://git.openjdk.java.net/loom/commit/0d80f6cf82ddab85f2461c7cc663a93bb222e988 8274379: Allow process of unsafe access errors in check_special_condition_for_native_trans Reviewed-by: rehn, dholmes ! src/hotspot/share/prims/jvm.cpp ! src/hotspot/share/prims/jvmtiEnv.cpp ! src/hotspot/share/runtime/safepoint.hpp ! src/hotspot/share/runtime/thread.cpp ! src/hotspot/share/runtime/thread.hpp ! src/hotspot/share/runtime/thread.inline.hpp ! src/hotspot/share/runtime/vmStructs.cpp Changeset: 3f073377 Author: Zhengyu Gu Date: 2021-10-11 15:10:57 +0000 URL: https://git.openjdk.java.net/loom/commit/3f07337722a0c8c6b452a44745598268d67c0864 8273614: Shenandoah: intermittent timeout with ConcurrentGCBreakpoint tests Reviewed-by: shade ! src/hotspot/share/gc/shenandoah/shenandoahConcurrentGC.cpp Changeset: 3f01d03a Author: Lin Zang Date: 2021-10-11 15:27:28 +0000 URL: https://git.openjdk.java.net/loom/commit/3f01d03a10cb3f647735ed4bbea1768ff18bf8f2 8275021: Test serviceability/sa/TestJmapCore.java fails with: java.io.IOException: Stack frame 0x4 not found Reviewed-by: dholmes, dcubed ! src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/utilities/HeapHprofBinWriter.java Changeset: 83c37719 Author: Thomas Stuefe Date: 2021-10-11 15:48:10 +0000 URL: https://git.openjdk.java.net/loom/commit/83c37719290039672cf261701028c8eb044a2e77 8273881: Metaspace: test repeated deallocations Reviewed-by: dholmes, shade ! test/hotspot/gtest/metaspace/test_metaspacearena.cpp Changeset: 75f5145e Author: Zhengyu Gu Date: 2021-10-11 16:58:53 +0000 URL: https://git.openjdk.java.net/loom/commit/75f5145e21a1320c1a08080af861497ce7c3f266 8274925: Shenandoah: shenandoah/TestAllocHumongousFragment.java test failed on lock rank check Reviewed-by: shade ! src/hotspot/share/gc/shenandoah/shenandoahControlThread.cpp Changeset: 829dea45 Author: Andrey Turbanov Committer: Pankaj Bansal Date: 2021-10-11 19:19:39 +0000 URL: https://git.openjdk.java.net/loom/commit/829dea45c9ab90518f03a66aad7e681cd4fda8b3 8274945: Cleanup unnecessary calls to Throwable.initCause() in java.desktop Reviewed-by: jdv, serb, pbansal ! src/java.desktop/share/classes/com/sun/imageio/plugins/jpeg/MarkerSegment.java ! src/java.desktop/share/classes/javax/imageio/metadata/IIOMetadata.java ! src/java.desktop/share/classes/javax/imageio/spi/ImageReaderWriterSpi.java ! src/java.desktop/share/classes/sun/awt/datatransfer/TransferableProxy.java Changeset: dd93c6e2 Author: Sergey Bylokhov Date: 2021-10-12 00:14:00 +0000 URL: https://git.openjdk.java.net/loom/commit/dd93c6e27b66acebb221583fd28d03c65bfc1f24 8272167: AbsPathsInImage.java should skip *.dSYM directories Reviewed-by: ihse, erikj ! test/jdk/build/AbsPathsInImage.java Changeset: 1e306959 Author: Hamlin Li Date: 2021-10-12 01:25:00 +0000 URL: https://git.openjdk.java.net/loom/commit/1e3069593e6f56714e1ee557b70930c2749d820c 8274466: G1: use field directly rather than method in G1CollectorState::in_mixed_phase Reviewed-by: ayang, sjohanss ! src/hotspot/share/gc/g1/g1CollectorState.hpp Changeset: ef0922e8 Author: Aleksey Shipilev Date: 2021-10-12 05:56:15 +0000 URL: https://git.openjdk.java.net/loom/commit/ef0922e88528bdf4fe75537ddf4e82123e3f58b3 8274560: JFR: Add test for OldObjectSample event when using Shenandoah Reviewed-by: mgronlun ! test/jdk/jdk/jfr/event/oldobject/TestObjectDescription.java + test/jdk/jdk/jfr/event/oldobject/TestShenandoah.java Changeset: a5f09d10 Author: Aleksey Shipilev Date: 2021-10-12 06:22:13 +0000 URL: https://git.openjdk.java.net/loom/commit/a5f09d1088d9dd610139370739e9fbd6e34416cb 8275031: runtime/ErrorHandling/MachCodeFramesInErrorFile.java fails when hsdis is present Reviewed-by: dholmes, dnsimon ! src/hotspot/share/code/nmethod.cpp ! test/hotspot/jtreg/runtime/ErrorHandling/MachCodeFramesInErrorFile.java Changeset: cfe7471f Author: Aleksey Shipilev Date: 2021-10-12 07:24:15 +0000 URL: https://git.openjdk.java.net/loom/commit/cfe7471f1769eca2a4e623f5ba9cddceb005f0bf 8177814: jdk/editpad is not in jdk TEST.groups Reviewed-by: serb ! test/jdk/TEST.groups Changeset: 7d2633f7 Author: Andrey Turbanov Committer: Pavel Rappo Date: 2021-10-12 09:37:54 +0000 URL: https://git.openjdk.java.net/loom/commit/7d2633f795c27edc2dfbbd7a9d9e44bdb23ec6a1 8275002: Remove unused AbstractStringBuilder.MAX_ARRAY_SIZE Reviewed-by: prappo, jlaskey, martin ! src/java.base/share/classes/java/lang/AbstractStringBuilder.java Changeset: 8de26361 Author: Kim Barrett Date: 2021-10-12 09:40:35 +0000 URL: https://git.openjdk.java.net/loom/commit/8de26361f7d789c7b317536198c891756038a8ea 8274615: Support relaxed atomic add for linux-aarch64 Reviewed-by: aph, dholmes ! src/hotspot/cpu/aarch64/atomic_aarch64.hpp ! src/hotspot/cpu/aarch64/stubGenerator_aarch64.cpp ! src/hotspot/os_cpu/linux_aarch64/atomic_linux_aarch64.S ! src/hotspot/os_cpu/linux_aarch64/atomic_linux_aarch64.hpp Changeset: 33050f80 Author: Doug Simon Date: 2021-10-12 09:49:50 +0000 URL: https://git.openjdk.java.net/loom/commit/33050f8013366f5e3a01ab1a75ba3fee9cc73089 8274986: max code printed in hs-err logs should be configurable Reviewed-by: never, dholmes ! src/hotspot/share/code/codeBlob.cpp ! src/hotspot/share/runtime/flags/jvmFlagLimit.cpp ! src/hotspot/share/runtime/globals.hpp ! src/hotspot/share/utilities/vmError.cpp ! src/hotspot/share/utilities/vmError.hpp ! test/hotspot/jtreg/runtime/ErrorHandling/MachCodeFramesInErrorFile.java Changeset: d04d4ee2 Author: Andrey Turbanov Committer: Daniel Fuchs Date: 2021-10-12 11:14:31 +0000 URL: https://git.openjdk.java.net/loom/commit/d04d4ee2c193baf4339ee3025e3fbcd31d62f484 8274894: Use Optional.empty() instead of ofNullable(null) in HttpResponse.BodySubscribers.discarding Reviewed-by: dfuchs ! src/java.net.http/share/classes/java/net/http/HttpResponse.java Changeset: b460d6dd Author: kabutz Committer: Markus Gr?nlund Date: 2021-10-12 11:38:21 +0000 URL: https://git.openjdk.java.net/loom/commit/b460d6ddafcd1be76bcf407254f843df6bbfb70b 8275091: /src/jdk.management.jfr/share/classes/module-info.java has non-canonical order Reviewed-by: mgronlun ! src/jdk.management.jfr/share/classes/module-info.java Changeset: 1ab64143 Author: Zhengyu Gu Date: 2021-10-12 11:58:35 +0000 URL: https://git.openjdk.java.net/loom/commit/1ab64143c06e33e23172dd77c39e434443347364 8275051: Shenandoah: Correct ordering of requested gc cause and gc request flag Reviewed-by: shade ! src/hotspot/share/gc/shenandoah/shenandoahControlThread.cpp Changeset: e16b93ad Author: Martin Doerr Date: 2021-10-12 12:18:49 +0000 URL: https://git.openjdk.java.net/loom/commit/e16b93ad52c96fddd9097c2cb0fa78ae781c547b 8274770: [PPC64] resolve_jobject needs a generic implementation to support load barriers Reviewed-by: goetz, nradomski ! src/hotspot/cpu/ppc/gc/shared/barrierSetAssembler_ppc.cpp ! src/hotspot/cpu/ppc/gc/shared/modRefBarrierSetAssembler_ppc.cpp ! src/hotspot/cpu/ppc/gc/shared/modRefBarrierSetAssembler_ppc.hpp Changeset: e393c5ea Author: Roman Kennke Date: 2021-10-12 13:16:20 +0000 URL: https://git.openjdk.java.net/loom/commit/e393c5ea9d9a254cdacbd311498c55c560e8ab25 8275074: Cleanup unused code in JFR LeakProfiler Reviewed-by: mgronlun ! src/hotspot/share/jfr/leakprofiler/chains/edgeUtils.cpp ! src/hotspot/share/jfr/leakprofiler/chains/edgeUtils.hpp - src/hotspot/share/jfr/leakprofiler/utilities/saveRestore.cpp - src/hotspot/share/jfr/leakprofiler/utilities/saveRestore.hpp Changeset: f6234606 Author: Christian Hagedorn Date: 2021-10-12 13:21:35 +0000 URL: https://git.openjdk.java.net/loom/commit/f62346066869b681d1cc9f63775393b11a48722a 8274911: testlibrary_tests/ir_framework/tests/TestIRMatching.java fails with "java.lang.RuntimeException: Should have thrown exception" Reviewed-by: kvn, thartmann ! test/hotspot/jtreg/compiler/lib/ir_framework/driver/IRMatcher.java ! test/hotspot/jtreg/testlibrary_tests/ir_framework/tests/TestIRMatching.java ! test/hotspot/jtreg/testlibrary_tests/ir_framework/tests/TestRunTests.java ! test/hotspot/jtreg/testlibrary_tests/ir_framework/tests/Utils.java Changeset: 07b1f1c2 Author: Brian Burkhalter Date: 2021-10-12 15:25:53 +0000 URL: https://git.openjdk.java.net/loom/commit/07b1f1c282ee0a7df6a6b0f240962a032ea3a413 8274548: (fc) FileChannel gathering write fails with IOException "Invalid argument" on macOS 11.6 Reviewed-by: alanb ! src/java.base/share/classes/sun/nio/ch/IOUtil.java ! src/java.base/unix/native/libnio/ch/IOUtil.c ! src/java.base/windows/native/libnio/ch/IOUtil.c + test/jdk/java/nio/channels/FileChannel/LargeGatheringWrite.java Changeset: 89999f70 Author: Dmitry Batrak Date: 2021-10-12 15:36:41 +0000 URL: https://git.openjdk.java.net/loom/commit/89999f70e06b41704c7c5b0f9a19582f90806a10 8275131: Exceptions after a touchpad gesture on macOS Reviewed-by: dmarkov, prr ! src/java.desktop/macosx/native/libawt_lwawt/awt/AWTWindow.m Changeset: b8bd259b Author: Evgeny Astigeevich Committer: Paul Hohensee Date: 2021-10-12 16:56:06 +0000 URL: https://git.openjdk.java.net/loom/commit/b8bd259bb83096f8727222a4e5cd84e80e096275 8271737: Only normalize the cached user.dir property once Reviewed-by: phh ! src/java.base/windows/classes/java/io/WinNTFileSystem.java Changeset: 8657f776 Author: Daniel D. Daugherty Date: 2021-10-12 17:05:47 +0000 URL: https://git.openjdk.java.net/loom/commit/8657f77608f37d7ff5254032858f2f16c7c204d5 8271514: support JFR use of new ThreadsList::Iterator Co-authored-by: Kim Barrett Reviewed-by: sspitsyn, mgronlun ! src/hotspot/share/jfr/utilities/jfrThreadIterator.cpp ! src/hotspot/share/jfr/utilities/jfrThreadIterator.hpp Changeset: 124f8237 Author: Sergey Tsypanov Committer: Sergey Bylokhov Date: 2021-10-12 19:13:17 +0000 URL: https://git.openjdk.java.net/loom/commit/124f82377ba93359bc59118ee315ba194080fa92 8268764: Use Long.hashCode() instead of int-cast where applicable Reviewed-by: kevinw, prr, kizune, serb ! src/java.desktop/share/classes/com/sun/media/sound/DLSSoundbank.java ! src/java.desktop/share/classes/com/sun/media/sound/WaveExtensibleFileReader.java ! src/java.rmi/share/classes/java/rmi/server/ObjID.java ! src/jdk.internal.vm.ci/share/classes/jdk.vm.ci.hotspot/src/jdk/vm/ci/hotspot/HotSpotResolvedJavaMethodImpl.java ! src/jdk.jdi/share/classes/com/sun/tools/jdi/FieldImpl.java ! src/jdk.jdi/share/classes/com/sun/tools/jdi/MethodImpl.java ! src/jdk.jdi/share/classes/com/sun/tools/jdi/ObjectReferenceImpl.java ! src/jdk.jdi/share/classes/com/sun/tools/jdi/ReferenceTypeImpl.java ! src/jdk.security.auth/share/classes/com/sun/security/auth/NTNumericCredential.java Changeset: 03c2b73e Author: Magnus Ihse Bursie Date: 2021-10-12 23:28:53 +0000 URL: https://git.openjdk.java.net/loom/commit/03c2b73e2112cdbcbd1230009de0a15a9bd31815 8275128: Build hsdis using normal build system Reviewed-by: erikj + make/Hsdis.gmk ! make/Main.gmk ! make/autoconf/configure.ac ! make/autoconf/help.m4 ! make/autoconf/jdk-options.m4 ! make/autoconf/spec.gmk.in ! src/utils/hsdis/README - src/utils/hsdis/hsdis-demo.c Changeset: b1b83500 Author: Daniel D. Daugherty Date: 2021-10-12 23:43:40 +0000 URL: https://git.openjdk.java.net/loom/commit/b1b83500a9c3a74bf39894e49eefd031d208b9b9 8275171: ProblemList compiler/codegen/aes/TestAESMain.java on linux-x64 and windows-x64 in -Xcomp mode Reviewed-by: iignatyev ! test/hotspot/jtreg/ProblemList-Xcomp.txt Changeset: ab34cced Author: Joe Darcy Date: 2021-10-13 05:26:33 +0000 URL: https://git.openjdk.java.net/loom/commit/ab34cced3beae765fe9d6b6acfef7e6a7f3082cd 8275186: Suppress warnings on non-serializable array component types in xml Reviewed-by: joehw ! src/java.xml/share/classes/com/sun/org/apache/bcel/internal/generic/TargetLostException.java ! src/java.xml/share/classes/com/sun/org/apache/xerces/internal/impl/dv/DatatypeException.java ! src/java.xml/share/classes/com/sun/org/apache/xerces/internal/impl/io/MalformedByteSequenceException.java ! src/java.xml/share/classes/com/sun/org/apache/xerces/internal/impl/xs/XMLSchemaException.java ! src/java.xml/share/classes/com/sun/org/apache/xerces/internal/impl/xs/traversers/XSDComplexTypeTraverser.java ! src/java.xml/share/classes/com/sun/org/apache/xpath/internal/axes/UnionPathIterator.java Changeset: cf828673 Author: Martin Doerr Date: 2021-10-13 07:12:52 +0000 URL: https://git.openjdk.java.net/loom/commit/cf828673a9b76fd3f26db9a3f714166861a65c9e 8275049: [ZGC] missing null check in ZNMethod::log_register Reviewed-by: nradomski, eosterlund, pliden ! src/hotspot/share/gc/z/zNMethod.cpp Changeset: 337b73a4 Author: Niklas Radomski Committer: Martin Doerr Date: 2021-10-13 07:36:52 +0000 URL: https://git.openjdk.java.net/loom/commit/337b73a459ba24aa529b7b097617434be1d0030e 8274851: [PPC64] Port zgc to linux on ppc64le Reviewed-by: ihse, pliden, mdoerr, eosterlund ! make/autoconf/jvm-features.m4 ! make/hotspot/gensrc/GensrcAdlc.gmk ! src/hotspot/cpu/ppc/assembler_ppc.hpp + src/hotspot/cpu/ppc/gc/z/zBarrierSetAssembler_ppc.cpp + src/hotspot/cpu/ppc/gc/z/zBarrierSetAssembler_ppc.hpp + src/hotspot/cpu/ppc/gc/z/zGlobals_ppc.cpp + src/hotspot/cpu/ppc/gc/z/zGlobals_ppc.hpp + src/hotspot/cpu/ppc/gc/z/z_ppc.ad ! src/hotspot/cpu/ppc/ppc.ad ! src/hotspot/cpu/ppc/vmreg_ppc.hpp + src/hotspot/os_cpu/linux_ppc/gc/z/zSyscall_linux_ppc.hpp Changeset: c3b75c6c Author: Thomas Schatzl Date: 2021-10-13 08:10:55 +0000 URL: https://git.openjdk.java.net/loom/commit/c3b75c6cdf03ffa3c887bf3db29e17668b228f79 8274516: [REDO] JDK-8271880: Tighten condition for excluding regions from collecting cards with cross-references Reviewed-by: sjohanss, ayang ! src/hotspot/share/gc/g1/g1CollectedHeap.cpp ! src/hotspot/share/gc/g1/g1CollectedHeap.hpp ! src/hotspot/share/gc/g1/g1CollectedHeap.inline.hpp ! src/hotspot/share/gc/g1/g1EvacFailure.cpp ! src/hotspot/share/gc/g1/g1EvacFailure.hpp ! src/hotspot/share/gc/g1/g1HeapRegionAttr.hpp ! src/hotspot/share/gc/g1/g1OopClosures.hpp ! src/hotspot/share/gc/g1/g1ParScanThreadState.cpp ! src/hotspot/share/gc/g1/g1ParScanThreadState.hpp ! src/hotspot/share/gc/g1/g1ParScanThreadState.inline.hpp ! src/hotspot/share/gc/g1/g1YoungCollector.cpp ! src/hotspot/share/gc/g1/g1YoungCollector.hpp ! src/hotspot/share/gc/g1/g1YoungGCPostEvacuateTasks.cpp ! src/hotspot/share/gc/g1/g1YoungGCPostEvacuateTasks.hpp ! src/hotspot/share/gc/shared/referenceProcessor.cpp ! src/hotspot/share/gc/shared/referenceProcessor.hpp Changeset: dcf428c7 Author: Andrey Turbanov Committer: Serguei Spitsyn Date: 2021-10-13 09:07:07 +0000 URL: https://git.openjdk.java.net/loom/commit/dcf428c7a74e568deaededfc11d3c4e1bf7821f2 8275075: Remove unnecessary conversion to String in jdk.hotspot.agent Reviewed-by: sspitsyn, cjplummer ! src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/HSDB.java ! src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/interpreter/BytecodeLoadConstant.java ! src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/runtime/PerfDataEntry.java ! src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/ui/classbrowser/HTMLGenerator.java Changeset: b8cb76ad Author: Jan Lahoda Date: 2021-10-13 10:15:54 +0000 URL: https://git.openjdk.java.net/loom/commit/b8cb76ad210cb3e7524c7f5b13cfe57746ac05d4 8273682: Upgrade Jline to 3.20.0 Reviewed-by: sundar ! src/jdk.internal.le/share/classes/jdk/internal/org/jline/reader/Candidate.java + src/jdk.internal.le/share/classes/jdk/internal/org/jline/reader/CompletionMatcher.java - src/jdk.internal.le/share/classes/jdk/internal/org/jline/reader/ConfigurationPath.java ! src/jdk.internal.le/share/classes/jdk/internal/org/jline/reader/EndOfFileException.java ! src/jdk.internal.le/share/classes/jdk/internal/org/jline/reader/LineReader.java ! src/jdk.internal.le/share/classes/jdk/internal/org/jline/reader/LineReaderBuilder.java ! src/jdk.internal.le/share/classes/jdk/internal/org/jline/reader/Parser.java + src/jdk.internal.le/share/classes/jdk/internal/org/jline/reader/PrintAboveWriter.java - src/jdk.internal.le/share/classes/jdk/internal/org/jline/reader/ScriptEngine.java + src/jdk.internal.le/share/classes/jdk/internal/org/jline/reader/impl/CompletionMatcherImpl.java ! src/jdk.internal.le/share/classes/jdk/internal/org/jline/reader/impl/DefaultHighlighter.java ! src/jdk.internal.le/share/classes/jdk/internal/org/jline/reader/impl/DefaultParser.java ! src/jdk.internal.le/share/classes/jdk/internal/org/jline/reader/impl/LineReaderImpl.java ! src/jdk.internal.le/share/classes/jdk/internal/org/jline/reader/impl/ReaderUtils.java ! src/jdk.internal.le/share/classes/jdk/internal/org/jline/reader/impl/completer/StringsCompleter.java + src/jdk.internal.le/share/classes/jdk/internal/org/jline/reader/impl/completer/SystemCompleter.java ! src/jdk.internal.le/share/classes/jdk/internal/org/jline/reader/impl/history/DefaultHistory.java ! src/jdk.internal.le/share/classes/jdk/internal/org/jline/terminal/Terminal.java ! src/jdk.internal.le/share/classes/jdk/internal/org/jline/terminal/TerminalBuilder.java ! src/jdk.internal.le/share/classes/jdk/internal/org/jline/terminal/impl/AbstractTerminal.java ! src/jdk.internal.le/share/classes/jdk/internal/org/jline/terminal/impl/AbstractWindowsTerminal.java ! src/jdk.internal.le/share/classes/jdk/internal/org/jline/terminal/spi/JansiSupport.java ! src/jdk.internal.le/share/classes/jdk/internal/org/jline/terminal/spi/JnaSupport.java ! src/jdk.internal.le/share/classes/jdk/internal/org/jline/utils/AttributedCharSequence.java ! src/jdk.internal.le/share/classes/jdk/internal/org/jline/utils/AttributedString.java ! src/jdk.internal.le/share/classes/jdk/internal/org/jline/utils/AttributedStringBuilder.java ! src/jdk.internal.le/share/classes/jdk/internal/org/jline/utils/AttributedStyle.java + src/jdk.internal.le/share/classes/jdk/internal/org/jline/utils/ColorPalette.java ! src/jdk.internal.le/share/classes/jdk/internal/org/jline/utils/Colors.java ! src/jdk.internal.le/share/classes/jdk/internal/org/jline/utils/Curses.java ! src/jdk.internal.le/share/classes/jdk/internal/org/jline/utils/Display.java ! src/jdk.internal.le/share/classes/jdk/internal/org/jline/utils/InfoCmp.java ! src/jdk.internal.le/share/classes/jdk/internal/org/jline/utils/Log.java ! src/jdk.internal.le/share/classes/jdk/internal/org/jline/utils/NonBlockingPumpInputStream.java ! src/jdk.internal.le/share/classes/jdk/internal/org/jline/utils/NonBlockingPumpReader.java ! src/jdk.internal.le/share/classes/jdk/internal/org/jline/utils/PumpReader.java ! src/jdk.internal.le/share/classes/jdk/internal/org/jline/utils/Signals.java ! src/jdk.internal.le/share/classes/jdk/internal/org/jline/utils/StyleResolver.java + src/jdk.internal.le/share/classes/jdk/internal/org/jline/utils/rxvt-basic.caps + src/jdk.internal.le/share/classes/jdk/internal/org/jline/utils/rxvt-unicode-256color.caps + src/jdk.internal.le/share/classes/jdk/internal/org/jline/utils/rxvt-unicode.caps + src/jdk.internal.le/share/classes/jdk/internal/org/jline/utils/rxvt.caps ! src/jdk.internal.le/share/legal/jline.md ! src/jdk.internal.le/windows/classes/jdk/internal/org/jline/terminal/impl/jna/JnaSupportImpl.java ! src/jdk.internal.le/windows/classes/jdk/internal/org/jline/terminal/impl/jna/win/JnaWinSysTerminal.java ! test/jdk/jdk/internal/jline/AbstractWindowsTerminalTest.java ! test/jdk/jdk/internal/jline/KeyConversionTest.java Changeset: 5ffb5d10 Author: Andrey Turbanov Committer: Pavel Rappo Date: 2021-10-13 11:34:24 +0000 URL: https://git.openjdk.java.net/loom/commit/5ffb5d100f3383f9afaf20c8a659971522153505 8272992: Replace usages of Collections.sort with List.sort call in jdk.* modules Reviewed-by: cjplummer, prappo ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/ClassUseWriter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/util/Group.java ! src/jdk.jcmd/share/classes/sun/tools/jstat/JStatLogger.java ! src/jdk.jcmd/share/classes/sun/tools/jstat/Jstat.java ! src/jdk.jconsole/share/classes/sun/tools/jconsole/inspector/XOpenTypeViewer.java Changeset: 451a2965 Author: Jie Fu Date: 2021-10-13 14:30:11 +0000 URL: https://git.openjdk.java.net/loom/commit/451a296510994ff9fe1e0381900ffa9a8a1caa54 8275173: testlibrary_tests/ir_framework/tests/TestCheckedTests.java fails after JDK-8274911 Reviewed-by: chagedorn, thartmann ! test/hotspot/jtreg/testlibrary_tests/ir_framework/tests/TestCheckedTests.java Changeset: d8f6b6c1 Author: Fairoz Matte Committer: Ioi Lam Date: 2021-10-13 15:38:36 +0000 URL: https://git.openjdk.java.net/loom/commit/d8f6b6c19a591512ff4e956823cb87a83e088ae8 8274718: runtime/cds/appcds/LambdaEagerInit.java fails with -XX:-CompactStrings Reviewed-by: iklam, ccheung ! test/hotspot/jtreg/runtime/cds/appcds/LambdaEagerInit.java From shade at openjdk.java.net Fri Oct 15 16:32:05 2021 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Fri, 15 Oct 2021 16:32:05 GMT Subject: Integrated: Harmonize actual and expected signature of Continuation.doYield In-Reply-To: References: Message-ID: On Thu, 14 Oct 2021 15:23:17 GMT, Aleksey Shipilev wrote: > Found this inconsistency when reading the Loom code during x86_32 porting. `Continuation.doYield` has an `int` argument, yet C2's `OptoRuntime::continuation_doYield_Type` does not declare it. I think this is basically asking for trouble in C2, as the optimizations may ask the function type, discover there is an input of type `int`, but no such input is actually present. Runtime stubs seem to be also oblivious there is an argument, and calling conventions probably put it in the register on x86_64 and AArch64. On other arches, that might not be true. > > I don't believe it breaks anything now, but let's fix it, while we are at it. It looks to me that `Continuation.doYield` is ever called with `0`, so we might just drop its `int` argument? Not sure if `scopes` is something Java code plans to use. > > Additional testing: > - [x] Linux x86_64 fastdebug, `jdk_loom hotspot_loom` This pull request has now been integrated. Changeset: 0ca7be1c Author: Aleksey Shipilev Committer: Ron Pressler URL: https://git.openjdk.java.net/loom/commit/0ca7be1c4434170bf96d65b1e67ddc07298fd357 Stats: 12 lines in 5 files changed: 2 ins; 4 del; 6 mod Harmonize actual and expected signature of Continuation.doYield Reviewed-by: rpressler ------------- PR: https://git.openjdk.java.net/loom/pull/78 From rpressler at openjdk.java.net Fri Oct 15 16:33:00 2021 From: rpressler at openjdk.java.net (Ron Pressler) Date: Fri, 15 Oct 2021 16:33:00 GMT Subject: RFR: Remove -XX:ContPerfTest In-Reply-To: References: Message-ID: On Thu, 14 Oct 2021 14:09:46 GMT, Aleksey Shipilev wrote: > When porting to x86_32, I noticed there is a diagnostic `ContPerfTest` option which effectively takes different paths, depending on diagnostic setting. Is it still useful? For a cleanup/preparation-for-upstreaming, I propose we roll it back. > > Additional testing: > - [x] Linux x86_64 fastdebug `jdk_loom hotspot_loom` You can leave it open. ------------- PR: https://git.openjdk.java.net/loom/pull/76 From rpressler at openjdk.java.net Fri Oct 15 16:33:03 2021 From: rpressler at openjdk.java.net (Ron Pressler) Date: Fri, 15 Oct 2021 16:33:03 GMT Subject: RFR: Drop x86_32 code from x86_64-specific files In-Reply-To: References: Message-ID: On Thu, 14 Oct 2021 14:29:00 GMT, Aleksey Shipilev wrote: > There are instances of x86_32 code in x86_64-specific files. That code would not be ever used and thus would bit rot, as it would never be compiled on x86_32. The porting to x86_32 would make the x86_32-specific versions of the StubGenerator. This simplifies x86_64 StubGenerator a bit. > > Additional testing: > - [x] Linux x86_64 fastdebug `jdk_loom hotspot_loom` Nice! ------------- Marked as reviewed by rpressler (Lead). PR: https://git.openjdk.java.net/loom/pull/77 From shade at openjdk.java.net Fri Oct 15 17:15:01 2021 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Fri, 15 Oct 2021 17:15:01 GMT Subject: Integrated: Drop x86_32 code from x86_64-specific files In-Reply-To: References: Message-ID: On Thu, 14 Oct 2021 14:29:00 GMT, Aleksey Shipilev wrote: > There are instances of x86_32 code in x86_64-specific files. That code would not be ever used and thus would bit rot, as it would never be compiled on x86_32. The porting to x86_32 would make the x86_32-specific versions of the StubGenerator. This simplifies x86_64 StubGenerator a bit. > > Additional testing: > - [x] Linux x86_64 fastdebug `jdk_loom hotspot_loom` This pull request has now been integrated. Changeset: 70824a1e Author: Aleksey Shipilev Committer: Ron Pressler URL: https://git.openjdk.java.net/loom/commit/70824a1ecd4c736de8377e911cf5305192afe021 Stats: 32 lines in 1 file changed: 0 ins; 16 del; 16 mod Drop x86_32 code from x86_64-specific files Reviewed-by: rpressler ------------- PR: https://git.openjdk.java.net/loom/pull/77 From alanb at openjdk.java.net Sun Oct 17 19:05:06 2021 From: alanb at openjdk.java.net (Alan Bateman) Date: Sun, 17 Oct 2021 19:05:06 GMT Subject: RFR: avoid extra park of vthread when using fixed thread pool [v2] In-Reply-To: References: Message-ID: On Mon, 30 Aug 2021 12:03:23 GMT, Miao Zheng wrote: >> The CustomScheduler test was indeed failing with this change but it's due to a test issue where it runs the scheduler tasks on the current thread. I've remove that case from the test so I think we are good to go now. > > @AlanBateman Thanks for your review. @miao-zheng The copyright header on the test is causing problems for a script that checks the copyright header on files. It doesn't seem to match the headers on files contributed by THL A29 Limited or Tencent. Can you check this? ------------- PR: https://git.openjdk.java.net/loom/pull/59 From augustnagro at gmail.com Mon Oct 18 03:14:33 2021 From: augustnagro at gmail.com (August Nagro) Date: Sun, 17 Oct 2021 20:14:33 -0700 Subject: Async-Await in Vertx with Project Loom Message-ID: Hello; I recently implemented async/await in Vertx using Project Loom. Feedback and code review are very welcome. The project is only about 100 lines of code. Hopefully something similar could be merged into `vertx-core` when Loom is released. https://github.com/AugustNagro/vertx-loom Cheers, August From duke at openjdk.java.net Mon Oct 18 03:33:22 2021 From: duke at openjdk.java.net (Miao Zheng) Date: Mon, 18 Oct 2021 03:33:22 GMT Subject: RFR: Fix problem of copyright header Message-ID: <0gghc3KtzKUDDkmGLyvtRtPXmvKD8aEeHpCKS6fGrf4=.d0a05797-cfb5-4ad6-b266-f6bbfc681c8e@github.com> The copyright of this test case have some problems, I try to fix this. ------------- Commit messages: - Fix problem of copyright header Changes: https://git.openjdk.java.net/loom/pull/79/files Webrev: https://webrevs.openjdk.java.net/?repo=loom&pr=79&range=00 Stats: 18 lines in 1 file changed: 4 ins; 3 del; 11 mod Patch: https://git.openjdk.java.net/loom/pull/79.diff Fetch: git fetch https://git.openjdk.java.net/loom pull/79/head:pull/79 PR: https://git.openjdk.java.net/loom/pull/79 From duke at openjdk.java.net Mon Oct 18 03:34:08 2021 From: duke at openjdk.java.net (Miao Zheng) Date: Mon, 18 Oct 2021 03:34:08 GMT Subject: RFR: avoid extra park of vthread when using fixed thread pool [v2] In-Reply-To: References: Message-ID: <1xcBQYV1r0T9BsLi2dJe2KzvLvjsSXEfsJmHF-RLOTA=.9af1623a-12cc-4a90-8b07-9d52d016448d@github.com> On Thu, 26 Aug 2021 11:00:58 GMT, Miao Zheng wrote: >> The test case of ParkWithFixedThreadPool.java create 300 virtual threads, each vthread(exclude latest vthread) park itself and unpark previous vthread. The expected result is any vthread can finish. >> >> Running this test case in slowdebug and the test will random hang. >> >> There are three vthreads which are vt-1, vt-2, vt-3; >> (1) vt-1 take the ReentrantLock, and vt-2 try to unpark vt-1, and vt-2 fail to get ReentrantLock so it park itself( the call stack is shown below); >> (2)vt-3 unpark vt-2, and vt-2 try to get ReentrantLock again, but the ReentrantLock is still owned by vt-1, vt-2 park itself again; >> (3)vt-1 release the ReentrantLock and unpark vt-2, vt-2 park itself at ParkWithFixedThreadPool.java:55, and it will never unpark.(because the unpark from vt-3 has consumed) >> >> The reason is scheduler.execute() will try to alloc a Reentrant lock when using fix thread pool, the call stack is like: >> at java.lang.VirtualThread.tryPark(VirtualThread.java:472) >> at java.lang.VirtualThread.park(VirtualThread.java:424) >> at java.lang.System$2.parkVirtualThread(System.java:1279) >> at sun.misc.VirtualThreads.park(VirtualThreads.java:56) >> at java.util.concurrent.locks.LockSupport.park(LockSupport.java:183) >> at java.util.concurrent.locks.AbstractQueuedSynchronizer.parkAndCheckInterrupt(AbstractQueuedSynchronizer.java:836) >> at java.util.concurrent.locks.AbstractQueuedSynchronizer.acquireQueued(AbstractQueuedSynchronizer.java:870) >> at java.util.concurrent.locks.AbstractQueuedSynchronizer.acquire(AbstractQueuedSynchronizer.java:1199) >> at java.util.concurrent.locks.ReentrantLock$NonfairSync.lock(ReentrantLock.java:209) >> at java.util.concurrent.locks.ReentrantLock.lock(ReentrantLock.java:285) >> at java.util.concurrent.LinkedBlockingQueue.offer(LinkedBlockingQueue.java:418) >> at java.util.concurrent.ThreadPoolExecutor.execute(ThreadPoolExecutor.java:1371) >> at java.lang.VirtualThread.unpark(VirtualThread.java:502) >> at java.lang.System$2.unparkVirtualThread(System.java:1287) >> at sun.misc.VirtualThreads.unpark(VirtualThreads.java:70) >> at ParkWithFixedThreadPool$1.run(ParkWithFixedThreadPool.java:51) >> >> >> The solution is switch back to carrier thread before call scheduler.execute(); > > Miao Zheng has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. Sorry for this problem, I have create a new PR to fix the problem. ------------- PR: https://git.openjdk.java.net/loom/pull/59 From alanb at openjdk.java.net Mon Oct 18 05:54:56 2021 From: alanb at openjdk.java.net (Alan Bateman) Date: Mon, 18 Oct 2021 05:54:56 GMT Subject: RFR: Fix problem of copyright header In-Reply-To: <0gghc3KtzKUDDkmGLyvtRtPXmvKD8aEeHpCKS6fGrf4=.d0a05797-cfb5-4ad6-b266-f6bbfc681c8e@github.com> References: <0gghc3KtzKUDDkmGLyvtRtPXmvKD8aEeHpCKS6fGrf4=.d0a05797-cfb5-4ad6-b266-f6bbfc681c8e@github.com> Message-ID: On Mon, 18 Oct 2021 03:27:26 GMT, Miao Zheng wrote: > The copyright of this test case have some problems, I try to fix this. Thanks for this. ------------- Marked as reviewed by alanb (Committer). PR: https://git.openjdk.java.net/loom/pull/79 From duke at openjdk.java.net Mon Oct 18 06:04:32 2021 From: duke at openjdk.java.net (duke) Date: Mon, 18 Oct 2021 06:04:32 GMT Subject: git: openjdk/loom: fibers: Fix copyright header Message-ID: Changeset: e3e10b2d Author: Alan Bateman Date: 2021-10-18 06:52:09 +0000 URL: https://git.openjdk.java.net/loom/commit/e3e10b2d865554007204cb30bc21684488a2d55d Fix copyright header ! src/hotspot/cpu/arm/continuation_arm.inline.hpp ! src/hotspot/cpu/ppc/continuation_ppc.inline.hpp ! src/hotspot/cpu/s390/continuation_s390.inline.hpp ! src/hotspot/cpu/zero/continuation_zero.inline.hpp From forax at univ-mlv.fr Mon Oct 18 06:20:06 2021 From: forax at univ-mlv.fr (Remi Forax) Date: Mon, 18 Oct 2021 08:20:06 +0200 (CEST) Subject: Async-Await in Vertx with Project Loom In-Reply-To: References: Message-ID: <1696490001.29025.1634538006212.JavaMail.zimbra@u-pem.fr> ----- Original Message ----- > From: "August Nagro" > To: vertx-dev at googlegroups.com, vertx at googlegroups.com, "loom-dev" > Sent: Lundi 18 Octobre 2021 05:14:33 > Subject: Async-Await in Vertx with Project Loom > Hello; I recently implemented async/await in Vertx using Project Loom. > > Feedback and code review are very welcome. The project is only about 100 > lines of code. Hopefully something similar could be merged into > `vertx-core` when Loom is released. > > https://github.com/AugustNagro/vertx-loom nice, but you have the same issue that i have with my re-implementation of Erlang message dispatch, the class Continuation is not visible anymore (it has been moved to jdk.internal). > > Cheers, > > August R?mi From duke at openjdk.java.net Mon Oct 18 07:19:03 2021 From: duke at openjdk.java.net (Miao Zheng) Date: Mon, 18 Oct 2021 07:19:03 GMT Subject: Integrated: Fix problem of copyright header In-Reply-To: <0gghc3KtzKUDDkmGLyvtRtPXmvKD8aEeHpCKS6fGrf4=.d0a05797-cfb5-4ad6-b266-f6bbfc681c8e@github.com> References: <0gghc3KtzKUDDkmGLyvtRtPXmvKD8aEeHpCKS6fGrf4=.d0a05797-cfb5-4ad6-b266-f6bbfc681c8e@github.com> Message-ID: <5u0Z7Aiu_3mU2Ik4OEn08DaEKFUhi-rHd6xLS6w8yCI=.5986ad25-ca88-4522-a97e-fd549caf0f23@github.com> On Mon, 18 Oct 2021 03:27:26 GMT, Miao Zheng wrote: > The copyright of this test case have some problems, I try to fix this. This pull request has now been integrated. Changeset: 8c2a17f9 Author: miao zheng Committer: Alan Bateman URL: https://git.openjdk.java.net/loom/commit/8c2a17f93e44be762bf4550bf17434f5c9c0a442 Stats: 18 lines in 1 file changed: 4 ins; 3 del; 11 mod Fix problem of copyright header Reviewed-by: alanb ------------- PR: https://git.openjdk.java.net/loom/pull/79 From augustnagro at gmail.com Mon Oct 18 13:40:24 2021 From: augustnagro at gmail.com (August Nagro) Date: Mon, 18 Oct 2021 06:40:24 -0700 Subject: Async-Await in Vertx with Project Loom In-Reply-To: <1696490001.29025.1634538006212.JavaMail.zimbra@u-pem.fr> References: <1696490001.29025.1634538006212.JavaMail.zimbra@u-pem.fr> Message-ID: Thanks for the info.. that's a bummer. Is it a permanent API change? On Sun, Oct 17, 2021, 11:20 PM Remi Forax wrote: > ----- Original Message ----- > > From: "August Nagro" > > To: vertx-dev at googlegroups.com, vertx at googlegroups.com, "loom-dev" < > loom-dev at openjdk.java.net> > > Sent: Lundi 18 Octobre 2021 05:14:33 > > Subject: Async-Await in Vertx with Project Loom > > > Hello; I recently implemented async/await in Vertx using Project Loom. > > > > Feedback and code review are very welcome. The project is only about 100 > > lines of code. Hopefully something similar could be merged into > > `vertx-core` when Loom is released. > > > > https://github.com/AugustNagro/vertx-loom > > nice, > but you have the same issue that i have with my re-implementation of > Erlang message dispatch, > the class Continuation is not visible anymore (it has been moved to > jdk.internal). > > > > > Cheers, > > > > August > > R?mi > From dholmes at openjdk.java.net Mon Oct 18 02:45:08 2021 From: dholmes at openjdk.java.net (David Holmes) Date: Mon, 18 Oct 2021 02:45:08 GMT Subject: RFR: avoid extra park of vthread when using fixed thread pool [v2] In-Reply-To: References: Message-ID: On Thu, 26 Aug 2021 11:00:58 GMT, Miao Zheng wrote: >> The test case of ParkWithFixedThreadPool.java create 300 virtual threads, each vthread(exclude latest vthread) park itself and unpark previous vthread. The expected result is any vthread can finish. >> >> Running this test case in slowdebug and the test will random hang. >> >> There are three vthreads which are vt-1, vt-2, vt-3; >> (1) vt-1 take the ReentrantLock, and vt-2 try to unpark vt-1, and vt-2 fail to get ReentrantLock so it park itself( the call stack is shown below); >> (2)vt-3 unpark vt-2, and vt-2 try to get ReentrantLock again, but the ReentrantLock is still owned by vt-1, vt-2 park itself again; >> (3)vt-1 release the ReentrantLock and unpark vt-2, vt-2 park itself at ParkWithFixedThreadPool.java:55, and it will never unpark.(because the unpark from vt-3 has consumed) >> >> The reason is scheduler.execute() will try to alloc a Reentrant lock when using fix thread pool, the call stack is like: >> at java.lang.VirtualThread.tryPark(VirtualThread.java:472) >> at java.lang.VirtualThread.park(VirtualThread.java:424) >> at java.lang.System$2.parkVirtualThread(System.java:1279) >> at sun.misc.VirtualThreads.park(VirtualThreads.java:56) >> at java.util.concurrent.locks.LockSupport.park(LockSupport.java:183) >> at java.util.concurrent.locks.AbstractQueuedSynchronizer.parkAndCheckInterrupt(AbstractQueuedSynchronizer.java:836) >> at java.util.concurrent.locks.AbstractQueuedSynchronizer.acquireQueued(AbstractQueuedSynchronizer.java:870) >> at java.util.concurrent.locks.AbstractQueuedSynchronizer.acquire(AbstractQueuedSynchronizer.java:1199) >> at java.util.concurrent.locks.ReentrantLock$NonfairSync.lock(ReentrantLock.java:209) >> at java.util.concurrent.locks.ReentrantLock.lock(ReentrantLock.java:285) >> at java.util.concurrent.LinkedBlockingQueue.offer(LinkedBlockingQueue.java:418) >> at java.util.concurrent.ThreadPoolExecutor.execute(ThreadPoolExecutor.java:1371) >> at java.lang.VirtualThread.unpark(VirtualThread.java:502) >> at java.lang.System$2.unparkVirtualThread(System.java:1287) >> at sun.misc.VirtualThreads.unpark(VirtualThreads.java:70) >> at ParkWithFixedThreadPool$1.run(ParkWithFixedThreadPool.java:51) >> >> >> The solution is switch back to carrier thread before call scheduler.execute(); > > Miao Zheng has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision: > > avoid extra park of vthread when using fixed thread pool The header has extra blank lines at the start and end that need to be removed. ------------- PR: https://git.openjdk.java.net/loom/pull/59 From duke at openjdk.java.net Tue Oct 19 08:48:28 2021 From: duke at openjdk.java.net (duke) Date: Tue, 19 Oct 2021 08:48:28 GMT Subject: git: openjdk/loom: fibers: fixed 8275001: hotspot/jtreg/serviceability/jvmti/negative/thrstat04/thrstat04.java SEGV in java_lang_VirtualThread::is_instance Message-ID: <7af47399-99a0-4302-841f-59aca78e10dc@openjdk.java.net> Changeset: 991d2764 Author: Serguei Spitsyn Date: 2021-10-19 08:47:04 +0000 URL: https://git.openjdk.java.net/loom/commit/991d27640a15105616442732f2c7f2bb47f7e081 fixed 8275001: hotspot/jtreg/serviceability/jvmti/negative/thrstat04/thrstat04.java SEGV in java_lang_VirtualThread::is_instance ! src/hotspot/share/prims/jvmtiExport.cpp From julien at julienviet.com Tue Oct 19 06:49:18 2021 From: julien at julienviet.com (Julien Viet) Date: Tue, 19 Oct 2021 08:49:18 +0200 Subject: [vertx-dev] Async-Await in Vertx with Project Loom In-Reply-To: References: Message-ID: Hi August, this is very exciting, there are a few ways Vert.x could use Loom and experimentations need to be done, thanks for coming with this project. I can see you are using the Continuation class from Loom, do you know wether this class will remain available ? I attended a presentation a long time ago and the presenter (Loom lead) said that such classes would remain internal. I encourage you to share this with the async / Vert.x community, I created a Loom channel [1] on our discord server where people like you can share their experiment and discuss Loom + Vert.x :-) Julien [1] https://discord.com/channels/751380286071242794/899911362770268181 On Mon, Oct 18, 2021 at 5:14 AM August Nagro wrote: > > Hello; I recently implemented async/await in Vertx using Project Loom. > > Feedback and code review are very welcome. The project is only about 100 lines of code. Hopefully something similar could be merged into `vertx-core` when Loom is released. > > https://github.com/AugustNagro/vertx-loom > > Cheers, > > August > > -- > You received this message because you are subscribed to the Google Groups "vertx-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an email to vertx-dev+unsubscribe at googlegroups.com. > To view this discussion on the web, visit https://groups.google.com/d/msgid/vertx-dev/CAHNb0ZN9%2B9HDNfgXj63%2BhFkW6Us%2B3d3TQFGu8aX2fyOxGUiLmw%40mail.gmail.com. From ron.pressler at oracle.com Tue Oct 19 10:31:29 2021 From: ron.pressler at oracle.com (Ron Pressler) Date: Tue, 19 Oct 2021 10:31:29 +0000 Subject: Async-Await in Vertx with Project Loom In-Reply-To: References: <1696490001.29025.1634538006212.JavaMail.zimbra@u-pem.fr> Message-ID: > On 18 Oct 2021, at 14:40, August Nagro wrote: > > Thanks for the info.. that's a bummer. Is it a permanent API change? For Continuation in its current form ? yes. It is not safe and could even result in miscompilation if not used carefully (the JIT compilers are allowed to assume that the identity of the current thread does not change within a method). Many of its use-cases could be achieved with a custom scheduler, although, depending on how much time we have to consider that API, it might not make the first Preview, either. ? Ron From duke at openjdk.java.net Tue Oct 19 16:03:21 2021 From: duke at openjdk.java.net (duke) Date: Tue, 19 Oct 2021 16:03:21 GMT Subject: git: openjdk/loom: fibers: Clear thawed frame's arguments' bits in bitmap to prevent a leak Message-ID: <050cf122-eccc-447f-8ed4-410f9b945553@openjdk.java.net> Changeset: a51e1100 Author: Ron Pressler Date: 2021-10-19 16:59:38 +0000 URL: https://git.openjdk.java.net/loom/commit/a51e1100bce24347fb5c3c916630762b103e0f0b Clear thawed frame's arguments' bits in bitmap to prevent a leak ! src/hotspot/share/runtime/continuation.cpp ! test/jdk/ProblemList-vthread.txt + test/jdk/jdk/internal/vm/Continuation/ClassUnloading.java From augustnagro at gmail.com Tue Oct 19 18:47:48 2021 From: augustnagro at gmail.com (August Nagro) Date: Tue, 19 Oct 2021 11:47:48 -0700 Subject: Async-Await in Vertx with Project Loom In-Reply-To: References: <1696490001.29025.1634538006212.JavaMail.zimbra@u-pem.fr> Message-ID: That's understandable. I hope eventually the ability to await Futures (or Rx, Mutiny, ZIO, etc) can be expressed, because it adds a lot of value to these ecosystems. You can 'code like you're sync', while still getting a Monad when you want, like to configure retry and timeout. With regards to a custom scheduler, can you elaborate on that idea? On Tue, Oct 19, 2021, 3:31 AM Ron Pressler wrote: > > > > On 18 Oct 2021, at 14:40, August Nagro wrote: > > > > Thanks for the info.. that's a bummer. Is it a permanent API change? > > For Continuation in its current form ? yes. It is not safe and could even > result in miscompilation if not > used carefully (the JIT compilers are allowed to assume that the identity > of the current thread does not change > within a method). Many of its use-cases could be achieved with a custom > scheduler, although, depending on > how much time we have to consider that API, it might not make the first > Preview, either. > > ? Ron > > From augustnagro at gmail.com Thu Oct 21 07:12:21 2021 From: augustnagro at gmail.com (August Nagro) Date: Thu, 21 Oct 2021 00:12:21 -0700 Subject: [vertx-dev] Async-Await in Vertx with Project Loom In-Reply-To: References: Message-ID: Thanks Julien! I had cc'd loom-dev, which told me the same; Continuation is now private. ( https://mail.openjdk.java.net/pipermail/loom-dev/2021-October/002989.html). I updated the repo README with a warning. Ron pointed out that a custom scheduler could support some Continuation use cases, but now that I've thought about it some more; I think we can actually implement 'async/await' with just a Virtual Thread and a lock. Here's a gist with one approach: https://gist.github.com/AugustNagro/29eaddbd281621a35dcd8b98337d5369 Now my big question is how Virtual Threads fit into the Vertx/Netty event-loop story. Cheers, - August On Mon, Oct 18, 2021 at 11:49 PM Julien Viet wrote: > Hi August, > > this is very exciting, there are a few ways Vert.x could use Loom and > experimentations need to be done, thanks for coming with this project. > > I can see you are using the Continuation class from Loom, do you know > wether this class will remain available ? I attended a presentation a > long time ago and the presenter (Loom lead) said that such classes > would remain internal. > > I encourage you to share this with the async / Vert.x community, I > created a Loom channel [1] on our discord server where people like you > can share their experiment and discuss Loom + Vert.x :-) > > Julien > > [1] https://discord.com/channels/751380286071242794/899911362770268181 > > On Mon, Oct 18, 2021 at 5:14 AM August Nagro > wrote: > > > > Hello; I recently implemented async/await in Vertx using Project Loom. > > > > Feedback and code review are very welcome. The project is only about 100 > lines of code. Hopefully something similar could be merged into > `vertx-core` when Loom is released. > > > > https://github.com/AugustNagro/vertx-loom > > > > Cheers, > > > > August > > > > -- > > You received this message because you are subscribed to the Google > Groups "vertx-dev" group. > > To unsubscribe from this group and stop receiving emails from it, send > an email to vertx-dev+unsubscribe at googlegroups.com. > > To view this discussion on the web, visit > https://groups.google.com/d/msgid/vertx-dev/CAHNb0ZN9%2B9HDNfgXj63%2BhFkW6Us%2B3d3TQFGu8aX2fyOxGUiLmw%40mail.gmail.com > . > > -- > You received this message because you are subscribed to the Google Groups > "vertx-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to vertx-dev+unsubscribe at googlegroups.com. > To view this discussion on the web, visit > https://groups.google.com/d/msgid/vertx-dev/CA%2BH-X4-Uf6t7wanrSKo%2BNwGJwixz5cWQVPOgtcgsJyOHb_RVog%40mail.gmail.com > . > From Alan.Bateman at oracle.com Thu Oct 21 08:12:36 2021 From: Alan.Bateman at oracle.com (Alan Bateman) Date: Thu, 21 Oct 2021 09:12:36 +0100 Subject: [vertx-dev] Async-Await in Vertx with Project Loom In-Reply-To: References: Message-ID: On 21/10/2021 08:12, August Nagro wrote: > : > > Now my big question is how Virtual Threads fit into the Vertx/Netty > event-loop story. I don't know if anyone has tried to run the event loop in a virtual thread but there has been a few reports of off-loading to virtual threads. This is problematic due to Netty's thread local buffer caches where a lot of the time is spent initializing and allocating native memory. Project Panama Foreign Memory API is looking very good and maybe some future version of Netty could build an allocator and buffer pool based on that and at the same time play well with virtual threads. -Alan From augustnagro at gmail.com Fri Oct 22 05:43:22 2021 From: augustnagro at gmail.com (August Nagro) Date: Thu, 21 Oct 2021 22:43:22 -0700 Subject: [vertx-dev] Async-Await in Vertx with Project Loom In-Reply-To: References: Message-ID: Altan Ozlu made a benchmark in 2019 which looked promising: https://github.com/altanozlu/NettyFiberBenchmarks . It is a big change though; more than I could bite off. I changed my async-await implementation to use Virtual Threads and Locking. It also uses a custom Executor like Ron suggested, to schedule tasks on the Event Loop Context. Doing so keeps everything asynchronous but still single-threaded, the big benefit of using Verticles. https://github.com/AugustNagro/vertx-async-await I also made an async-await implementation for CompletionStage and friends: https://github.com/AugustNagro/java-async-await - August On Thu, Oct 21, 2021 at 1:12 AM Alan Bateman wrote: > On 21/10/2021 08:12, August Nagro wrote: > > : > > > > Now my big question is how Virtual Threads fit into the Vertx/Netty > > event-loop story. > I don't know if anyone has tried to run the event loop in a virtual > thread but there has been a few reports of off-loading to virtual > threads. This is problematic due to Netty's thread local buffer caches > where a lot of the time is spent initializing and allocating native > memory. Project Panama Foreign Memory API is looking very good and maybe > some future version of Netty could build an allocator and buffer pool > based on that and at the same time play well with virtual threads. > > -Alan > From julien at julienviet.com Fri Oct 22 06:10:05 2021 From: julien at julienviet.com (Julien Viet) Date: Fri, 22 Oct 2021 08:10:05 +0200 Subject: [vertx-dev] Async-Await in Vertx with Project Loom In-Reply-To: References: Message-ID: nice work On Fri, Oct 22, 2021 at 7:43 AM August Nagro wrote: > > Altan Ozlu made a benchmark in 2019 which looked promising: https://github.com/altanozlu/NettyFiberBenchmarks . It is a big change though; more than I could bite off. > > I changed my async-await implementation to use Virtual Threads and Locking. It also uses a custom Executor like Ron suggested, to schedule tasks on the Event Loop Context. Doing so keeps everything asynchronous but still single-threaded, the big benefit of using Verticles. > > https://github.com/AugustNagro/vertx-async-await > > I also made an async-await implementation for CompletionStage and friends: > > https://github.com/AugustNagro/java-async-await > > - August > > On Thu, Oct 21, 2021 at 1:12 AM Alan Bateman wrote: >> >> On 21/10/2021 08:12, August Nagro wrote: >> > : >> > >> > Now my big question is how Virtual Threads fit into the Vertx/Netty >> > event-loop story. >> I don't know if anyone has tried to run the event loop in a virtual >> thread but there has been a few reports of off-loading to virtual >> threads. This is problematic due to Netty's thread local buffer caches >> where a lot of the time is spent initializing and allocating native >> memory. Project Panama Foreign Memory API is looking very good and maybe >> some future version of Netty could build an allocator and buffer pool >> based on that and at the same time play well with virtual threads. >> >> -Alan > > -- > You received this message because you are subscribed to the Google Groups "vertx-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an email to vertx-dev+unsubscribe at googlegroups.com. > To view this discussion on the web, visit https://groups.google.com/d/msgid/vertx-dev/CAHNb0ZNd8mrLG4H8OKr66FUUA8RZJppqTb22O9OfZeHXjdQn2A%40mail.gmail.com. From oleksandr.otenko at gmail.com Fri Oct 22 14:25:50 2021 From: oleksandr.otenko at gmail.com (Alex Otenko) Date: Fri, 22 Oct 2021 15:25:50 +0100 Subject: Async-Await in Vertx with Project Loom In-Reply-To: References: Message-ID: That example doesn't appear to be comparable. CompletableFuture example is parallel, async/await is sequential. It would be great to see the amount of boilerplate needed to implement both in both cases. Alex On Mon, 18 Oct 2021, 04:15 August Nagro, wrote: > Hello; I recently implemented async/await in Vertx using Project Loom. > > Feedback and code review are very welcome. The project is only about 100 > lines of code. Hopefully something similar could be merged into > `vertx-core` when Loom is released. > > https://github.com/AugustNagro/vertx-loom > > Cheers, > > August > From duke at openjdk.java.net Sat Oct 23 12:24:45 2021 From: duke at openjdk.java.net (duke) Date: Sat, 23 Oct 2021 12:24:45 GMT Subject: git: openjdk/loom: fibers: Windows debug builds failing intermittently Message-ID: <907e91bf-e36f-4e86-a500-180bad5461ce@openjdk.java.net> Changeset: 89ffb9a6 Author: Alan Bateman Date: 2021-10-23 13:23:59 +0000 URL: https://git.openjdk.java.net/loom/commit/89ffb9a6212cc5ceeb32c263f37b623d303a26d7 Windows debug builds failing intermittently ! src/hotspot/cpu/x86/stubRoutines_x86.hpp From openjdk-loom-dev at jotschi.de Mon Oct 25 05:02:51 2021 From: openjdk-loom-dev at jotschi.de (=?UTF-8?Q?Johannes_Sch=C3=BCth?=) Date: Mon, 25 Oct 2021 07:02:51 +0200 Subject: Netty Support / VirtualThread Selector#select Issue Message-ID: Hello, I started some experiments on how to add Loom VirtualThread support to Netty. During my tests I noticed that Netty was no longer able to handle requests when using 500+ virtual threads for its reactor pool. I created a dedicated test without Netty to replicate this issue and found that the JVM would not run / start a new virtual thread if 400+ previous threads were calling new `Selector().select().` I'm not yet sure why this is the case. The thread dump shows all threads as 'Running'. --snip-- static final int THREAD_COUNT = 1500; @Test public void testSelectorThreads() throws InterruptedException, TimeoutException { CountDownLatch latch = new CountDownLatch(THREAD_COUNT); AtomicInteger startCounter = new AtomicInteger(); for (int i = 0; i < THREAD_COUNT; i++) { Thread.startVirtualThread(() -> { try { System.out.println("Running: " + startCounter.incrementAndGet()); latch.countDown(); Selector selector = Selector.open(); selector.select(); Thread.sleep(10_000); } catch (Exception e) { e.printStackTrace(); } }); } if (!latch.await(5_000, TimeUnit.MILLISECONDS)) { dumpThreads(); } assertEquals("Not all thread did start.", THREAD_COUNT, startCounter.get()); } --snap-- The full repository can be found on Github: https://github.com/Jotschi/netty-loom-experiment Aside of this problem my two major concerns for Netty Loom support are Garbage/GC overhead due to newly created threadlocals for on-demand virtual threads and JNI usage within Netty itself (e.g. EPoll and soon hopefully io_uring). I'm however not a Netty expert and merely experimenting out of curiosity. As mentioned in the async-await thread the thread local problem could be addressed by the Foreign Memory API of Project Panama. Any other feedback would be welcome. Thanks for the great work. Greetings, Johannes From duke at openjdk.java.net Mon Oct 25 06:29:13 2021 From: duke at openjdk.java.net (duke) Date: Mon, 25 Oct 2021 06:29:13 GMT Subject: git: openjdk/loom: fibers: fix root cause of MethodExitTest failure Message-ID: <87287ba4-3445-4cfc-ad41-aa554300c965@openjdk.java.net> Changeset: d7a3e05d Author: Serguei Spitsyn Date: 2021-10-25 06:27:37 +0000 URL: https://git.openjdk.java.net/loom/commit/d7a3e05dccebd74ad8b69b095aae6d4d40a60b51 fix root cause of MethodExitTest failure ! src/hotspot/share/prims/jvm.cpp ! src/java.base/share/classes/java/lang/VirtualThread.java From Alan.Bateman at oracle.com Mon Oct 25 08:21:46 2021 From: Alan.Bateman at oracle.com (Alan Bateman) Date: Mon, 25 Oct 2021 09:21:46 +0100 Subject: Netty Support / VirtualThread Selector#select Issue In-Reply-To: References: Message-ID: <0d530a83-7905-a661-dd53-a0008ba657b9@oracle.com> On 25/10/2021 06:02, Johannes Sch?th wrote: > Hello, > > I started some experiments on how to add Loom VirtualThread support to > Netty. > > During my tests I noticed that Netty was no longer able to handle requests > when using 500+ virtual threads for its reactor pool. > > I created a dedicated test without Netty to replicate this issue and found > that the JVM would not run / start a new virtual thread if 400+ previous > threads were calling new `Selector().select().` > I'm not yet sure why this is the case. The thread dump shows all threads as > 'Running'. > There are cases where the VM cannot suspend a virtual thread, we say that the thread is "pinned". One scenario (that we expect will go away in the long term) is when a virtual thread is holding a monitor. Blocking selection operations are one of these cases. Selector is specified to synchronize on the Selector object and can't be changed for compatibility reasons. So the summary that invoking blocking selection operations on a virtual thread will pin the thread for the duration of the selection operation. This means the underlying thread is not released to do other work. To compensate, parallelism will increase for the duration of the selection operations so you will see the number of carrier threads increase up to a limit (default is 256 but can be configured). That said, I'm a bit surprised that you have a Selector per thread. That seems an architectural mismatch. Do you have an event loop per thread or how does this arise? -Alan. From duke at openjdk.java.net Mon Oct 25 08:27:27 2021 From: duke at openjdk.java.net (duke) Date: Mon, 25 Oct 2021 08:27:27 GMT Subject: git: openjdk/loom: fibers: make JVMTI notification in afterTerminate() about UnmountEnd conditional Message-ID: <495564bf-cb62-4a79-ad88-92a5e67cce16@openjdk.java.net> Changeset: e68ce6ca Author: Serguei Spitsyn Date: 2021-10-25 08:26:38 +0000 URL: https://git.openjdk.java.net/loom/commit/e68ce6cafaba704df97e11a99978219d962c7194 make JVMTI notification in afterTerminate() about UnmountEnd conditional ! src/java.base/share/classes/java/lang/VirtualThread.java From openjdk-loom-dev at jotschi.de Mon Oct 25 09:59:34 2021 From: openjdk-loom-dev at jotschi.de (=?UTF-8?Q?Johannes_Sch=C3=BCth?=) Date: Mon, 25 Oct 2021 11:59:34 +0200 Subject: Netty Support / VirtualThread Selector#select Issue In-Reply-To: <0d530a83-7905-a661-dd53-a0008ba657b9@oracle.com> References: <0d530a83-7905-a661-dd53-a0008ba657b9@oracle.com> Message-ID: Hello Alan, yes - there is one eventloop per thread. That's the default behavior for Netty. Your feedback gave me some clues on how to adapt the implementation. Using a single selector with multiple threads makes more sense. I'm not sure why Netty is using a different approach. Maybe this is done this way to avoid synchronization on selection key operations (which are not thread safe). Johannes Am Mo., 25. Okt. 2021 um 10:22 Uhr schrieb Alan Bateman < Alan.Bateman at oracle.com>: > On 25/10/2021 06:02, Johannes Sch?th wrote: > > Hello, > > > > I started some experiments on how to add Loom VirtualThread support to > > Netty. > > > > During my tests I noticed that Netty was no longer able to handle > requests > > when using 500+ virtual threads for its reactor pool. > > > > I created a dedicated test without Netty to replicate this issue and > found > > that the JVM would not run / start a new virtual thread if 400+ previous > > threads were calling new `Selector().select().` > > I'm not yet sure why this is the case. The thread dump shows all threads > as > > 'Running'. > > > There are cases where the VM cannot suspend a virtual thread, we say > that the thread is "pinned". One scenario (that we expect will go away > in the long term) is when a virtual thread is holding a monitor. > Blocking selection operations are one of these cases. Selector is > specified to synchronize on the Selector object and can't be changed for > compatibility reasons. So the summary that invoking blocking selection > operations on a virtual thread will pin the thread for the duration of > the selection operation. This means the underlying thread is not > released to do other work. To compensate, parallelism will increase for > the duration of the selection operations so you will see the number of > carrier threads increase up to a limit (default is 256 but can be > configured). > > That said, I'm a bit surprised that you have a Selector per thread. That > seems an architectural mismatch. Do you have an event loop per thread or > how does this arise? > > -Alan. > From oleksandr.otenko at gmail.com Mon Oct 25 13:36:49 2021 From: oleksandr.otenko at gmail.com (Alex Otenko) Date: Mon, 25 Oct 2021 14:36:49 +0100 Subject: Netty Support / VirtualThread Selector#select Issue In-Reply-To: References: <0d530a83-7905-a661-dd53-a0008ba657b9@oracle.com> Message-ID: Selector per thread allows to spread the load across multiple threads. A single selector either won't scale, or will waste cycles handing off work to others. But you want to keep the number of event loop threads close to #CPUs. (Ideally equal to the number of cores, but it depends) Alex On Mon, 25 Oct 2021, 12:14 Johannes Sch?th, wrote: > Hello Alan, > > yes - there is one eventloop per thread. That's the default behavior for > Netty. Your feedback gave me some clues on how to adapt the implementation. > Using a single selector with multiple threads makes more sense. > I'm not sure why Netty is using a different approach. Maybe this is done > this way to avoid synchronization on selection key operations (which are > not thread safe). > > Johannes > > > Am Mo., 25. Okt. 2021 um 10:22 Uhr schrieb Alan Bateman < > Alan.Bateman at oracle.com>: > > > On 25/10/2021 06:02, Johannes Sch?th wrote: > > > Hello, > > > > > > I started some experiments on how to add Loom VirtualThread support to > > > Netty. > > > > > > During my tests I noticed that Netty was no longer able to handle > > requests > > > when using 500+ virtual threads for its reactor pool. > > > > > > I created a dedicated test without Netty to replicate this issue and > > found > > > that the JVM would not run / start a new virtual thread if 400+ > previous > > > threads were calling new `Selector().select().` > > > I'm not yet sure why this is the case. The thread dump shows all > threads > > as > > > 'Running'. > > > > > There are cases where the VM cannot suspend a virtual thread, we say > > that the thread is "pinned". One scenario (that we expect will go away > > in the long term) is when a virtual thread is holding a monitor. > > Blocking selection operations are one of these cases. Selector is > > specified to synchronize on the Selector object and can't be changed for > > compatibility reasons. So the summary that invoking blocking selection > > operations on a virtual thread will pin the thread for the duration of > > the selection operation. This means the underlying thread is not > > released to do other work. To compensate, parallelism will increase for > > the duration of the selection operations so you will see the number of > > carrier threads increase up to a limit (default is 256 but can be > > configured). > > > > That said, I'm a bit surprised that you have a Selector per thread. That > > seems an architectural mismatch. Do you have an event loop per thread or > > how does this arise? > > > > -Alan. > > > From Alan.Bateman at oracle.com Mon Oct 25 14:20:30 2021 From: Alan.Bateman at oracle.com (Alan Bateman) Date: Mon, 25 Oct 2021 15:20:30 +0100 Subject: Netty Support / VirtualThread Selector#select Issue In-Reply-To: References: <0d530a83-7905-a661-dd53-a0008ba657b9@oracle.com> Message-ID: <3f1a8c3b-b522-f777-7fb8-72144b90a5ad@oracle.com> On 25/10/2021 10:59, Johannes Sch?th wrote: > Hello Alan, > > yes - there is one eventloop per thread. That's the default behavior for > Netty. Your feedback gave me some clues on how to adapt the implementation. > Using a single selector with multiple threads makes more sense. > I'm not sure why Netty is using a different approach. Maybe this is done > this way to avoid synchronization on selection key operations (which are > not thread safe). It might be that you don't need to use non-blocking I/O and Selectors. As regards the synchronization on selection keys then they have always been specified to be safe for use by concurrent threads. Maybe you are thinking about updates to the interest set needing to synchronize with selection operations? The spec was relaxed in Java 11 to not require that. Any changes to the interest set will be seen by the next selection operation. -Alan From duke at openjdk.java.net Tue Oct 26 02:20:15 2021 From: duke at openjdk.java.net (duke) Date: Tue, 26 Oct 2021 02:20:15 GMT Subject: git: openjdk/loom: fibers: add needed sync to serviceability/thread/GetFrameCount/framecnt01 test Message-ID: <861541cb-bf44-4c3a-a0a8-69ea70cb2b70@openjdk.java.net> Changeset: 9a5f9fc6 Author: Serguei Spitsyn Date: 2021-10-26 02:18:44 +0000 URL: https://git.openjdk.java.net/loom/commit/9a5f9fc603c5bcfbf2b7af2c86164b733449b242 add needed sync to serviceability/thread/GetFrameCount/framecnt01 test ! test/hotspot/jtreg/serviceability/jvmti/thread/GetFrameCount/framecnt01/framecnt01.java From duke at openjdk.java.net Tue Oct 26 08:43:05 2021 From: duke at openjdk.java.net (duke) Date: Tue, 26 Oct 2021 08:43:05 GMT Subject: git: openjdk/loom: fibers: minor correction of the JVMTI ThreadStart/ThreadEnd spec Message-ID: <24c0b8a7-3695-4f8a-8941-4703ce82f7e7@openjdk.java.net> Changeset: f68e3f3d Author: Serguei Spitsyn Date: 2021-10-26 08:42:29 +0000 URL: https://git.openjdk.java.net/loom/commit/f68e3f3d56e043303a7a74129fab52b6ae7cc564 minor correction of the JVMTI ThreadStart/ThreadEnd spec ! src/hotspot/share/prims/jvmti.xml From duke at openjdk.java.net Tue Oct 26 12:06:45 2021 From: duke at openjdk.java.net (duke) Date: Tue, 26 Oct 2021 12:06:45 GMT Subject: git: openjdk/loom: fibers: Change ReferenceQueue to use j.u.c locks Message-ID: <4a45b8f6-02e6-4e54-afa5-150f979aa5e0@openjdk.java.net> Changeset: e3cc6e74 Author: Ron Pressler Date: 2021-10-12 18:50:07 +0000 URL: https://git.openjdk.java.net/loom/commit/e3cc6e74d1d93cddf5a8430ae60dfe432cec0d2b Change ReferenceQueue to use j.u.c locks ! src/java.base/share/classes/java/lang/VirtualThread.java ! src/java.base/share/classes/java/lang/ref/ReferenceQueue.java ! src/java.base/share/classes/java/util/concurrent/ForkJoinPool.java ! src/java.base/share/classes/java/util/concurrent/ForkJoinTask.java ! src/java.base/share/classes/java/util/concurrent/locks/AbstractQueuedLongSynchronizer.java ! src/java.base/share/classes/java/util/concurrent/locks/AbstractQueuedSynchronizer.java + src/java.base/share/classes/java/util/concurrent/locks/ForkJoinPoolHelper.java ! test/hotspot/jtreg/serviceability/sa/ClhsdbInspect.java From duke at openjdk.java.net Tue Oct 26 21:37:49 2021 From: duke at openjdk.java.net (duke) Date: Tue, 26 Oct 2021 21:37:49 GMT Subject: git: openjdk/loom: fibers: 2 new changesets Message-ID: Changeset: b734bde5 Author: Chris Plummer Date: 2021-10-26 21:22:04 +0000 URL: https://git.openjdk.java.net/loom/commit/b734bde58dcb949b962edb15d80dd02f1c742653 Updated comment for VMOutOfMemoryException001 test. ! test/hotspot/jtreg/ProblemList-vthread.txt Changeset: 2ec33820 Author: Chris Plummer Date: 2021-10-26 21:36:13 +0000 URL: https://git.openjdk.java.net/loom/commit/2ec33820a111284dedb16ab329386f8d7c22dc20 Do a notify on the threadLock after calling ResumeAllVirtualThreads ust like we do whereever else we resume a thread. ! src/jdk.jdwp.agent/share/native/libjdwp/threadControl.c From augustnagro at gmail.com Wed Oct 27 02:48:33 2021 From: augustnagro at gmail.com (August Nagro) Date: Tue, 26 Oct 2021 19:48:33 -0700 Subject: Async-Await in Vertx with Project Loom In-Reply-To: References: Message-ID: To make the sequential Async-Await code parallel, we could define a method 'awaitAll' (which is probably be a good addition to the library): public static List awaitAll(List> stages) { return stages.stream().map(stage -> await(stage)).toList(); } And change the sequential part from List userNames = userIds.stream() .map(id -> await(userNamesFromSomeApi(id))) .toList(); To: List userNames = awaitAll( userIds.stream() .map(id -> userNamesFromSomeApi(id)) .toList() ); To make the CompletableFuture example sequential, we could make a chain of thenCompose operations. So From: List> userNameFutures = userIds.stream() .map(id -> userNamesFromSomeApi(id)) .map(CompletionStage::toCompletableFuture) .toList(); CompletableFuture.allOf(userNameFutures.toArray(new CompletableFuture[0])) .thenCompose(voidd -> {...}); To: CompletionStage> userNames = CompletableFuture.supplyAsync(() -> new ArrayList<>()); for (Long userId : userIds) { userNames = userNames.thenCompose(list -> { return userNamesFromSomeApi(userId) .thenApply(userName -> { list.add(userName); return list; }); }); } userNames.thenCompose(...) Overall, I think async-await is nicer than flatMap/thenCompose chains. And 'just blocking' on a virtual thread is even nicer. On Fri, Oct 22, 2021 at 7:26 AM Alex Otenko wrote: > That example doesn't appear to be comparable. > > CompletableFuture example is parallel, async/await is sequential. > > It would be great to see the amount of boilerplate needed to implement > both in both cases. > > Alex > > On Mon, 18 Oct 2021, 04:15 August Nagro, wrote: > >> Hello; I recently implemented async/await in Vertx using Project Loom. >> >> Feedback and code review are very welcome. The project is only about 100 >> lines of code. Hopefully something similar could be merged into >> `vertx-core` when Loom is released. >> >> https://github.com/AugustNagro/vertx-loom >> >> Cheers, >> >> August >> > From duke at openjdk.java.net Wed Oct 27 08:59:03 2021 From: duke at openjdk.java.net (duke) Date: Wed, 27 Oct 2021 08:59:03 GMT Subject: git: openjdk/loom: fibers: fixed regression caused failures of serviceability/jvmti/RedefineClasses tests Message-ID: <5a9e9942-7358-4f88-83a6-d0c4b95f7eaa@openjdk.java.net> Changeset: 4bca5260 Author: Serguei Spitsyn Date: 2021-10-27 08:57:49 +0000 URL: https://git.openjdk.java.net/loom/commit/4bca526042d319fc2ec2b7e63806c6afeb3b6e3d fixed regression caused failures of serviceability/jvmti/RedefineClasses tests ! src/java.base/share/classes/java/lang/VirtualThread.java From duke at openjdk.java.net Wed Oct 27 20:24:24 2021 From: duke at openjdk.java.net (duke) Date: Wed, 27 Oct 2021 20:24:24 GMT Subject: git: openjdk/loom: fibers: 2 new changesets Message-ID: Changeset: 0168e324 Author: lmesnik Date: 2021-10-27 14:23:07 +0000 URL: https://git.openjdk.java.net/loom/commit/0168e324d392c745d93ac7d39e958e98aa80e618 jtregMW version bumped ! make/conf/jib-profiles.js Changeset: edc6c808 Author: lmesnik Date: 2021-10-27 14:23:44 +0000 URL: https://git.openjdk.java.net/loom/commit/edc6c808a7af3e7f9fd60954e6f31409f82c89c4 Merge branch 'fibers' of https://github.com/openjdk/loom into fibers ! make/conf/jib-profiles.js ! make/conf/jib-profiles.js From duke at openjdk.java.net Thu Oct 28 14:27:08 2021 From: duke at openjdk.java.net (duke) Date: Thu, 28 Oct 2021 14:27:08 GMT Subject: git: openjdk/loom: fibers: 3 new changesets Message-ID: <85a76fe6-8ba2-4da4-b366-b6324512a78e@openjdk.java.net> Changeset: 1373ab17 Author: lmesnik Date: 2021-10-26 21:06:20 +0000 URL: https://git.openjdk.java.net/loom/commit/1373ab17f7e59e645e18edf6ed0021769d5a3af4 delete added. ! src/hotspot/share/prims/jvmtiEnv.cpp Changeset: 55c9d60f Author: lmesnik Date: 2021-10-26 22:30:49 +0000 URL: https://git.openjdk.java.net/loom/commit/55c9d60fad90b5dd477e9c39d324cb770cfb401f fx ! src/hotspot/share/prims/jvmtiEnv.cpp ! src/hotspot/share/prims/jvmtiEnvBase.cpp ! src/hotspot/share/prims/jvmtiEnvBase.hpp Changeset: 0cd786bf Author: lmesnik Date: 2021-10-28 08:22:51 +0000 URL: https://git.openjdk.java.net/loom/commit/0cd786bf9764bd9f062558426b9274263250ecdd Merge branch 'fibers' of https://github.com/openjdk/loom into cthread_with_continuation From duke at openjdk.java.net Fri Oct 29 08:26:00 2021 From: duke at openjdk.java.net (Miao Zheng) Date: Fri, 29 Oct 2021 08:26:00 GMT Subject: RFR: Ensure compensate when ForkJoinWorkerThread is pinned Message-ID: Hello, We have a test case about Loom, it can pass before; The test case can be seen on this PR; But it cannot pass after this patch: commit de90a43c7a5f0b28bd0af9271de210475808ca0c Author: Alan Bateman Date: Wed Sep 1 09:22:23 2021 +0100 Replace lock/condition objects to simplify pinned park Actually, this modify cause the test fail, because getCondition.await() will call tryCompensate() of ForkJoinPool eventually: + private void parkOnCarrierThread(long nanos) { - if (!parkPermit) { - // wait to be signalled or interrupted - getCondition().await(); + if (!parkPermit) { + U.park(false, nanos); } ``` If ForkJoinWorkerThread are all pinned, how to make vt work correct? Thanks? Miao ------------- Commit messages: - Ensure compensate when ForkJoinWorkerThread is pinned Changes: https://git.openjdk.java.net/loom/pull/80/files Webrev: https://webrevs.openjdk.java.net/?repo=loom&pr=80&range=00 Stats: 87 lines in 1 file changed: 87 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/loom/pull/80.diff Fetch: git fetch https://git.openjdk.java.net/loom pull/80/head:pull/80 PR: https://git.openjdk.java.net/loom/pull/80 From duke at openjdk.java.net Fri Oct 29 13:03:50 2021 From: duke at openjdk.java.net (duke) Date: Fri, 29 Oct 2021 13:03:50 GMT Subject: git: openjdk/loom: fibers: 6 new changesets Message-ID: <9f387697-23f7-4a29-a3f7-c80124d4e2d4@openjdk.java.net> Changeset: 0631c640 Author: Alan Bateman Date: 2021-10-26 13:44:13 +0000 URL: https://git.openjdk.java.net/loom/commit/0631c640944e47dfe981294d07575222edcb51cc Remove remaining uses of VH ! src/java.base/share/classes/java/lang/VirtualThread.java Changeset: 5e77a1a1 Author: Alan Bateman Date: 2021-10-26 17:34:03 +0000 URL: https://git.openjdk.java.net/loom/commit/5e77a1a11193705253f7e04ed3aa907e9c03ac4d Rename to resultNow and exceptionNow ! src/java.base/share/classes/java/util/concurrent/CompletableFuture.java ! src/java.base/share/classes/java/util/concurrent/ForkJoinTask.java ! src/java.base/share/classes/java/util/concurrent/Future.java ! src/java.base/share/classes/java/util/concurrent/FutureTask.java ! test/jdk/java/lang/Thread/virtual/ThreadPerTaskExecutorTest.java ! test/jdk/java/util/concurrent/Future/DefaultMethods.java Changeset: e88f1de5 Author: Alan Bateman Date: 2021-10-28 12:31:13 +0000 URL: https://git.openjdk.java.net/loom/commit/e88f1de5e1de7fd5c230fe5e25928108b43630dd Refactoring/cleanup of TC infrastructure to make it more general ! src/java.base/share/classes/java/lang/System.java ! src/java.base/share/classes/java/lang/Thread.java ! src/java.base/share/classes/java/lang/VirtualThread.java ! src/java.base/share/classes/jdk/internal/access/JavaLangAccess.java ! src/java.base/share/classes/jdk/internal/vm/SharedThreadContainer.java + src/java.base/share/classes/jdk/internal/vm/StackableScope.java ! src/java.base/share/classes/jdk/internal/vm/ThreadContainer.java ! src/java.base/share/classes/jdk/internal/vm/ThreadContainers.java Changeset: 03b41ff4 Author: Alan Bateman Date: 2021-10-29 08:14:42 +0000 URL: https://git.openjdk.java.net/loom/commit/03b41ff40c8e501b433b23fe405f3fb25f7b66be Improve exceptions ! src/java.base/share/classes/java/util/concurrent/Future.java Changeset: 75ff309e Author: Alan Bateman Date: 2021-10-29 12:33:21 +0000 URL: https://git.openjdk.java.net/loom/commit/75ff309ead29bf5095f0f12a055571415f2d5ac2 More exception messages ! src/java.base/share/classes/java/util/concurrent/Future.java ! src/java.base/share/classes/java/util/concurrent/FutureTask.java Changeset: f3dd9cf6 Author: Alan Bateman Date: 2021-10-29 12:33:55 +0000 URL: https://git.openjdk.java.net/loom/commit/f3dd9cf60484c92a10e168f769a13fee87922898 Remove Upcall from exclude list ! test/jdk/ProblemList.txt From duke at openjdk.java.net Fri Oct 29 16:10:36 2021 From: duke at openjdk.java.net (duke) Date: Fri, 29 Oct 2021 16:10:36 GMT Subject: git: openjdk/loom: fibers: Add an additional ReferenceQueue implementation that uses native monitors. Message-ID: <0147616f-7710-401c-b3f0-a721eb07202c@openjdk.java.net> Changeset: ba6e2afe Author: Ron Pressler Date: 2021-10-29 13:49:21 +0000 URL: https://git.openjdk.java.net/loom/commit/ba6e2afe31507bf563d8240e27481c0e8c640f0e Add an additional ReferenceQueue implementation that uses native monitors. ! src/java.base/share/classes/java/lang/invoke/MethodType.java ! src/java.base/share/classes/java/lang/ref/Finalizer.java + src/java.base/share/classes/java/lang/ref/NativeReferenceQueue.java ! src/java.base/share/classes/java/lang/ref/Reference.java ! src/java.base/share/classes/java/lang/ref/ReferenceQueue.java ! src/java.base/share/classes/jdk/internal/access/JavaLangRefAccess.java From ron.pressler at oracle.com Fri Oct 29 18:42:20 2021 From: ron.pressler at oracle.com (Ron Pressler) Date: Fri, 29 Oct 2021 18:42:20 +0000 Subject: RFR: Ensure compensate when ForkJoinWorkerThread is pinned In-Reply-To: References: Message-ID: <52A74C31-E2B3-4D9A-950A-3A8539D5AC61@oracle.com> Hi. The problem here isn?t that all of the scheduler?s workers are pinned, but that the pinned threads can only be unblocked by another, unpinned, virtual thread. You might reasonably have 100K threads waiting, and no amount of compensation would help. As it is, compensation would only help up until the upper FJPool limit, which is quite low. It makes sense to try and compensate when there?s a good chance the pinned thread is waiting for some other pinned thread, a platform thread, or an OS operation, and so we can smooth over minor and temporary disturbances. But cases like yours are fundamentally unbounded. In light of that, I think the current behaviour is the right one. With compensation, the problem would manifest when you have ~300 threads rather than ~10, but given that virtual threads are intended to be used when there?s need for many thousands of them, compensation for arbitrary pinning is unlikely to significantly help in real-world instances. Worse ? my fear is that it might make problems that could manifest in production harder to spot in testing. The solution is to rely on the available diagnostics to identify the problem in the program ? that a virtual thread can wait for another virtual thread while pinned ? and fix it. ? Ron > On 29 Oct 2021, at 09:26, Miao Zheng wrote: > > Hello, > We have a test case about Loom, it can pass before; > The test case can be seen on this PR; > > But it cannot pass after this patch: > > commit de90a43c7a5f0b28bd0af9271de210475808ca0c > Author: Alan Bateman > Date: Wed Sep 1 09:22:23 2021 +0100 > > Replace lock/condition objects to simplify pinned park > > > Actually, this modify cause the test fail, because getCondition.await() will call tryCompensate() of ForkJoinPool eventually: > > + private void parkOnCarrierThread(long nanos) { > > - if (!parkPermit) { > - // wait to be signalled or interrupted > - getCondition().await(); > > + if (!parkPermit) { > + U.park(false, nanos); > } > ``` > If ForkJoinWorkerThread are all pinned, how to make vt work correct? > > Thanks? > > Miao > > ------------- > > Commit messages: > - Ensure compensate when ForkJoinWorkerThread is pinned > > Changes: https://git.openjdk.java.net/loom/pull/80/files > Webrev: https://webrevs.openjdk.java.net/?repo=loom&pr=80&range=00 > Stats: 87 lines in 1 file changed: 87 ins; 0 del; 0 mod > Patch: https://git.openjdk.java.net/loom/pull/80.diff > Fetch: git fetch https://git.openjdk.java.net/loom pull/80/head:pull/80 > > PR: https://git.openjdk.java.net/loom/pull/80 From duke at openjdk.java.net Sun Oct 31 09:10:15 2021 From: duke at openjdk.java.net (duke) Date: Sun, 31 Oct 2021 09:10:15 GMT Subject: git: openjdk/loom: fibers: 3 new changesets Message-ID: Changeset: 83060468 Author: Alan Bateman Date: 2021-10-30 08:20:38 +0000 URL: https://git.openjdk.java.net/loom/commit/83060468b36e15bdb1cda0dbc6f288f034112b82 Remove fixed test from exclude list ! test/hotspot/jtreg/ProblemList.txt Changeset: 8ddd4cdf Author: Alan Bateman Date: 2021-10-30 16:03:56 +0000 URL: https://git.openjdk.java.net/loom/commit/8ddd4cdf7f035a1a252856e6594bfb6fe3127886 Replace use of TG.stop ! src/java.desktop/share/classes/sun/awt/AppContext.java ! test/jdk/ProblemList.txt Changeset: bf5ac544 Author: Alan Bateman Date: 2021-10-31 08:02:30 +0000 URL: https://git.openjdk.java.net/loom/commit/bf5ac544ce7796a80adaffb93e738fd31589085a Send JFR therad start/end event on vthread ! src/java.base/share/classes/java/lang/VirtualThread.java ! test/jdk/ProblemList.txt ! test/jdk/jdk/jfr/api/consumer/TestRecordedEventGetThread.java ! test/jdk/jdk/jfr/api/consumer/TestRecordedEventGetThreadOther.java ! test/jdk/jdk/jfr/event/runtime/LatchedThread.java ! test/jdk/jdk/jfr/event/runtime/TestVirtualThreadEndEvent.java ! test/jdk/jdk/jfr/event/runtime/TestVirtualThreadStartEvent.java From emoryzheng at tencent.com Thu Oct 28 03:00:28 2021 From: emoryzheng at tencent.com (=?utf-8?B?ZW1vcnl6aGVuZyjpg5Hmt7wp?=) Date: Thu, 28 Oct 2021 03:00:28 -0000 Subject: Compensate when Pinned Message-ID: Hello, We have a test case about Loom, it can pass before; The test case can be seen on attach file; But it cannot pass after this patch: ``` commit de90a43c7a5f0b28bd0af9271de210475808ca0c Author: Alan Bateman Date: Wed Sep 1 09:22:23 2021 +0100 Replace lock/condition objects to simplify pinned park ``` Actually, this modify cause the test fail, because getCondition.await() will call tryCompensate() of ForkJoinPool eventually: + private void parkOnCarrierThread(long nanos) { ??? - if (!parkPermit) { - // wait to be signalled or interrupted - getCondition().await(); ??? + if (!parkPermit) { + U.park(false, nanos); } If there are 4 ForkJoinWorkerThread, and they are all pinned, how to make vt work correct? Thanks? Miao