RFR: Stop compiling old oopMapStubGenerator
Aleksey Shipilev
shade at openjdk.java.net
Mon Sep 27 10:07:24 UTC 2021
On Mon, 27 Sep 2021 09:56:38 GMT, Alan Bateman <alanb at openjdk.org> wrote:
>> This code is currently not used, and it might not be used in future too. There is no way to test if it works, currently. It is the major source of build failure when compiling x86_32. So, it would be better to `#if 0` it, or even remove it wholesale.
>>
>> Additional testing:
>> - [x] Linux x86_64 `tier1_loom`
>
> src/hotspot/share/compiler/oopMapStubGenerator.hpp line 60:
>
>> 58: #else
>> 59: #error This code is not used
>> 60: #endif
>
> Can you check Windows, I suspect it might have to be excluded.
Um, Windows builds fail here:
https://github.com/shipilev/loom/runs/3716995428?check_suite_focus=true
Which implies `oopMapStubGenerator_x86.cpp` is still compiled? What. Let me see...
-------------
PR: https://git.openjdk.java.net/loom/pull/66
More information about the loom-dev
mailing list