RFR: Fix Optimized builds [v2]

Aleksey Shipilev shade at openjdk.java.net
Thu Sep 30 10:13:37 UTC 2021


On Thu, 30 Sep 2021 10:06:03 GMT, Ron Pressler <rpressler at openjdk.org> wrote:

> Ah, OK. I understand the logic now, but it means that the guard will need to be revisited once the traces are cleaned up. 

Yes.

> Is there a logging mode that is guarded by ASSERT (that would be the most common intent in this code)?

I don't think so. IIRC, the purpose of "optimized" was to dump the diagnostic output without suffering the performance loss of fastdebug, so it stands to reason why logging is `!PRODUCT`. But, it is a recurrent theme to ditch the "optimized" builds -- https://bugs.openjdk.java.net/browse/JDK-8183287 -- which should put this problem where it belongs, into the dustbin.

-------------

PR: https://git.openjdk.java.net/loom/pull/69


More information about the loom-dev mailing list