RFR: Fix Windows aarch64 builds [v2]
Aleksey Shipilev
shade at openjdk.java.net
Thu Sep 30 12:11:14 UTC 2021
On Thu, 30 Sep 2021 10:50:41 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:
>> Current GHA point the problem with Windows aarch64 builds:
>> https://github.com/shipilev/loom/runs/3721167733
>>
>> It passes now:
>> https://github.com/shipilev/loom/runs/3722819426
>>
>> Additional testing:
>> - [x] Windows aarch64 GHA builds fine
>> - [x] Linux aarch64 `tier1_loom` still passes
>
> Aleksey Shipilev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
>
> - Merge branch 'fibers' into windows-aarch64-builds
> - More changes
> - Fixing GHA failures in Windows AArch64
There are still weird failures on macos-aarch64, like:
2021-09-30T11:41:57.9432190Z /Users/runner/work/loom/loom/jdk/src/hotspot/share/oops/accessBackend.hpp:1203:5: warning: unused typedef 'STATIC_ASSERT_DUMMY_TYPE_1205' [-Wunused-local-typedef]
2021-09-30T11:41:57.9433590Z STATIC_ASSERT((HasDecoratoUndefined symbols for architecture x86_64:
2021-09-30T11:41:57.9434590Z "JvmtiThreadState::set_thread(JavaThread*)", referenced from:
2021-09-30T11:41:57.9435460Z JavaThread::rebind_to_jvmti_thread_state_of(oop) in thread.o
2021-09-30T11:41:57.9436330Z "JvmtiVTMTDisabler::start_VTMT(_jobject*, int)", referenced from:
2021-09-30T11:41:57.9437180Z _JVM_VirtualThreadMountBegin in jvm.o
2021-09-30T11:41:57.9438020Z _JVM_VirtualThreadUnmountBegin in jvm.o
2021-09-30T11:41:57.9438870Z "JvmtiVTMTDisabler::_VTMT_count", referenced from:
2021-09-30T11:41:57.9439640Z JavaThread::set_is_VTMT_disabler(bool) in thread.o
2021-09-30T11:41:57.9440470Z "JvmtiVTMTDisabler::finish_VTMT(_jobject*, int)", referenced from:
2021-09-30T11:41:57.9441300Z _JVM_VirtualThreadMountEnd in jvm.o
2021-09-30T11:41:57.9442080Z _JVM_VirtualThreadUnmountEnd in jvm.o
2021-09-30T11:41:57.9442930Z "JvmtiVTMTDisabler::_VTMT_disable_count", referenced from:
2021-09-30T11:41:57.9443720Z JavaThread::set_is_in_VTMT(bool) in thread.o
2021-09-30T11:41:57.9444370Z JavaThread::java_suspend() in thread.o
2021-09-30T11:41:57.9445220Z "JvmtiEventController::thread_started(JavaThread*)", referenced from:
2021-09-30T11:41:57.9446160Z JavaThread::rebind_to_jvmti_thread_state_of(oop) in thread.o
2021-09-30T11:41:57.9446890Z ld: symbol(s) not found for architecture x86_64
2021-09-30T11:41:57.9448190Z clang: error: linker command failed with exit code 1 (use -v to see invocation)
But I believe they are unrelated to this patch. windows-aarch64 and linux-aarch64 seem to build fine in GHA. I propose we integrate this PR, and deal with the rest later.
-------------
PR: https://git.openjdk.java.net/loom/pull/70
More information about the loom-dev
mailing list