Integrated: Fix Optimized builds

[Aleksey Shipilev]

On Mon, 27 Sep 2021 12:13:00 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

> The usual trap in Hotspot code is the belief that `ASSERT <=> !PRODUCT`, but that's not actually true. You would not see this in regular release (`!ASSERT`, `PRODUCT`) or fastdebug (`ASSERT`, `!PRODUCT`) builds, but you would see it in optimized (`!ASSERT`, `!PRODUCT`) builds. See for example GHA: https://github.com/shipilev/loom/runs/3717294006?check_suite_focus=true
> 
> The use of `ASSERT` and `PRODUCT` should be consistent to avoid build failures in optimized builds.
> 
> Additional testing:
>  - [x] Linux x86_64 optimized now builds
>  - [x] Linux x86_64 release still builds
>  - [x] Linux x86_64 fastdebug still builds

This pull request has now been integrated.

Changeset: 6a960707
Author:    Aleksey Shipilev <shade at openjdk.org>
Committer: Ron Pressler <rpressler at openjdk.org>
URL:       https://git.openjdk.java.net/loom/commit/6a9607076500389838e0abce7626b8ff8256bef4
Stats:     23 lines in 8 files changed: 7 ins; 1 del; 15 mod

Fix Optimized builds

Reviewed-by: kvn

-------------

PR: https://git.openjdk.java.net/loom/pull/69