RFR: Some more descriptive names, removed redundant asserts. Request for comments. [v3]

Coleen Phillimore coleenp at openjdk.java.net
Thu Apr 7 16:01:07 UTC 2022


On Wed, 6 Apr 2022 20:03:56 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> src/hotspot/share/runtime/continuation.cpp line 1589:
>> 
>>> 1587: #endif
>>> 1588: 
>>> 1589:   // Why 'vsp' what is 'v' ?  isn't this the sp on the real stack?
>> 
>> To distinguish between stacks, John called the continuation stack a "horizontal stack", hence `h`, and the thread stack a "vertical stack`, hence `v`.
>
> Ok I wouldn't have guessed.

s/vsp/top_sp/ or top_thread_sp ?
s/hsp/frame_sp/ ?

-------------

PR: https://git.openjdk.java.net/loom/pull/139


More information about the loom-dev mailing list