RFR: Some more descriptive names, removed redundant asserts. Request for comments. [v6]

Coleen Phillimore coleenp at openjdk.java.net
Fri Apr 8 02:53:21 UTC 2022


> Also, there's an if statement already for chunk_available which the compiler shouldn't have trouble optimizing.  Otherwise we should refactor freeze_fast.
> Tested locally with make test TEST=jdk/jdk/internal/vm/Continuation since only names.

Coleen Phillimore has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains five commits:

 - Minor work to get other platforms to compile (except x86).  Move around
   some functions to continuationHelpers_cpu.linline.hpp to match x86 and
   aarch implementations.
 - Renamed vsp to frame_sp and hsp to heap_sp.
 - More questions
 - Revert untemplatization
 - Some more descriptive names, removed redundant asserts.  Request for comments.

-------------

Changes: https://git.openjdk.java.net/loom/pull/139/files
 Webrev: https://webrevs.openjdk.java.net/?repo=loom&pr=139&range=05
  Stats: 458 lines in 25 files changed: 193 ins; 120 del; 145 mod
  Patch: https://git.openjdk.java.net/loom/pull/139.diff
  Fetch: git fetch https://git.openjdk.java.net/loom pull/139/head:pull/139

PR: https://git.openjdk.java.net/loom/pull/139


More information about the loom-dev mailing list