RFR: Split out ContinuationEntry and ContinuationWrapper classes
Ron Pressler
rpressler at openjdk.java.net
Thu Apr 14 07:37:36 UTC 2022
On Thu, 14 Apr 2022 01:01:17 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:
> Moved ContinuationEntry and ContinuationWrapper to their own files.
> There's a bit of inconsistency because 3 ContinuationEntry functions are in ContinuationHelper_cpu.inline.hpp - maybe we should have continuationEntry_cpu.inline.hpp files for just the three.
> I'd like to change the name ContinuationEntry to ContinuationAnchor or ContinuationFrameAnchor but want to study how that would look a bit more first.
> Tested with other platforms and testing with loom-tier1 as sanity.
src/hotspot/share/runtime/continuationWrapper.cpp line 50:
> 48: disallow_safepoint();
> 49: read();
> 50: }
This constructor should go in the .inline file, and the intialization of the JFR fields should be #ifdefed
src/hotspot/share/runtime/continuationWrapper.inline.hpp line 51:
> 49:
> 50: short _e_size;
> 51: short _e_num_interpreted_frames;
The decalration of these two fields needs to be guarded by `#if CONT_JFR`.
-------------
PR: https://git.openjdk.java.net/loom/pull/145
More information about the loom-dev
mailing list