RFR: Split out ContinuationEntry and ContinuationWrapper classes
Stefan Karlsson
stefank at openjdk.java.net
Thu Apr 14 08:16:17 UTC 2022
On Thu, 14 Apr 2022 01:01:17 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:
> Moved ContinuationEntry and ContinuationWrapper to their own files.
> There's a bit of inconsistency because 3 ContinuationEntry functions are in ContinuationHelper_cpu.inline.hpp - maybe we should have continuationEntry_cpu.inline.hpp files for just the three.
> I'd like to change the name ContinuationEntry to ContinuationAnchor or ContinuationFrameAnchor but want to study how that would look a bit more first.
> Tested with other platforms and testing with loom-tier1 as sanity.
Thanks for splitting the files. I agree that it would make sense to move out the ContinuationEntry functions out of the ContinuationHelper files. I hope you get to that after this change.
There are number of inconsitencies in whitespace, include guards, and include orders. I've fixed those as a patch on top of your changes:
https://github.com/openjdk/loom/compare/fibers...stefank:pr_loom_145
Would you mind including those in your PR?
Thanks
-------------
Changes requested by stefank (no project role).
PR: https://git.openjdk.java.net/loom/pull/145
More information about the loom-dev
mailing list