RFR: Alex review

Fri Apr 15 05:32:55 UTC 2022

On Fri, 15 Apr 2022 05:20:07 GMT, Chris Plummer <cjplummer at openjdk.org> wrote:

> Minor fixes based on input from Alex

src/java.se/share/data/jdwp/jdwp.spec line 2155:

> 2153:                                      "or the thread is a virtual thread and the target "
> 2154:                                      "VM is unable to force its current frame to return, "
> 2155:                                      "or the implementation is "

It's okay to join the sentences but if you do then we need to re-forward L2152 so that we don't have a line break after the comma at L2152.

src/jdk.jdi/share/classes/com/sun/jdi/request/ThreadStartRequest.java line 56:

> 54:      * Restricts the events generated by this request to those in
> 55:      * the given thread.
> 56:      * @param thread the thread to filter on.

Dropped the "The behavior ..." from both requests and in both methods is okay.

-------------

PR: https://git.openjdk.java.net/loom/pull/149