RFR: Alex review [v2]
Alan Bateman
alanb at openjdk.java.net
Fri Apr 15 10:58:46 UTC 2022
On Fri, 15 Apr 2022 06:33:28 GMT, Chris Plummer <cjplummer at openjdk.org> wrote:
>> Minor fixes based on input from Alex
>
> Chris Plummer has updated the pull request incrementally with one additional commit since the last revision:
>
> Fix some formatting.
src/java.se/share/data/jdwp/jdwp.spec line 2155:
> 2153: "VM is unable to force its current frame to return, "
> 2154: "or the implementation is unable to provide this "
> 2155: "functionality on this frame.")
No objection to joining the sentences but there is an extra "or" and a missing comma. I think this is how it should read in list form:
"Attempted to return early from a frame corresponding to a native method, the thread is a virtual thread and the target VM is unable to force its current frame to return, or the implementation is unable to provide this functionality on this frame."
-------------
PR: https://git.openjdk.java.net/loom/pull/149
More information about the loom-dev
mailing list