RFR: No caching of can fast result

Coleen Phillimore coleenp at openjdk.java.net
Wed Apr 20 12:52:50 UTC 2022


On Wed, 20 Apr 2022 12:34:06 GMT, Robbin Ehn <rehn at openjdk.org> wrote:

> can_freeze_fast() result could be changed byt JRT_BLOCK.
> Let's not cache it.

Changes requested by coleenp (Committer).

src/hotspot/share/runtime/continuationFreezeThaw.cpp line 1407:

> 1405:     fr.set_jvmti_event_collector(&jsoaec);
> 1406: 
> 1407:     freeze_result res = can_freeze_fast(current) ? fr.template try_freeze_fast<false>(sp)

we need a comment why not so some ambitious person doesn't think they can optimize it back ...

-------------

PR: https://git.openjdk.java.net/loom/pull/157


More information about the loom-dev mailing list