RFR: Freeze functions [v3]
Robbin Ehn
rehn at openjdk.java.net
Thu Apr 21 12:09:47 UTC 2022
On Thu, 21 Apr 2022 11:56:56 GMT, Robbin Ehn <rehn at openjdk.org> wrote:
>> src/hotspot/share/runtime/continuationFreezeThaw.cpp line 348:
>>
>>> 346: intptr_t* _cont_stack_bottom;
>>> 347: int _cont_size;
>>> 348:
>>
>> I know these are in logical grouping and it's a StackObj, but can you move the two bools to after cont_size to minimize alignment gaps. Also there are three sizes now in this class. Can we have bigger comments for what each means in the declaration? I think this will be helpful for the abstraction.
>
> Why do you care about alignment? These are like local variables.
I removed "int _cont_size"
-------------
PR: https://git.openjdk.java.net/loom/pull/156
More information about the loom-dev
mailing list