Integrated: Remove is_owning_locks() call from freeze slow path

Patricio Chilano Mateo pchilanomate at openjdk.java.net
Thu Apr 21 14:41:50 UTC 2022


On Mon, 18 Apr 2022 16:18:54 GMT, Patricio Chilano Mateo <pchilanomate at openjdk.org> wrote:

> The call to is_owning_locks() on each frame when we recurse on freeze can be removed. Instead we can check _held_monitor_count once at the beginning on freeze_internal().
> 
> Tested locally by running all tests in test/jdk/java/lang/Thread/virtual/ and jdk/jdk/internal/vm/Continuation/, and in mach5 tiers loom-tier1, loom-tier2 and loom-tier3.
> 
> Thanks,
> Patricio

This pull request has now been integrated.

Changeset: 2e72645c
Author:    Patricio Chilano Mateo <pchilanomate at openjdk.org>
Committer: Coleen Phillimore <coleenp at openjdk.org>
URL:       https://git.openjdk.java.net/loom/commit/2e72645cc345cd0b63c9304a8a5a988313496d4f
Stats:     74 lines in 4 files changed: 24 ins; 42 del; 8 mod

Remove is_owning_locks() call from freeze slow path

Reviewed-by: rpressler, coleenp

-------------

PR: https://git.openjdk.java.net/loom/pull/155


More information about the loom-dev mailing list