RFR: First refactoring (thaw_fast) [v4]
Frederic Parain
fparain at openjdk.java.net
Mon Apr 25 19:19:36 UTC 2022
On Mon, 25 Apr 2022 17:36:12 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:
>> Frederic Parain has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last revision:
>>
>> - Merge remote-tracking branch 'upstream/fibers' into renaming1
>> - Merge remote-tracking branch 'upstream/fibers' into renaming1
>> - Move new methods to ThawBase
>> - Fixes to address Coleen's comments.
>> - First refactoring (thaw_fast)
>
> src/hotspot/share/runtime/continuationFreezeThaw.cpp line 1763:
>
>> 1761: // returns the size required to store the frame on stack, and because it is a
>> 1762: // compiled frame, it must include a copy of the arguments passed by the caller
>> 1763: return frame_size + argsize;
>
> small nit, can you put these functions above the ones that call them in the file?
Sure. Methods re-ordered: clear_chunk(), remove_top_compiled_frame_from_chunk(), copy_from_chunk() and patch_return().
-------------
PR: https://git.openjdk.java.net/loom/pull/158
More information about the loom-dev
mailing list