RFR: Changes and cleanups after review comments
Coleen Phillimore
coleenp at openjdk.java.net
Tue Apr 26 13:49:51 UTC 2022
On Tue, 26 Apr 2022 13:20:37 GMT, Ron Pressler <rpressler at openjdk.org> wrote:
> Changes and cleanups after review comments
Looks like you had a great code walkthrough.
src/hotspot/cpu/aarch64/continuationEntry_aarch64.inline.hpp line 35:
> 33:
> 34: inline frame ContinuationEntry::to_frame() const {
> 35: static CodeBlob* cb = CodeCache::find_blob_fast(entry_pc());
looks like needs 2 indent.
src/hotspot/cpu/aarch64/frame_aarch64.cpp line 166:
> 164: sender_sp = s.sp();
> 165: sender_pc = s.pc();
> 166: }
this function is too long. Can you put a comment why this is added here?
-------------
Marked as reviewed by coleenp (Committer).
PR: https://git.openjdk.java.net/loom/pull/171
More information about the loom-dev
mailing list